New issue
Advanced search Search tips

Issue 757868 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

virtual/threaded/animations/animations-parsing.html is Flaky on Linux Trusty

Project Member Reported by iclell...@chromium.org, Aug 22 2017

Issue description

daebb6a8-213d-4afd-b62f-696fbd5373c2

Builders failed on: 
- WebKit Linux Trusty (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29

Going to mark virtual/threaded/animations/animations-parsing.html test as flaky.
 
Components: Blink>Animation Tests>Flaky
Labels: OS-Linux Pri-2 Type-Bug-Regression
Owner: suzyh@chromium.org
suzyh, I think you had the last non-trivial change to that test -- are you able to help fix and/or find an appropriate owner for this? Thanks!
Labels: -Sheriff-Chromium
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bd200d2258900ca1e7f6e506be321eb59a5394f

commit 0bd200d2258900ca1e7f6e506be321eb59a5394f
Author: Ian Clelland <iclelland@google.com>
Date: Tue Aug 22 18:53:28 2017

Mark animations-parsing.html layout test as flaky.

The test has been failing more-or-less consistently on the Linux Trusty
bot.

Bug:  757868 
Change-Id: Ia05d5fd66e82ac55aab2e630af7de1851b74cb75
TBR: suzyh@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/626481
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496389}
[modify] https://crrev.com/0bd200d2258900ca1e7f6e506be321eb59a5394f/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by shend@chromium.org, Aug 22 2017

Labels: Update-Fortnightly
Owner: ----
Status: Available (was: Assigned)
Marking as available since suzyh has left the style team.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f1db3401e52e8fc1415ec403efe9eab37278a5

commit 81f1db3401e52e8fc1415ec403efe9eab37278a5
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Wed Oct 11 17:56:02 2017

CSS Animations/Transitions: use testharness for parsing tests

The parsing tests previously used shouldBe, which requires an eval of each argument.

The tests have been flaky.

BUG= 757868 

Change-Id: I0d7bc8a58a4ba15baab9103c8f4f104c1f74fcb2
Reviewed-on: https://chromium-review.googlesource.com/706877
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508028}
[delete] https://crrev.com/e4159d97a69759595319b3a48e9b93e0fec9b9eb/third_party/WebKit/LayoutTests/animations/animations-parsing-expected.txt
[modify] https://crrev.com/81f1db3401e52e8fc1415ec403efe9eab37278a5/third_party/WebKit/LayoutTests/animations/animations-parsing.html
[delete] https://crrev.com/e4159d97a69759595319b3a48e9b93e0fec9b9eb/third_party/WebKit/LayoutTests/compositing/will-change/parse-will-change-expected.txt
[modify] https://crrev.com/81f1db3401e52e8fc1415ec403efe9eab37278a5/third_party/WebKit/LayoutTests/compositing/will-change/parse-will-change.html
[modify] https://crrev.com/81f1db3401e52e8fc1415ec403efe9eab37278a5/third_party/WebKit/LayoutTests/transitions/transitions-parsing-expected.txt
[modify] https://crrev.com/81f1db3401e52e8fc1415ec403efe9eab37278a5/third_party/WebKit/LayoutTests/transitions/transitions-parsing.html

Labels: Test-Layout OS-Mac OS-Windows
Owner: ericwilligers@chromium.org
Status: Started (was: Available)
Moving from shouldBe (eval) to testharness has reduced the flakes, but flakes remain.

The attacment shows the recent improvement.

The test files can be sharded to avoid the timeouts.

parsing-flakiness.pdf
168 KB Download
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1df55b72d2347277c36c0c1a39f578292f4c915

commit a1df55b72d2347277c36c0c1a39f578292f4c915
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Oct 17 03:19:08 2017

Shard transitions/transitions-parsing.html

The test has taken 10s to run in recent debug builds.

We shard the test to avoid virtual/threaded flakes.

BUG= 757868 

Change-Id: Ic2c796d7896ed3211caf161575a3fca3295e278d
Reviewed-on: https://chromium-review.googlesource.com/720657
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509262}
[add] https://crrev.com/a1df55b72d2347277c36c0c1a39f578292f4c915/third_party/WebKit/LayoutTests/transitions/transitions-parsing-001.html
[add] https://crrev.com/a1df55b72d2347277c36c0c1a39f578292f4c915/third_party/WebKit/LayoutTests/transitions/transitions-parsing-002.html
[add] https://crrev.com/a1df55b72d2347277c36c0c1a39f578292f4c915/third_party/WebKit/LayoutTests/transitions/transitions-parsing-003.html
[add] https://crrev.com/a1df55b72d2347277c36c0c1a39f578292f4c915/third_party/WebKit/LayoutTests/transitions/transitions-parsing-004.html
[add] https://crrev.com/a1df55b72d2347277c36c0c1a39f578292f4c915/third_party/WebKit/LayoutTests/transitions/transitions-parsing-005-expected.txt
[add] https://crrev.com/a1df55b72d2347277c36c0c1a39f578292f4c915/third_party/WebKit/LayoutTests/transitions/transitions-parsing-005.html
[delete] https://crrev.com/dbae6909a3db07237e39bc1b9894f14b42f855ee/third_party/WebKit/LayoutTests/transitions/transitions-parsing-expected.txt
[delete] https://crrev.com/dbae6909a3db07237e39bc1b9894f14b42f855ee/third_party/WebKit/LayoutTests/transitions/transitions-parsing.html

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69eba886f47efdb4976a9285f4499ec0920996cc

commit 69eba886f47efdb4976a9285f4499ec0920996cc
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Fri Oct 20 00:40:47 2017

Shard animations/animations-parsing.html

The test has taken more than ten seconds to run in recent
debug builds.

We shard the test to avoid flakes, for example when running
under virtual/threaded.

BUG= 757868 

Change-Id: I0ca84820bafb5be00c3f39a0aa4dc95d45134be2
Reviewed-on: https://chromium-review.googlesource.com/722480
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510271}
[modify] https://crrev.com/69eba886f47efdb4976a9285f4499ec0920996cc/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/69eba886f47efdb4976a9285f4499ec0920996cc/third_party/WebKit/LayoutTests/animations/animations-parsing-001.html
[add] https://crrev.com/69eba886f47efdb4976a9285f4499ec0920996cc/third_party/WebKit/LayoutTests/animations/animations-parsing-002.html
[add] https://crrev.com/69eba886f47efdb4976a9285f4499ec0920996cc/third_party/WebKit/LayoutTests/animations/animations-parsing-003.html
[add] https://crrev.com/69eba886f47efdb4976a9285f4499ec0920996cc/third_party/WebKit/LayoutTests/animations/animations-parsing-004.html
[add] https://crrev.com/69eba886f47efdb4976a9285f4499ec0920996cc/third_party/WebKit/LayoutTests/animations/animations-parsing-005.html
[delete] https://crrev.com/140f8ce04cc4ee5d4b3ca2eb83888d2452a1f43b/third_party/WebKit/LayoutTests/animations/animations-parsing.html

Status: Fixed (was: Started)

Sign in to add a comment