Daydream elbow model in Chrome differs from that on home world |
||||||
Issue descriptionIn Chrome the elbow model that positions the controller consistently places it almost directly at the users side, while on other apps (Like the home world) the controller usually sits out in front of the user a bit more. IMO the homeworld behavior feels a bit more natural, and provides more visual clues about the behavior of the controller. If nothing else we should strive for consistency between Chrome's behavior and that of other first party apps. The attached two images show the controller pointing forward and sitting on a desk, while the phone is placed face down next to it, effectively simulating looking straight down while holding the controller horizontally in front of you. You can see that in Chrome the controller is much closer to the center of the view, which translates to it appearing closer to the user's side.
,
Aug 22 2017
We should be bumping our gvr version in the next few weeks, hopefully in time for M62 to get some bugfixes in, so we should do this at the same time.
,
Aug 22 2017
,
Aug 25 2017
,
Aug 29 2017
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0f4066277d75490c3b0a485b0addbdb022c33e9 commit b0f4066277d75490c3b0a485b0addbdb022c33e9 Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Aug 30 17:24:43 2017 VR: Reuse daydream arm model. Deletes our arm model implementation and replaces it with the one provided as part of the controller API. This is based on https://chromium-review.googlesource.com/c/chromium/src/+/641650 but gerrit is absolute garbage at doing diffbases so that change is included here. Bug: 757867 Change-Id: Iaeb8f796a7b758f6556cf77cf3d3209c0e8ce811 Reviewed-on: https://chromium-review.googlesource.com/641930 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#498518} [modify] https://crrev.com/b0f4066277d75490c3b0a485b0addbdb022c33e9/chrome/browser/android/vr_shell/BUILD.gn [delete] https://crrev.com/5c0c6f1ec64ecf9b132ea30892ab9dd1b4e27afe/chrome/browser/android/vr_shell/elbow_model.cc [delete] https://crrev.com/5c0c6f1ec64ecf9b132ea30892ab9dd1b4e27afe/chrome/browser/android/vr_shell/elbow_model.h [modify] https://crrev.com/b0f4066277d75490c3b0a485b0addbdb022c33e9/chrome/browser/android/vr_shell/vr_controller.cc [modify] https://crrev.com/b0f4066277d75490c3b0a485b0addbdb022c33e9/chrome/browser/android/vr_shell/vr_controller.h [modify] https://crrev.com/b0f4066277d75490c3b0a485b0addbdb022c33e9/chrome/browser/android/vr_shell/vr_shell_gl.cc
,
Aug 30 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mthiesse@chromium.org
, Aug 22 2017