Long Tasks: Instrument v8 execute script |
||
Issue descriptionInstrument v8 execute script similar to v8 compile CL: https://chromium-review.googlesource.com/c/chromium/src/+/594675 Relevant doc here: https://docs.google.com/document/d/1iUmC6zb9jPG5Tk1jJ2vcRL1V0xSeVRM1_zR04GKMOYE/edit
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e74c18d1bc755aff8a135a18308554b75ef90d60 commit e74c18d1bc755aff8a135a18308554b75ef90d60 Author: Liquan (Max) Gu <maxlg@chromium.org> Date: Mon Aug 28 23:49:12 2017 Long tasks v2: implement probe::V8 Execute Script This CL is to implement probe::V8ExecuteScript as an effort to attribute long tasks with the subtasks 'script-run'. 'script-run' corresponds to V8ScriptRunner::RunCompileScript() and v8ScriptRunner::EvaluateModule(). The probe records the url of culprit script, and finally become entries in the attribution of long task performance entries. This feature is temporarily hidden behind a command line flag "LongTaskV2". Bug: 757858 Change-Id: Idacbfeb2221a7dc5c5cc0f8807863af7c736a21c Reviewed-on: https://chromium-review.googlesource.com/627418 Commit-Queue: Liquan Gu <maxlg@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#497941} [modify] https://crrev.com/e74c18d1bc755aff8a135a18308554b75ef90d60/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4af39544053707097c14c22f25a20a09a4704cae commit 4af39544053707097c14c22f25a20a09a4704cae Author: Liquan (Max) Gu <maxlg@chromium.org> Date: Thu Aug 31 08:21:54 2017 [LongTask] Layout tests for 'script-run' attribution After implementing the probe::ExecuteScript(), any long task which takes more than 12ms to execute script will result in adding an attribute of 'script-run' of a performance long task timing entry, a feature behind a runtime feature flag - LongTaskV2. But there is no test covering this behavior yet, so this CL is to provide Layout test to cover this behavior. Bug: 757858 Change-Id: I54c02c4d244095f32fa79b72a5e5e38aa62ead2e Reviewed-on: https://chromium-review.googlesource.com/639359 Commit-Queue: Liquan Gu <maxlg@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#498786} [modify] https://crrev.com/4af39544053707097c14c22f25a20a09a4704cae/third_party/WebKit/LayoutTests/VirtualTestSuites [add] https://crrev.com/4af39544053707097c14c22f25a20a09a4704cae/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/longtask-executescript-expected.txt [add] https://crrev.com/4af39544053707097c14c22f25a20a09a4704cae/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/longtask-executescript.html [add] https://crrev.com/4af39544053707097c14c22f25a20a09a4704cae/third_party/WebKit/LayoutTests/virtual/longtask-v2/http/tests/performance-timing/longtask-v2/README.txt [add] https://crrev.com/4af39544053707097c14c22f25a20a09a4704cae/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/performance-timing/longtask-v2/README.txt
,
Sep 5 2017
Should we mark this as 'finished'?
,
Sep 5 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c3bf609ebf12e1112211071582b78f3e61fd086 commit 3c3bf609ebf12e1112211071582b78f3e61fd086 Author: Liquan (Max) Gu <maxlg@chromium.org> Date: Wed Oct 11 17:10:30 2017 [LongTaskV2]Fix failed test of script-run instrumentation of LongTaskV2 This Cl is to fix the failed test longtask-executescript when enabling the LongTaskV2 blink feature and change the way of verifying the attributes to make it easier to understand. Bug: 757858 Change-Id: I662c0cad355478ddb0bf6008aedb1906ad6d8dd7 Reviewed-on: https://chromium-review.googlesource.com/703116 Commit-Queue: Liquan Gu <maxlg@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#508010} [modify] https://crrev.com/3c3bf609ebf12e1112211071582b78f3e61fd086/third_party/WebKit/LayoutTests/VirtualTestSuites [modify] https://crrev.com/3c3bf609ebf12e1112211071582b78f3e61fd086/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/longtask-executescript-expected.txt [modify] https://crrev.com/3c3bf609ebf12e1112211071582b78f3e61fd086/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/longtask-executescript.html [add] https://crrev.com/3c3bf609ebf12e1112211071582b78f3e61fd086/third_party/WebKit/LayoutTests/virtual/longtask-v2/http/tests/performance-timing/longtask-v2/longtask-executescript-expected.txt |
||
►
Sign in to add a comment |
||
Comment 1 by maxlg@chromium.org
, Aug 24 2017