New issue
Advanced search Search tips

Issue 757857 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Document Origin::GetURL to discourage use

Project Member Reported by csharrison@chromium.org, Aug 22 2017 
The method converts an origin (scheme + host + port + suborigin) into a GURL with only those components.

This loses type information and should be discouraged. If a method wants to operate on an origin it should explicitly take in a Origin.

Comment 1 by csharrison@chromium.org, Aug 22 2017 

Passing one of these "faux" origins to a method that expected a full URL was the root cause of issue 756465.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f8c91bbcab3ff7c2ab73ff3ef689d0979ad7b3

commit c5f8c91bbcab3ff7c2ab73ff3ef689d0979ad7b3
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Aug 22 18:08:24 2017

Discourage use of Origin::GetURL with a comment

Bug:  757857 
Change-Id: Id1780fbb7d126e933f9be26f7c6817c57e1f5a44
Reviewed-on: https://chromium-review.googlesource.com/626536
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496368}
[modify] https://crrev.com/c5f8c91bbcab3ff7c2ab73ff3ef689d0979ad7b3/url/origin.h

Comment 3 by csharrison@chromium.org, Aug 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment