BrowserTest.ThirtyFourTabs flaky on Win7, runs out of memory |
|||||
Issue descriptionEvery few runs crash on running out of memory: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/23574 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/23572 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/23569 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%20Tests/builds/23566 msw@ could you triage?
,
Aug 22 2017
I'm definitely not the right owner, and don't know where to begin with triage... why was I chosen? I also wonder if disabling the test was the right call; couldn't this be a real memory regression? The V8 isolate heap error (afaik) "Fatal process OOM in heap setup" comes from: https://cs.chromium.org/chromium/src/v8/src/isolate.cc?rcl=6ae1f2eeeb4c099e748fa7e541f65cc63d1e2e00&l=2753 Casting a really wide net, for lack of any experience here, sorry.
,
Aug 22 2017
This is probably caused by this change which landed yesterday: https://chromium-review.googlesource.com/c/chromium/src/+/616340 It reserves a large chunk of address space, which should be released when other allocations fail. It looks like that isn't happening for some reason - likely I've missed the release logic for some large allocation in V8. We should definitely keep the test. I'll revert my change.
,
Aug 22 2017
Thanks! Are you planning on reinstating the test once your revert lands? (Removing this from the sheriff queue for now, since the failures should be taken care of in two different ways)
,
Aug 22 2017
I could, but I'm OOO until next week. It might be better if someone re-enables before then. I'm trying to revert my change but need some +1's to do so.
,
Aug 22 2017
I think you could just TBR jbroman, and that should be enough to commit -- otherwise, I could revert it for you. (I can't edit your revert CL, apparently)
,
Aug 22 2017
Ahh, it's a conflict -- looks like it's this one which needs to be reverted: https://chromium-review.googlesource.com/c/chromium/src/+/620926 I'll revert that one.
,
Aug 22 2017
Reverting as https://chromium-review.googlesource.com/c/chromium/src/+/626458 (Hopefully that goes through)
,
Aug 23 2017
It landed, and now the bot is green! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Aug 22 2017