New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757836 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

BrowserTest.ThirtyFourTabs flaky on Win7, runs out of memory

Project Member Reported by hbos@chromium.org, Aug 22 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c73d5a44d670ec6957d87582129c0ac27b2c68bc

commit c73d5a44d670ec6957d87582129c0ac27b2c68bc
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Aug 22 15:38:14 2017

Disable BrowserTest.ThirtyFourTabs on Win, even in release builds.

Bug:  757836 
TBR=msw@chromium.org
NOTRY=True

Change-Id: I5f9ce976f8555e2102fb7494750eb214af9697ad
Reviewed-on: https://chromium-review.googlesource.com/626300
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496314}
[modify] https://crrev.com/c73d5a44d670ec6957d87582129c0ac27b2c68bc/chrome/browser/ui/browser_browsertest.cc

Comment 2 by msw@chromium.org, Aug 22 2017

Components: Blink>MemoryAllocator Blink>JavaScript>Runtime Internals>Instrumentation>Memory Internals>Core
Labels: Hotlist-MemoryInfra Performance-Memory Stability-Memory OS-Windows
Owner: ----
I'm definitely not the right owner, and don't know where to begin with triage... why was I chosen?
I also wonder if disabling the test was the right call; couldn't this be a real memory regression?

The V8 isolate heap error (afaik) "Fatal process OOM in heap setup" comes from:
https://cs.chromium.org/chromium/src/v8/src/isolate.cc?rcl=6ae1f2eeeb4c099e748fa7e541f65cc63d1e2e00&l=2753
Casting a really wide net, for lack of any experience here, sorry.

Comment 3 by bbudge@chromium.org, Aug 22 2017

Owner: bbudge@chromium.org
Status: Assigned (was: Untriaged)
This is probably caused by this change which landed yesterday:

https://chromium-review.googlesource.com/c/chromium/src/+/616340

It reserves a large chunk of address space, which should be released when other allocations fail. It looks like that isn't happening for some reason - likely I've missed the release logic for some large allocation in V8. We should definitely keep the test.

I'll revert my change.
Cc: iclell...@chromium.org
Labels: -Sheriff-Chromium
Thanks! Are you planning on reinstating the test once your revert lands?

(Removing this from the sheriff queue for now, since the failures should be taken care of in two different ways)

Comment 5 by bbudge@chromium.org, Aug 22 2017

I could, but I'm OOO until next week. It might be better if someone re-enables before then. I'm trying to revert my change but need some +1's to do so.
I think you could just TBR jbroman, and that should be enough to commit -- otherwise, I could revert it for you. (I can't edit your revert CL, apparently)
Ahh, it's a conflict -- looks like it's this one which needs to be reverted:
https://chromium-review.googlesource.com/c/chromium/src/+/620926

I'll revert that one.
Reverting as https://chromium-review.googlesource.com/c/chromium/src/+/626458 (Hopefully that goes through)

Comment 9 by hbos@chromium.org, Aug 23 2017

Status: Fixed (was: Assigned)
It landed, and now the bot is green!

Sign in to add a comment