New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757831 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in content::DeviceOrientationEventPumpBase::SendFakeDataForTesting

Project Member Reported by ClusterFuzz, Aug 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5282965327446016

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  content::DeviceOrientationEventPumpBase::SendFakeDataForTesting
  base::internal::Invoker<base::internal::BindState<void
  base::debug::TaskAnnotator::RunTask
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=495972:496126

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5282965327446016

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org blundell@chromium.org
Components: Internals>Core
Labels: Test-Predator-Wrong-CLs M-62 CF-NeedsTriage
I don't have a Windows development machine, and I don't see anything obvious from the stack trace. How confident are we in that regression range being correct?
Project Member

Comment 3 by ClusterFuzz, Oct 1 2017

Components: Blink>Sensor>DeviceOrientation
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Owner: reillyg@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/#/c/chromium/src/+/695873 should resolve this issue.
Cc: reillyg@chromium.org
 Issue 727011  has been merged into this issue.
Cc: nyerramilli@chromium.org timvolod...@chromium.org
 Issue 442249  has been merged into this issue.
Project Member

Comment 7 by ClusterFuzz, Oct 3 2017

Labels: OS-Mac OS-Linux
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f68ff4d6110c632f087c3ba0fb66abe1b9f1fc3

commit 9f68ff4d6110c632f087c3ba0fb66abe1b9f1fc3
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Oct 06 21:19:29 2017

Prevent crash when sending fake sensor data

If there is no currently registered event listener then there is nothing
to notify when a fake sensor event is reported. This resolves a crash
discovered by ClusterFuzz when mangling existing LayoutTests. This issue
is not reproducible by normal web content.

Bug:  727936 ,  757831 
Change-Id: I4ea874b9e738f94a4a2e5b2b20cd2f3124242ddc
Reviewed-on: https://chromium-review.googlesource.com/695873
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507180}
[modify] https://crrev.com/9f68ff4d6110c632f087c3ba0fb66abe1b9f1fc3/content/renderer/device_sensors/device_motion_event_pump.cc
[modify] https://crrev.com/9f68ff4d6110c632f087c3ba0fb66abe1b9f1fc3/content/renderer/device_sensors/device_orientation_event_pump.cc

Status: Fixed (was: Started)
 Issue 772609  has been merged into this issue.
Project Member

Comment 11 by ClusterFuzz, Oct 7 2017

ClusterFuzz has detected this issue as fixed in range 507143:507182.

Detailed report: https://clusterfuzz.com/testcase?key=5282965327446016

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  content::DeviceOrientationEventPumpBase::SendFakeDataForTesting
  base::internal::Invoker<base::internal::BindState<void
  base::debug::TaskAnnotator::RunTask
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=495972:496126
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=507143:507182

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5282965327446016

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Oct 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5282965327446016 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment