New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757830 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in webrtc::PeerConnection::GenerateMediaDescriptionOptions

Project Member Reported by ClusterFuzz, Aug 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5202720574406656

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  webrtc::PeerConnection::GenerateMediaDescriptionOptions
  webrtc::PeerConnection::GetOptionsForAnswer
  webrtc::PeerConnection::CreateAnswer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=496140:496160

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5202720574406656

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 22 2017

Labels: OS-Android OS-Mac OS-Linux
Cc: msrchandra@chromium.org zhihuang@webrtc.org sandeepkumars@chromium.org
Components: Blink>WebRTC
Labels: M-62 CF-NeedsTriage Test-Predator-Wrong-CLs
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "peerconnection.cc" assigning to the concern owner who might be related.

Suspecting Commit#
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+/4e4b0a26b2ac7491fdba128da7a2f01e08d253c4

@zhihuang -- Could you please look into the issue, kindly re-assign if this is not related to your changes.

Thank You.

Comment 3 by zhihuang@webrtc.org, Aug 28 2017

It's seems to be related to my changes. I'll take a look.

Comment 4 by guidou@chromium.org, Aug 29 2017

Components: -Blink>WebRTC Blink>WebRTC>Network
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/141aacbf0b2df237e3e509ead278b770a2a04ad7

commit 141aacbf0b2df237e3e509ead278b770a2a04ad7
Author: zhihuang <zhihuang@webrtc.org>
Date: Tue Aug 29 20:23:53 2017

Fix the Chromium crash when creating an answer without a remote description.

Replacing the RTC_DCHECK with an if condition so that the method GetOptionsForAnswer
won't crash when there is no remote description. WebRtcSessionDescriptionFactory
will handle the null remote description.

TBR=deadbeef@webrtc.org
BUG= chromium:757830 

Review-Url: https://codereview.webrtc.org/3006723002
Cr-Commit-Position: refs/heads/master@{#19589}

[modify] https://crrev.com/141aacbf0b2df237e3e509ead278b770a2a04ad7/webrtc/pc/peerconnection.cc
[modify] https://crrev.com/141aacbf0b2df237e3e509ead278b770a2a04ad7/webrtc/pc/peerconnectioninterface_unittest.cc

Project Member

Comment 6 by ClusterFuzz, Aug 31 2017

ClusterFuzz has detected this issue as fixed in range 498412:498437.

Detailed report: https://clusterfuzz.com/testcase?key=5202720574406656

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  webrtc::PeerConnection::GenerateMediaDescriptionOptions
  webrtc::PeerConnection::GetOptionsForAnswer
  webrtc::PeerConnection::CreateAnswer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=496140:496160
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=498412:498437

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5202720574406656

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Owner: zhihuang@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 8 by ClusterFuzz, Aug 31 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5202720574406656 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment