New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757809 link

Starred by 1 user
Status: Fixed
Owner:
arthurso...@chromium.org
Closed: Aug 2017
Cc:
█ mkwst@chromium.org
jam@chromium.org
clamy@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: 2
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PlzNavigate: BlockLegacySubresources happens after the request has been made.

Project Member Reported by arthurso...@chromium.org, Aug 22 2017 
Chrome block subresources requests that target "legacy" protocol (like "ftp") when the main document is not served from a "legacy" protocol.

With PlzNavigate, it happens after the request has been made instead of before.

What steps will reproduce the problem?
(1) Navigate to data:text/html,<iframe src="ftp://ftp.funet.fi/not_found.html"></iframe>

What is the expected result? (Without --enable-browser-side-navigation)
A blank page is displayed.

What happens instead? (With --enable-browser-side-navigation)
An error page "The webpage at ftp://ftp.funet.fi/not_found.html might be temporarily down or it [...]"
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b43863ad9ea99cc432eb95f99c15375bd73bee5e

commit b43863ad9ea99cc432eb95f99c15375bd73bee5e
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Aug 30 15:53:20 2017

PlzNavigate: Make BlockLegacySubresources work.

Chrome blocks 'ftp:' subresource request inside 'http'/'https' pages.
See https://crbug.com/435547.

It was broken with PlzNavigate (--enable-browser-side-navigation) when
the subresource is an iframe. The page was blocked, but only after the
request had been sent to the server.
This CL makes chrome block requests before they are submitted.

Additionnally, it removes the
--enable-blink-feature=BlockLegacySubresources switch. It should be
removed for M60 and this patch will land for M62.

Test: NavigationHandleImplBrowserTest.BlockLegacySubresources
Bug:  757809 ,435547
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ia85417af453b2e0532b0b7c0f381fa8a2f8e6e8a
Reviewed-on: https://chromium-review.googlesource.com/625942
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498476}
[modify] https://crrev.com/b43863ad9ea99cc432eb95f99c15375bd73bee5e/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/b43863ad9ea99cc432eb95f99c15375bd73bee5e/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/b43863ad9ea99cc432eb95f99c15375bd73bee5e/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/b43863ad9ea99cc432eb95f99c15375bd73bee5e/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/b43863ad9ea99cc432eb95f99c15375bd73bee5e/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/b43863ad9ea99cc432eb95f99c15375bd73bee5e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 2 by arthurso...@chromium.org, Aug 30 2017

Status: Fixed (was: Started)
Last CL fixed this issue.
►

Sign in to add a comment