New issue
Advanced search Search tips

Issue 757808 link

Starred by 1 user
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Signin bookmark cells should not be resized to compute its size

Project Member Reported by jlebel@chromium.org, Aug 22 2017 
This bug is a follow up of issue 754874

When the UICollection is asking for the cell size, we should not resize the current cell. On iOS 9, this triggers an infinite loop because the UICollectionView asks for the cell size right after.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c3a821c294c9f309e84ddb77ac34b26b777f3f7

commit 8c3a821c294c9f309e84ddb77ac34b26b777f3f7
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Wed Aug 23 14:47:55 2017

[iOS] Cell size should not be changed when computing its size

When -[BookmarkCollectionView collectionView:layout:sizeForItemAtIndexPath:]
is called, the current cell should not be resized. On iOS 9, this creates
an infinite loop.

Bug:  757808 
Change-Id: Iaa2c3821affdb6b4d6515539c4d4394486423666
Reviewed-on: https://chromium-review.googlesource.com/628170
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496684}
[modify] https://crrev.com/8c3a821c294c9f309e84ddb77ac34b26b777f3f7/ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm

Comment 2 by jlebel@chromium.org, Aug 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment