record_wpr doesn't work correctly without --use-wpr-go flag |
|||||
Issue descriptionSteps to reproduce: $ tools/perf/record_wpr --browser=android-chrome-canary --story-filter=GuitarTuner loading_mobile $ tools/perf/run_benchmark --browser=android-chrome-canary loading.mobile The first step seems to record the archive in Python Wpr format. If you open the .wprgo file in an editor, you can see "HttpArchive" and "ArchivedHttpResponse", which are from the Python Wpr. To temporarily work around this, --use-wpr-go flag is needed for the first step. Also, why does record_wpr run multiple iterations of the benchmark? Can we make it only run once?
,
Aug 22 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9da3225969d4e3c6f71dab3d1f617d1079d97a2c commit 9da3225969d4e3c6f71dab3d1f617d1079d97a2c Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Wed Aug 23 06:05:04 2017 Roll src/third_party/catapult/ 810d9d2ae..6980765be (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/810d9d2ae52b..6980765beb91 $ git log 810d9d2ae..6980765be --date=short --no-merges --format='%ad %ae %s' 2017-08-22 nednguyen Modify record_wpr to record benchmark once only Created with: roll-dep src/third_party/catapult BUG= 757804 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Idc48ad38e2acdcb95dddabb57615bb78f35b8372 Reviewed-on: https://chromium-review.googlesource.com/627497 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#496593} [modify] https://crrev.com/9da3225969d4e3c6f71dab3d1f617d1079d97a2c/DEPS
,
Aug 23 2017
,
Sep 15 2017
Oops, turn out I didn't really make sure that wprgo is always used in recording mode. Make another patch fix now
,
Sep 18 2017
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5d87ad6a98aefec7f44b37c9805597998429644 commit f5d87ad6a98aefec7f44b37c9805597998429644 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Mon Sep 18 16:56:29 2017 Roll src/third_party/catapult/ c49949828..8a5e45fe0 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c49949828b72..8a5e45fe0c46 $ git log c49949828..8a5e45fe0 --date=short --no-merges --format='%ad %ae %s' 2017-09-18 nednguyen Always use wpr go for recording mode for real Created with: roll-dep src/third_party/catapult BUG= 757804 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib764aa844a9f9b159e1b142c65151e951ef43893 Reviewed-on: https://chromium-review.googlesource.com/671124 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502595} [modify] https://crrev.com/f5d87ad6a98aefec7f44b37c9805597998429644/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xunji...@chromium.org
, Aug 22 2017