New issue
Advanced search Search tips

Issue 757801 link

Starred by 1 user
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS] Clean up code for the layout of SigninPromoView

Project Member Reported by jlebel@chromium.org, Aug 22 2017 
The current code to describe the layout constraints is a bit complicated to work with. It should be simplified with shorter names for metrics.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e60a338df3e9c62db9695e4566ca038ceb8f06d7

commit e60a338df3e9c62db9695e4566ca038ceb8f06d7
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Aug 22 15:26:36 2017

Simplifying layout visual constraints in SigninPromoView

Simplifying the metric keys for the visual constraints layout in
SigninPromoView.

Bug:  757801 
Change-Id: I3098046c767616db1ce45ea48fc22365c46c4818
Reviewed-on: https://chromium-review.googlesource.com/626077
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496311}
[modify] https://crrev.com/e60a338df3e9c62db9695e4566ca038ceb8f06d7/ios/chrome/browser/ui/authentication/signin_promo_view.mm

Comment 2 by jlebel@chromium.org, Aug 23 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment