No strings shown in recovery UI for locales en-US, en-CA |
||||||
Issue descriptionThe recovery UI fails to render any messages. After digging a bit, I found that: 1. make_images.py doesn't output message PNGs for en-US 2. The reason for that is a change in grit, which disables the fallback to english for missing translations, which we had relied on for en-US messages: https://codereview.chromium.org/1676793002 3. This was rolled in per https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/588140 I think we need a solution that allows us to fall back to English messages from cros_recovery.grd again so people can see messages they add. Whether that happens as part of grit or externally doesn't really matter. There doesn't seem to be an obvious way to restore that behavior though. Marking as release blocker for M-62 just in case.
,
Aug 23 2017
vapier: In the absence of obvious solutions, maybe we should revert the grit roll?
,
Aug 30 2017
Here's a revert FWIW: https://chromium-review.googlesource.com/641412
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6eae0e94c4be6e3dde9e35bf8a7e04bf6e7c398a commit 6eae0e94c4be6e3dde9e35bf8a7e04bf6e7c398a Author: Mattias Nissler <mnissler@chromium.org> Date: Thu Aug 31 11:52:17 2017 Revert "grit-i18n: update to current tree" This reverts commit 9e64cff36bf14da50737f1fc78fa403c2e5a4150. The updated grit version fails to generate recovery message strings for en-US and en-CA. See bug for more details. BUG= chromium:757792 TEST=Recovery UI displays strings again. Change-Id: If6047bb430f2977ed67cb0da447087ef371eabfe Reviewed-on: https://chromium-review.googlesource.com/641412 Commit-Ready: Mattias Nissler <mnissler@chromium.org> Tested-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6eae0e94c4be6e3dde9e35bf8a7e04bf6e7c398a/sys-devel/grit-i18n/Manifest [rename] https://crrev.com/6eae0e94c4be6e3dde9e35bf8a7e04bf6e7c398a/sys-devel/grit-i18n/grit-i18n-20150304.ebuild
,
Oct 13 2017
Does this need merged into 62?
,
Oct 13 2017
it's already in R62 ... landed before the branch i think
,
Oct 18 2017
Mike is correct: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+log/release-R62-9901.B/sys-devel/grit-i18n
,
Jan 22 2018
,
Jan 23 2018
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/initramfs/+/9cf462923fbfa414101d05ca62e45bd1f58cf4c1 commit 9cf462923fbfa414101d05ca62e45bd1f58cf4c1 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Nov 07 14:35:01 2018 make_images: support fallback English translations ourselves Grit has changed behavior where it won't write out the fallback English translations to the non-English messages. That means we have to write out the English database ourselves, and then load the missing content from it on the fly. This makes it easy to issue warnings when translations are missing. BUG= chromium:757792 TEST=generating screens with new & old grit are the same Change-Id: I4061d04377c18ba6d9eb7946591a6a9728d4f314 Reviewed-on: https://chromium-review.googlesource.com/1319409 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> [modify] https://crrev.com/9cf462923fbfa414101d05ca62e45bd1f58cf4c1/recovery/make_images [modify] https://crrev.com/9cf462923fbfa414101d05ca62e45bd1f58cf4c1/recovery/localized_text/cros_recovery.grd |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vapier@chromium.org
, Aug 22 2017