New issue
Advanced search Search tips

Issue 757768 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add a feature flag for the new media controls

Project Member Reported by beccahughes@chromium.org, Aug 22 2017

Issue description

Add a feature flag for the new media controls and split up css/images.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d

commit 0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Sep 29 00:10:37 2017

Media Controls: Add a feature flag for redesign

Add a feature flag for the redesigned modern
media controls and reshuffle the existing
resources.

BUG= 757768 

Change-Id: If4626b285f15ab30168eeb54a4a83e9c1fc08708
Reviewed-on: https://chromium-review.googlesource.com/625937
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505222}
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/content/child/blink_platform_impl.cc
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/content/child/runtime_features.cc
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/media/base/media_switches.cc
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/media/base/media_switches.h
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_cast_off.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_cast_on.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_closedcaption.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_closedcaption_disabled.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_closedcaptions_icon.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_download.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_enter_fullscreen.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_exit_fullscreen.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_overflow_menu.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_overlay_cast_off.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_overlay_cast_on.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_overlay_play.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_pause.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_play.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_slider_thumb.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_sound_muted.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_sound_not_muted.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_subtitles_icon.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_trackselection_checkmark.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaplayer_volume_slider_thumb.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/legacy/mediaremoting_cast.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/legacy/mediaremoting_cast.png
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css
[rename] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControlsAndroid.css
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
[add] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/0efe7fa3cbc49b7b15c0ba13879f9c92d84e519d/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Status: Fixed (was: Started)

Sign in to add a comment