New issue
Advanced search Search tips

Issue 757766 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Aug 2017
Cc:
leon....@intel.com
robertma@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT import] CQ done logic checks all jobs, not just CQ jobs (so android_blink_rel still blocks imports)

Project Member Reported by raphael....@intel.com, Aug 22 2017 
If I recall correctly, android_blink_rel's purple results no longer block the initial job of trying out the import on the layout test bots.

It still seems to block things if the original import patch does not need to be rebased or cause any expectation file to be updated.

https://chromium-review.googlesource.com/c/chromium/src/+/625320 seems to have run fine, and the only explanation I can think of for https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F503%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout failing with "CQ appears to have failed; aborting" is the fact that there's one purple bubble for android_blink_rel.

Comment 1 by robertma@chromium.org, Aug 22 2017 

Is the following case (an earlier run) another case?

https://chromium-review.googlesource.com/615426
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F474%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout

These cases look like what qyearsley@ mentioned in an earlier email:
> For 454 and 455, I think the issue is that it just checks whether any jobs have failed with git cl try-results rather than checking specifically whether the CQ jobs failed; this usually doesn't cause the job to fail, but when one of the initial try jobs failed this will cause the import to be imported incorrectly.

Quinten, can you confirm? If yes, we should probably file a more specific bug for this.

Comment 2 by qyears...@chromium.org, Aug 22 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Summary: [WPT import] CQ done logic checks all jobs, not just CQ jobs (so android_blink_rel still blocks imports) (was: [WPT import] android_blink_rel still blocks imports)
You're both right -- android_blink_rel doesn't block import if there's a second upload, but it does block import if there's no second patchset, because the CQ checking logic is currently incorrect.

I think we can use this bug, and focus this bug on the CQ checking logic problem; the main practical consequence of this bug right now is that sometimes jobs fail unnecessarily due to android_blink_rel failures.

Comment 3 by foolip@chromium.org, Aug 22 2017

Labels: -Pri-2 Pri-1

Comment 4 by qyears...@chromium.org, Aug 23 2017

Cc: -qyears...@chromium.org
Owner: qyears...@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/chromium/src/+/628642

Comment 6 by qyears...@chromium.org, Aug 28 2017

Status: Fixed (was: Started)
In theory this should be fixed, will reopen if it's not.
►

Sign in to add a comment