Regression: Chrome text and webstore links are missing in chrome://apps on using find |
||||||||||||||
Issue descriptionChrome Version: 62.0.3193.0 dev OS: Ubuntu 14.04 , Windows What steps will reproduce the problem? (1) Launch chrome and go to chrome://apps >> Now hit ctrl+f for find box and search for "f" or "ch" and observe chrome logo and webstore link on bottom of page Expected: Both logo and link should be present. Actual: Instead both are seen vanished. This is a regression issue broken in M61. Will provide bisect info soon.
,
Aug 22 2017
Manual Bisect Info: ==================== Good Build: 61.0.3157.0 dev Bad Build: 61.0.3158.0 dev
,
Aug 22 2017
Tool Bisect Info: ================= You are probably looking for a change made after 486678 (known good), but no later than 486683 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/d16c95a41c56a1b7b78a786347a3eb6a3bb06ef8..9fc8b5226ecbb15641639c630846c0c3a0c0b243 Suspecting https://chromium-review.googlesource.com/550237 from changelog @sunyunjia: Please confirm the behaviour and help in re-assigning if it is not related to your change. Thanks!
,
Aug 22 2017
URGENT - PTAL. M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Know that this issue shouldn't block the release? Remove the ReleaseBlock-Stable label or move to M62. Thank you! Note: We will only have 2 beta releases before Stable promotion. Plan is to cut M61 Stable RC on 08/31/17.
,
Aug 23 2017
,
Aug 23 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f3497d70f7560d468c064f7833c21f7f3ef9f7d commit 4f3497d70f7560d468c064f7833c21f7f3ef9f7d Author: Sandra Sun <sunyunjia@chromium.org> Date: Thu Aug 24 14:26:13 2017 Remove UserScroll from SmoothScrollSequencer. Previously, we put all LayoutObject::ScrollRectToVisible into SmoothScrollSequencer and use ProgrammaticScroll whenever we pop a scroll from the sequence. However, some scrolls should be called with UserScroll instead of ProgrammaticScroll, because we don't want scrollers with overflow::hidden to scroll in some cases. In this patch, we only put ProgrammaticScroll into SmoothScrollSequencer so that UserScrolls can still be called with the correct parameters. Bug: 757765 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I53eac549d3aa55b4699e04612fa10242afa06575 Reviewed-on: https://chromium-review.googlesource.com/627697 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#497035} [modify] https://crrev.com/4f3497d70f7560d468c064f7833c21f7f3ef9f7d/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/4f3497d70f7560d468c064f7833c21f7f3ef9f7d/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp [modify] https://crrev.com/4f3497d70f7560d468c064f7833c21f7f3ef9f7d/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/4f3497d70f7560d468c064f7833c21f7f3ef9f7d/third_party/WebKit/Source/core/page/scrolling/SmoothScrollTest.cpp [modify] https://crrev.com/4f3497d70f7560d468c064f7833c21f7f3ef9f7d/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
,
Aug 24 2017
,
Aug 24 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 25 2017
Tested the issue using #62 .0.3196.0 on Win 7, Linux Ubuntu 14.04 and Mac 10.12.6 as per the observations mentioned in comment #0. Observed both logo and link is seen on hitting ctrl+f for find box and search for "f" or "ch". Please find the screen cast for the same. Hence adding Verified labels. Thanks!!
,
Aug 25 2017
,
Aug 25 2017
,
Aug 25 2017
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 25 2017
This fix should be a safe merge.
,
Aug 25 2017
Approving merge to M61 branch 3163 based on comment #10, #12 & #14. Please merge ASAP. Thank you.
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74142288cb40cdf43276510b3e70c5242027eaae commit 74142288cb40cdf43276510b3e70c5242027eaae Author: Sandra Sun <sunyunjia@chromium.org> Date: Fri Aug 25 19:55:18 2017 Remove UserScroll from SmoothScrollSequencer. This patch directly works on branch 3163, as the bug is release-block-M61. We previously have a patch https://chromium-review.googlesource.com/c/chromium/src/+/627697 that fixes the bug. However, that patch relies on some other commits that are not yet merged to M61. So we create this patch in order to merge it to M61. Bug: 757765 Change-Id: I53eac549d3aa55b4699e04612fa10242afa06575 Reviewed-on: https://chromium-review.googlesource.com/636264 Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#898} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/74142288cb40cdf43276510b3e70c5242027eaae/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/74142288cb40cdf43276510b3e70c5242027eaae/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp [modify] https://crrev.com/74142288cb40cdf43276510b3e70c5242027eaae/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/74142288cb40cdf43276510b3e70c5242027eaae/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/74142288cb40cdf43276510b3e70c5242027eaae/third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
,
Aug 28 2017
Rechecked the issue using #61.0.3163.65 on Win 10, Ubuntu 14.04 and Mac 10.12.6 as per the steps provided in comment #0. Observed both logo and link are visible on hitting ctrl+f for find box and made a search for "f" or "ch". Adding TE-Verified labels for M61. Thanks.!
,
Aug 28 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by krajshree@chromium.org
, Aug 22 2017Status: Untriaged (was: Unconfirmed)