Regression: Cursor is not seen immediately in find in box |
||||||
Issue descriptionChrome Version: 62.0.3193.0 dev OS: Ubuntu 14.04 , Windows What steps will reproduce the problem? (1) Launch chrome, hit ctrl+f for Find and observe for cursor. Expected: Cursor should be seen immediately without any delay. Actual: Instead some delay is seen. This is a regression issue broken in M62. Will provide bisect info soon
,
Aug 22 2017
Manual Bisect Info: =================== Good Build: 62.0.3185.0 Bad Build: 62.0.3186.0
,
Aug 22 2017
Bisect Information: ------------------- You are probably looking for a change made after 494149 (known good), but no later than 494150 (first known bad) CHANGELOG URL: -------------- https://chromium.googlesource.com/chromium/src/+log/8342b9d1a124b1990b6b94cc41bf7d9d3afe0d34..a0b867b844d0e05d5b5699016468870581a12ad4 @yiyix: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!!
,
Aug 29 2017
my changing caused it. Looking into it now.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b959d967c8219d4752d5c70362eb89fa5d1fbc commit d2b959d967c8219d4752d5c70362eb89fa5d1fbc Author: yiyix <yiyix@chromium.org> Date: Wed Aug 30 23:34:42 2017 Regression: Cursor is not seen immediately in find in box In the previous cl, https://chromium-review.googlesource.com/608628, I updated the cursor height be to (visible_bound.height - 2y) to avoid to show cursor longer than the textfield. However, when the find in box slowly appears on the screen, the height of the visible_bounds is 0 at the start of the animation. As a result, the height of the text cursor is 0 at the first blink. A verification of height of visible bounds is added before updating the height of the text cursor. Bug: 757763 Change-Id: I15b9fdbcee84d2e417bc97061c3a1ad70ff08f55 Reviewed-on: https://chromium-review.googlesource.com/641653 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#498666} [modify] https://crrev.com/d2b959d967c8219d4752d5c70362eb89fa5d1fbc/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/d2b959d967c8219d4752d5c70362eb89fa5d1fbc/ui/views/controls/textfield/textfield_unittest.cc
,
Aug 31 2017
,
Aug 31 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 31 2017
M62 is not branched yet. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Aug 22 2017Status: Untriaged (was: Unconfirmed)