Discarding changes while editing username doesnt work after second discard |
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36 Steps to reproduce the problem: 1. enter any website with credentials 2. click edit 3. edit username 4. press escape key 5. click edit again 6. press escape again 7. you have your username updated instead of changes being discarded. What is the expected behavior? Username should not be updated if user presses escape key. What went wrong? Username is updated if user presses edit, escape key, edit, escape key in this order. Did this work before? N/A Chrome version: 60.0.3112.101 Channel: stable OS Version: Flash Version: This is a bug for myself but i am unable to assign it to myself, so my host will be the assignee until i fix it. O:)
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/802da946eaf38c9ba8ea23811f44f654befdfe2a commit 802da946eaf38c9ba8ea23811f44f654befdfe2a Author: Irmak Kavasoğlu <irmakk@google.com> Date: Wed Aug 23 08:33:08 2017 Fixed escape not discarding username changes after editing on mac platform When username is edited, if user presses escape, we expect the changes to be discarded. The ui seemed fine but the username in the model was still being updated. This cl fixes the problem and updates the corresponding test. Bug: 757752 Change-Id: I367ab82f31cacf97f158e2dbd20ec75b2c4a70a7 Reviewed-on: https://chromium-review.googlesource.com/626397 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Cr-Commit-Position: refs/heads/master@{#496627} [modify] https://crrev.com/802da946eaf38c9ba8ea23811f44f654befdfe2a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm [modify] https://crrev.com/802da946eaf38c9ba8ea23811f44f654befdfe2a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
,
Aug 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by melandory@chromium.org
, Aug 22 2017