Log audio input stream failures on Windows |
||||||||
Issue descriptionWhen we start an audio input stream, at least on Windows, we don't log failures. We should do so, to the WebRTC log. https://cs.chromium.org/chromium/src/media/audio/audio_input_controller.cc?sq=package:chromium&l=390 and https://cs.chromium.org/chromium/src/media/audio/win/audio_low_latency_input_win.cc?sq=package:chromium&l=162
,
Nov 29 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df64b29e17efa7aed791da9f93b573f2d5af68fc commit df64b29e17efa7aed791da9f93b573f2d5af68fc Author: Henrik Grunell <grunell@chromium.org> Date: Thu Nov 30 16:18:37 2017 Add WebRTC logging to Windows audio input implementation. Log failures in Open() and Start(). Bug: 757737 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idaad68af9aabc753cb4fca17b2dfff3cdf69d83b Reviewed-on: https://chromium-review.googlesource.com/795727 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520562} [modify] https://crrev.com/df64b29e17efa7aed791da9f93b573f2d5af68fc/media/audio/audio_manager.h [modify] https://crrev.com/df64b29e17efa7aed791da9f93b573f2d5af68fc/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/df64b29e17efa7aed791da9f93b573f2d5af68fc/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/df64b29e17efa7aed791da9f93b573f2d5af68fc/media/audio/win/audio_manager_win.cc
,
Nov 30 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f289287bf59a1b0be2723cf9cb20ab09a7319df4 commit f289287bf59a1b0be2723cf9cb20ab09a7319df4 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Nov 30 19:52:09 2017 Revert "Add WebRTC logging to Windows audio input implementation." This reverts commit df64b29e17efa7aed791da9f93b573f2d5af68fc. Reason for revert: Caused http://crbug.com/790557 . Original change's description: > Add WebRTC logging to Windows audio input implementation. > > Log failures in Open() and Start(). > > Bug: 757737 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Idaad68af9aabc753cb4fca17b2dfff3cdf69d83b > Reviewed-on: https://chromium-review.googlesource.com/795727 > Commit-Queue: Henrik Grunell <grunell@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520562} TBR=grunell@chromium.org,maxmorin@chromium.org,marinaciocea@chromium.org Change-Id: I54d97e5063d5a63325977ce19753d1e5439dd396 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757737 , 790557 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/801263 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520648} [modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/audio_manager.h [modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/win/audio_manager_win.cc
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9 commit 92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9 Author: Henrik Grunell <grunell@chromium.org> Date: Fri Dec 01 14:11:38 2017 Re-land Add WebRTC logging to Windows audio input implementation. Log failures in Open() and Start(). Previous (reverted) CL: https://chromium-review.googlesource.com/c/chromium/src/+/795727 Bug: 757737 , 790557 Change-Id: Idecad5ba1a692da1386823d30ce65462c9a05ff3 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/795727 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#520562} Reviewed-on: https://chromium-review.googlesource.com/803219 Cr-Commit-Position: refs/heads/master@{#520930} [modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/audio_manager.h [modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_manager_win.cc
,
Dec 1 2017
,
Dec 2 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4 2017
,
Dec 4 2017
What is the specific request for merge? Which CL will be merged?
,
Dec 4 2017
The request is for the CL in comment #6. (A re-land of the reverted CL in comment 3 with a trivial unit test fix.)
,
Dec 5 2017
Approving merge to M64. Branch:3282
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4251ea30cd82b564d0d35b094c44b468eef5f9a7 commit 4251ea30cd82b564d0d35b094c44b468eef5f9a7 Author: Henrik Grunell <grunell@chromium.org> Date: Wed Dec 06 08:15:37 2017 Re-land Add WebRTC logging to Windows audio input implementation. Log failures in Open() and Start(). Previous (reverted) CL: https://chromium-review.googlesource.com/c/chromium/src/+/795727 Bug: 757737 , 790557 Change-Id: Idecad5ba1a692da1386823d30ce65462c9a05ff3 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/795727 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#520562} Reviewed-on: https://chromium-review.googlesource.com/803219 Cr-Original-Commit-Position: refs/heads/master@{#520930}(cherry picked from commit 92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9) Reviewed-on: https://chromium-review.googlesource.com/809427 Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#52} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/audio_manager.h [modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_manager_win.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by grunell@chromium.org
, Nov 29 2017Status: Started (was: Assigned)
Summary: Log audio input stream failures on Windows (was: Log audio input stream start failures)