Failing on L and M with --enable-features=ChromeHome,ChromeHomeModernLayout https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testSnippetAppearance I'm sending a CL to disable the test.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/648a03cbb08c558d675d8530a124d52324506454 commit 648a03cbb08c558d675d8530a124d52324506454 Author: Matthew Cary <mattcary@chromium.org> Date: Tue Aug 22 09:30:39 2017 Disable ArticleSnippetsTest.testSnippetAppearance Failing with chrome home + chrome modern on L, M. BUG= 757735 TBR=mvanouwerkerk@chromium.org Change-Id: I9ec686f40cc85aef5c5aed39227d3bb59799a6ba Reviewed-on: https://chromium-review.googlesource.com/625621 Reviewed-by: Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#496260} [modify] https://crrev.com/648a03cbb08c558d675d8530a124d52324506454/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
Removing from sheriff-android queue as test is now disabled.
Issue 757575 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab6406625331e73b54e0c6a70b195efb3101cfae commit ab6406625331e73b54e0c6a70b195efb3101cfae Author: Bernhard Bauer <bauerb@chromium.org> Date: Mon Sep 11 18:08:44 2017 Render snippets in ArticleSnippetsTest in isolation Remove the "snippets" render that shows all cards together, because multiple, non-article sections are not realistic in the modern design anymore. Rebaseline other renders: * Use relative timestamp instead of Jan 17, 1970 * Use only single-card backgrounds for pre-modern cards * Update modern card background color after https://crrev.com/497799 * Update pre-modern text color after https://crrev.com/500684 Also move card contents in the modern layout except for the rounded corners into a RelativeLayout, to avoid a circular dependency between the height of the containing layout and the position of the bottom corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html). Bug: 757735 Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91 Reviewed-on: https://chromium-review.googlesource.com/628562 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#500975} [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/build/android/findbugs_filter/findbugs_exclude.xml [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/android/java/res/layout/content_suggestions_card_modern.xml [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/android/BUILD.gn [add] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/compositor/layouts/DisableChromeAnimations.java [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_snippet.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.minimal_snippet.Nexus_5-19.png [add] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-download_snippet_placeholder.Nexus_5-19.png [add] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-download_snippet_thumbnail.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-minimal_snippet.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet_narrow.Nexus_5-19.png [delete] https://crrev.com/aa28a986ec23a5fca6ca69ee7466fccc9370ae50/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets.Nexus_5-19.png [delete] https://crrev.com/aa28a986ec23a5fca6ca69ee7466fccc9370ae50/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_snippet.Nexus_5-19.png [modify] https://crrev.com/ab6406625331e73b54e0c6a70b195efb3101cfae/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_snippet_narrow.Nexus_5-19.png [delete] https://crrev.com/aa28a986ec23a5fca6ca69ee7466fccc9370ae50/chrome/test/data/android/render_tests/ArticleSnippetsTest.snippets.Nexus_5-19.png [delete] https://crrev.com/aa28a986ec23a5fca6ca69ee7466fccc9370ae50/chrome/test/data/android/render_tests/ArticleSnippetsTest.snippets_narrow.Nexus_5-19.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fddbc77926f40bd924b00661433b9c82e2c910c9 commit fddbc77926f40bd924b00661433b9c82e2c910c9 Author: John Mellor <johnme@chromium.org> Date: Tue Sep 12 14:35:15 2017 Revert "Render snippets in ArticleSnippetsTest in isolation" This reverts commit ab6406625331e73b54e0c6a70b195efb3101cfae. Reason for revert: ArticleSnippetsTest has failed consistently on KitKat Tablet Tester since this landed. Specifically the following tests are failing: ArticleSnippetsTest#testDownloadSuggestion__ChromeHomeEnabled ArticleSnippetsTest#testSigninPromo__ChromeHomeEnabled ArticleSnippetsTest#testSnippetAppearance__ChromeHomeEnabled Additionally, many other test suites that follow chrome_public_test_apk started failing when this landed; not sure if that's related. Original change's description: > Render snippets in ArticleSnippetsTest in isolation > > Remove the "snippets" render that shows all cards together, because > multiple, non-article sections are not realistic in the modern design > anymore. > > Rebaseline other renders: > * Use relative timestamp instead of Jan 17, 1970 > * Use only single-card backgrounds for pre-modern cards > * Update modern card background color after https://crrev.com/497799 > * Update pre-modern text color after https://crrev.com/500684 > > Also move card contents in the modern layout except for the rounded > corners into a RelativeLayout, to avoid a circular dependency between > the height of the containing layout and the position of the bottom > corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html). > > Bug: 757735 > Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91 > Reviewed-on: https://chromium-review.googlesource.com/628562 > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500975} TBR=bauerb@chromium.org,skyostil@chromium.org,perezju@chromium.org,peconn@chromium.org Change-Id: Iedb4e042448a8e4c8090d8af5fbdbb6e2f19a6b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757735 Reviewed-on: https://chromium-review.googlesource.com/663382 Reviewed-by: John Mellor <johnme@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#501269} [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/build/android/findbugs_filter/findbugs_exclude.xml [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/android/java/res/layout/content_suggestions_card_modern.xml [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/android/BUILD.gn [delete] https://crrev.com/d95a5c1bd393ebb4c7875810b73ca7167fd11f53/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/compositor/layouts/DisableChromeAnimations.java [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_snippet.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.minimal_snippet.Nexus_5-19.png [delete] https://crrev.com/d95a5c1bd393ebb4c7875810b73ca7167fd11f53/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-download_snippet_placeholder.Nexus_5-19.png [delete] https://crrev.com/d95a5c1bd393ebb4c7875810b73ca7167fd11f53/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-download_snippet_thumbnail.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-minimal_snippet.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet_narrow.Nexus_5-19.png [add] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets.Nexus_5-19.png [add] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_snippet.Nexus_5-19.png [modify] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_snippet_narrow.Nexus_5-19.png [add] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.snippets.Nexus_5-19.png [add] https://crrev.com/fddbc77926f40bd924b00661433b9c82e2c910c9/chrome/test/data/android/render_tests/ArticleSnippetsTest.snippets_narrow.Nexus_5-19.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39 commit ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39 Author: Bernhard Bauer <bauerb@chromium.org> Date: Wed Sep 20 16:52:25 2017 Reland "Render snippets in ArticleSnippetsTest in isolation" This is a reland of ab6406625331e73b54e0c6a70b195efb3101cfae Original change's description: > Render snippets in ArticleSnippetsTest in isolation > > Remove the "snippets" render that shows all cards together, because > multiple, non-article sections are not realistic in the modern design > anymore. > > Rebaseline other renders: > * Use relative timestamp instead of Jan 17, 1970 > * Use only single-card backgrounds for pre-modern cards > * Update modern card background color after https://crrev.com/497799 > * Update pre-modern text color after https://crrev.com/500684 > > Also move card contents in the modern layout except for the rounded > corners into a RelativeLayout, to avoid a circular dependency between > the height of the containing layout and the position of the bottom > corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html). > > Bug: 757735 > Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91 > Reviewed-on: https://chromium-review.googlesource.com/628562 > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500975} TBR: perezju@chromium.org Bug: 757735 Change-Id: I0ea32d6b8008f40ae4917c6306c0706621e3b54f Reviewed-on: https://chromium-review.googlesource.com/671084 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#503184} [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/build/android/findbugs_filter/findbugs_exclude.xml [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/android/java/res/layout/content_suggestions_card_modern.xml [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/android/BUILD.gn [add] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/compositor/layouts/DisableChromeAnimations.java [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_snippet.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.minimal_snippet.Nexus_5-19.png [add] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-cold_state_personalized_signin_promo.Nexus_5-19.png [add] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-download_snippet_placeholder.Nexus_5-19.png [add] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-download_snippet_thumbnail.Nexus_5-19.png [add] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-hot_state_personalized_signin_promo.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-minimal_snippet.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet_narrow.Nexus_5-19.png [delete] https://crrev.com/7f5bf455cfc1531b8df24a5e19854066ba526840/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets.Nexus_5-19.png [delete] https://crrev.com/7f5bf455cfc1531b8df24a5e19854066ba526840/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_snippet.Nexus_5-19.png [modify] https://crrev.com/ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39/chrome/test/data/android/render_tests/ArticleSnippetsTest.short_snippet_narrow.Nexus_5-19.png [delete] https://crrev.com/7f5bf455cfc1531b8df24a5e19854066ba526840/chrome/test/data/android/render_tests/ArticleSnippetsTest.snippets.Nexus_5-19.png [delete] https://crrev.com/7f5bf455cfc1531b8df24a5e19854066ba526840/chrome/test/data/android/render_tests/ArticleSnippetsTest.snippets_narrow.Nexus_5-19.png
Comment 1 by mattcary@chromium.org
, Aug 22 2017