GenerateMaskedSmallIcon does not work properly with multi color vector icon |
||
Issue descriptionmessage_center::Notification::GenerateMaskedSmallIcon does not work properly when the vector icon contains PATH_COLOR_ARGB, which ignores the color given in the argument of CreateVectorIcon. Right now, we can workaround that by setting kNoneIcon to |vector_small_image|. In the attached screenshot, the shelf icon is using GenerateMaskedSmallIcon. The screenshot with the white icon is the correct one.
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c commit cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c Author: Evan Stade <estade@chromium.org> Date: Fri Feb 09 15:59:03 2018 Use PATH_COLOR_ALPHA instead of PATH_COLOR_ARGB for some notification icons. This means the color passed at runtime will be respected (orange, red, etc., for notification toast; white for tray). Bug: 757724 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I45e57d7f561fddfad1d4056944e59bea9199f923 Reviewed-on: https://chromium-review.googlesource.com/909411 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#535723} [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/BUILD.gn [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/notification_battery_critical.icon [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/notification_battery_fluctuating.icon [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/notification_battery_low.icon [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/notification_bluetooth_battery_warning.icon [rename] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/notification_low_power_charger.icon [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/resources/vector_icons/notification_stylus_battery_warning.icon [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/system/power/battery_notification.cc [modify] https://crrev.com/cab92226d6ea0075cc63ac4fe8e85eb8dbfd2a7c/ash/system/power/tray_power.cc
,
Feb 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tetsui@chromium.org
, Feb 8 2018Owner: est...@chromium.org