[WPT Import] "Git repository not found" when turning off WIP mode in CL |
||||
Issue descriptionImporter failed at https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/502 The detailed log: " Issue: Issue number: 625257 (https://chromium-review.googlesource.com/625257) Triggering try jobs for updating expectations. Waiting for try jobs (timeout: 10800 seconds). Waiting. 121 seconds passed. XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX Waiting. 3983 seconds passed. Triggering CQ try jobs. All jobs finished. Waiting for try jobs (timeout: 10800 seconds). Waiting. 121 seconds passed. XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX Waiting. 8121 seconds passed. All jobs finished. CQ appears to have passed; trying to commit. Traceback (most recent call last): File "/mnt/data/b/rr/tmp1aClXN/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module> host.exit(importer.main()) File "/mnt/data/b/rr/tmp1aClXN/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 130, in main if not self.run_commit_queue_for_cl(): File "/mnt/data/b/rr/tmp1aClXN/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 182, in run_commit_queue_for_cl self.git_cl.run(['upload', '-f', '--send-mail']) # Turn off WIP mode. File "/mnt/data/b/rr/tmp1aClXN/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 51, in run return self._host.executive.run_command(command, cwd=self._cwd) File "/mnt/data/b/rr/tmp1aClXN/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 326, in run_command (error_handler or self.default_error_handler)(script_error) File "/mnt/data/b/rr/tmp1aClXN/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 234, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'upload', '-f', '--send-mail']" exit_code: 1 output: Last 500 characters of output: external/wpt/README.md | 44 +++++++++++--------- .../external/wpt/html/dom/original-harness.js | 3 +- 3 files changed, 43 insertions(+), 51 deletions(-) fatal: remote error: Git repository not found Error after CL description prompt -- saving description to /home/chrome-bot/.git_cl_description_backup Failed to create a change. Please examine output above for the reason of the failure. Hint: run command below to diagnose common Git/Gerrit credential problems: git cl creds-check step returned non-zero exit code: 1 "
,
Aug 22 2017
> Sorry I have not enough knowledge of the importer script so my question may be silly: why we need to run 'git cl upload' again at last?
The code in test_importer.py looks like this:
if try_results and self.git_cl.all_success(try_results):
_log.info('CQ appears to have passed; trying to commit.')
self.git_cl.run(['upload', '-f', '--send-mail']) # Turn off WIP mode.
self.git_cl.run(['set-commit'])
_log.info('Update completed.')
return True
so it's used to mark it ready for committing as well as actually triggering the CQ.
,
Aug 22 2017
Got it, Thank you very much Raphael!
,
Aug 22 2017
This is rather strange. We are seeing some more intermittent errors from git and/or Gerrit recently (e.g. issue 756373 , issue 756816 ). It's hard to debug because 1) they're intermittent; 2) I have never seen these errors in my local development environment. Perhaps we can ask the teams which maintain these tools about the possible causes of these error messages. What is the right point of contact?
,
Aug 22 2017
You should file internal bug against GoB team through go/gob-bug. If you have timestamps of when this happens, include them on the bug s.t. GoB can look at logs.
,
Aug 22 2017
Thanks Andrii -- filed b/64936123. We don't have exact timestamps in the logs currently, so we may need to change our logging to help diagnose the issue...
,
Aug 23 2017
GoB team found nothing obvious in the logs -- so, the next two steps here are: - Consider including timestamps with all importer logs - Add retry logic to GitCL.run - Add more detailed error logging when we get a ScriptError running git cl upload there
,
Aug 23 2017
Thanks, Quinten! > - Consider including timestamps with all importer logs We should do this! It will also help us understand the timing of the importer better. > - Add more detailed error logging when we get a ScriptError running git cl upload there Generally speaking, I think we should probably log all error messages during ScriptError. Currently, we often only print out messages[-500:], which is not a lot.
,
Aug 24 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c42504bb635f8cfd5657da8096411572e7b4566e commit c42504bb635f8cfd5657da8096411572e7b4566e Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Aug 25 16:25:38 2017 Include timestamps in wpt-import logs. Bug: 757722 Change-Id: I5791a412054732193721969aa922b09bdd2b33c9 Reviewed-on: https://chromium-review.googlesource.com/630278 Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#497434} [modify] https://crrev.com/c42504bb635f8cfd5657da8096411572e7b4566e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
,
Oct 16 2017
Haven't seen this in a while. Should be re-opened if observed again. |
||||
►
Sign in to add a comment |
||||
Comment 1 by leon....@intel.com
, Aug 22 2017