Two-finger tap should give context menu of the item(s) being tapped |
||||||||
Issue descriptionChrome Version: 59.0.3071.134 Chrome OS Version: 9460.73.0 Steps To Reproduce: (1) Open the Files app. Make sure there are 1 or more files in the file list view, and no one is selected. (2) Tap on one of the files with two fingers. Expected Result: A context menu for the item pops up. Actual Result: A context menu for the current directory pops up. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? In case of the grid view mode, there is a visual feedback which is same as when the file is hovered. (gray checkmark) So it may be confusing. This is currently not reproducible on ToT due to Issue 755757 , because crrev.com/c/606068 has disabled opening context menu by touch events. Once that issue is resolved, we'll see this again.
,
Aug 28 2017
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8923a9615796b43edf1fe4e5a22ecf7725605cd8 commit 8923a9615796b43edf1fe4e5a22ecf7725605cd8 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Mon Aug 28 13:08:57 2017 Target the tapped item before opening context menu by two-finger tap. Currently a two-finger tap doesn't change the selection status before opening the context menu. This change will make it consistent with the right-click of mouse. Bug: 757716 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0ea18bd95c99423a4c7eec0c5c3567329613935e Reviewed-on: https://chromium-review.googlesource.com/637302 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#497747} [modify] https://crrev.com/8923a9615796b43edf1fe4e5a22ecf7725605cd8/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js [modify] https://crrev.com/8923a9615796b43edf1fe4e5a22ecf7725605cd8/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js
,
Aug 28 2017
,
Aug 28 2017
,
Aug 28 2017
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 28 2017
Approving merge for M61.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea5d5ce7b5a7ce63bd10c285c3b75b688f708c36 commit ea5d5ce7b5a7ce63bd10c285c3b75b688f708c36 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Aug 29 01:07:34 2017 Target the tapped item before opening context menu by two-finger tap. Currently a two-finger tap doesn't change the selection status before opening the context menu. This change will make it consistent with the right-click of mouse. TBR=yamaguchi@chromium.org (cherry picked from commit 8923a9615796b43edf1fe4e5a22ecf7725605cd8) Bug: 757716 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0ea18bd95c99423a4c7eec0c5c3567329613935e Reviewed-on: https://chromium-review.googlesource.com/637302 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497747} Reviewed-on: https://chromium-review.googlesource.com/640050 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#960} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ea5d5ce7b5a7ce63bd10c285c3b75b688f708c36/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js [modify] https://crrev.com/ea5d5ce7b5a7ce63bd10c285c3b75b688f708c36/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by weifangsun@chromium.org
, Aug 23 2017Labels: -Pri-3 M-61 Pri-1
Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)