New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757712 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[sensor]Crash occurs when invoking the LinearAccelerationSensor.start() method on Windows

Reported by canx....@intel.com, Aug 22 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3188.4 Safari/537.36

Steps to reproduce the problem:
Console in dev tools as below:
{code}
let a = new LinearAccelerationSensor();
a.start();
{code}

What is the expected behavior?
No crash.

What went wrong?
Crash occurs.

Did this work before? Yes 62.0.3188.0

Does this work in other browsers? N/A

Chrome version: 62.0.3192.0  Channel: canary
OS Version: 10.0
Flash Version: 

I have uploaded crash log, crash id: e456b0e12512a493 and 89d07f55f9d60e99, and i hope that'll be helpful.
 

Comment 1 by canx....@intel.com, Aug 22 2017

@alexander.shalamov@intel.com , @wanming.lin@intel.com
Please take a look, thanks!

Comment 2 by canx....@intel.com, Aug 23 2017

This issue also exist on Linux (Chrome Dev channel:62.0.3192.0).
Cc: kkaluri@chromium.org
Components: Blink>Sensor
Labels: Needs-Feedback OS-Linux
Tested this issue on Windows 10 with chrome Canary #62.0.3192.0 

After entering the following code in console: 
let a = new LinearAccelerationSensor();
a.start();

Observed a "LinearAccelerationSensor is not defined" error in the console.

Attaching the screenshot for reference.

canx.cao@ could you please look into it and let us know your observations.
757712.PNG
47.8 KB View Download

Comment 4 by canx....@intel.com, Aug 23 2017

@kkaluri, I'm sorry to inform you that the information is incomplete, I'd like to add that: 
1. Enable sensor flag. Chrome://flags---> find "Generic Sensor" ---> enable and relaunch.
2. Make sure keep the access page is "https://****", for example(https://www.google.com/)
3. Open the dev tool, then follow the steps of bug description.

Thanks!
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: hasbisect-per-revision M-62 Needs-Triage-M62
Owner: mikhail....@intel.com
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Ubuntu 14.04 with chrome Dev #62.0.3192.0, Canary #62.0.3193.0 but not on Stable #60.0.3112.101, Beta #61.0.3163.49
Issue broken in M62.

Bisect Info:
===========
Good build : 62.0.3188.0 ,  Revision Range - 495023
Bad build  : 62.0.3189.0 ,  Revision Range - 495410

After executing the per-revision bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/3967f7dbf8dd2634b4da2932e323ee1560c6bdc0..21e2fed8405b6a3ba251d11b6470232f2f1e896f


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/21e2fed8405b6a3ba251d11b6470232f2f1e896f

mikhail.pozdnyakov@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Status: Started (was: Assigned)
 Issue 757713  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e81350f5bd49d7ef465040667b5626f26258bf7

commit 0e81350f5bd49d7ef465040667b5626f26258bf7
Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Wed Aug 23 12:04:01 2017

Fix crash on LinearAccelerationSensor.start()

Crash happened due to accidental access of a moved
object inside PlatformSensorFusion constructor.

Bug:  757712 
Change-Id: I8b7c9106fbe69e80b3f04f690547cbc92a695946
Reviewed-on: https://chromium-review.googlesource.com/628296
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Cr-Commit-Position: refs/heads/master@{#496661}
[modify] https://crrev.com/0e81350f5bd49d7ef465040667b5626f26258bf7/services/device/generic_sensor/platform_sensor_fusion.cc

Status: Fixed (was: Started)
Issue 758152 has been merged into this issue.

Comment 12 by canx....@intel.com, Aug 25 2017

I will verify them once the CL(https://chromium-review.googlesource.com/628296)landed in Chrome canary build.
Thanks.
Labels: TE-Verified-M62 TE-Verified-62.0.3196.0
Tested the issue on Windows 7, Mac 10.12.6, Ubuntu 14.04 using Chrome Canary version M62 - 62.0.3196.0 as per the issue mentioned in original comment. Observed that issue is working as intended (After enabling the flag "Generic Sensor" and running the code given in the original comment is not leading Chrome to Crash). Hence adding TE-Verified label. Attached the screencast for reference.

Thank you!
757712.webm
5.7 MB View Download

Comment 14 by canx....@intel.com, Aug 31 2017

QA verified this issue, it has been fixed.
Thanks.

Sign in to add a comment