Currently, old system notifications are still kept using chrome://flags#enable-message-center-new-style-notification . They have to be removed once the feature is launched.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/259450762b26c56504650f27f06405507d33e7bf commit 259450762b26c56504650f27f06405507d33e7bf Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Dec 04 04:02:18 2017 Remove IsNewStyleNotificationEnabled checks from ash/ As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL does not remove ash::system_notifier::CreateSystemNotification right now, as we also have to remove ununsed old |icon| assets with it. BUG= 757703 Change-Id: Ibb7e8cdbf01068489b2c0f17443a66043834f1eb Reviewed-on: https://chromium-review.googlesource.com/802658 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#521268} [modify] https://crrev.com/259450762b26c56504650f27f06405507d33e7bf/ash/system/screen_security/screen_capture_tray_item.cc [modify] https://crrev.com/259450762b26c56504650f27f06405507d33e7bf/ash/system/screen_security/screen_share_tray_item.cc [modify] https://crrev.com/259450762b26c56504650f27f06405507d33e7bf/ash/system/system_notifier.cc [modify] https://crrev.com/259450762b26c56504650f27f06405507d33e7bf/ash/system/system_notifier.h [modify] https://crrev.com/259450762b26c56504650f27f06405507d33e7bf/ash/system/tray_accessibility.cc [modify] https://crrev.com/259450762b26c56504650f27f06405507d33e7bf/ash/system/tray_caps_lock.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2 commit 3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Dec 06 04:35:07 2017 Remove IsNewStyleNotificationEnabled checks from chrome/browser/chromeos As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL makes following changes. - Remove IsNewStyleNotificationEnabled checks under chrome/browser/chromeos. (*.cc) - Remove UI strings that are no longer used. (*.grdp) - Remove icons that are no longer used. (*.png, *.icon) Icons that are not removed are referenced in somewhere. BUG= 757703 Change-Id: I46e52295115c3e0a619d1eeefb02321034ce5117 Reviewed-on: https://chromium-review.googlesource.com/802601 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#522004} [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/ash/resources/ash_resources.grd [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ash/resources/default_100_percent/cros/network/statusbar_vpn_dark.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ash/resources/default_200_percent/cros/network/statusbar_vpn_dark.png [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/app/chromeos_strings.grdp [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/chrome/app/theme/default_100_percent/cros/notification_play_store.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/chrome/app/theme/default_200_percent/cros/notification_play_store.png [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/chrome/app/vector_icons/arc_migrate_encryption_notification.icon [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/arc/arc_auth_notification.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/eol_notification.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/hats/hats_notification_controller.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/net/network_state_notifier.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/chrome/browser/chromeos/printing/cups_print_job_notification.cc [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/components/vector_icons/BUILD.gn [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/components/vector_icons/notifications_off.icon [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ui/chromeos/resources/default_100_percent/print_notification/print_job_done.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ui/chromeos/resources/default_100_percent/print_notification/print_job_error.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ui/chromeos/resources/default_100_percent/print_notification/print_job_printing.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ui/chromeos/resources/default_200_percent/print_notification/print_job_done.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ui/chromeos/resources/default_200_percent/print_notification/print_job_error.png [delete] https://crrev.com/9b99a43fc119a2533a87e2357cad8f603779a7b9/ui/chromeos/resources/default_200_percent/print_notification/print_job_printing.png [modify] https://crrev.com/3eb22b88c77205cbcf5bec3549cc5fb1440d1ec2/ui/chromeos/resources/ui_chromeos_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b77b93162006ceb603a506dacabd91f03683ff8 commit 2b77b93162006ceb603a506dacabd91f03683ff8 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Dec 13 02:32:33 2017 Remove IsNewStyleNotificationEnabled checks from chrome/browser As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL makes following changes. - Remove IsNewStyleNotificationEnabled checks under chrome/browser. (*.cc) - Remove icons that are no longer used. (*.png, *.icon) Icons that are not removed are referenced in somewhere. Bug: 757703 Change-Id: Ibfd26747c05d516140026718c093f18bac443cfe Reviewed-on: https://chromium-review.googlesource.com/810348 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#523660} [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/app/generated_resources.grd [delete] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/chrome/app/theme/default_100_percent/common/notification_alert.png [delete] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/chrome/app/theme/default_200_percent/common/notification_alert.png [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/chrome/app/vector_icons/file_download_incognito.1x.icon [delete] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/chrome/app/vector_icons/file_download_incognito.icon [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/browser/download/notification/download_item_notification.cc [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/browser/download/notification/download_notification_browsertest.cc [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/browser/signin/signin_error_notifier_ash.cc [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/browser/sync/sync_error_notifier_ash.cc [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/browser/ui/ash/chrome_screenshot_grabber.cc [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/chrome/browser/ui/extensions/extension_installed_notification.cc [modify] https://crrev.com/2b77b93162006ceb603a506dacabd91f03683ff8/components/vector_icons/BUILD.gn [delete] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/components/vector_icons/error_circle.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009 commit 5735cf1d89e23baa6c1e4edc6541d9fd1eed6009 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Dec 15 02:17:35 2017 Remove GetDeprecatedAcceleratorImage(). This CL removes ash::ShellDelegate::GetDeprecatedAcceleratorImage(). This is only used in accelerator_controller.cc as an argument of system_notifier::CreateSystemNotification(), which is ignored. This CL also replaces system_notifier::CreateSystemNotification() by message_center::Notification::CreateSystemNotification(), because the former function just forwards to the latter. IDR_BLUETOOTH_KEYBOARD is not removed, because it's still used in chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html BUG= 757703 Change-Id: I92f5a982c817cec34f8d508a11cf813a1caec5fb Reviewed-on: https://chromium-review.googlesource.com/826663 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#524293} [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/shell/shell_delegate_impl.h [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/shell_delegate.h [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/shell_delegate_mus.cc [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/shell_delegate_mus.h [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/test_shell_delegate.cc [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/ash/test_shell_delegate.h [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/chrome/browser/ui/ash/chrome_shell_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f24e7a943b9bbe2dae866eec2279525af4cd4983 commit f24e7a943b9bbe2dae866eec2279525af4cd4983 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Dec 19 03:15:00 2017 Use CreateSystemNotification instead of directly calling ctor. When creating Chrome OS system notification, it is encouraged to use CreateSystemNotification instead of directly calling Notification constructor. By using CreateSystemNotification, we don't have to call all the setters on each call site. (set_small_image, set_vector_small_image, set_accent_color) This was not possible before, because we had two different notification classes. (One in ui/message_center, and another in chrome/browser/notifications. Removed in https://crrev.com/c/699797) BUG= 757703 Change-Id: I024584839c38ac442bc045f27285ddb458d16315 Reviewed-on: https://chromium-review.googlesource.com/822317 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#524928} [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/chromeos/eol_notification.cc [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/chromeos/hats/hats_notification_controller.cc [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/signin/signin_error_notifier_ash.cc [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/sync/sync_error_notifier_ash.cc [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/ui/ash/chrome_screenshot_grabber.cc [modify] https://crrev.com/f24e7a943b9bbe2dae866eec2279525af4cd4983/chrome/browser/ui/extensions/extension_installed_notification.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8adbb294ac2832f51cde5bbbdefb76c3ad507eef commit 8adbb294ac2832f51cde5bbbdefb76c3ad507eef Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Dec 19 03:32:57 2017 Remove system_notifier::CreateSystemNotification. system_notifier::CreateSystemNotification is a proxy function that just calls message_center::Notification::CreateSystemNotification. The only difference they have is that system_notifier's one ignores 5-th argument |icon|. (It was previously doing flag checking.) This CL makes following changes: - Remove system_notifier::CreateSystemNotification. - Replace all system_notifier::CreateSystemNotification calls by message_center::Notification::CreateSystemNotification. (*.cc) - Remove icons that are no longer used. (*.png, *.icon) Icons that are not removed are referenced in somewhere. List of such icons (ref count > 0 still): - kSystemMenuTimerIcon - kSystemMenuAccessibilityIcon - IDR_AURA_NOTIFICATION_DISPLAY - IDR_AURA_UBER_TRAY_NETWORK_NOTIFICATION_LTE - IDR_AURA_UBER_TRAY_NETWORK_NOTIFICATION_3G - IDR_DISK_SPACE_NOTIFICATION_CRITICAL - IDR_STORAGE_MANAGER_BUTTON BUG= 757703 Change-Id: I6e5995191da9166a730c97e3d73dcb86671ff7e2 Reviewed-on: https://chromium-review.googlesource.com/822556 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#524934} [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/display/display_util.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/resources/ash_resources.grd [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/notification/notification_battery_critical_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/notification/notification_battery_fluctuating_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/notification/notification_battery_low_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/notification/notification_bluetooth_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/notification/notification_low_power_charger.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/notification/notification_peripheral_battery_low.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/status/status_locale.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/status/status_screenshare.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_100_percent/cros/status/status_screenshare_dark.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/notification/notification_battery_critical_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/notification/notification_battery_fluctuating_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/notification/notification_battery_low_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/notification/notification_bluetooth_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/notification/notification_low_power_charger.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/notification/notification_peripheral_battery_low.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/status/status_locale.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/status/status_screenshare.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/default_200_percent/cros/status/status_screenshare_dark.png [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/resources/vector_icons/BUILD.gn [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/vector_icons/notification_display_error.icon [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/vector_icons/notification_feedback_button.1x.icon [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/vector_icons/notification_feedback_button.icon [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ash/resources/vector_icons/system_menu_sms.icon [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/bluetooth/bluetooth_notification_controller.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/locale/locale_notification_controller.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/network/sms_observer.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/power/battery_notification.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/power/dual_role_notification.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/power/peripheral_battery_notifier.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/power/tray_power.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/screen_layout_observer.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/screen_security/screen_capture_tray_item.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/screen_security/screen_share_tray_item.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/session/tray_session_length_limit.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/supervised/tray_supervised_user.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/system_notifier.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ash/system/system_notifier.h [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/app/theme/default_100_percent/cros/captive_portal_icon.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/chrome/app/theme/default_200_percent/cros/captive_portal_icon.png [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/chrome/browser/chromeos/net/network_portal_notification_controller.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/chrome/browser/chromeos/status/data_promo_notification.cc [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/chrome/browser/chromeos/ui/low_disk_notification.cc [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ui/chromeos/resources/default_100_percent/filesystem/notification_disk_space_low.png [delete] https://crrev.com/9e12fa765e2b878bb57c1d6a73655e0f162e7027/ui/chromeos/resources/default_200_percent/filesystem/notification_disk_space_low.png [modify] https://crrev.com/8adbb294ac2832f51cde5bbbdefb76c3ad507eef/ui/chromeos/resources/ui_chromeos_resources.grd
Comment 1 by tetsui@chromium.org
, Dec 1 2017