New issue
Advanced search Search tips

Issue 757680 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ChromeTestExtensionLoader does not support failed loading of an unpacked extension.

Project Member Reported by karandeepb@chromium.org, Aug 22 2017

Issue description

If we unsuccessfully try to load an unpacked extension using the ChromeTestExtensionLoader, it enters into an endless runloop since only successful loads are supported for unpacked extensions. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b794ad5740574fd211514773ee703b9468269d1b

commit b794ad5740574fd211514773ee703b9468269d1b
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Tue Aug 22 22:13:14 2017

ChromeTestExtensionLoader: Add support for failed unpacked extensions load.

If an unpacked extension is loaded unsuccessfully using the
ChromeTestExtensionLoader, it enters an endless loop since it keeps waiting for
the extension to be loaded successfully. This CL adds support for the
|should_fail_| parameter to unpacked extensions, so that load errors can be
tested for unpacked extensions as well.

BUG= 757680 

Change-Id: I3fd9009522a31368f741da8d72178f54b9cfc82b
Reviewed-on: https://chromium-review.googlesource.com/625070
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496468}
[modify] https://crrev.com/b794ad5740574fd211514773ee703b9468269d1b/chrome/browser/extensions/chrome_test_extension_loader.cc
[modify] https://crrev.com/b794ad5740574fd211514773ee703b9468269d1b/chrome/browser/extensions/chrome_test_extension_loader.h

Status: Fixed (was: Assigned)

Sign in to add a comment