Spoke with Allen - revising this edit to be 12pt, not 10, to match divisible harmony units. 

------

Original Harmony spacing between label and control: 16pt
Updated Harmony spacing between label and control: 12pt

The spec originally wanted 16pt between label and control, to match with Harmony grid. Harmony grid has been relaxed a bit since then + feedback for closer spacing considered. 

*12pt should be applied to elements in the bookmarks bar as well

Deleted: 01.png 36.6 KB

	01.png 36.6 KB View Download

Deleted: 02.png 146 KB

	02.png 146 KB View Download

I think 12 pt in the bookmark bar is too much.  It's currently 8 in Harmony and used to be more like 5 pre-Harmony.  I think it should stay as 8.

12 seems OK between labels and controls, but what was wrong with 10?  Or even 8 there as well, as was originally suggested long ago?

->bettes until he and I have convinced each other to align on a behavior here, then will probably be ->kylixrd

I used DISTANCE_RELATED_LABEL_HORIZONTAL for the space between a table cell's icon and its text. It looks odd if it doesn't match DISTANCE_TABLE_CELL_HORIZONTAL_MARGIN, so keep that in mind when implementing this. I think I should have made it a separate metric after all.

IIRC, keeping DISTANCE_RELATED_LABEL_HORIZONTAL and DISTANCE_TABLE_CELL_HORIZONTAL_MARGIN consistent was a cleaner and more consistent approach. 

We're trying not to diverge from the 16/8/4 spacing that seems to be working in other places. 

I'd prefer not to spend too many cycles debating this issue. We can always tweak it if it doesn't work out, but the 12px spacing feels like a comfortable median. It'll also open up the range of what designers can do on desktop if they aren't confined to such tight/dense arrangements. 

Attachments comparing 8 and 12

Deleted: bkmk-8.png 575 KB

	bkmk-8.png 575 KB View Download

Deleted: bkmk-12.png 575 KB

	bkmk-12.png 575 KB View Download

Given those screenshots, I'm reaaaally uncomfortable making the bookmarks bar be 12.  The icon and text already feel a little spaced out from each other at 8, and we had a couple user bugs filed on it being too large at 8 (even though Harmony isn't default yet!).  12 looks very strange to me.  And 8 is more in keeping with 16/8/4.  Can we just leave as 8?  I guess I don't understand the larger context of opening up design range here to go from 8 to 12 in the bookmarks bar alone.

12 is the distance between radio/checkbox and label, so the change recommended here isn't in the bookmarks bar alone. 

Passing this to bsep to triage. Nothing has changed since c10

You didn't really respond to Peter's concerns in #9. It isn't clear to me either what you mean by "opening up the range of what designers can do."

I actually agree with Peter here: 12pt looks strange on the bookmarks bar, like the icons aren't associated with their labels. It's not ideal that we're using a one-off spacing here, but the bookmarks bar needs to look good too.

The actual technical work here is trivial so I can fire off a patch if the disagreement is resolved.

One strategy for validation would be to make the change and let us all see it in Canary. I'd rather not discuss this any further until we can evaluate it IRL.
 
Re: opening up the range of what designers can do.

This is about the relationship between icons and labels in various areas of Chrome. An example of this is in the new omnibox suggestions launching in Q1 (see below). 

https://docs.google.com/presentation/d/1FORT1XkTkc1r5BBWydxN5Y5e1Vjn5-ZkpZzGq5UUZ6E/edit#slide=id.g1ea3466fe1_1_105

 Issue 794480  has been merged into this issue.

 Bug 794480  comment 5 has some commentary about implementation.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7512a8bb8f1b45dda88cdbf6500d143c23cdf62c

commit 7512a8bb8f1b45dda88cdbf6500d143c23cdf62c
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jan 12 21:08:00 2018

Reduce Harmony icon/label spacing globally.

This patch:
* Changes DISTANCE_RELATED_LABEL_HORIZONTAL and
  DISTANCE_RELATED_LABEL_HORIZONTAL_LIST to be consistent, at 12pt.
* Merges DISTANCE_BUTTON_IMAGE_LABEL_PADDING with
  DISTANCE_RELATED_LABEL_HORIZONTAL.
* Changes DISTANCE_TABLE_CELL_HORIZONTAL_MARGIN to also be 12pt, so
  table cells look even.

Bug:  757673 
Change-Id: I02ca44856e370cfaebd1fdf1579444aa30b965a2
Reviewed-on: https://chromium-review.googlesource.com/861914
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529066}
[modify] https://crrev.com/7512a8bb8f1b45dda88cdbf6500d143c23cdf62c/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/7512a8bb8f1b45dda88cdbf6500d143c23cdf62c/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/7512a8bb8f1b45dda88cdbf6500d143c23cdf62c/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/7512a8bb8f1b45dda88cdbf6500d143c23cdf62c/ui/views/layout/layout_provider.h