Separate logic of StartTryJobOnDemandPipeline to a service module. Add a pipeline specifically for compile failures.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f304d7789f3ed26e48f0e6f9240de864b3d1dca1 commit f304d7789f3ed26e48f0e6f9240de864b3d1dca1 Author: Chan <chanli@chromium.org> Date: Tue Sep 19 00:25:12 2017 [Findit] separate logic of start_try_job_on_demand_pipeline. 1. Move try_job_util.py to service/ and rename it to try_job.py 2. Move failure specific logic in try_job.py to failure specific modules 3. Move logic in start_try_job_on_demand_pipeline to above service modules This CL is only refactoring the code. Bug: 757665 Change-Id: I8e1272c702ffc3b1c260f9a5a43eb8ab7ebff9ea Reviewed-on: https://chromium-review.googlesource.com/665962 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [add] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/compile_failure/test/compile_try_job_test.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/test/gtest_test.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py [add] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/test/try_job_test.py [add] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/compile_failure/compile_try_job.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/test_failure/ci_test_failure.py [delete] https://crrev.com/01be310f56a8f06933ce8fb282144ae7e0e1845d/appengine/findit/waterfall/try_job_util.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/gtest.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/waterfall/process_swarming_tasks_result_pipeline.py [add] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/try_job.py [delete] https://crrev.com/01be310f56a8f06933ce8fb282144ae7e0e1845d/appengine/findit/waterfall/test/try_job_util_test.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/waterfall/test/process_swarming_tasks_result_pipeline_test.py [add] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/test_failure/test/test_try_job_test.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/test_failure/test/ci_test_failure_test.py [modify] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py [add] https://crrev.com/f304d7789f3ed26e48f0e6f9240de864b3d1dca1/appengine/findit/services/test_failure/test_try_job.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b4344ad6d9ec8b2a195281c0d641213267ecced1 commit b4344ad6d9ec8b2a195281c0d641213267ecced1 Author: Chan <chanli@chromium.org> Date: Fri Sep 22 00:44:05 2017 [Findit] Add sub pipelines to start try jobs based on failure type. Bug: 757665 Change-Id: I322578260faa9e48b7d2a227409dc7b5ca8d5aa4 Reviewed-on: https://chromium-review.googlesource.com/674173 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [add] https://crrev.com/b4344ad6d9ec8b2a195281c0d641213267ecced1/appengine/findit/pipelines/test_failure/start_test_try_job_pipeline.py [add] https://crrev.com/b4344ad6d9ec8b2a195281c0d641213267ecced1/appengine/findit/pipelines/test_failure/test/start_test_try_job_pipeline_test.py [add] https://crrev.com/b4344ad6d9ec8b2a195281c0d641213267ecced1/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py [add] https://crrev.com/b4344ad6d9ec8b2a195281c0d641213267ecced1/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py
Comment 1 by chanli@chromium.org
, Sep 12 2017