Separate logic of IdentifyTryJobCulpritPipeline to a service module. Add a pipeline specifically for compile failures.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2f737fd6715f62eae0be3cad59c5cb8f98911485 commit 2f737fd6715f62eae0be3cad59c5cb8f98911485 Author: Chan <chanli@chromium.org> Date: Thu Sep 21 17:23:39 2017 [Findit] Refactor: Add subpipelines to identify suspects based on failure type. Bug: 757664 , 764531 Change-Id: I2a6c92c3c3584f2cf2ed36cb8f8bd310af169c73 Reviewed-on: https://chromium-review.googlesource.com/674025 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [add] https://crrev.com/2f737fd6715f62eae0be3cad59c5cb8f98911485/appengine/findit/pipelines/test_failure/test/identify_test_failure_suspect_pipeline_test.py [add] https://crrev.com/2f737fd6715f62eae0be3cad59c5cb8f98911485/appengine/findit/pipelines/compile_failure/test/identify_compile_failure_suspect_pipeline_test.py [add] https://crrev.com/2f737fd6715f62eae0be3cad59c5cb8f98911485/appengine/findit/pipelines/compile_failure/identify_compile_failure_suspect_pipeline.py [add] https://crrev.com/2f737fd6715f62eae0be3cad59c5cb8f98911485/appengine/findit/pipelines/test_failure/identify_test_failure_suspect_pipeline.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/323ae81fc45084b8efc03a1c76921effc1e3d847 commit 323ae81fc45084b8efc03a1c76921effc1e3d847 Author: Chan <chanli@chromium.org> Date: Mon Sep 25 18:41:04 2017 [Findit] Refactor: Add a subpipeline to identify try job culprits for compile failures. The new pipeline is a subset of https://chromium.googlesource.com/infra/infra/+/refs/heads/master/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py. And also in the new pipeline it calls the new subpipeline to revert the culprit and send notification. Bug: 757664 Change-Id: I071ecfaab8e0de713a51f1ad07e3ae070990cfca Reviewed-on: https://chromium-review.googlesource.com/677094 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/compile_failure/test/compile_try_job_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/compile_failure/compile_failure_analysis.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/build_failure_analysis.py [add] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/pipelines/compile_failure/test/identify_compile_try_job_culprit_pipeline_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/test/try_job_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/compile_failure/compile_try_job.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/pipelines/compile_failure/test/start_compile_try_job_pipeline_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/pipelines/compile_failure/start_compile_try_job_pipeline.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/test/build_failure_analysis_test.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py [add] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/pipelines/compile_failure/identify_compile_try_job_culprit_pipeline.py [modify] https://crrev.com/323ae81fc45084b8efc03a1c76921effc1e3d847/appengine/findit/services/try_job.py
Comment 1 by bugdroid1@chromium.org
, Sep 21 2017