in chrome://extensions in the details page, the rows have different styling than other MD pages. TODO make the styling common and load from cr_elements.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f8ddb0a186d92a8dc249d41d128cae7a328eebb commit 6f8ddb0a186d92a8dc249d41d128cae7a328eebb Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Aug 23 21:53:40 2017 [MD Extensions] move row styling into --cr-section This CL moves common UI styling into a common --cr-section variable for use in MD Extensions. Bug: 757663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I23be3eaaa1529654c06a7a43f260520782a0e58e Reviewed-on: https://chromium-review.googlesource.com/625242 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#496821} [modify] https://crrev.com/6f8ddb0a186d92a8dc249d41d128cae7a328eebb/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/6f8ddb0a186d92a8dc249d41d128cae7a328eebb/chrome/browser/resources/settings/controls/settings_toggle_button.html [modify] https://crrev.com/6f8ddb0a186d92a8dc249d41d128cae7a328eebb/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/6f8ddb0a186d92a8dc249d41d128cae7a328eebb/chrome/browser/resources/settings/settings_vars_css.html [modify] https://crrev.com/6f8ddb0a186d92a8dc249d41d128cae7a328eebb/ui/webui/resources/cr_elements/shared_vars_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45291332ba537851a413c31da777a9c9293f45ad commit 45291332ba537851a413c31da777a9c9293f45ad Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Aug 25 20:46:29 2017 [MD extensions] details colors and section var This Cl changes the Extensions details view colors to match the MD style in other webui pages. Also fixes typo on --cr-section var. TBR=scottchen@chromium.org Bug: 757663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icfa4d125f19dd7b242bdce8129d5bba8b892c413 Reviewed-on: https://chromium-review.googlesource.com/633854 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#497528} [modify] https://crrev.com/45291332ba537851a413c31da777a9c9293f45ad/chrome/browser/resources/md_extensions/detail_view.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8db6db057c0d4a11d2e5040b926dd96777fc48bc commit 8db6db057c0d4a11d2e5040b926dd96777fc48bc Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Aug 28 22:00:37 2017 [MD extensions] cr-primary-text; extensions item styling This CL adds cr-primary-text for styling primary text consistently across webui. Also provides and example use in md extensions item.html (along with other cr-* style changes). Bug: 757663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88caa32c266880643ca3a09378ceb2800419efe9 Reviewed-on: https://chromium-review.googlesource.com/636177 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#497890} [modify] https://crrev.com/8db6db057c0d4a11d2e5040b926dd96777fc48bc/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/8db6db057c0d4a11d2e5040b926dd96777fc48bc/ui/webui/resources/cr_elements/shared_vars_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1e22875b9829a624071bd104962ee3bf79eba74 commit e1e22875b9829a624071bd104962ee3bf79eba74 Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue Aug 29 23:04:58 2017 [MD extensions] add cr-link-row This CL adds a light cr-link-row extension for <button> to encapsulate horizontal rows for subpage links and external links. Bug: 757663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If11b08fea0e37b96f3fc025afaf5e9dc3bdb308e Reviewed-on: https://chromium-review.googlesource.com/636150 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#498273} [modify] https://crrev.com/e1e22875b9829a624071bd104962ee3bf79eba74/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/e1e22875b9829a624071bd104962ee3bf79eba74/ui/webui/resources/cr_elements/compiled_resources2.gyp [add] https://crrev.com/e1e22875b9829a624071bd104962ee3bf79eba74/ui/webui/resources/cr_elements/cr_link_row/compiled_resources2.gyp [add] https://crrev.com/e1e22875b9829a624071bd104962ee3bf79eba74/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html [add] https://crrev.com/e1e22875b9829a624071bd104962ee3bf79eba74/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js [modify] https://crrev.com/e1e22875b9829a624071bd104962ee3bf79eba74/ui/webui/resources/cr_elements_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6aa64faed7569dc488e300e6d3c93ae9e913f38 commit c6aa64faed7569dc488e300e6d3c93ae9e913f38 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Aug 31 22:13:37 2017 [MD cr] cr-secondary-text This CL replaces --settings-secondary with --cr-secondary-text css variable so that a consistent secondary text style can be used across MD webui. Bug: 757663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I26dea8cce24d3109dc4114a202dd97a30c70417c Reviewed-on: https://chromium-review.googlesource.com/634465 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#499036} [modify] https://crrev.com/c6aa64faed7569dc488e300e6d3c93ae9e913f38/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/c6aa64faed7569dc488e300e6d3c93ae9e913f38/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/c6aa64faed7569dc488e300e6d3c93ae9e913f38/chrome/browser/resources/settings/settings_vars_css.html [modify] https://crrev.com/c6aa64faed7569dc488e300e6d3c93ae9e913f38/ui/webui/resources/cr_elements/shared_vars_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/673e8a437f569bff9705e9b6e9883d25b795d384 commit 673e8a437f569bff9705e9b6e9883d25b795d384 Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue Sep 12 21:06:38 2017 [cr ui] use cr-link-row in MD settings This CL expands the usage of cr-link-row into settings. This doesn't replace all instances of link rows. It's a sampling of a few different cases. Changes UI for: device display overscan, customize fonts, passwords and forms links. Bug: 757663 , 763177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id63d8b8c5a6c3c36e6804018ea66d8d03679f1ad Reviewed-on: https://chromium-review.googlesource.com/656527 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501394} [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c31a7fd20c45dd90838b9886302b87e58e6d3d16 commit c31a7fd20c45dd90838b9886302b87e58e6d3d16 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Sep 29 19:32:53 2017 [cr webui] cr-link-row in appearance This CL adds a slot to cr-link-row (currently used for policy indicator), removes the border on cr-link-row, adds .hr class, and completes the changeover to cr-link-row in the appearance_page. Bug: 757663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic4fca205c855c077b53b487e7db1f54d0d2f47f8 Reviewed-on: https://chromium-review.googlesource.com/679482 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505442} [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/chrome/browser/resources/settings/appearance_page/appearance_page.js [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/chrome/test/data/webui/settings/appearance_page_test.js [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html [modify] https://crrev.com/c31a7fd20c45dd90838b9886302b87e58e6d3d16/ui/webui/resources/cr_elements/shared_style_css.html
Comment 1 by bugdroid1@chromium.org
, Aug 23 2017