New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 757667

Blocking:
issue 754527
issue 759774



Sign in to add a comment

[Findit] Refactor IdentifyCulpritPipeline

Project Member Reported by chanli@chromium.org, Aug 22 2017

Issue description

Separate logic of IdentifyCulpritPipeline to a service module.
Add a pipeline specifically for compile failures.
 

Comment 1 by chanli@chromium.org, Aug 22 2017

Blocking: 757517

Comment 2 by chanli@chromium.org, Aug 28 2017

Blockedon: 757667

Comment 3 by chanli@chromium.org, Aug 28 2017

Blocking: -757517 759774
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f4440177a18c37caf33e04c87c319cec4beb8b4b

commit f4440177a18c37caf33e04c87c319cec4beb8b4b
Author: Chan <chanli@chromium.org>
Date: Wed Sep 06 17:26:36 2017

[Findit] separate logic of analyzing build failures based on failure type.

And move the logic to service layer.

This is a refactoring change.

Bug:  757661 
Change-Id: I50580be35477e43bc4ee641ed305196892ebe60f
Reviewed-on: https://chromium-review.googlesource.com/648171
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/handlers/test/list_analyses_test.py
[add] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/services/compile_failure/compile_failure_analysis.py
[rename] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/services/build_failure_analysis.py
[add] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/services/test_failure/test_failure_analysis.py
[add] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/waterfall/test/identify_culprit_pipeline_test.py
[add] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[delete] https://crrev.com/9b0da5125907d943cd34aefef46ca3923414cf90/appengine/findit/waterfall/test/build_failure_analysis_test.py
[modify] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/waterfall/identify_culprit_pipeline.py
[add] https://crrev.com/f4440177a18c37caf33e04c87c319cec4beb8b4b/appengine/findit/services/test_failure/test/test_failure_analysis_test.py

Comment 5 by chanli@chromium.org, Sep 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment