Separate logic of extract_signals_pipeline to a service module
Also add a subpipeline specifically for compile failures.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58 commit 73df5c9cc0d0a66a7e84d3b97085e62ec1085f58 Author: Chan <chanli@chromium.org> Date: Tue Aug 29 17:58:51 2017 [Findit] Separate logic in extract_signal_pipeline to a service module. Bug:757659 Change-Id: Ifba00507ec6e188d8ef244671dbf849f19b76df2 Reviewed-on: https://chromium-review.googlesource.com/639574 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [rename] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/test/data/m_b_125_abc_test.json [modify] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/test/gtest_test.py [rename] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/test/data/m_b_124_abc_test.json [modify] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/waterfall/test/extract_signal_pipeline_test.py [add] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/extract_signal.py [modify] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/gtest.py [modify] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/waterfall/extract_signal_pipeline.py [add] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/test/extract_signal_test.py [rename] https://crrev.com/73df5c9cc0d0a66a7e84d3b97085e62ec1085f58/appengine/findit/services/test/data/m_b_123_abc_test.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/4e86636f2270a8d1475ef1f54f42c07e4445ab0f commit 4e86636f2270a8d1475ef1f54f42c07e4445ab0f Author: Chan <chanli@chromium.org> Date: Thu Aug 31 00:34:33 2017 [Findit] Separate logic for extacting signals based on failure type. In preparation of separating pipelines for compile and test failures, separate the logics first. This change is pretty much refactoring. Bug: 757659 Change-Id: Ib59fabd26414f97e0efa943d173e07b56a16ae63 Reviewed-on: https://chromium-review.googlesource.com/642015 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [delete] https://crrev.com/8bd7ec93ec67455eed4e7ae85c8eb3afe4158f3b/appengine/findit/services/test/data/m_b_125_abc_test.json [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test/gtest_test.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test/data/m_b_124_abc_test.json [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/waterfall/test/extract_signal_pipeline_test.py [add] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/compile_failure/test/__init__.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/extract_signal.py [add] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/compile_failure/extract_compile_signal.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/waterfall/test/buildbot_test.py [add] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test_failure/extract_test_signal.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/gtest.py [add] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test_failure/test/__init__.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/waterfall/extract_signal_pipeline.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test/extract_signal_test.py [add] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test_failure/test/extract_test_signal_test.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/test/data/m_b_123_abc_test.json [add] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/services/compile_failure/test/extract_compile_signal_test.py [modify] https://crrev.com/4e86636f2270a8d1475ef1f54f42c07e4445ab0f/appengine/findit/waterfall/buildbot.py
Comment 1 by chanli@chromium.org
, Aug 22 2017