Separate logic of detect first failure to a service module.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/906c23f989d613e6d8322be48fcf62ca56597909 commit 906c23f989d613e6d8322be48fcf62ca56597909 Author: Chan <chanli@chromium.org> Date: Fri Aug 25 23:53:00 2017 [Findit] Refactor detect_first_failure_pipeline 1. Move the logic of the pipeline to a separate service module 2. Move the logic of examing current failure to build_failure_analysis_pipelines (before pipelines) Bug: 754527 , 757657 Change-Id: Iad16582294dc8e40c90e1741c8e20647511cf6d6 Reviewed-on: https://chromium-review.googlesource.com/620008 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py [add] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/services/test/gtest_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/detect_first_failure_pipeline.py [add] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/build_failure_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/services/gtest.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/build_util.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/build_failure_analysis_pipelines.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/handlers/test/process_failure_analysis_requests_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/analyze_build_failure_pipeline.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/handlers/test/build_failure_test.py [modify] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/test/build_util_test.py [add] https://crrev.com/906c23f989d613e6d8322be48fcf62ca56597909/appengine/findit/waterfall/build_failure.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b283f124b3610104b580b3f1431798c7002d8f3f commit b283f124b3610104b580b3f1431798c7002d8f3f Author: Chan <chanli@chromium.org> Date: Fri Sep 01 18:23:49 2017 [Findit] Separate build_failure based on failure_type Move waterfall/build_failure.py to service/ Move test failure specific logic to service/test_failure/test_build_failure This is a refactoring CL. Bug: 757657 Change-Id: Ia30c576dc14165aef8fa264b75a0e648eb88ac42 Reviewed-on: https://chromium-review.googlesource.com/646380 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_223_abc_test_flaky.json [modify] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py [modify] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/waterfall/build_failure_analysis_pipelines.py [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_123.json [add] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/sample_swarming_build_abctest_tasks.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_222_abc_test.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/isolatedhashabctest [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_122_abc_test.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/abctestoutputjsonhash [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_122.json [delete] https://crrev.com/9e5fd2d5113a1d6148820d1c4f3fa54aaa853bdd/appengine/findit/waterfall/test/build_failure_test.py [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test_failure/ci_test_failure.py [modify] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_221_abc_test.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_223.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_0.json [add] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test_failure/test/ci_test_failure_test.py [modify] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/handlers/test/build_failure_test.py [add] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/ci_failure.py [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_1.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_121.json [rename] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/data/m_b_223_abc_test.json [modify] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/waterfall/detect_first_failure_pipeline.py [add] https://crrev.com/b283f124b3610104b580b3f1431798c7002d8f3f/appengine/findit/services/test/ci_failure_test.py
Comment 1 by chanli@chromium.org
, Aug 22 2017