Add back 1px hairline for focused input fields |
|||||||||||||||||||||||
Issue descriptionActual: When a text input or select box is focused, a soft blue ring replaces the 1px outline Expected: Keep the 1px outline when control is focused. This will match the behavior seen on secondary (white) buttons
,
Aug 22 2017
,
Aug 23 2017
Gonna farm out this focus state stuff to Trent
,
Aug 24 2017
https://chromium-review.googlesource.com/631456 But there's a quirk. Which requires us to answer the following: - How should buttons in the downloads bar indicate focus? Current (non-harmony): They get a blue border - same as textfield Current (harmony): There is no focus indication - separator disappears (bug!) Simplest fix for this issue: They get a *grey* border when focused (no focus ring) - looks kinda weird Slightly better fix for this issue (and the bug!, above): Modify download_item_view.cc to always use kColorId_FocusedBorderColor Also attaching screenshot of textfield/Combobox for reference.
,
Aug 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11b7b5d13d4c1e6c5045310838b3def0286e2c84 commit 11b7b5d13d4c1e6c5045310838b3def0286e2c84 Author: Trent Apted <tapted@chromium.org> Date: Sun Aug 27 23:56:42 2017 Views: Retain the (unfocused) border on focused Harmony text fields. This affects Textfield, Combobox and buttons on the downloads bar. Currently the unfocused border is not painted at all when these controls have focus. Instead, always paint the border, but keep the unfocused color. Fixes a bug with the downloads bar with --secondary-ui-md where the border disappears. This CL restores the regular behavior for downloads bar buttons (i.e. paint it blue) rather than having it adopt the new Textfield behavior (i.e. paint it grey with a focus ring). Bug: 757656 Change-Id: If1f0248267624b0ec4b80455ea6e351083725153 Reviewed-on: https://chromium-review.googlesource.com/631456 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#497683} [modify] https://crrev.com/11b7b5d13d4c1e6c5045310838b3def0286e2c84/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/11b7b5d13d4c1e6c5045310838b3def0286e2c84/ui/views/controls/focusable_border.cc
,
Aug 28 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bettes@chromium.org
, Aug 22 2017