New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757654 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 754527
issue 757517



Sign in to add a comment

[Findit] Separate logic of creating a revert to a service module.

Project Member Reported by chanli@chromium.org, Aug 22 2017

Issue description

Move business logic in create_revert_cl_pipeline.py to revert.py
 

Comment 1 by chanli@chromium.org, Aug 22 2017

Blocking: 757517
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5ddc471291e27a4040ae4854aab3325de37a428c

commit 5ddc471291e27a4040ae4854aab3325de37a428c
Author: Chan <chanli@chromium.org>
Date: Wed Aug 23 00:39:03 2017

[Findit] Separate logic of creating a revert to a service module.

Bug:  754527 ,  757654 
Change-Id: Ifd34f032c6826df0e5581bad0d359c268f9930d3
Reviewed-on: https://chromium-review.googlesource.com/622280
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/create_revert_cl_pipeline.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/send_notification_to_irc_pipeline.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
[add] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/revert_test.py
[add] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/revert.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py
[modify] https://crrev.com/5ddc471291e27a4040ae4854aab3325de37a428c/appengine/findit/waterfall/submit_revert_cl_pipeline.py

Comment 3 by chanli@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment