Gonna farm out this focus state stuff to Trent

fix -> https://chromium-review.googlesource.com/630259

Is it just when folio.googleplex.com has to load over the Pacific that it's so slow o_O

attaching the linked spec.

https://chromium-review.googlesource.com/c/chromium/src/+/546697 introduced a -2px "in"set, which is needed for radio buttons, and to make room for the focus ring. But that inset needs to be reversed when painting the checkbox focus ring. (It can't simply be removed since that will cause the focus ring to be clipped).

Attaching screenshots for https://chromium-review.googlesource.com/630259

Deleted: SPEC-secondary-UI-04-radio-checkboxes.png 134 KB

	SPEC-secondary-UI-04-radio-checkboxes.png 134 KB View Download

Deleted: checked-FIXED.png 33.0 KB

	checked-FIXED.png 33.0 KB View Download

Deleted: unchecked-FIXED.png 31.1 KB

	unchecked-FIXED.png 31.1 KB View Download

Lol, you'd think that the folio team was take cross-ocean comms as a high priority XD

Thanks Trent. Looks great. 

still need to get the patch reviewed :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b79679cad6ca1fb69b3ecd1c977833fbb95fb741

commit b79679cad6ca1fb69b3ecd1c977833fbb95fb741
Author: Trent Apted <tapted@chromium.org>
Date: Mon Aug 28 19:29:42 2017

Inset checkbox focus rings.

The focus ring bounds are 2px larger than the checkbox so that it is not
clipped. Radio buttons need to do nothing special because they paint from
the centre point. But Checkbox's focus ring paint method needs to remove
this 2px.

Bug:  757653 
Change-Id: Iad4c42d349cef655edc44c976f1edbdd993b590e
Reviewed-on: https://chromium-review.googlesource.com/630259
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497836}
[modify] https://crrev.com/b79679cad6ca1fb69b3ecd1c977833fbb95fb741/ui/views/controls/button/checkbox.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac451a29d52b758818bee8492a99aa8637825f26

commit ac451a29d52b758818bee8492a99aa8637825f26
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Aug 28 23:03:02 2017

Speculatively revert "Inset checkbox focus rings."

This reverts commit b79679cad6ca1fb69b3ecd1c977833fbb95fb741.

Reason for speculative revert:
Breaks test:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62727

Original change's description:
> Inset checkbox focus rings.
> 
> The focus ring bounds are 2px larger than the checkbox so that it is not
> clipped. Radio buttons need to do nothing special because they paint from
> the centre point. But Checkbox's focus ring paint method needs to remove
> this 2px.
> 
> Bug:  757653 
> Change-Id: Iad4c42d349cef655edc44c976f1edbdd993b590e
> Reviewed-on: https://chromium-review.googlesource.com/630259
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497836}

TBR=pkasting@chromium.org,tapted@chromium.org

Change-Id: I8b7b3904ce61e7bb3768bdd25c0ba533e7ce6be7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  757653 
Reviewed-on: https://chromium-review.googlesource.com/639241
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497919}
[modify] https://crrev.com/ac451a29d52b758818bee8492a99aa8637825f26/ui/views/controls/button/checkbox.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e0252247308646430a8ad488ffeb9005f1a653

commit d5e0252247308646430a8ad488ffeb9005f1a653
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Aug 29 00:50:25 2017

Revert "Speculatively revert "Inset checkbox focus rings.""

This reverts commit ac451a29d52b758818bee8492a99aa8637825f26.

Reason for revert:
The speculative revert was unnecessary.

Original change's description:
> Speculatively revert "Inset checkbox focus rings."
> 
> This reverts commit b79679cad6ca1fb69b3ecd1c977833fbb95fb741.
> 
> Reason for speculative revert:
> Breaks test:
> https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62727
> 
> Original change's description:
> > Inset checkbox focus rings.
> > 
> > The focus ring bounds are 2px larger than the checkbox so that it is not
> > clipped. Radio buttons need to do nothing special because they paint from
> > the centre point. But Checkbox's focus ring paint method needs to remove
> > this 2px.
> > 
> > Bug:  757653 
> > Change-Id: Iad4c42d349cef655edc44c976f1edbdd993b590e
> > Reviewed-on: https://chromium-review.googlesource.com/630259
> > Commit-Queue: Trent Apted <tapted@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#497836}
> 
> TBR=pkasting@chromium.org,tapted@chromium.org
> 
> Change-Id: I8b7b3904ce61e7bb3768bdd25c0ba533e7ce6be7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  757653 
> Reviewed-on: https://chromium-review.googlesource.com/639241
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497919}

TBR=pkasting@chromium.org,tapted@chromium.org,tbansal@chromium.org

Bug:  757653 
Change-Id: Ibaa2d17dd2972f6bb10ec296a1ef76508798ff5e
Reviewed-on: https://chromium-review.googlesource.com/639345
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497962}
[modify] https://crrev.com/d5e0252247308646430a8ad488ffeb9005f1a653/ui/views/controls/button/checkbox.cc