New issue
Advanced search Search tips

Issue 757649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 652510



Sign in to add a comment

Checkbox colors incorrect

Project Member Reported by bettes@chromium.org, Aug 22 2017

Issue description

See screenshot
 
checkbox.png
23.1 KB View Download

Comment 1 by bettes@chromium.org, Aug 22 2017

Summary: Checkbox colors incorrect (was: Checkbox_ON wrong color)
ON and OFF state colors incorrect
checkbox_off.png
20.8 KB View Download

Comment 2 by bettes@chromium.org, Aug 22 2017

Blocking: 652510

Comment 3 by bettes@chromium.org, Aug 22 2017

Labels: -Pri-2 Pri-1
Labels: Proj-HarmonyControls
Owner: kylixrd@chromium.org
Status: Assigned (was: Available)
In each of these, is one the "current" and one the "desired" state?
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb54be3058cd3c872f84a6fe200b5a2b64e1401

commit ecb54be3058cd3c872f84a6fe200b5a2b64e1401
Author: Allen Bauer <kylixrd@chromium.org>
Date: Thu Aug 31 15:45:11 2017

Fix the colors of the checkbox/radio button icon for MD mode.

Bug:  757679 ,  757649 
Change-Id: I554d74b41a5b9baeaec4eaf6504ea7f97003b8e5
Reviewed-on: https://chromium-review.googlesource.com/636038
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498874}
[modify] https://crrev.com/ecb54be3058cd3c872f84a6fe200b5a2b64e1401/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/ecb54be3058cd3c872f84a6fe200b5a2b64e1401/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/ecb54be3058cd3c872f84a6fe200b5a2b64e1401/ui/views/controls/button/checkbox.h

Status: Fixed (was: Assigned)

Sign in to add a comment