MacViews - Extension popup arrow chevron misplaced |
|||||||||
Issue descriptionChrome Version: 62.3192 OS: Mac OSX What steps will reproduce the problem? (1) Enable chrome://flags/#secondary-ui-md (2) Restart. (3) Click an extension's toolbar button. What is the expected result? Arrow is centered. What happens instead? Arrow is right-aligned. I'm not entirely sure my configuration is a valid one (I had turned on this switch to test something else) but figured I should file to check.
,
Aug 22 2017
Thanks! yeah this isn't wired up yet, so the window is Cocoa instead of views. Cocoa windows don't know how to anchor MD-stylee. Issue 728174 is where the conversion for this dialog is tracked, but I've marked that non-blocking. Whereas this anchoring needs to be fixed before we launch, so I guess we should keep it.
,
Sep 5 2017
,
Sep 5 2017
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Nov 13 2017
I reproduced this locally. I'll look at this this week.
,
Nov 17 2017
The NextAction date has arrived: 2017-11-17
,
Dec 7 2017
Issue 792799 has been merged into this issue.
,
Jan 5 2018
I made a start on this - hope you don't mind! https://chromium-review.googlesource.com/c/chromium/src/+/850497
,
Jan 5 2018
Sweet, thanks! :)
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/049975acdd1ea7b29aadcfdfca266f125f36e3cd commit 049975acdd1ea7b29aadcfdfca266f125f36e3cd Author: Trent Apted <tapted@chromium.org> Date: Mon Jan 08 22:48:16 2018 Mac: Remove the arrow from extension popups with SecondaryUiMd. MD/Harmony bubbles have no arrows and anchor to a bottom corner of the anchor button. BubbleDialogDelegate takes care of this for Views dialogs but for Harmony phase 1, the extension popup doesn't need to change to MacViews. Currently the anchor location is updated, but the bubble still has an arrow. Remove the arrow to make bubbles consistent. As a bonus, this actually makes them more consistent with the NSMenu that's shown for extensions without their own popup, which also doesn't have an arrow. Bug: 757646 Change-Id: I868e64f2d062f9b6cbddd5c48fe9fd9539306f8f Reviewed-on: https://chromium-review.googlesource.com/850497 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#527792} [modify] https://crrev.com/049975acdd1ea7b29aadcfdfca266f125f36e3cd/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm [modify] https://crrev.com/049975acdd1ea7b29aadcfdfca266f125f36e3cd/chrome/browser/ui/cocoa/extensions/extension_popup_controller.h [modify] https://crrev.com/049975acdd1ea7b29aadcfdfca266f125f36e3cd/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
,
Jan 8 2018
,
Jan 9 2018
Verified this issue on Mac OS 10.12.6 using chrome latest canary M65 #65.0.3316.0 by following steps mentioned in the original comment and observed no arrow from extension popups as expected. Hence adding TE-Verified label for M65. Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by elawrence@chromium.org
, Aug 22 201749.3 KB
49.3 KB View Download