New issue
Advanced search Search tips

Issue 757634 link

Starred by 1 user
Status: Fixed
Owner:
sriram...@samsung.com
Closed: Sep 2017
Cc:
szager@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

[RLS] LocalFrameView::ContentsSize shouldn't reflect overflow

Project Member Reported by skobes@chromium.org, Aug 21 2017 
With RLS enabled, LocalFrameView::ContentsSize returns the size of the LayoutView's layout overflow rect.

This is problematic, since the LocalFrameView should not have overflow with RLS.

Other ScrollableArea APIs rely on ContentsSize - for example, LFV::MaximumScrollOffsetInt(), which should return (0, 0) with RLS.

RLS should make LFV::ContentsSize equal to LFV::VisibleContentSize.

Comment 1 by skobes@chromium.org, Aug 21 2017 

Repro: http://crrev.com/c/624941

Comment 2 by skobes@chromium.org, Sep 13 2017

Owner: sriram...@samsung.com
Status: Assigned (was: Available)
srirama.m is working on this at http://crrev.com/c/664898
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adba729bbf7af302a720be51f5cce8268bc48459

commit adba729bbf7af302a720be51f5cce8268bc48459
Author: Sriram <srirama.m@samsung.com>
Date: Fri Sep 22 08:53:35 2017

[RLS] LocalFrameView::ContentsSize shouldn't reflect overflow

With RLS enabled, LocalFrameView::ContentsSize returns the size of
the LayoutView's layout overflow rect. This is problematic,
since the LocalFrameView should not have overflow with RLS.
Made LFV::ContentsSize equal to LFV::VisibleContentSize incase of RLS.

Bug:  757634 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I37597f910d0b2fbf9755e28950dd10ab87e529fe
Reviewed-on: https://chromium-review.googlesource.com/664898
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#503694}
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
[modify] https://crrev.com/adba729bbf7af302a720be51f5cce8268bc48459/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp

Comment 4 by sriram...@samsung.com, Sep 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment