New issue
Advanced search Search tips

Issue 757630 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Test results in SoM Alerts

Project Member Reported by jojwang@google.com, Aug 21 2017

Issue description

Design Dog: go/tr-in-som


 

Comment 1 by jojwang@google.com, Aug 21 2017

Components: Infra>Sheriffing>SheriffOMatic
"Design Dog" needs to be a meme :)

Comment 3 by jojwang@google.com, Aug 23 2017

Labels: Milestone-Workflow
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/df6d9a5637122da990c523fcb3c077acd56d8004

commit df6d9a5637122da990c523fcb3c077acd56d8004
Author: Joanna Wang <jojwang@google.com>
Date: Tue Aug 29 19:29:43 2017

Add master-results element

collapsed: https://screenshot.googleplex.com/KkOGuvpviLo
expanded: https://screenshot.googleplex.com/FWguhGcpzar

Bug:757630
Change-Id: I2ffe146b2e9da7726ce57d25206ba6408d1a17ae
Reviewed-on: https://chromium-review.googlesource.com/636510
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Joanna Wang <jojwang@google.com>

[modify] https://crrev.com/df6d9a5637122da990c523fcb3c077acd56d8004/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html
[add] https://crrev.com/df6d9a5637122da990c523fcb3c077acd56d8004/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-results/som-master-results.html
[rename] https://crrev.com/df6d9a5637122da990c523fcb3c077acd56d8004/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-results/som-builder-results-test.html
[add] https://crrev.com/df6d9a5637122da990c523fcb3c077acd56d8004/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-results/som-master-results-test.html
[modify] https://crrev.com/df6d9a5637122da990c523fcb3c077acd56d8004/go/src/infra/appengine/sheriff-o-matic/frontend/bower.json
[rename] https://crrev.com/df6d9a5637122da990c523fcb3c077acd56d8004/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-results/som-builder-results.html

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/af3cb71cb676e54146b7d16170f5529ed90d760b

commit af3cb71cb676e54146b7d16170f5529ed90d760b
Author: Joanna Wang <jojwang@google.com>
Date: Fri Sep 01 01:33:41 2017

Add test-results.

collapse: https://screenshot.googleplex.com/KiTt0K5gyuV
expand: https://screenshot.googleplex.com/3vACUS2Fz5c
expand master: https://screenshot.googleplex.com/pv5ih8cWKkT

Bug:757630
Change-Id: Ib46fff4937b7517b55a57d8fcab7c55794ca2a03
Reviewed-on: https://chromium-review.googlesource.com/644847
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Joanna Wang <jojwang@google.com>

[modify] https://crrev.com/af3cb71cb676e54146b7d16170f5529ed90d760b/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html
[add] https://crrev.com/af3cb71cb676e54146b7d16170f5529ed90d760b/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-results/som-test-details-test.html
[add] https://crrev.com/af3cb71cb676e54146b7d16170f5529ed90d760b/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-results/test-data.js
[modify] https://crrev.com/af3cb71cb676e54146b7d16170f5529ed90d760b/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-results/som-master-results-test.html
[modify] https://crrev.com/af3cb71cb676e54146b7d16170f5529ed90d760b/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-results/som-master-results.html
[add] https://crrev.com/af3cb71cb676e54146b7d16170f5529ed90d760b/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-results/som-test-details.html

Comment 9 by jojwang@google.com, Sep 15 2017

Cc: martiniss@chromium.org

Comment 10 by jojwang@google.com, Nov 14 2017

Blockedon: 765432
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/311f433c50cc4ee13169626b39dfd9d0fa1d56f6

commit 311f433c50cc4ee13169626b39dfd9d0fa1d56f6
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Sat Dec 09 00:47:23 2017

[som] Stop splitting test failures into one alert per test failure.

This is causing a huge blow-up of alerts in another change I'm working
on to display individual test result histories inside alerts.

Bug:  757630 
Change-Id: Ic388c926865b6159c66de8eea8a6da95952f508d
Reviewed-on: https://chromium-review.googlesource.com/815940
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/311f433c50cc4ee13169626b39dfd9d0fa1d56f6/go/src/infra/appengine/sheriff-o-matic/som/analyzer/analyzer.go
[modify] https://crrev.com/311f433c50cc4ee13169626b39dfd9d0fa1d56f6/go/src/infra/appengine/sheriff-o-matic/som/analyzer/step/test_step_test.go
[modify] https://crrev.com/311f433c50cc4ee13169626b39dfd9d0fa1d56f6/go/src/infra/appengine/sheriff-o-matic/som/analyzer/step/test_step.go

Blockedon: -765432
Slight change of plan regarding the source data: For Q4 we can just read from test-results server the same way flakiness dashboard does.  I have some CLs that do this already it's running on SoM staging right now: https://sheriff-o-matic-staging.appspot.com/chromium (data from test-results, not BQ or dremel). 

So it isn't blocked on migrating TestResult events to the BQ pipeline any more. Admittedly, this is kinda janky under the hood, but we have the exact same data you see on flakiness dashboard this way.
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c9095a4fa36fb889223d8b11f35e2fd65101331d

commit c9095a4fa36fb889223d8b11f35e2fd65101331d
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Dec 12 00:31:09 2017

[som] Add support for using test run history from test-results server

This works around a dependency on the new test results bigquery
pipeline, and also keeps the data as fresh as what's on the
flakiness dashboard.

There is a subsequent CL to integrate this with the analyzer.

Bug:  757630 
Change-Id: I07df9fbd119b4ba4f1e916ad1f3ebe8632bcb974
Reviewed-on: https://chromium-review.googlesource.com/817495
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/c9095a4fa36fb889223d8b11f35e2fd65101331d/go/src/infra/appengine/sheriff-o-matic/som/client/testresults_test.go
[modify] https://crrev.com/c9095a4fa36fb889223d8b11f35e2fd65101331d/go/src/infra/appengine/sheriff-o-matic/som/handler/testresults_test.go
[modify] https://crrev.com/c9095a4fa36fb889223d8b11f35e2fd65101331d/go/src/infra/appengine/sheriff-o-matic/som/client/testresults.go
[modify] https://crrev.com/c9095a4fa36fb889223d8b11f35e2fd65101331d/go/src/infra/monitoring/messages/flakiness_results.go

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a9f648b3f73fde98753a7c460ebd17edd9a2e122

commit a9f648b3f73fde98753a7c460ebd17edd9a2e122
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Dec 12 21:17:10 2017

[som] Add test result history fetching to the analyzer.

This still needs some work to handle cases where the same set of
multiple tests fail in the same step across multiple builders, but it
produces usable results for now.

Bug:  757630 
Change-Id: I38d5db782fb52167e5202c50c97a782367a48b7c
Reviewed-on: https://chromium-review.googlesource.com/821191
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/a9f648b3f73fde98753a7c460ebd17edd9a2e122/go/src/infra/appengine/sheriff-o-matic/som/handler/analyze.go
[modify] https://crrev.com/a9f648b3f73fde98753a7c460ebd17edd9a2e122/go/src/infra/appengine/sheriff-o-matic/som/handler/analyze_test.go

Owner: seanmccullough@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment