New issue
Advanced search Search tips

Issue 757625 link

Starred by 11 users
Status: Verified
Owner:
zentaro@chromium.org
Closed: Sep 28
Cc:
baileyberro@chromium.org
zentaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 838946


Sign in to add a comment

Add native SMB support to Chrome OS

Project Member Reported by allenvic@chromium.org, Aug 21 2017 
Description:

Add smbclientd to act as a DBus daemon server
Showing comments 358 - 457 of 457 Older ›
Project Member

Comment 358 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8fc1dd86b38d256a7589671cb09e1ae2430112de

commit 8fc1dd86b38d256a7589671cb09e1ae2430112de
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 06:59:43 2018

smbprovider: Add fake implementation of readdirplus

- Add fake implementation and tests

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Iebf0256d76401524e102e4c7024afdbf199776e9
Reviewed-on: https://chromium-review.googlesource.com/1104992
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/constants.h
[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/fake_samba_test.cc
Project Member

Comment 359 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/375ecd1ac23eeeeb5ce99ffb69918c466fd564b1

commit 375ecd1ac23eeeeb5ce99ffb69918c466fd564b1
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 06:59:44 2018

smbprovider: Add implementation of readdirplus

- Code is not called yet.
- Follow up CL's integrate to SmbProvider

BUG= chromium:844476 , chromium:757625 
TEST=emerges and unittests

Change-Id: I943fd84b03788539b582762e807003e0cdfcbf02
Reviewed-on: https://chromium-review.googlesource.com/1104993
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/375ecd1ac23eeeeb5ce99ffb69918c466fd564b1/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/375ecd1ac23eeeeb5ce99ffb69918c466fd564b1/smbprovider/samba_interface_impl.cc
Project Member

Comment 360 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/32cabe73b153e2b40a7a9fcc71db3efe14177e7c

commit 32cabe73b153e2b40a7a9fcc71db3efe14177e7c
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 15:50:54 2018

smbprovider: Add plumbing to iterators to support metadata

- Adds additional argument to BaseDirectoryIterator to specify
  whether the iterator should populate metadata while reading
  the directory.
- Makes no change to existing functionality in this CL.
- The new method to populate the metadata is implemented in a
  follow up CL.

BUG= chromium:844476 , chromium:757625 
TEST=emerges and unittest

Change-Id: I1658adf0fd3ede4366dcb5de8572cd737e46e489
Reviewed-on: https://chromium-review.googlesource.com/1104994
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/32cabe73b153e2b40a7a9fcc71db3efe14177e7c/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/32cabe73b153e2b40a7a9fcc71db3efe14177e7c/smbprovider/iterator/directory_iterator.h
Project Member

Comment 361 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/033a847e3bb706164a0e02e4107cf60a5a698ec8

commit 033a847e3bb706164a0e02e4107cf60a5a698ec8
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 15:50:55 2018

smbprovider: Factor out a ClearVector() method

- Adds a helper method to clear the vector and reset the index
- Follow up CL will use this in an additional place

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Id4e96c0354d173a02a6a5b33438b8badea598582
Reviewed-on: https://chromium-review.googlesource.com/1104995
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/033a847e3bb706164a0e02e4107cf60a5a698ec8/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/033a847e3bb706164a0e02e4107cf60a5a698ec8/smbprovider/iterator/directory_iterator.h
Project Member

Comment 362 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5

commit 0abbfcca2be3ee0ac0719fef2785e25eb659e3a5
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 27 18:56:00 2018

Use cr-searchable-drop-down in Add Smb Share dialog

This change makes the share entry field in the Add SmbShare dialog
a cr-searchable-drop-down that is populated with shares discovered
on the network as they are found.

Test=verified locally

Bug:  chromium:757625 
Change-Id: I6fdd74bc2c6f1efaea190bfc3d93eef046de7334
Reviewed-on: https://chromium-review.googlesource.com/1152211
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578732}
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/resources/settings/downloads_page/BUILD.gn
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
Project Member

Comment 363 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a94a2f9536463e19180ddb41ad003583a171fe44

commit a94a2f9536463e19180ddb41ad003583a171fe44
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 27 20:56:26 2018

Add NetworkFileSharesAllowed pref and policy

This change adds a NetworkFileSharesAllowed pref and policy to store
whether or not a user is allowed to use the Network File Shares
feature.

Bug:  chromium:757625 
Change-Id: Icaf2015a841c31328b8cb36d26c73b2fa09fbcb6
Reviewed-on: https://chromium-review.googlesource.com/1141301
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578771}
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service_factory.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service_factory.h
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/common/pref_names.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/common/pref_names.h
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/components/policy/resources/policy_templates.json
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/tools/metrics/histograms/enums.xml
Project Member

Comment 364 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42

commit 4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:33 2018

smbprovider: Implement iterator including metadata

- Adds implementation to call readdir plus to support an iterator
  that includes metadata.

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I3c1cd2f219ab5f0b42ea4d6f79ecddb4fa3496ba
Reviewed-on: https://chromium-review.googlesource.com/1104996
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42/smbprovider/iterator/directory_iterator_test.cc
[modify] https://crrev.com/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42/smbprovider/iterator/directory_iterator.h
Project Member

Comment 365 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0196479b97944850be6b1b027c2cd018b6d79922

commit 0196479b97944850be6b1b027c2cd018b6d79922
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:33 2018

smbprovider: Add skeleton of metadata cache.

- Adds do nothing cache class and test file
- Adds cache and test file to build
- Follow up CL implements the cache

BUG= chromium:844476 , chromium:757625 
TEST=emerges and unit tests

Change-Id: I05f0e2a19f51a184709f919f99b7b7e700c0b078
Reviewed-on: https://chromium-review.googlesource.com/1106770
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/metadata_cache.cc
[add] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/metadata_cache.h
[add] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/metadata_cache_test.cc
[modify] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/smbprovider.gyp
Project Member

Comment 366 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4dd4469b76bae5009823921d7a523ec03d9f313a

commit 4dd4469b76bae5009823921d7a523ec03d9f313a
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:34 2018

smbprovider: Replace the mount_root with a MountInfo struct

- Changes the map in the mount manager to hold a struct instead
  of just a string.
- Currently the struct just contains the string mount_root field.
- Updates relevant references to the mount_root via mounts_
- Makes no change to behavior.
- Follow up CL will add the cache to the MountInfo struct.

BUG= chromium:844476 , chromium:757625 
TEST=emerges and unittests

Change-Id: Ib16706a3e90b683c17e8aa9a16fccb5ebce7eb34
Reviewed-on: https://chromium-review.googlesource.com/1106771
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4dd4469b76bae5009823921d7a523ec03d9f313a/smbprovider/mount_manager.cc
[modify] https://crrev.com/4dd4469b76bae5009823921d7a523ec03d9f313a/smbprovider/mount_manager.h
Project Member

Comment 367 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/de1ee63bb73b61e5905442a5d6a92af12fcbb44e

commit de1ee63bb73b61e5905442a5d6a92af12fcbb44e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:34 2018

smbprovider: Add a flag to SmbProvider to enable metadata cache

- Flag is currently not used

BUG= chromium:757625 
TEST=emerges and unittests

Change-Id: I0cb5a616bc52eebafb55840ded5afcca6313f15a
Reviewed-on: https://chromium-review.googlesource.com/1106772
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider.cc
[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider.h
[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider_main.cc
Project Member

Comment 368 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c2a576f23929c3241188da00db220a0e9b36a840

commit c2a576f23929c3241188da00db220a0e9b36a840
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:35 2018

smbprovider: Support adding and finding entries from cache

- Adds AddEntry and FindEntry and tests
- Cache currently never invalidates or clears
- The cache code is not being used yet
- Follow up CL's wire up the cache and add purging and
  invalidation

BUG= chromium:757625 
TEST=emerges and unittests

Change-Id: I11eab2e308a0be6541b71bbc70c41ba360adefd9
Reviewed-on: https://chromium-review.googlesource.com/1106773
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/c2a576f23929c3241188da00db220a0e9b36a840/smbprovider/metadata_cache.cc
[modify] https://crrev.com/c2a576f23929c3241188da00db220a0e9b36a840/smbprovider/metadata_cache.h
[modify] https://crrev.com/c2a576f23929c3241188da00db220a0e9b36a840/smbprovider/metadata_cache_test.cc
Project Member

Comment 369 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4b67f7a74545ec7869ececb35d913689bd750c51

commit 4b67f7a74545ec7869ececb35d913689bd750c51
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:37 2018

smbprovider: Wire up the metadata iterator

- The metadata iterator will now be used if caching is enabled
- The cache flag is currently off, so there is no behavior change
- Nothing currently consumes the additional metadata

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I70add04a16ace19ec3e8013398923ab802bad8ff
Reviewed-on: https://chromium-review.googlesource.com/1144613
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/smbprovider.cc
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/smbprovider.h
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/iterator/directory_iterator.h
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/constants.h
Project Member

Comment 370 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/38ea0ba4104031e3386f8ba86c1e11cb40598cd1

commit 38ea0ba4104031e3386f8ba86c1e11cb40598cd1
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:37 2018

smbprovider: Add the cache to the MountManager

- Adds an instance of the cache for each mount in the mount
  manager.
- Nothing currently reads or writes from the cache.

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Id92d36c11d58684ea92823b56a5021d462237c91
Reviewed-on: https://chromium-review.googlesource.com/1144614
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/mount_manager.cc
[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/metadata_cache.h
[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/mount_manager.h
Project Member

Comment 371 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3c1120159bee8430abea92f5f1605bcf1bbc08fe

commit 3c1120159bee8430abea92f5f1605bcf1bbc08fe
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:38 2018

smbprovider: Add code to check the cache on metadata requests

- Nothing populates the cache yet
- The flag is never turned on so this isn't run yet
- No change to existing behavior

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I4c329325ec7a45ffdca688afba28466e71a19c0d
Reviewed-on: https://chromium-review.googlesource.com/1144615
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/3c1120159bee8430abea92f5f1605bcf1bbc08fe/smbprovider/smbprovider.cc
[modify] https://crrev.com/3c1120159bee8430abea92f5f1605bcf1bbc08fe/smbprovider/smbprovider.h
[modify] https://crrev.com/3c1120159bee8430abea92f5f1605bcf1bbc08fe/smbprovider/smbprovider_test.cc
Project Member

Comment 372 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0781df5fffecf218a381480066a277fca7465fa4

commit 0781df5fffecf218a381480066a277fca7465fa4
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:38 2018

smbprovider: Implement a caching iterator

- Wraps an inner iterator and adds to the cache each time Get()
  is called

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I00aa5ed75f88cdd664b9455748f2f158ffbee055
Reviewed-on: https://chromium-review.googlesource.com/1144616
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/0781df5fffecf218a381480066a277fca7465fa4/smbprovider/iterator/caching_iterator.h
[modify] https://crrev.com/0781df5fffecf218a381480066a277fca7465fa4/smbprovider/smbprovider.gyp
[add] https://crrev.com/0781df5fffecf218a381480066a277fca7465fa4/smbprovider/iterator/caching_iterator_test.cc
Project Member

Comment 373 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9f221ba0bedef0a024f775901f1d7bd4b9728b8c

commit 9f221ba0bedef0a024f775901f1d7bd4b9728b8c
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:39 2018

smbprovider: Wire up CachingIterator in ReadDirectory

- When caching is enabled, ReadDirectory will use a caching
  iterator for DirectoryReads
- Caching is not used for reading shares.

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I8ed2d08354e08536d62c380b7ecfaaec8f741933
Reviewed-on: https://chromium-review.googlesource.com/1144617
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9f221ba0bedef0a024f775901f1d7bd4b9728b8c/smbprovider/smbprovider.cc
[modify] https://crrev.com/9f221ba0bedef0a024f775901f1d7bd4b9728b8c/smbprovider/smbprovider_test.cc
Project Member

Comment 374 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7fd728f2f97bd6f0c527a9754b3a19e8edc78045

commit 7fd728f2f97bd6f0c527a9754b3a19e8edc78045
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:39 2018

smbprovider: Add a TickClock to MountManager

- Adds a TickClock to MountManager to be used for the metadata cache
- Currently the clock is unused
- Future CL will use the clock when constructing MetadataCache
  so that it can be used to invalidate cache entries
- Makes no change to current behavior

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I7b6d6bb9d1b7050add5569ca8c0366a20a8344fd
Reviewed-on: https://chromium-review.googlesource.com/1144618
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/mount_manager.cc
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/mount_manager.h
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/smbprovider_test.cc
Project Member

Comment 375 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921

commit dcfcf79752edb3624a4ee5c492cad5e6a6ec7921
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:40 2018

smbprovider: Adds TickClock to MetadataCache

- Construct the MetadataCache using the TickClock owned
  by MountManager
- Update test code
- Clock is currently not used
- Makes no change to current behavior

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Ibf245e518e6f240dd5f259b74d05346fd016b96a
Reviewed-on: https://chromium-review.googlesource.com/1144619
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/mount_manager.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/metadata_cache_test.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/iterator/caching_iterator_test.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/metadata_cache.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/metadata_cache.h
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/mount_manager.h
Project Member

Comment 376 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ecaf8e55bd2f641e18eb555879b344a2a4dc97ba

commit ecaf8e55bd2f641e18eb555879b344a2a4dc97ba
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:41 2018

smbprovider: Rename a genericly named variable

- kBufferSize gave an ambiguous name resolution
- Limit the scope of the variable and give it a better name

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Ie696151624d1bb34057e9dc945f1823b6d146547
Reviewed-on: https://chromium-review.googlesource.com/1144620
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/ecaf8e55bd2f641e18eb555879b344a2a4dc97ba/smbprovider/mount_manager_test.cc
Project Member

Comment 378 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/48f019d46479516677f5c80e467e1f7203f2eba7

commit 48f019d46479516677f5c80e467e1f7203f2eba7
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:42 2018

smbprovider: Support removing items from the metadata cache

- Adds method to remove an item from the cache by path
- Adds tests for removing item
- Does not change current behavior

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Ia2cc6c45e28351694f5d0beef092587002677410
Reviewed-on: https://chromium-review.googlesource.com/1144622
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/48f019d46479516677f5c80e467e1f7203f2eba7/smbprovider/metadata_cache.cc
[modify] https://crrev.com/48f019d46479516677f5c80e467e1f7203f2eba7/smbprovider/metadata_cache.h
[modify] https://crrev.com/48f019d46479516677f5c80e467e1f7203f2eba7/smbprovider/metadata_cache_test.cc
Project Member

Comment 379 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ff17c09d21a914380be0a7c9103ee838d04b2a9e

commit ff17c09d21a914380be0a7c9103ee838d04b2a9e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:42 2018

smbprovider: Add an IsExpired method to MetadatCache

- Add private method to test if a cache entry has expired

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: If328b84b37298d20a5a1a3ba8731aa9d82148ab0
Reviewed-on: https://chromium-review.googlesource.com/1144623
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/ff17c09d21a914380be0a7c9103ee838d04b2a9e/smbprovider/metadata_cache.cc
[modify] https://crrev.com/ff17c09d21a914380be0a7c9103ee838d04b2a9e/smbprovider/metadata_cache.h
Project Member

Comment 380 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9989a19c531171a5ac2f9f4098b59d6e61f4f482

commit 9989a19c531171a5ac2f9f4098b59d6e61f4f482
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:43 2018

smbprovider: FindEntry in cache respects expiration

- If an entry is expired don't return it and delete it

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: Ie126f51f3309c4c04fe9bfbcbe2e0e5e81b2b658
Reviewed-on: https://chromium-review.googlesource.com/1144624
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9989a19c531171a5ac2f9f4098b59d6e61f4f482/smbprovider/metadata_cache.cc
[modify] https://crrev.com/9989a19c531171a5ac2f9f4098b59d6e61f4f482/smbprovider/metadata_cache.h
[modify] https://crrev.com/9989a19c531171a5ac2f9f4098b59d6e61f4f482/smbprovider/metadata_cache_test.cc
Project Member

Comment 381 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bc4715434d4b9db305c784016983824202f9ce75

commit bc4715434d4b9db305c784016983824202f9ce75
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:43 2018

smbprovider: Support purging the entire cache by time

- Add a method to iterate the cache and remove items that are
  expired
- Makes no change to current behavior

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I18b2472069420c955a31a0107b0ee9aa16e1e04e
Reviewed-on: https://chromium-review.googlesource.com/1144625
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/bc4715434d4b9db305c784016983824202f9ce75/smbprovider/metadata_cache.cc
[modify] https://crrev.com/bc4715434d4b9db305c784016983824202f9ce75/smbprovider/metadata_cache.h
[modify] https://crrev.com/bc4715434d4b9db305c784016983824202f9ce75/smbprovider/metadata_cache_test.cc
Project Member

Comment 382 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/566801eb4d612aa4dfa94dbef020dc03368abfd6

commit 566801eb4d612aa4dfa94dbef020dc03368abfd6
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:44 2018

smbprovider: Purge the cache before each read directory

- Purges the cache of expired entries before each new directory
  is read
- This is the most simplistic strategy to keep the cache
  from growing uncontrollably
- Future CL's may further optimize this to use other information
  to decide whether to actually purge

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I7a986bf41d97cf20551397cfd34210fa6b64ed04
Reviewed-on: https://chromium-review.googlesource.com/1145554
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/566801eb4d612aa4dfa94dbef020dc03368abfd6/smbprovider/smbprovider.cc
[modify] https://crrev.com/566801eb4d612aa4dfa94dbef020dc03368abfd6/smbprovider/smbprovider_test.cc
Project Member

Comment 383 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/91be32d59fc705aa9d6892dcb57992ff84e961a2

commit 91be32d59fc705aa9d6892dcb57992ff84e961a2
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:44 2018

smbprovider: Enable the metadata cache

- Just turns on the caching flag to enable the optimization
- See previous CL's for full implementation
- Now all explicit ReadDirectories use readdirplus which reads
  directory entries with all the stat() metadata from one call
- The iterator caches the entries as they are iterated over
- GetMetadata calls check the cache before making a network call
- Cache just has a simple expiration time of 30 sec
- Cache is purged of all expired entries each time a new directory
  is read
- Future optimizations may make the purging smarter
- Implicit readDirectorys such as finding shares, or traversals
  to perform recursive copies or deletes do not use readdirplus
  or cache as they iterate

BUG= chromium:844476 , chromium:757625 
TEST=emerges

Change-Id: I07f0b37865a5ebb1a0f879f2b899aa73f7aa7f71
Reviewed-on: https://chromium-review.googlesource.com/1145555
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/91be32d59fc705aa9d6892dcb57992ff84e961a2/smbprovider/smbprovider_main.cc
Project Member

Comment 384 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a917d920050ae82b2be8f188a502983c550a6d07

commit a917d920050ae82b2be8f188a502983c550a6d07
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:35 2018

smbprovider: Support clearing and testing cache is empty

- Adds ClearAll() to remove all cache entries
- Adds IsEmpty() to test if the cache is empty

BUG= chromium:844476 , chromium:757625 
TEST=emerges and unittests

Change-Id: I125110aa29e93f1cd37360695325618640734851
Reviewed-on: https://chromium-review.googlesource.com/1146761
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/a917d920050ae82b2be8f188a502983c550a6d07/smbprovider/metadata_cache.cc
[modify] https://crrev.com/a917d920050ae82b2be8f188a502983c550a6d07/smbprovider/metadata_cache.h
[modify] https://crrev.com/a917d920050ae82b2be8f188a502983c550a6d07/smbprovider/metadata_cache_test.cc
Project Member

Comment 385 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e5a6f33596d96c402d25a418b50e27c74dcc923a

commit e5a6f33596d96c402d25a418b50e27c74dcc923a
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:36 2018

smbprovider: Add support for setting date on fake directories

- Needed for testing the new metadata versions of ReadDirectory
  populate the fields correctly.

BUG= chromium:844476 , chromium:757625 
TEST=emerges and unittests

Change-Id: If128b4bb726ccb87a8112e8b668150a571b79903
Reviewed-on: https://chromium-review.googlesource.com/1146762
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/e5a6f33596d96c402d25a418b50e27c74dcc923a/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/e5a6f33596d96c402d25a418b50e27c74dcc923a/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/e5a6f33596d96c402d25a418b50e27c74dcc923a/smbprovider/fake_samba_test.cc
Project Member

Comment 386 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/adb6a28fb3639543118d0caa4c0eeefec5daab91

commit adb6a28fb3639543118d0caa4c0eeefec5daab91
Author: jimmy <jimmyxgong@google.com>
Date: Tue Jul 31 23:37:29 2018

Add SanityTest to SmbProvider autotest

- Adds SanityTest. Future CLs will add functionality to SanityTest so
  that it eventually tests all possible operations on the SMB daemon.
- Add Mount and Unmount test through mounting->unmounting error checks.

BUG= chromium:757625 
TEST=emerges

Change-Id: I6e0f844f4eaac8d3eb36a320dc30e1fb28481818
Reviewed-on: https://chromium-review.googlesource.com/1149278
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/adb6a28fb3639543118d0caa4c0eeefec5daab91/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 387 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9f73edbb57d8414b4930cf4e0556384a51ce59a3

commit 9f73edbb57d8414b4930cf4e0556384a51ce59a3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Aug 03 08:31:23 2018

smbprovider: Use GetSambaInterface Method

This change is the first in a series that will introduce an instance
of SambaInterface for each mount, allowing per mount configurations and
improving the authentication flow.

Switches all methods in SmbProvider to calling SambaInterface via a
GetSambaInterface method, removing the dependency on the
samba_interface_ memeber variable. A follow-up CL will transition the
GetSambaInterface method to returning a unique SambaInterface* for each
mount id.

BUG= chromium:757625 
TEST=unittests
Change-Id: I34b0958178cc1af6225b785c5012b1d55ec98291
Reviewed-on: https://chromium-review.googlesource.com/1157512
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9f73edbb57d8414b4930cf4e0556384a51ce59a3/smbprovider/smbprovider.cc
[modify] https://crrev.com/9f73edbb57d8414b4930cf4e0556384a51ce59a3/smbprovider/smbprovider.h
Project Member

Comment 388 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/248ca334a23d56248916c06165bfc5b4ff39991c

commit 248ca334a23d56248916c06165bfc5b4ff39991c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Aug 03 13:29:16 2018

smbprovider: Introduce FakeSambaProxy

This change introdcues FakeSambaProxy. FakeSambaProxy is a proxy
class that has zero logic and passes through all calls to an underlying
FakeSamabaInterface. FakeSambaProxy is needed for testing in order to
return unique_ptrs to SambaInterfaces that are all backed by the same
fake underneath.

BUG= chromium:757625 
TEST=unittest
Change-Id: I5dca0745ae9529fd05d91aa9d19490a2e3085626
Reviewed-on: https://chromium-review.googlesource.com/1159081
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/248ca334a23d56248916c06165bfc5b4ff39991c/smbprovider/fake_samba_proxy.cc
[add] https://crrev.com/248ca334a23d56248916c06165bfc5b4ff39991c/smbprovider/fake_samba_proxy.h
[modify] https://crrev.com/248ca334a23d56248916c06165bfc5b4ff39991c/smbprovider/smbprovider.gyp
Project Member

Comment 389 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2ac19614c3e77f8aef9ae85993790df83c5c0b13

commit 2ac19614c3e77f8aef9ae85993790df83c5c0b13
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Aug 04 05:14:47 2018

smbprovider: use SambaInterface per mount

This change completes the switch from using one SambaInterface to having
one SambaInterface per mount.

- Calls to GetShares, used for discovering shares on a host, uses a
system SambaInterface maintained by the MountManager.
- All other calls use a SambaInterface mapped to the mount_id

BUG= chromium:757625 
TEST=unittests
Change-Id: I3659086af6e230d413c0de6617c9a22885ee72e4
Reviewed-on: https://chromium-review.googlesource.com/1157690
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/mount_manager.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider.h
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/proto.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/constants.h
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/mount_manager.h
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider_test.cc
Project Member

Comment 390 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0fc2a8524f4cb0660398cceb49e4d06fd0fe7d93

commit 0fc2a8524f4cb0660398cceb49e4d06fd0fe7d93
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 08:59:46 2018

smbprovider: Change map to unordered_map

- Lookup is faster and we never need ordered access

BUG= chromium:757625 
TEST=unittests

Change-Id: I7b4aae136873de59da8f0db216f2f1903ff2f49f
Reviewed-on: https://chromium-review.googlesource.com/1157175
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0fc2a8524f4cb0660398cceb49e4d06fd0fe7d93/smbprovider/metadata_cache.h
Project Member

Comment 391 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7f089bb0bdc67faab9cb059b663624b0455ff704

commit 7f089bb0bdc67faab9cb059b663624b0455ff704
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Aug 04 08:59:47 2018

smbprovider: Remove unnecessary pass by value

This change switches the LogAndSetError method to pass the Proto
argument by const ref instead of by value to eliminate an unnecessary
copy.

BUG= chromium:757625 
TEST=unittests
Change-Id: I6a54149c178fd37a05b02429ded663d20bb4e921
Reviewed-on: https://chromium-review.googlesource.com/1161286
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/7f089bb0bdc67faab9cb059b663624b0455ff704/smbprovider/smbprovider_helper.h
Project Member

Comment 392 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/49e77b2fc4e8c01d7fbf7067ae7975da2458af18

commit 49e77b2fc4e8c01d7fbf7067ae7975da2458af18
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:50 2018

smbprovider: Optimize the case where the entire cache is expired

- Keep track of the max expiration time
- If the current time if higher than the max then just clear the
  map and don't bother iterating.

BUG= chromium:757625 
TEST=unittests

Change-Id: Ibd4d80c6f6eec3e9e687b32d2b8be95c2a225c6e
Reviewed-on: https://chromium-review.googlesource.com/1157176
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/49e77b2fc4e8c01d7fbf7067ae7975da2458af18/smbprovider/metadata_cache.cc
[modify] https://crrev.com/49e77b2fc4e8c01d7fbf7067ae7975da2458af18/smbprovider/metadata_cache.h
Project Member

Comment 393 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1c94351e72213412552fbe7a0bdac1ea022dbd98

commit 1c94351e72213412552fbe7a0bdac1ea022dbd98
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:50 2018

smbprovider: Rename SequentialIdMap to IdMap

- Only a rename with no logic change
- It's not necessary for the IDs to be sequential, just unique
  at any point in time.
- Follow up CL will change the behavior to allow re-use and remove
  possibility of overflow.

BUG= chromium:757625 
TEST=unittests

Change-Id: Iceb304365d01a5f3dd5800813c96d4c2f475033d
Reviewed-on: https://chromium-review.googlesource.com/1158791
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/smbprovider.gyp
[rename] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/id_map.h
[rename] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/id_map_test.cc
Project Member

Comment 394 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/64407ce6fb0a4b911eb6563078e836c80725faa9

commit 64407ce6fb0a4b911eb6563078e836c80725faa9
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:49 2018

smbprovider: Improve the method comment for FindEntry

BUG= chromium:757625 
TEST=unittests

Change-Id: I2377a7f791539a498418b22d1528b1ae1037a640
Reviewed-on: https://chromium-review.googlesource.com/1159083
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/64407ce6fb0a4b911eb6563078e836c80725faa9/smbprovider/metadata_cache.h
Project Member

Comment 395 by bugdroid1@chromium.org, Aug 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b6daa00d532c2262ad440c7f9da11b9e00fdbee7

commit b6daa00d532c2262ad440c7f9da11b9e00fdbee7
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:49 2018

smbprovider: IsExpired method can be const

BUG= chromium:757625 
TEST=unittests

Change-Id: I1f944f39ea039fe51975357dc06b57b59b860239
Reviewed-on: https://chromium-review.googlesource.com/1159084
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/b6daa00d532c2262ad440c7f9da11b9e00fdbee7/smbprovider/metadata_cache.cc
[modify] https://crrev.com/b6daa00d532c2262ad440c7f9da11b9e00fdbee7/smbprovider/metadata_cache.h
Project Member

Comment 396 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bb14de6063d6af9117ac35f6876d88ac935195a8

commit bb14de6063d6af9117ac35f6876d88ac935195a8
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Aug 07 08:50:42 2018

smbprovider: Remove assumptions that id are sequential

- Cleans up the tests to not make assumptions about how the
  ids get given out

BUG= chromium:757625 
TEST=unittests

Change-Id: Ib46dd00a9e6c9933278ca2c7f307b1036e023171
Reviewed-on: https://chromium-review.googlesource.com/1162866
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/bb14de6063d6af9117ac35f6876d88ac935195a8/smbprovider/id_map_test.cc
Project Member

Comment 397 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/467241ee35f8eeafe9eeb5a094acf6e51fc2c78b

commit 467241ee35f8eeafe9eeb5a094acf6e51fc2c78b
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Aug 07 08:50:43 2018

smbprovider: Add a MapType typedef to the IdMap

- No logic change

BUG= chromium:757625 
TEST=unittests

Change-Id: I3fe63e3a45d7a29de4872cae3650fc677ab2a2e5
Reviewed-on: https://chromium-review.googlesource.com/1162867
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/467241ee35f8eeafe9eeb5a094acf6e51fc2c78b/smbprovider/id_map.h
Project Member

Comment 398 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/10811ef6a25ed6640fa0ecf475173de092451b9f

commit 10811ef6a25ed6640fa0ecf475173de092451b9f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:45 2018

smbprovider: Use unordered_map in IdMap

BUG= chromium:757625 
TEST=unittests

Change-Id: I3523d4a9364462c999de17e11b62c088436fced3
Reviewed-on: https://chromium-review.googlesource.com/1162868
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/10811ef6a25ed6640fa0ecf475173de092451b9f/smbprovider/id_map.h
Project Member

Comment 399 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f24bd321e537aa71653fd74c42fa1a8e4a21a173

commit f24bd321e537aa71653fd74c42fa1a8e4a21a173
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:45 2018

smbprovider: Add a helper method for getting the next id.

- No behavior change
- Follow up CL will change the way ids are assigned

BUG= chromium:757625 
TEST=unittests

Change-Id: I73afe599e7a0a563ce8e061a0a64a57aedbd84be
Reviewed-on: https://chromium-review.googlesource.com/1162869
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/f24bd321e537aa71653fd74c42fa1a8e4a21a173/smbprovider/id_map.h
Project Member

Comment 400 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fff74e6604d04e9cc3dadf3d59e324bd06aea131

commit fff74e6604d04e9cc3dadf3d59e324bd06aea131
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:46 2018

smbprovider: Update the IdMap to reuse ids

BUG= chromium:757625 
TEST=unittests

Change-Id: I05a283dd3c787ff0012423e34ae12a62336e83e0
Reviewed-on: https://chromium-review.googlesource.com/1162870
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/fff74e6604d04e9cc3dadf3d59e324bd06aea131/smbprovider/id_map.h
[modify] https://crrev.com/fff74e6604d04e9cc3dadf3d59e324bd06aea131/smbprovider/id_map_test.cc
Project Member

Comment 401 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c44f6581f56626de95407445126b7c3a539ac9e3

commit c44f6581f56626de95407445126b7c3a539ac9e3
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:46 2018

smbprovider: Add support for insertion with specific id to IdMap

- This is used for the remounting case to rebuild our mapping to
  be in sync with Chrome

BUG= chromium:757625 
TEST=unittests

Change-Id: Ie09e80e834aa008b74c76f89ccccede26efeca38
Reviewed-on: https://chromium-review.googlesource.com/1162871
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/c44f6581f56626de95407445126b7c3a539ac9e3/smbprovider/id_map.h
[modify] https://crrev.com/c44f6581f56626de95407445126b7c3a539ac9e3/smbprovider/id_map_test.cc
Project Member

Comment 402 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b4efae3196141cc28bfbfda503acd1a240f51dfd

commit b4efae3196141cc28bfbfda503acd1a240f51dfd
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 17:24:52 2018

smbprovider: Use IdMap for MountManager

- Re-uses IdMap for handing out mount_ids
- Remove test that tested for not-reusing IDs

BUG= chromium:757625 
TEST=unittests

Change-Id: Ia55cd800bb086a0e53955409404bfeb9951d9cbe
Reviewed-on: https://chromium-review.googlesource.com/1162872
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/mount_manager.cc
[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/mount_manager.h
[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/id_map.h
Project Member

Comment 403 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ef68de91596cf74af277cab8886c9ad28902b421

commit ef68de91596cf74af277cab8886c9ad28902b421
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 17:24:52 2018

smbprovider: Use emplace instead of insert in IdMap

BUG= chromium:757625 
TEST=unittests

Change-Id: If1a795d3d3b24fb936f3130aa0506031ec4c9d33
Reviewed-on: https://chromium-review.googlesource.com/1165501
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/ef68de91596cf74af277cab8886c9ad28902b421/smbprovider/id_map.h
Project Member

Comment 404 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649

commit e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649
Author: jimmy <jimmyxgong@google.com>
Date: Thu Aug 09 03:46:05 2018

Add CreateDirectory to SmbProvider autotest

- Implements CreateDirectory in smbprovider.py.
- Adds GenerateRandomID for directory/file naming purposes.
- Adds CreateDirectory test to sanity test for SmbProvder autotests.

BUG= chromium:757625 
TEST=emerges

Change-Id: I68a9584fdacd348a17da0033c35e99b062b38c84
Reviewed-on: https://chromium-review.googlesource.com/1150458
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
[modify] https://crrev.com/e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649/client/common_lib/cros/smbprovider.py
Project Member

Comment 405 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8480fa1327818cafc8fc377b4bcbac9e31e5a31e

commit 8480fa1327818cafc8fc377b4bcbac9e31e5a31e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Aug 09 03:46:18 2018

smbprovider: Reuse IdMap for copy tracking

- Previously had duplicated logic for maintaining an ID mapping

BUG= chromium:757625 
TEST=unittests

Change-Id: I34d3eeb66ff4b913d339662f652eeb6c8b3c230e
Reviewed-on: https://chromium-review.googlesource.com/1165582
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/8480fa1327818cafc8fc377b4bcbac9e31e5a31e/smbprovider/smbprovider.cc
[modify] https://crrev.com/8480fa1327818cafc8fc377b4bcbac9e31e5a31e/smbprovider/smbprovider.h
Project Member

Comment 406 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0f8b78f0afd9a7e6ec736d989f55ba9d02b4e76e

commit 0f8b78f0afd9a7e6ec736d989f55ba9d02b4e76e
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:07 2018

Add DeleteEntry to SmbProvider autotest

Adds DeleteEntry check to the autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: I99a5da72cac518655f1684d315b27aec94ea7c29
Reviewed-on: https://chromium-review.googlesource.com/1152165
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0f8b78f0afd9a7e6ec736d989f55ba9d02b4e76e/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 407 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c8261ef936c526b68dbcb4a35f67a99842db69ca

commit c8261ef936c526b68dbcb4a35f67a99842db69ca
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:07 2018

Add CreateFile to SmbProvider autotest

Adds CreateFile test to sanity test for SmbProvider autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: I5eb392f2818544b93c686d0476ba5dc749bd1cce
Reviewed-on: https://chromium-review.googlesource.com/1152448
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/c8261ef936c526b68dbcb4a35f67a99842db69ca/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 408 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9ca61906a1ff1397c6a587c54a13ee3abf40fd7a

commit 9ca61906a1ff1397c6a587c54a13ee3abf40fd7a
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:08 2018

Add open/close file to SmbProvider autotest

Adds open file testing along with close file testing to the autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: Id5a52f3cd336dfe8f970baa092af23412f8f60ae
Reviewed-on: https://chromium-review.googlesource.com/1152518
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9ca61906a1ff1397c6a587c54a13ee3abf40fd7a/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 409 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b381c2d4b2aa6d8585010aa99d01136872766c9a

commit b381c2d4b2aa6d8585010aa99d01136872766c9a
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:08 2018

Add write file to SmbProvider autotest

Adds WriteFile check to the autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: Idfd9f875f0416444b6187d41ec0f48b10d52c7cf
Reviewed-on: https://chromium-review.googlesource.com/1152533
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b381c2d4b2aa6d8585010aa99d01136872766c9a/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 410 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ead96786b9dbf4493f0f960d55cdf6ff186ecdd7

commit ead96786b9dbf4493f0f960d55cdf6ff186ecdd7
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:10 2018

Add recursive create test to SmbProvder autotest

Adds recursive creation of directories in SmbProvider autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: I38378fc5e41b3cb4553480c22af7b2f89f09aeaa
Reviewed-on: https://chromium-review.googlesource.com/1153506
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ead96786b9dbf4493f0f960d55cdf6ff186ecdd7/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 411 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8e5a01768a0a5c7cf3a6f89a3c780d295ce8dd07

commit 8e5a01768a0a5c7cf3a6f89a3c780d295ce8dd07
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:10 2018

Add GetMetadata to SmbProvider autotest

Adds GetMetadata test to SmbProvider autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: I47f5ae07d80202f9d13265e5b6583bda12a2ff70
Reviewed-on: https://chromium-review.googlesource.com/1156047
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/8e5a01768a0a5c7cf3a6f89a3c780d295ce8dd07/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 412 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/74b4d995c649b83ff5d94e447437859af22fba2c

commit 74b4d995c649b83ff5d94e447437859af22fba2c
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:11 2018

Add MoveEntry to SmbProvider autotest

Adds MoveEntry test to SmbProvider autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: Iecabee3fc7ece801b25cd687e9145d0447a1e312
Reviewed-on: https://chromium-review.googlesource.com/1157425
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/74b4d995c649b83ff5d94e447437859af22fba2c/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
[modify] https://crrev.com/74b4d995c649b83ff5d94e447437859af22fba2c/client/common_lib/cros/smbprovider.py
Project Member

Comment 413 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e662652f5e3ee29ff948417ddc632f6a3bbe9694

commit e662652f5e3ee29ff948417ddc632f6a3bbe9694
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:09 2018

Add ReadFile to SmbProvider autotest

Adds ReadFile test to SmbProvider autotest.

BUG= chromium:757625 
TEST=emerges

Change-Id: If3d31a432d3ca013f21001bc489cf0bae88e42ce
Reviewed-on: https://chromium-review.googlesource.com/1166284
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e662652f5e3ee29ff948417ddc632f6a3bbe9694/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
Project Member

Comment 414 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6075a7efccebdc2ed5718563df87791d079141

commit 0d6075a7efccebdc2ed5718563df87791d079141
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Aug 20 15:00:28 2018

Add policy checks to SmbShare UI.

If the policy for NetworkFileSharesAllowed is set to false, users will
not be able to mount shares nor will the be able to access the mount ui


Bug:  chromium:757625 
Change-Id: Ief64c9a9c3c2a574b931bc3f21516d471c26bcd4
Reviewed-on: https://chromium-review.googlesource.com/1152490
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584443}
[modify] https://crrev.com/0d6075a7efccebdc2ed5718563df87791d079141/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/0d6075a7efccebdc2ed5718563df87791d079141/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/0d6075a7efccebdc2ed5718563df87791d079141/chrome/browser/resources/settings/downloads_page/smb_shares_page.html
[modify] https://crrev.com/0d6075a7efccebdc2ed5718563df87791d079141/chrome/browser/resources/settings/downloads_page/smb_shares_page.js
[modify] https://crrev.com/0d6075a7efccebdc2ed5718563df87791d079141/chrome/test/data/webui/settings/smb_shares_page_tests.js
Project Member

Comment 415 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/125c51c78da1d4fbce1ee8b1427ae8468a4602b2

commit 125c51c78da1d4fbce1ee8b1427ae8468a4602b2
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Aug 22 19:10:16 2018

Do not start SmbService if disallowed by policy

This change adds a check for the NetworkFileSharesAllowed policy
when starting up SmbService. If the policy is set to false, meaning
that Network File Shares should not be allowed, SmbService will not
be registered with the FSP, removing the entry point from the
"Add new services" menu in the Files App.

Additionally, since the Settings UI picks up policy changes on the fly
but the NetworkFileSharesAllowed policy does not support dynamic
refresh, SmbService respects the state of the policy at login.

Bug:  757625 
Test: verified by setting policy locally.
Change-Id: I2d7cc147e51b584255679a00f233750f1b8cb4fe
Reviewed-on: https://chromium-review.googlesource.com/1153488
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585192}
[modify] https://crrev.com/125c51c78da1d4fbce1ee8b1427ae8468a4602b2/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/125c51c78da1d4fbce1ee8b1427ae8468a4602b2/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/125c51c78da1d4fbce1ee8b1427ae8468a4602b2/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
Project Member

Comment 416 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3813b7b39beb40002cf57d8e862c5a2620cf6ce9

commit 3813b7b39beb40002cf57d8e862c5a2620cf6ce9
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Aug 23 00:59:02 2018

Add policy for NetBios SMB Share discovery

This change adds an enterprise policy that disables NetBios share discovery
by default for enterprises and allows enterprises to manually turn it on.
NetBios discovery will be on for non-enterprise users.

This change does include any code to enforce the policy.

Bug:  chromium:757625 
Change-Id: I30288a13ef89378f021364b6f1fe4cead4e44afe
Reviewed-on: https://chromium-review.googlesource.com/1184240
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585345}
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/chrome/common/pref_names.cc
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/chrome/common/pref_names.h
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/components/policy/resources/policy_templates.json
[modify] https://crrev.com/3813b7b39beb40002cf57d8e862c5a2620cf6ce9/tools/metrics/histograms/enums.xml
Project Member

Comment 417 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/607c2083aac88ccf4f51ad80ad8cef49ebbfbfa8

commit 607c2083aac88ccf4f51ad80ad8cef49ebbfbfa8
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Aug 23 16:43:46 2018

Check NetBios Discovery policy when adding host locators

This change enforces the NetBiosShareDiscoveryEnabled policy. If enforced,
no NetBios discovery will be set up or performed when by the SmbService.

Bug:  757625 
Change-Id: I8bcd8d049dc597db208f9c38fae5a17b8069dd28
Reviewed-on: https://chromium-review.googlesource.com/1185405
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585516}
[modify] https://crrev.com/607c2083aac88ccf4f51ad80ad8cef49ebbfbfa8/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/607c2083aac88ccf4f51ad80ad8cef49ebbfbfa8/chrome/browser/chromeos/smb_client/smb_service.h
Project Member

Comment 418 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50c655c05e98da13c38d530cb72cdef7de9018ee

commit 50c655c05e98da13c38d530cb72cdef7de9018ee
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Aug 29 22:03:17 2018

SmbService: Ensure DBusThreadManager is initialized before Get()

Prevents an issue once enabling SMB by default where the SmbService
ctor runs before the DBusThreadManager is properly initialized. This
only happens during tests.

Bug:  chromium:757625 
Change-Id: Id25265a7a9b763c5ea1ab59106df366dda4fd309
Reviewed-on: https://chromium-review.googlesource.com/1195644
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587298}
[modify] https://crrev.com/50c655c05e98da13c38d530cb72cdef7de9018ee/chrome/browser/chromeos/smb_client/smb_service.cc
Project Member

Comment 419 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbd1d02f0d352476b06e82490e3c911fff1fc52

commit ebbd1d02f0d352476b06e82490e3c911fff1fc52
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Aug 29 22:17:53 2018

Do not pass unretained pointer to replies

This change fixes an issue when calling PostTaskWithTraitsAndReply with a
reply that has an unretained pointer to the member class. Because of a race in
tests, SmbService would be torn down and the reply would be run with a pointer
to SmbService resulting in a crash.

Bug:  chromium:757625 
Change-Id: Ide6b8dd4e05032c504152fafab88ec561d40e30a
Reviewed-on: https://chromium-review.googlesource.com/1195845
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587325}
[modify] https://crrev.com/ebbd1d02f0d352476b06e82490e3c911fff1fc52/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/ebbd1d02f0d352476b06e82490e3c911fff1fc52/chrome/browser/chromeos/smb_client/smb_service.cc
Project Member

Comment 420 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3663f072afbde13f2d65de1738b89887664efae0

commit 3663f072afbde13f2d65de1738b89887664efae0
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Aug 30 20:45:10 2018

Filter out native FSPs in Browser Tests

The FileSystemProviderApiTests assume that there are no native providers
and that the test extension is the only fsp. Once the SMB FSP is enabled,
this will no longer be the case so we need to explicitly filter out native
fsps in tests.

Bug:  chromium:757625 
Change-Id: I8ba9a8089d5b00aa8bfd3206ced9d60a4f2d05ce
Reviewed-on: https://chromium-review.googlesource.com/1195883
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587751}
[modify] https://crrev.com/3663f072afbde13f2d65de1738b89887664efae0/chrome/test/data/extensions/api_test/file_system_provider/configure/test.js
[modify] https://crrev.com/3663f072afbde13f2d65de1738b89887664efae0/chrome/test/data/extensions/api_test/file_system_provider/mount/test.js
Project Member

Comment 421 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/74d6276bbc07d7cbe1be69660b2216af1ffb38fa

commit 74d6276bbc07d7cbe1be69660b2216af1ffb38fa
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Aug 30 21:42:06 2018

smbprovider: Add SMB1 unsupported ErrorType

Adds an error to the smbprovider::ErrorType enum to be used to
differentiate between a generic failure and a failure because a
specified share is SMB1 which we do not support.

BUG= chromium:757625 
TEST=emerges
Change-Id: Ia2847f903d471c4015681a04303d2f01ce4310f1
Reviewed-on: https://chromium-review.googlesource.com/1195586
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/74d6276bbc07d7cbe1be69660b2216af1ffb38fa/dbus/smbprovider/directory_entry.proto
Project Member

Comment 422 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccb3179be7746902b7d090574adfb67920e056be

commit ccb3179be7746902b7d090574adfb67920e056be
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Aug 30 23:27:31 2018

Use unsupported device error message for SMB1

- Use more descriptive error message than the generic failure message when
failing to mount an SMB share because it is SMB1, which is unsupported.


Bug:  chromium:757625 
Change-Id: I8293ce065293172cd3faacab7fac304908069f09
Reviewed-on: https://chromium-review.googlesource.com/1196009
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587840}
[modify] https://crrev.com/ccb3179be7746902b7d090574adfb67920e056be/chrome/browser/chromeos/smb_client/smb_errors.cc
Project Member

Comment 423 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c5174d0e50b7ffac1b1998923dfa4b83c9f2630

commit 4c5174d0e50b7ffac1b1998923dfa4b83c9f2630
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Aug 30 23:54:29 2018

Update CrSearchableDropDown to support autofocus

- Updates the CrSearchableDropDown element to support the autofocus property.

Bug:  chromium:757625 
Change-Id: I2df07bd7dde0a22a7b724c2bd9132c7df321a5fb
Reviewed-on: https://chromium-review.googlesource.com/1196017
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587859}
[modify] https://crrev.com/4c5174d0e50b7ffac1b1998923dfa4b83c9f2630/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html
[modify] https://crrev.com/4c5174d0e50b7ffac1b1998923dfa4b83c9f2630/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.js
Project Member

Comment 424 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e27112dade01684cd1fd81c684dfe41413f2b843

commit e27112dade01684cd1fd81c684dfe41413f2b843
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Aug 31 00:28:00 2018

Disable NativeSmb feature in tests of Add New Services menu

The browser_tests for the Add New Services menu make the assumption that
there are no native FSPs installed, so this change disables NativeSmb in
those tests.

Bug:  chromium:757625 
Change-Id: I0d4d5d20fd71b3d537b0ef58a109a37ca4fc0cf3
Reviewed-on: https://chromium-review.googlesource.com/1197222
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587877}
[modify] https://crrev.com/e27112dade01684cd1fd81c684dfe41413f2b843/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
Project Member

Comment 425 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c1d9a3120434b77ad72b259607b94d017de1a6b

commit 9c1d9a3120434b77ad72b259607b94d017de1a6b
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Aug 31 02:48:16 2018

Set NativeSmb flag to enabled by default

- Network File Shares for ChromeOS will be availible by default starting in M70

Bug:  chromium:757625 
Change-Id: I0d4a6051cee3ac1893f34b78dc39f7b9c9378291
Reviewed-on: https://chromium-review.googlesource.com/1194790
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587926}
[modify] https://crrev.com/9c1d9a3120434b77ad72b259607b94d017de1a6b/chrome/common/chrome_features.cc
Project Member

Comment 426 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4aec5d456a2790378e63b5fb9f3377aa3bb8c73

commit e4aec5d456a2790378e63b5fb9f3377aa3bb8c73
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Sep 07 23:10:02 2018

Split share discovery into two steps

This change modifies the current GetSharesInNetwork function so that a
callback is fired as soon a discovery is done to indicate that name
resolution is possible. Additionally, a new ShareFinder::DiscoveryHosts
method enables performing host discovery without querying each host for
its shares. This change will make it possible to perform name resolution
on reboot.

Bug:  chromium:757625 
Change-Id: I437ca8ad6400824a3fbc9b870b5fb0307cee2ac4
Reviewed-on: https://chromium-review.googlesource.com/1199685
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589711}
[modify] https://crrev.com/e4aec5d456a2790378e63b5fb9f3377aa3bb8c73/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/e4aec5d456a2790378e63b5fb9f3377aa3bb8c73/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/e4aec5d456a2790378e63b5fb9f3377aa3bb8c73/chrome/browser/chromeos/smb_client/smb_share_finder.cc
[modify] https://crrev.com/e4aec5d456a2790378e63b5fb9f3377aa3bb8c73/chrome/browser/chromeos/smb_client/smb_share_finder.h
[modify] https://crrev.com/e4aec5d456a2790378e63b5fb9f3377aa3bb8c73/chrome/browser/chromeos/smb_client/smb_share_finder_unittest.cc
Project Member

Comment 427 by bugdroid1@chromium.org, Sep 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/425e22df6932c2dd87361a08b0cdf7876cfe2dc2

commit 425e22df6932c2dd87361a08b0cdf7876cfe2dc2
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sun Sep 09 02:06:32 2018

smbprovider: Cleanup initializer in FileCopyProgressTest

BUG= chromium:757625 
TEST=emerges

Change-Id: I39d86f167645d9240bec6388ddde05bc0d537186
Reviewed-on: https://chromium-review.googlesource.com/1214107
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/425e22df6932c2dd87361a08b0cdf7876cfe2dc2/smbprovider/file_copy_progress_test.cc
Project Member

Comment 428 by bugdroid1@chromium.org, Sep 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0f4ab44c8ffbfd1e1b0ba08041c5c01a956834f3

commit 0f4ab44c8ffbfd1e1b0ba08041c5c01a956834f3
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sun Sep 09 02:06:33 2018

smbprovider: Cleanup leftover TODO comment

- Doesn't not change any code

BUG= chromium:757625 
TEST=emerges

Change-Id: I6efaf0306cc7b38fb5810dba82abcffb3b36f294
Reviewed-on: https://chromium-review.googlesource.com/1214109
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0f4ab44c8ffbfd1e1b0ba08041c5c01a956834f3/smbprovider/samba_interface_impl.h
Project Member

Comment 429 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9aa7ff9830fb451ab8745837a48f3d88919e6c25

commit 9aa7ff9830fb451ab8745837a48f3d88919e6c25
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Mon Sep 10 05:09:08 2018

smbprovider: Release FD's so they can be reused

BUG= chromium:757625 
TEST=emerges

Change-Id: I4b347549422690e4c039b4577005088425a67de9
Reviewed-on: https://chromium-review.googlesource.com/1214110
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9aa7ff9830fb451ab8745837a48f3d88919e6c25/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/9aa7ff9830fb451ab8745837a48f3d88919e6c25/smbprovider/samba_interface_impl.cc
Project Member

Comment 430 by bugdroid1@chromium.org, Sep 10

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d13953ce495bf3e5fdb96d91150a80b85980f1c

commit 4d13953ce495bf3e5fdb96d91150a80b85980f1c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 10 14:20:13 2018

Disable NativeSmb feature in tests of Add New Services menu

The browser_tests for the Add New Services menu make the assumption that
there are no native FSPs installed, so this change disables NativeSmb in
those tests.

Bug:  chromium:757625 
Change-Id: I0d4d5d20fd71b3d537b0ef58a109a37ca4fc0cf3
Reviewed-on: https://chromium-review.googlesource.com/1197222
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587877}(cherry picked from commit e27112dade01684cd1fd81c684dfe41413f2b843)
Reviewed-on: https://chromium-review.googlesource.com/1216028
Cr-Commit-Position: refs/branch-heads/3538@{#206}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/4d13953ce495bf3e5fdb96d91150a80b85980f1c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
Project Member

Comment 431 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a792106c734cc63b0489876fc022bb13af69259

commit 1a792106c734cc63b0489876fc022bb13af69259
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 10 14:21:16 2018

Set NativeSmb flag to enabled by default

- Network File Shares for ChromeOS will be availible by default starting in M70

Bug:  chromium:757625 
Change-Id: I0d4a6051cee3ac1893f34b78dc39f7b9c9378291
Reviewed-on: https://chromium-review.googlesource.com/1194790
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587926}(cherry picked from commit 9c1d9a3120434b77ad72b259607b94d017de1a6b)
Reviewed-on: https://chromium-review.googlesource.com/1216029
Cr-Commit-Position: refs/branch-heads/3538@{#209}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1a792106c734cc63b0489876fc022bb13af69259/chrome/common/chrome_features.cc
Project Member

Comment 432 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9126be00169ab6b0a4bab649f82436c7f9cdf69

commit a9126be00169ab6b0a4bab649f82436c7f9cdf69
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 10 16:10:58 2018

Reresolve hostname of SMB Share on Remount

This change updates the remount flow so that hosts on the network are
rediscovered, so if the hostname is the same but the ip has changed since
the share was originally mounted, the share will be able to be mounted.

Bug:  chromium:757625 
Change-Id: I5038882fa44be15b725e1ccc0b377b244b62f787
Reviewed-on: https://chromium-review.googlesource.com/1199939
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589936}
[modify] https://crrev.com/a9126be00169ab6b0a4bab649f82436c7f9cdf69/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/a9126be00169ab6b0a4bab649f82436c7f9cdf69/chrome/browser/chromeos/smb_client/smb_service.h
Project Member

Comment 433 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a223d9577eda9cd5501491a15bc8516862971e09

commit a223d9577eda9cd5501491a15bc8516862971e09
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 10 21:27:43 2018

Shorten delay before mounting SMB share

Currently, we wait until the first batch of shares is returned from host
discovery before attempting to Mount a share so that name resolution can
be performed. This change switches to using the GatherSharesInNetwork method that
takes a HostDiscoveryResponse callback so that the delay is shortened.

Bug:  chromium:757625 
Change-Id: I22cf5fd48bdcc633fa4d7f2f08b1e6f7e10af764
Reviewed-on: https://chromium-review.googlesource.com/1211947
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590069}
[modify] https://crrev.com/a223d9577eda9cd5501491a15bc8516862971e09/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
[modify] https://crrev.com/a223d9577eda9cd5501491a15bc8516862971e09/chrome/browser/ui/webui/settings/chromeos/smb_handler.h
Project Member

Comment 434 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/b03af0353854028bfae0ce978e8666e815f621b9

commit b03af0353854028bfae0ce978e8666e815f621b9
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 17 20:17:43 2018

smbprovider: Generalize operation errors

This change adds more generic Start/Continue operation errors and method
constants for Start/ContinueReadDirectory.

BUG= chromium:757625 
TEST=emerges
Change-Id: Ic73faa628e3e825190e4d46ddaa3d1f671054edd
Reviewed-on: https://chromium-review.googlesource.com/1226156
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b03af0353854028bfae0ce978e8666e815f621b9/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/b03af0353854028bfae0ce978e8666e815f621b9/dbus/smbprovider/directory_entry.proto
Project Member

Comment 435 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fafe9f012e13ad72db3539fbdb6102d4708a08dd

commit fafe9f012e13ad72db3539fbdb6102d4708a08dd
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 17 23:46:39 2018

Roll src/third_party/cros_system_api/ 326384d6d..b03af0353 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/326384d6d8ea..b03af0353854

$ git log 326384d6d..b03af0353 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 baileyberro smbprovider: Generalize operation errors

Created with:
  roll-dep src/third_party/cros_system_api

Bug:  chromium:757625 
Change-Id: I4f195100af64ffb88013df0bba9a2361ab5a5e8c
Reviewed-on: https://chromium-review.googlesource.com/1228437
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591879}
[modify] https://crrev.com/fafe9f012e13ad72db3539fbdb6102d4708a08dd/DEPS
Project Member

Comment 436 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e9ecb6947605aae709fed0585e72edcba833b5ee

commit e9ecb6947605aae709fed0585e72edcba833b5ee
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:17 2018

smbprovider: Add metadata_cache_enabled to MountManager

- Adds a metadata_cache_enabled member to MountManager. Since this
needs to be known at cache construction time rather than by SmbProvider,
this change adds metadata_cache_enabled to the MountManager ctor

BUG= chromium:757625 
TEST=unittests run
Change-Id: I797cf8878e5d78c0b19fdaaf26ee07072f7c6079
Reviewed-on: https://chromium-review.googlesource.com/1222471
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e9ecb6947605aae709fed0585e72edcba833b5ee/smbprovider/mount_tracker.h
[modify] https://crrev.com/e9ecb6947605aae709fed0585e72edcba833b5ee/smbprovider/mount_tracker.cc
[modify] https://crrev.com/e9ecb6947605aae709fed0585e72edcba833b5ee/smbprovider/mount_tracker_test.cc
[modify] https://crrev.com/e9ecb6947605aae709fed0585e72edcba833b5ee/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/e9ecb6947605aae709fed0585e72edcba833b5ee/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/e9ecb6947605aae709fed0585e72edcba833b5ee/smbprovider/smbprovider_test.cc
Project Member

Comment 437 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ed7b9df625f456217a04d3862359e27d9e27bb8c

commit ed7b9df625f456217a04d3862359e27d9e27bb8c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:17 2018

smbprovider: Remove enable_metadata_cache from SmbProvider

This change removes the enable_metadata_cache bool from SmbProvider.
This is now injected into MountManger via its ctor. All ReadDirectories
will now include metadata.

BUG= chromium:757625 
TEST=unittests
Change-Id: I7de2abefc0f4724b2535645792583f35d2981db5
Reviewed-on: https://chromium-review.googlesource.com/1222472
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>

[modify] https://crrev.com/ed7b9df625f456217a04d3862359e27d9e27bb8c/smbprovider/smbprovider.cc
[modify] https://crrev.com/ed7b9df625f456217a04d3862359e27d9e27bb8c/smbprovider/smbprovider.h
[modify] https://crrev.com/ed7b9df625f456217a04d3862359e27d9e27bb8c/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/ed7b9df625f456217a04d3862359e27d9e27bb8c/smbprovider/smbprovider_main.cc
Project Member

Comment 438 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5f7129fd9fb98e839e177ad7b4f21bceba3f4a09

commit 5f7129fd9fb98e839e177ad7b4f21bceba3f4a09
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:19 2018

smbprovider: Seperate readdir flow for shares and dirs

This change seperates the readdir flow for shares and directories.
This is in anticipation of moving readdir for directories into a
ReadDirProgress class.

BUG= chromium:757625 
TEST=unittests
Change-Id: I30de8a51e0e7f0f4740bb2607bbd3ecbf279ab2e
Reviewed-on: https://chromium-review.googlesource.com/1222473
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>

[modify] https://crrev.com/5f7129fd9fb98e839e177ad7b4f21bceba3f4a09/smbprovider/smbprovider.cc
[modify] https://crrev.com/5f7129fd9fb98e839e177ad7b4f21bceba3f4a09/smbprovider/smbprovider.h
Project Member

Comment 439 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9

commit 3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:20 2018

smbprovider: Remove iterator templating

This change reduces the complexity of the various iterators by more
closely coupling CachingIterator and DirectoryIterator. Additionally,
becuase the GetShares and ReadDir flows have been broken up, the various
templated Get() functions are no longer needed and constructors can
simply be used instead.

BUG= chromium:757625 
TEST=unittests run
Change-Id: I9f5f1af7306c87f937274cc8a74fccd90fd143c1
Reviewed-on: https://chromium-review.googlesource.com/1222474
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>

[modify] https://crrev.com/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9/smbprovider/smbprovider.h
[modify] https://crrev.com/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9/smbprovider/iterator/caching_iterator.h
[modify] https://crrev.com/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9/smbprovider/smbprovider.cc
[modify] https://crrev.com/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9/smbprovider/iterator/directory_iterator.h
[modify] https://crrev.com/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9/smbprovider/iterator/caching_iterator_test.cc
[modify] https://crrev.com/3ac5ec44a76e37bb8f169b5c86a1c0a53befc2e9/smbprovider/smbprovider_test.cc
Project Member

Comment 440 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9e7f30f846df0360ce976566d2c55529ab6464be

commit 9e7f30f846df0360ce976566d2c55529ab6464be
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:20 2018

smbprovider: Create ReadDirProgress

This change creates the scaffolding for a ReadDirProgress and
corresponding tests. Following CLs will implement this class.

BUG= chromium:757625 
TEST=unittests run
Change-Id: If8d22664a49ee8a73b76693334540e5b6021e811
Reviewed-on: https://chromium-review.googlesource.com/1222475
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>

[add] https://crrev.com/9e7f30f846df0360ce976566d2c55529ab6464be/smbprovider/read_dir_progress.cc
[modify] https://crrev.com/9e7f30f846df0360ce976566d2c55529ab6464be/smbprovider/smbprovider.gyp
[add] https://crrev.com/9e7f30f846df0360ce976566d2c55529ab6464be/smbprovider/read_dir_progress_test.cc
[modify] https://crrev.com/9e7f30f846df0360ce976566d2c55529ab6464be/smbprovider/constants.h
[add] https://crrev.com/9e7f30f846df0360ce976566d2c55529ab6464be/smbprovider/read_dir_progress.h
Project Member

Comment 441 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3ec81f29a517c7180eccc26c347bdd4f45a56453

commit 3ec81f29a517c7180eccc26c347bdd4f45a56453
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:18 2018

smbprovider: Remove invalid tests

This change removes a couple of tests that do not make sense in a real
world scenario. These tests were verifying that non-files/non-dirs were
not returned via ReadDirectory, but this does not really make sense
because the type returned from a ReadDir+ (which is now all ReadDirs) is
libsmb_file_info which represents a File or Directory.

BUG= chromium:757625 
TEST=unittests
Change-Id: I9369ecf9e8873d25c59b60c080254f02799b244b
Reviewed-on: https://chromium-review.googlesource.com/1224635
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>

[modify] https://crrev.com/3ec81f29a517c7180eccc26c347bdd4f45a56453/smbprovider/iterator/directory_iterator_test.cc
[modify] https://crrev.com/3ec81f29a517c7180eccc26c347bdd4f45a56453/smbprovider/smbprovider_test.cc
Project Member

Comment 442 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5e575eb1d5bd1eec7e91497806877fe81008bf67

commit 5e575eb1d5bd1eec7e91497806877fe81008bf67
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:19 2018

smbprovider: Remove symlinks from Readdir

This change adds filtering for symlinks in ReadDirectory. Previously,
symlinks were not filtered, which could be a potential security threat
vector, and could result in weird behavior in CrOS which does not have a
concept of symlinks.

BUG= chromium:757625 
TEST=unittests
Change-Id: Ide14027bb494e2f3e52c6aee4b445fe139665cd4
Reviewed-on: https://chromium-review.googlesource.com/1224636
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>

[modify] https://crrev.com/5e575eb1d5bd1eec7e91497806877fe81008bf67/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/5e575eb1d5bd1eec7e91497806877fe81008bf67/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/5e575eb1d5bd1eec7e91497806877fe81008bf67/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/5e575eb1d5bd1eec7e91497806877fe81008bf67/smbprovider/constants.h
Project Member

Comment 443 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9d77e13119c34411918b17aba7deb115595f1d7a

commit 9d77e13119c34411918b17aba7deb115595f1d7a
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:21 2018

smbprovider: Implement ReadDirProgress

- Implements the ReadDirProgress class plus tests.
- Keeps track of an in progress ReadDirectory, scaling up the number of
results returned each time so that initial results are returned to the
user as quickly as possible.

BUG= chromium:757625 
TEST=unittests
Change-Id: I1b908e72a3f8368c0060d8f36c727502a22e8737
Reviewed-on: https://chromium-review.googlesource.com/1225212
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9d77e13119c34411918b17aba7deb115595f1d7a/smbprovider/read_dir_progress.cc
[modify] https://crrev.com/9d77e13119c34411918b17aba7deb115595f1d7a/smbprovider/read_dir_progress_test.cc
[modify] https://crrev.com/9d77e13119c34411918b17aba7deb115595f1d7a/smbprovider/read_dir_progress.h
Project Member

Comment 444 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/21e035983cf8590a0c3701263dc15d09892b58d8

commit 21e035983cf8590a0c3701263dc15d09892b58d8
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:22 2018

smbprovider: Add Start/ContinueReadDirectory methods to D-Bus

- Adds StartReadDirectory and ContinueReadDirectory methods to the
smbprovider D-Bus interface.
- Future CLs will implement and add tests.

BUG= chromium:757625 
TEST=emerges
Change-Id: I5385a310c1f8e88388fa1961d2248dc58c7d719e
Reviewed-on: https://chromium-review.googlesource.com/1226215
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/21e035983cf8590a0c3701263dc15d09892b58d8/smbprovider/smbprovider.cc
[modify] https://crrev.com/21e035983cf8590a0c3701263dc15d09892b58d8/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/21e035983cf8590a0c3701263dc15d09892b58d8/smbprovider/smbprovider.h
Project Member

Comment 445 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/236e738fc55c80b6bab1727adf9de2d5cab0da04

commit 236e738fc55c80b6bab1727adf9de2d5cab0da04
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 18:58:22 2018

smbprovider: Add StartReadDirectory and ContinueReadDirectory helpers to SmbProvider

- Adds StartReadDirectory and ContinueReadDirectory helper methods to
SmbProvider to be used to implement the public versions.

BUG= chromium:757625 
TEST=emerges
Change-Id: I03d1870df95b83f3e10870deea072bd2188331ba
Reviewed-on: https://chromium-review.googlesource.com/1226216
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/236e738fc55c80b6bab1727adf9de2d5cab0da04/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/236e738fc55c80b6bab1727adf9de2d5cab0da04/smbprovider/smbprovider.h
[modify] https://crrev.com/236e738fc55c80b6bab1727adf9de2d5cab0da04/smbprovider/smbprovider.cc
Project Member

Comment 446 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/676bcc9aed522536a9b4f2734ef11aaedc384eb9

commit 676bcc9aed522536a9b4f2734ef11aaedc384eb9
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Sep 26 20:48:11 2018

Add Start/ContinueReadDirectory to SmbProviderClient.

This change adds Start/ContinueReadDirectory methods to
SmbProviderClient. These map 1:1 to corresponding smbprovider daemon
methods.

Bug:  chromium:757625 
Change-Id: Idb33b81492949b5499fb402686c211948d736f00
Reviewed-on: https://chromium-review.googlesource.com/1228438
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594467}
[modify] https://crrev.com/676bcc9aed522536a9b4f2734ef11aaedc384eb9/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/676bcc9aed522536a9b4f2734ef11aaedc384eb9/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/676bcc9aed522536a9b4f2734ef11aaedc384eb9/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/676bcc9aed522536a9b4f2734ef11aaedc384eb9/chromeos/dbus/smb_provider_client.h
Project Member

Comment 447 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2f5297f1a1e083b03e619a543a16a29d1f576fd3

commit 2f5297f1a1e083b03e619a543a16a29d1f576fd3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Sep 28 02:45:01 2018

smbprovider: Implement Start/ContinueReadDirectory on SmbProvider

- Implements Start/ContinueReadDirectory
- Tests duplicated from ReadDirectory tests

BUG= chromium:757625 
TEST=unittests
Change-Id: I78e438626e4674be2ffd4a9f5272ab2f9bc7ea73
Reviewed-on: https://chromium-review.googlesource.com/1226217
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/2f5297f1a1e083b03e619a543a16a29d1f576fd3/smbprovider/smbprovider.cc
[modify] https://crrev.com/2f5297f1a1e083b03e619a543a16a29d1f576fd3/smbprovider/smbprovider_test.cc

Comment 448 by zentaro@chromium.org, Sep 28

Status: Fixed (was: Assigned)
We can stop using this bug now as a catch all for the initial implementation.

Further bugs and features can have their own bug now.
Project Member

Comment 449 by bugdroid1@chromium.org, Sep 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad601e7f945bbb91018c82552a4e63ab070bb37b

commit ad601e7f945bbb91018c82552a4e63ab070bb37b
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Sep 29 00:16:39 2018

Add Start/ContinueReadDirectory methods to SmbFileSystem

- Implements Start/ContinueReadDirectory methods to SmbFileSystem

Bug:  chromium:757625 
Change-Id: Ib692fb34b488c951c518d265af19cb147ee40c9e
Reviewed-on: https://chromium-review.googlesource.com/1231816
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595265}
[modify] https://crrev.com/ad601e7f945bbb91018c82552a4e63ab070bb37b/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/ad601e7f945bbb91018c82552a4e63ab070bb37b/chrome/browser/chromeos/smb_client/smb_file_system.h
Project Member

Comment 450 by bugdroid1@chromium.org, Sep 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb453f1b06c748bb1f0ee542196545ba64823f88

commit eb453f1b06c748bb1f0ee542196545ba64823f88
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Sep 29 02:09:21 2018

Switch to new SmbFileSystem readdir method

-Switches SmbFileSystem to using the new Start/Continue ReadDirectory flow

Bug:  chromium:757625 
Change-Id: I7e6501b90c4158775440871125dba0d05df7b508
Reviewed-on: https://chromium-review.googlesource.com/1231918
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595288}
[modify] https://crrev.com/eb453f1b06c748bb1f0ee542196545ba64823f88/chrome/browser/chromeos/smb_client/smb_file_system.cc
Project Member

Comment 451 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f575ede58fe0e5ea3268533f7d825b6db0bdfc

commit 28f575ede58fe0e5ea3268533f7d825b6db0bdfc
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Oct 02 13:14:11 2018

Update CrSearchableDropDown to support autofocus

- Updates the CrSearchableDropDown element to support the autofocus property.

Bug:  chromium:757625 
Change-Id: I2df07bd7dde0a22a7b724c2bd9132c7df321a5fb
Reviewed-on: https://chromium-review.googlesource.com/1196017
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587859}(cherry picked from commit 4c5174d0e50b7ffac1b1998923dfa4b83c9f2630)
Reviewed-on: https://chromium-review.googlesource.com/1256626
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#811}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/28f575ede58fe0e5ea3268533f7d825b6db0bdfc/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html
[modify] https://crrev.com/28f575ede58fe0e5ea3268533f7d825b6db0bdfc/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.js
Project Member

Comment 452 by cr-audit...@appspot.gserviceaccount.com, Oct 2

Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 28f575ede58fe0e5ea3268533f7d825b6db0bdfc was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 453 by cr-audit...@appspot.gserviceaccount.com, Oct 2

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/28f575ede58fe0e5ea3268533f7d825b6db0bdfc

Commit: 28f575ede58fe0e5ea3268533f7d825b6db0bdfc
Author: baileyberro@chromium.org
Commiter: zentaro@chromium.org
Date: 2018-10-02 13:14:11 +0000 UTC

Update CrSearchableDropDown to support autofocus

- Updates the CrSearchableDropDown element to support the autofocus property.

Bug:  chromium:757625 
Change-Id: I2df07bd7dde0a22a7b724c2bd9132c7df321a5fb
Reviewed-on: https://chromium-review.googlesource.com/1196017
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587859}(cherry picked from commit 4c5174d0e50b7ffac1b1998923dfa4b83c9f2630)
Reviewed-on: https://chromium-review.googlesource.com/1256626
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#811}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Project Member

Comment 454 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8aa1f7981550cd58cabe34d46e2f96593af53df

commit f8aa1f7981550cd58cabe34d46e2f96593af53df
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Oct 02 13:35:20 2018

Use unsupported device error message for SMB1

- Use more descriptive error message than the generic failure message when
failing to mount an SMB share because it is SMB1, which is unsupported.

TBR=baileyberro@chromium.org

(cherry picked from commit ccb3179be7746902b7d090574adfb67920e056be)

Bug:  chromium:757625 
Change-Id: I8293ce065293172cd3faacab7fac304908069f09
Reviewed-on: https://chromium-review.googlesource.com/1196009
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587840}
Reviewed-on: https://chromium-review.googlesource.com/1256374
Cr-Commit-Position: refs/branch-heads/3538@{#813}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/f8aa1f7981550cd58cabe34d46e2f96593af53df/chrome/browser/chromeos/smb_client/smb_errors.cc
Project Member

Comment 455 by cr-audit...@appspot.gserviceaccount.com, Oct 2 

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision f8aa1f7981550cd58cabe34d46e2f96593af53df was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 456 by cr-audit...@appspot.gserviceaccount.com, Oct 2 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/f8aa1f7981550cd58cabe34d46e2f96593af53df

Commit: f8aa1f7981550cd58cabe34d46e2f96593af53df
Author: zentaro@chromium.org
Commiter: zentaro@chromium.org
Date: 2018-10-02 13:35:20 +0000 UTC

Use unsupported device error message for SMB1

- Use more descriptive error message than the generic failure message when
failing to mount an SMB share because it is SMB1, which is unsupported.

TBR=baileyberro@chromium.org

(cherry picked from commit ccb3179be7746902b7d090574adfb67920e056be)

Bug:  chromium:757625 
Change-Id: I8293ce065293172cd3faacab7fac304908069f09
Reviewed-on: https://chromium-review.googlesource.com/1196009
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587840}
Reviewed-on: https://chromium-review.googlesource.com/1256374
Cr-Commit-Position: refs/branch-heads/3538@{#813}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Comment 457 by ibezmenov@chromium.org, Nov 8

Status: Verified (was: Fixed)
Marking this a catch-all bug as Verified, based on the feature testing: https://bugs.chromium.org/p/chromium/issues/detail?id=865443#c34
Showing comments 358 - 457 of 457 Older ›
►

Sign in to add a comment