New issue
Advanced search Search tips
Starred by 9 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 838946



Sign in to add a comment

Add native SMB support to Chrome OS

Project Member Reported by allenvic@chromium.org, Aug 21 2017

Issue description

Description:

Add smbclientd to act as a DBus daemon server

 
Showing comments 314 - 413 of 413 Older
Project Member

Comment 314 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/34739f93aaa93596cf0bdb8b222cac7a04b279e2

commit 34739f93aaa93596cf0bdb8b222cac7a04b279e2
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:18 2018

Add ReadDirectory to SmbProvider autotest

Adds ReadDirectory function to the D-Bus wrapper for autotest

Bug:757625
Change-Id: Ide650c5c6587b8719ea6fe48f0bfd9a2c12ffa3a
TEST=test_that -b $BOARD $DUT_IP enterprise_SmbProviderDaemon --args="mount_path=$MOUNT"
Reviewed-on: https://chromium-review.googlesource.com/1109021
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/34739f93aaa93596cf0bdb8b222cac7a04b279e2/client/common_lib/cros/smbprovider.py

Project Member

Comment 315 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/43022474e1a405db79b9fe67540182ade7c3cb92

commit 43022474e1a405db79b9fe67540182ade7c3cb92
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:19 2018

Add unmount to SmbProvider autotest

Adds unmount function to the D-Bus wrapper for autotest

Bug:757625
Change-Id: Ic184d1f87993266f245e79cf13eeada9a8f504ef
TEST=tested manually
Reviewed-on: https://chromium-review.googlesource.com/1109257
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/43022474e1a405db79b9fe67540182ade7c3cb92/client/common_lib/cros/smbprovider.py

Project Member

Comment 316 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1ba15530f80164f574d40ae215e3178a65910d45

commit 1ba15530f80164f574d40ae215e3178a65910d45
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:19 2018

Add get_metadata to SmbProvider autotest

Adds get_metadata function to the D-Bus wrapper for autotest

Bug:757625
Change-Id: Id0159e8438d25dcdf075b64cf1f3cc7a594d4d00
Reviewed-on: https://chromium-review.googlesource.com/1110448
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/1ba15530f80164f574d40ae215e3178a65910d45/client/common_lib/cros/smbprovider.py

Project Member

Comment 317 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1455cb59fd49110d4b081436d7bec4b7fc0ca6a

commit b1455cb59fd49110d4b081436d7bec4b7fc0ca6a
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:20 2018

Add open_file and close_file to SmbProvider autotest

Adds open_file and close_file functions to the D-Bus wrapper for
autotest

Bug:757625
Change-Id: I554d0b8ebe3d15cdabcd639362a08a9f89026db1
Reviewed-on: https://chromium-review.googlesource.com/1110841
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/b1455cb59fd49110d4b081436d7bec4b7fc0ca6a/client/common_lib/cros/smbprovider.py

Project Member

Comment 318 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d6aa01143c4d65e5c9cf292fa7de771bfdb8fa78

commit d6aa01143c4d65e5c9cf292fa7de771bfdb8fa78
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:21 2018

Add read_file to SmbProvider autotest

Adds read_file function to the D-Bus wrapper for autotest. This allows
reading of files from an SMB share

Bug:757625
Change-Id: I74297c878066816a8d12f779849828070f664c16
Reviewed-on: https://chromium-review.googlesource.com/1111102
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/d6aa01143c4d65e5c9cf292fa7de771bfdb8fa78/client/common_lib/cros/smbprovider.py

Project Member

Comment 319 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f91f9c6068d8a96d95a391cf3a2d03f42d26352c

commit f91f9c6068d8a96d95a391cf3a2d03f42d26352c
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:21 2018

Add create_file to SmbProvider autotest

Adds create_file function to the D-Bus wrapper for autotest

Bug:757625
Change-Id: Ife8a277e1eafcd53ba854c257d13161bf92a020e
Reviewed-on: https://chromium-review.googlesource.com/1111343
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/f91f9c6068d8a96d95a391cf3a2d03f42d26352c/client/common_lib/cros/smbprovider.py

Project Member

Comment 320 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7658c597c1c386829885da95b7eeb07783d1811b

commit 7658c597c1c386829885da95b7eeb07783d1811b
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:22 2018

Add delete_entry to SmbProvider autotest

Adds delete_entry function to the D-Bus wrapper for autotest

Bug:757625
Change-Id: I21f6464cf4cc5256a8dc0411174cfacd2ebcc05a
Reviewed-on: https://chromium-review.googlesource.com/1112341
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/7658c597c1c386829885da95b7eeb07783d1811b/client/common_lib/cros/smbprovider.py

Project Member

Comment 321 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d486356f1053de25fd4703e421832d2e4cb344b6

commit d486356f1053de25fd4703e421832d2e4cb344b6
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jun 29 21:16:23 2018

Add truncate and write_file to SmbProvider autotest

Adds truncate and write_file functions to the D-Bus wrapper for autotest
and change PasswordFd to DataFd

Bug:757625
Change-Id: I6df97698a529420cd1adff3c47c10fbba3a32446
Reviewed-on: https://chromium-review.googlesource.com/1112343
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/d486356f1053de25fd4703e421832d2e4cb344b6/client/common_lib/cros/smbprovider.py

Project Member

Comment 322 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d0ae43f9f1cd510b2795b4fae202b8d0d081fa92

commit d0ae43f9f1cd510b2795b4fae202b8d0d081fa92
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:42 2018

smbprovider: Add function pointers for _ctx functions.

- Part of a sequence of CL's to transition from libsmbclients
  compat API to the underlying _ctx API
- Adds the remaining function pointers
- Alphabetizes the function pointer members
- No functionality is changed in this CL

BUG= chromium:857487 ,chromium:757625
TEST=emerges, unittests

Change-Id: I655b8928d1d095c831364a1717cb5b9a2bd515f9
Reviewed-on: https://chromium-review.googlesource.com/1118924
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/d0ae43f9f1cd510b2795b4fae202b8d0d081fa92/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/d0ae43f9f1cd510b2795b4fae202b8d0d081fa92/smbprovider/samba_interface_impl.cc

Project Member

Comment 323 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d16dbf81ffcefaecbd9bdb54a072b4c289b98b23

commit d16dbf81ffcefaecbd9bdb54a072b4c289b98b23
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:43 2018

smbprovider: Populates function pointers for _ctx functions.

- Part of a sequence of CL's to transition from libsmbclients
  compat API to the underlying _ctx API
- Populates all the function pointers
- No functionality is changed in this CL

BUG= chromium:857487 ,chromium:757625
TEST=emerges, unittests

Change-Id: If56ed4ee842d9a9ca47918f3257eb41cc7bf5619
Reviewed-on: https://chromium-review.googlesource.com/1118965
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/d16dbf81ffcefaecbd9bdb54a072b4c289b98b23/smbprovider/samba_interface_impl.cc

Project Member

Comment 324 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a82f44362ec93e33e4a5bc918923840b5d8e3efa

commit a82f44362ec93e33e4a5bc918923840b5d8e3efa
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:43 2018

smbprovider: Add skeleton of SequentialIdMap

- Part of CL's to transition to using smbc_*_ctx functions
- Adds skeleton implementation and test file
- No logic is changed in this CL

BUG= chromium:857487 ,chromium:757625
TEST=emerges,unittests

Change-Id: I93fc9ffb629eb675883131c779e6913de4aa6547
Reviewed-on: https://chromium-review.googlesource.com/1118966
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/a82f44362ec93e33e4a5bc918923840b5d8e3efa/smbprovider/sequential_id_map.h
[add] https://crrev.com/a82f44362ec93e33e4a5bc918923840b5d8e3efa/smbprovider/sequential_id_map_test.cc
[modify] https://crrev.com/a82f44362ec93e33e4a5bc918923840b5d8e3efa/smbprovider/smbprovider.gyp

Project Member

Comment 325 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/15804f7d20882a749cc6ffe6e182bc9bdb334e5b

commit 15804f7d20882a749cc6ffe6e182bc9bdb334e5b
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:44 2018

smbprovider: Implement Insert and Find on SequentialIdMap

- Part of CL's to transition to using smbc_*_ctx functions
- No behavior change to live code in this CL

BUG= chromium:857487 ,chromium:757625
TEST=emerges,unittests

Change-Id: I4da74039090dd633cd7e2d47d16bab1151ce0983
Reviewed-on: https://chromium-review.googlesource.com/1118967
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/15804f7d20882a749cc6ffe6e182bc9bdb334e5b/smbprovider/sequential_id_map.h
[modify] https://crrev.com/15804f7d20882a749cc6ffe6e182bc9bdb334e5b/smbprovider/sequential_id_map_test.cc

Project Member

Comment 326 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4318b9b29d30550ef6f95847b64a8ed4ab8b137f

commit 4318b9b29d30550ef6f95847b64a8ed4ab8b137f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:44 2018

smbprovider: Implement Contains on SequentialIdMap

- Part of CL's to transition to using smbc_*_ctx functions
- No behavior change to live code in this CL

BUG= chromium:857487 ,chromium:757625
TEST=emerges,unittests

Change-Id: I95df2a50d25e131a94f40ea6caad616ceaf6d986
Reviewed-on: https://chromium-review.googlesource.com/1118968
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4318b9b29d30550ef6f95847b64a8ed4ab8b137f/smbprovider/sequential_id_map.h
[modify] https://crrev.com/4318b9b29d30550ef6f95847b64a8ed4ab8b137f/smbprovider/sequential_id_map_test.cc

Project Member

Comment 327 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b841c3951c8f7ff238206b80ca70c76ce3aa5a1c

commit b841c3951c8f7ff238206b80ca70c76ce3aa5a1c
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:45 2018

smbprovider: Implement Remove and Count on SequentialIdMap

- Part of CL's to transition to using smbc_*_ctx functions
- No behavior change to live code in this CL

BUG= chromium:857487 ,chromium:757625
TEST=emerges,unittests

Change-Id: Ie271077a4737186749f34a374ce4b5a054c16a75
Reviewed-on: https://chromium-review.googlesource.com/1118969
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/b841c3951c8f7ff238206b80ca70c76ce3aa5a1c/smbprovider/sequential_id_map.h
[modify] https://crrev.com/b841c3951c8f7ff238206b80ca70c76ce3aa5a1c/smbprovider/sequential_id_map_test.cc

Project Member

Comment 328 by bugdroid1@chromium.org, Jun 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3e071ea2d1311b0d97064c683ff2e0d4bc23e1ae

commit 3e071ea2d1311b0d97064c683ff2e0d4bc23e1ae
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jun 30 05:00:45 2018

smbprovider: Use new FD mapping on splice calls

- Part of CL's to transition to using smbc_*_ctx functions
- Adds a map to SambaInterface to track FD->SMBCFILE
- Updates the function calls already using _ctx
- Follow up will convert remaining functions

BUG= chromium:857487 ,chromium:757625
TEST=emerges,unittests

Change-Id: I08f1f5aa1eafb3e0672e9603177b2bb80f66148e
Reviewed-on: https://chromium-review.googlesource.com/1118970
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/3e071ea2d1311b0d97064c683ff2e0d4bc23e1ae/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/3e071ea2d1311b0d97064c683ff2e0d4bc23e1ae/smbprovider/samba_interface_impl.cc

Project Member

Comment 329 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/57aa1bcab86c44319632c60b8b4d259303ca1358

commit 57aa1bcab86c44319632c60b8b4d259303ca1358
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sun Jul 01 00:21:22 2018

smbprovider: Implement ParseNetBiosPacket

This change implements SmbProvider::ParseNetBiosPacket
which calls the NetBiosPacketParser to parse the packet.

BUG=chromium:757625
TEST=needs unittests
Change-Id: Ia6d8bf53195945c604a28babed9fee66ad45315e
Reviewed-on: https://chromium-review.googlesource.com/1070557
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/57aa1bcab86c44319632c60b8b4d259303ca1358/smbprovider/smbprovider.cc
[modify] https://crrev.com/57aa1bcab86c44319632c60b8b4d259303ca1358/smbprovider/smbprovider.h
[modify] https://crrev.com/57aa1bcab86c44319632c60b8b4d259303ca1358/smbprovider/smbprovider_test.cc

Project Member

Comment 330 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/0e87cf5dc5ef30723eed5991cec27d01ba7eccee

commit 0e87cf5dc5ef30723eed5991cec27d01ba7eccee
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sun Jul 01 04:17:52 2018

system_api: Add Smb Copy Errors

This change adds ERROR_COPY_PENDING and ERROR_COPY_FAILED to
smbprovider::ErrorType in order to represent a copy erroring
for a non-file related reason, and a copy being incomplete.

BUG=chromium:757625
TEST=emerges
Change-Id: Ie2126d44a4ba166322ab992130f85f6d991f2a4d
Reviewed-on: https://chromium-review.googlesource.com/1118615
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/0e87cf5dc5ef30723eed5991cec27d01ba7eccee/dbus/smbprovider/directory_entry.proto

Project Member

Comment 331 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4ebf6f2d389324b049a8befece4835d7ddf9b587

commit 4ebf6f2d389324b049a8befece4835d7ddf9b587
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sun Jul 01 04:17:50 2018

smbprovider: Add password_fd as a remount param

This change adds password_fd as a parameter to
SmbProvider::Remount() so that is can be passed
down to the MountManager in order to add non-empty
credentials to the CredentialStore.

BUG=chromium:757625
TEST=emerges
Change-Id: I241130324e2c912aaa31d05d47bd9851807e3bc7
Reviewed-on: https://chromium-review.googlesource.com/1097740
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/4ebf6f2d389324b049a8befece4835d7ddf9b587/smbprovider/smbprovider.cc
[modify] https://crrev.com/4ebf6f2d389324b049a8befece4835d7ddf9b587/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/4ebf6f2d389324b049a8befece4835d7ddf9b587/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/4ebf6f2d389324b049a8befece4835d7ddf9b587/smbprovider/smbprovider.h

Project Member

Comment 332 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e496d6c809f8721d2e046411189c8345cf6a666c

commit e496d6c809f8721d2e046411189c8345cf6a666c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sun Jul 01 04:17:51 2018

smbprovider: Add parameters to MountManager::Remount

This change adds parameters to the MountManager Remount
function to take credentials so that Kerberos ChromAD
shares can be remounted.

BUG=chromium:757625
TEST=emerges
Change-Id: I2ef4dce91c8d7c735dbf71934e3983143bb5ab27
Reviewed-on: https://chromium-review.googlesource.com/1097741
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e496d6c809f8721d2e046411189c8345cf6a666c/smbprovider/mount_manager.cc
[modify] https://crrev.com/e496d6c809f8721d2e046411189c8345cf6a666c/smbprovider/smbprovider.h
[modify] https://crrev.com/e496d6c809f8721d2e046411189c8345cf6a666c/smbprovider/smbprovider.cc
[modify] https://crrev.com/e496d6c809f8721d2e046411189c8345cf6a666c/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/e496d6c809f8721d2e046411189c8345cf6a666c/smbprovider/proto.cc
[modify] https://crrev.com/e496d6c809f8721d2e046411189c8345cf6a666c/smbprovider/mount_manager.h

Project Member

Comment 333 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc3698a4aa1d4443e32edf5e17f01c3505360ad7

commit dc3698a4aa1d4443e32edf5e17f01c3505360ad7
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 02 13:53:16 2018

Add authentication parameters to SmbProviderClient::Remount

This change adds authentication parameters to SmbProviderClient::Remount
so ChromAD Kerberos shares can be remounted by passing in a user's
username and workgroup.

Bug: chromium:757625
Change-Id: I201a100526cbf1f29188e2b9b7e797c60b929620
Reviewed-on: https://chromium-review.googlesource.com/1098079
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571882}
[modify] https://crrev.com/dc3698a4aa1d4443e32edf5e17f01c3505360ad7/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/dc3698a4aa1d4443e32edf5e17f01c3505360ad7/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/dc3698a4aa1d4443e32edf5e17f01c3505360ad7/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/dc3698a4aa1d4443e32edf5e17f01c3505360ad7/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/dc3698a4aa1d4443e32edf5e17f01c3505360ad7/chromeos/dbus/smb_provider_client.h

Project Member

Comment 334 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fdc10d9c7373625982b59739b8688ec6fa87680

commit 7fdc10d9c7373625982b59739b8688ec6fa87680
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 02 15:49:21 2018

Implement Kerberos-ChromAD remount in SmbService::Remount.

This change implements the logic to check whether a mount was originally
mounted with ChromAD Kerberos, and if so passes the user's username and
workgroup when attempting to remount.

Bug: chromium:757625
Change-Id: I3f1d4261d118f11cb410c7c44a8150423c99fbf9
Reviewed-on: https://chromium-review.googlesource.com/1098115
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571906}
[modify] https://crrev.com/7fdc10d9c7373625982b59739b8688ec6fa87680/chrome/browser/chromeos/smb_client/smb_service.cc

Project Member

Comment 336 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3b35acc913a3b11c7ecf2e3c746fe3d6223c291b

commit 3b35acc913a3b11c7ecf2e3c746fe3d6223c291b
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jul 10 16:45:55 2018

smbprovider: Make dtor of DepthFirstIterator virtual

This change makes the destructor of DepthFirstIterator
virtual so that derived classes are properly destroyed.

BUG=chromium:757625
TEST=none
Change-Id: Ib12989d63cf610e8ee373366de13ccf782c59846
Reviewed-on: https://chromium-review.googlesource.com/1123256
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/3b35acc913a3b11c7ecf2e3c746fe3d6223c291b/smbprovider/iterator/depth_first_iterator.h

Project Member

Comment 337 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/700bfa7d9c23b473f274a7c33c04abdeefcaa5e9

commit 700bfa7d9c23b473f274a7c33c04abdeefcaa5e9
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Jul 12 18:35:37 2018

smbprovider: Add SpliceFile to SambaInterface

-Adds SpliceFile to SambaInterface
-Implements SpliceFile on SambaInterfaceImpl
-Stubs out SpliceFile in FakeSambaInterface

BUG=chromium:757625
TEST=emerges
Change-Id: I9b015815b1b42ec830b953d39aa286063eef9dcd
Reviewed-on: https://chromium-review.googlesource.com/1117738
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/700bfa7d9c23b473f274a7c33c04abdeefcaa5e9/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/700bfa7d9c23b473f274a7c33c04abdeefcaa5e9/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/700bfa7d9c23b473f274a7c33c04abdeefcaa5e9/smbprovider/samba_interface.h
[modify] https://crrev.com/700bfa7d9c23b473f274a7c33c04abdeefcaa5e9/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/700bfa7d9c23b473f274a7c33c04abdeefcaa5e9/smbprovider/samba_interface_impl.h

Project Member

Comment 338 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/3826363d134935718a4be0a6996e8e77f589ca6c

commit 3826363d134935718a4be0a6996e8e77f589ca6c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 13 09:22:21 2018

system_api: Add StartCopy and ContinueCopy to SmbProvider constants

This change adds D-Bus method name constants for SmbProvider::StartCopy
and SmbProvider::ContinueCopy to SmbProvider D-Bus constants so that
they can be called from the Chrome process.

BUG=chromium:757625
TEST=emerges
Change-Id: I676cb92625ffa8535c81d1cf44e1f0d5ca239d82
Reviewed-on: https://chromium-review.googlesource.com/1130547
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/3826363d134935718a4be0a6996e8e77f589ca6c/dbus/smbprovider/dbus-constants.h

Project Member

Comment 339 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b97935010d90757a3c8df96ff9832ff77ab1f816

commit b97935010d90757a3c8df96ff9832ff77ab1f816
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 13 09:22:28 2018

smbprovider: Use new FD mapping on all calls

- Part of CL's to transition to using smbc_*_ctx functions
- Updates remaining functions to new API

BUG= chromium:857487 ,chromium:757625
TEST=emerges,unittests

Change-Id: I9491fa7e8227359b309a7aba7ab4fbdadd3063d3
Reviewed-on: https://chromium-review.googlesource.com/1120688
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/b97935010d90757a3c8df96ff9832ff77ab1f816/smbprovider/samba_interface_impl.cc

Project Member

Comment 340 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f6f92502a80e59096456dcaf506684d396326f65

commit f6f92502a80e59096456dcaf506684d396326f65
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 13 09:22:09 2018

smbprovider: Implement Splice on FakeSambaInterface

This change implements Splice on FakeSambaInterface and adds
corresponding tests.

BUG=chromium:757625
TEST=unittests
Change-Id: I6b1c93c7975f7ea9aedb9ab3ab08d59a9005a981
Reviewed-on: https://chromium-review.googlesource.com/1122836
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/f6f92502a80e59096456dcaf506684d396326f65/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/f6f92502a80e59096456dcaf506684d396326f65/smbprovider/fake_samba_test.cc

Project Member

Comment 341 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7ecbbade941862fa6d12591c55ff443f1d06a825

commit 7ecbbade941862fa6d12591c55ff443f1d06a825
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 13 09:22:10 2018

smbprovider: Create CopyProgressInterface

This change creates CopyProgressInterface.
- Used to keep track of an in-progress copy of a
file within an Smb Share.

BUG=chromium:757625
TEST=none.
Change-Id: Ieee932dd88c7ac6cd76b2fbd121600e5eee9bce9
Reviewed-on: https://chromium-review.googlesource.com/1122837
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/7ecbbade941862fa6d12591c55ff443f1d06a825/smbprovider/copy_progress_interface.h
[modify] https://crrev.com/7ecbbade941862fa6d12591c55ff443f1d06a825/smbprovider/smbprovider.gyp

Project Member

Comment 342 by bugdroid1@chromium.org, Jul 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fad479dff63cd2b9366740f94db453f2d9eb50e1

commit fad479dff63cd2b9366740f94db453f2d9eb50e1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Jul 14 00:28:47 2018

smbprovider: Create FileCopyProgress

This change Creates FileCopyProgress which implements the
CopyProgressInterface.
- Used to keep track of the prgoress of an individual file
copy.

BUG=chromium:757625
TEST=unittests
Change-Id: Ib7531853cac66035b04590a77824af91360ae497
Reviewed-on: https://chromium-review.googlesource.com/1122838
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/fad479dff63cd2b9366740f94db453f2d9eb50e1/smbprovider/file_copy_progress.cc
[add] https://crrev.com/fad479dff63cd2b9366740f94db453f2d9eb50e1/smbprovider/file_copy_progress.h
[add] https://crrev.com/fad479dff63cd2b9366740f94db453f2d9eb50e1/smbprovider/file_copy_progress_test.cc
[modify] https://crrev.com/fad479dff63cd2b9366740f94db453f2d9eb50e1/smbprovider/smbprovider.gyp

Project Member

Comment 344 by bugdroid1@chromium.org, Jul 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cc45ab0b18d8e65d0b053631203f58b3f4c7d276

commit cc45ab0b18d8e65d0b053631203f58b3f4c7d276
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Jul 14 00:28:48 2018

smbprovider: Add StartCopy and ContinueCopy method stubs

This change creates StartCopy and ContinueCopy method
stubs on the SmbProvider Interface.

BUG=chromium:757625
TEST=emerges
Change-Id: I853edfef8c39dcbad7e0b7d04e756caac780ee80
Reviewed-on: https://chromium-review.googlesource.com/1130536
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/cc45ab0b18d8e65d0b053631203f58b3f4c7d276/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/cc45ab0b18d8e65d0b053631203f58b3f4c7d276/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/cc45ab0b18d8e65d0b053631203f58b3f4c7d276/smbprovider/smbprovider.h
[modify] https://crrev.com/cc45ab0b18d8e65d0b053631203f58b3f4c7d276/smbprovider/smbprovider.cc

Project Member

Comment 345 by bugdroid1@chromium.org, Jul 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36163c326e3545e1810d64ab611e7a0ca1f1b53

commit b36163c326e3545e1810d64ab611e7a0ca1f1b53
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Jul 14 23:01:48 2018

Add StartCopy and ContinueCopy to SmbProviderClient

This change adds StartCopy and ContinueCopy on SmbProviderClient so that
SmbFileSystem can call these methods on the SmbProvider daemon over
D-Bus. These methods enable chunking units of work of a copy operation
since the SmbProvider daemon is single threaded and we do not want to block
it during long running copies.

Bug: 757625
Change-Id: I3de4df31907c29d872820d13ff5004f82160d663
Reviewed-on: https://chromium-review.googlesource.com/1130821
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575164}
[modify] https://crrev.com/b36163c326e3545e1810d64ab611e7a0ca1f1b53/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/b36163c326e3545e1810d64ab611e7a0ca1f1b53/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/b36163c326e3545e1810d64ab611e7a0ca1f1b53/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/b36163c326e3545e1810d64ab611e7a0ca1f1b53/chromeos/dbus/smb_provider_client.h

Project Member

Comment 346 by bugdroid1@chromium.org, Jul 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/88ba7cde3c43907bd1213a38bea152cdb3234139

commit 88ba7cde3c43907bd1213a38bea152cdb3234139
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sun Jul 15 01:11:38 2018

smbprovider: Implement StartCopy and ContinueCopy

This change implements StartCopy and ContinueCopy on
SmbProvider, allowing callers to iterate through a
copy manually.

BUG=chromium:757625
TEST=unittests
Change-Id: If30b28978c3ef9443f793cd2d962edf7caeba36a
Reviewed-on: https://chromium-review.googlesource.com/1130537
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/88ba7cde3c43907bd1213a38bea152cdb3234139/smbprovider/smbprovider.cc
[modify] https://crrev.com/88ba7cde3c43907bd1213a38bea152cdb3234139/smbprovider/smbprovider.h
[modify] https://crrev.com/88ba7cde3c43907bd1213a38bea152cdb3234139/smbprovider/smbprovider_test.cc

Project Member

Comment 347 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bb62cadf8a845f8319c05385ac58e9404ce95bc

commit 2bb62cadf8a845f8319c05385ac58e9404ce95bc
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 16 14:44:16 2018

Add NetBiosHostLocator to SmbService for discovery

- Registers a NetBiosHostLocator with SmbService's share_locator_
so that shares can be discovered via NetBios

BUG=chromium:757625

Change-Id: If2e88d543ab90c3e0e79050ec41ed8d0f38220eb
Reviewed-on: https://chromium-review.googlesource.com/1136800
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575255}
[modify] https://crrev.com/2bb62cadf8a845f8319c05385ac58e9404ce95bc/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/2bb62cadf8a845f8319c05385ac58e9404ce95bc/chrome/browser/chromeos/smb_client/smb_service.h

Project Member

Comment 348 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e011de2bd6227ae369f61188c93929c3c01db63

commit 8e011de2bd6227ae369f61188c93929c3c01db63
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 16 15:25:54 2018

Implement StartCopy and ContinueCopy on SmbFileSystem

This change implements StartCopy and ContinueCopy on SmbFileSystems.
StartCopy will be called by CopyEntry to begin a copy operation. When
the StartCopy handler callback is run, if there is more work to do the
ContinueCopy method is called.

Bug: chromium:757625
Change-Id: I9a8640e6e6b5cd089d65d3d7b668159676121250
Reviewed-on: https://chromium-review.googlesource.com/1132462
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575275}
[modify] https://crrev.com/8e011de2bd6227ae369f61188c93929c3c01db63/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/8e011de2bd6227ae369f61188c93929c3c01db63/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 349 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72c10a4a4b9b2c7564e73a641399acd628f6ad22

commit 72c10a4a4b9b2c7564e73a641399acd628f6ad22
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 16 15:56:40 2018

Switch SmbFileSystem to use splittable copy methods.

This change transitions SmbFileSystem to using the StartCopy and
ContinueCopy methods so that CopyEntry operations no longer block users
from navigating around during a copy.

Bug: 757625
Change-Id: I9a63e0198b6e529e935fab5f70e8aa95235d2b82
Reviewed-on: https://chromium-review.googlesource.com/1132465
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575284}
[modify] https://crrev.com/72c10a4a4b9b2c7564e73a641399acd628f6ad22/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 350 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4121d448f2e31f0d2a00c2e4cc8d045942a862d1

commit 4121d448f2e31f0d2a00c2e4cc8d045942a862d1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Jul 16 23:25:51 2018

Remove race condition in Smb Share discovery

Stores a mount call if host discovery is not yet complete and runs it as
soon as the first share names start coming back, indicating that host
discovery is complete.

The mount can be attempted before share discovery is complete because
mounting via a hostname is only dependent on host discovery for name
resolution.

Bug: 757625,  863178 
Change-Id: If53ec9061c79a4f408278be4ddd990a7c9ca3791
Reviewed-on: https://chromium-review.googlesource.com/1136528
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575477}
[modify] https://crrev.com/4121d448f2e31f0d2a00c2e4cc8d045942a862d1/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
[modify] https://crrev.com/4121d448f2e31f0d2a00c2e4cc8d045942a862d1/chrome/browser/ui/webui/settings/chromeos/smb_handler.h

Labels: M-70
Project Member

Comment 352 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0564a5eed2fa1ea436fbfaee10fdfacec8aef057

commit 0564a5eed2fa1ea436fbfaee10fdfacec8aef057
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jul 17 20:18:52 2018

Fix SMB remount on reboot with hostname

This change fixes a bug where shares mounted with a hostname rather than
an ip address are not remounted when a user logs out and back in.

Previously, we were storing the unresolved share_path rather than the
resolved share path that is used to mount the share.

Bug: 863513, 757625
Change-Id: I183200d9193c439f46a1609074706c5b2e2c0355
Reviewed-on: https://chromium-review.googlesource.com/1136863
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575753}
[modify] https://crrev.com/0564a5eed2fa1ea436fbfaee10fdfacec8aef057/chrome/browser/chromeos/smb_client/smb_service.cc

Project Member

Comment 353 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5da09bb0b63d0389951d44db420462ab9b98289d

commit 5da09bb0b63d0389951d44db420462ab9b98289d
Author: jimmy <jimmyxgong@google.com>
Date: Fri Jul 20 12:31:24 2018

smbprovider: rename kBufferSize to be more descriptive in smbprovider

Renamed kBufferSize to kDirEntBufferSize to be more
descriptive in smbprovider: constants.h, smbprovider_helper_test.cc,
and /iterator/directory_iterator.cc

BUG=chromium:757625
TEST=emerges

Change-Id: Ib500a844a9ba67b6d16fa97f47b13e282f37fde3
Reviewed-on: https://chromium-review.googlesource.com/1144441
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/5da09bb0b63d0389951d44db420462ab9b98289d/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/5da09bb0b63d0389951d44db420462ab9b98289d/smbprovider/smbprovider_helper_test.cc
[modify] https://crrev.com/5da09bb0b63d0389951d44db420462ab9b98289d/smbprovider/constants.h

Project Member

Comment 354 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7421161bc54c88c9e90513ba4861f1f7fab64d67

commit 7421161bc54c88c9e90513ba4861f1f7fab64d67
Author: jimmy <jimmyxgong@chromium.org>
Date: Fri Jul 20 22:26:39 2018

Capitalize SMB in comments in smb_file_system.h

Correctly capitalize smb->SMB in smb_file_system.h comments.

Bug: chromium:757625
Change-Id: I8d708c2ef8a29bc9f752fe50177b0a726191b974
Reviewed-on: https://chromium-review.googlesource.com/1144130
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577014}
[modify] https://crrev.com/7421161bc54c88c9e90513ba4861f1f7fab64d67/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 355 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/735b928c8dd94975af375d22228edb2bf94c88f6

commit 735b928c8dd94975af375d22228edb2bf94c88f6
Author: Jimmy <jimmyxgong@google.com>
Date: Sat Jul 21 01:34:06 2018

smbprovider: fix ParseNetBiosPacket error checking

This change corrects the error checking of SerializeProtoToBlob in
smbprovider::ParseNetBiosPacket

BUG=chromium:757625
TEST=emerges

Change-Id: Ida7d3e6a48ca71620395823847c22ff7462c6bf2
Reviewed-on: https://chromium-review.googlesource.com/1144049
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/735b928c8dd94975af375d22228edb2bf94c88f6/smbprovider/smbprovider.cc

Project Member

Comment 356 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6

commit 380a0ef6fcb6d2d8b4485d7aef110e107544fcf6
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Jul 26 16:19:43 2018

net-fs/samba: Backport readdir plus optimization.

Backports an optimization that returns a combined read directory
with stat to return all metadata at once without have to do
roundtrips for each files.

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I0fef31b6a433c12cbc4ed513d4a96aa10fde4128
Reviewed-on: https://chromium-review.googlesource.com/1147303
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/samba-4.8.0.ebuild
[add] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/files/samba-4.8.0-readdirplus_3_add_dirplus.patch
[add] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/files/samba-4.8.0-readdirplus_4_update_abi.patch
[add] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/files/samba-4.8.0-readdirplus_2_data_structures.patch
[add] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/files/samba-4.8.0-readdirplus_1_btime.patch
[add] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/files/samba-4.8.0-readdirplus_5_cleanup_close.patch
[rename] https://crrev.com/380a0ef6fcb6d2d8b4485d7aef110e107544fcf6/net-fs/samba/samba-4.8.0-r7.ebuild

Project Member

Comment 357 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0fa814875328e4f8b33717dc246f491aadf08a1d

commit 0fa814875328e4f8b33717dc246f491aadf08a1d
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 06:59:43 2018

smbprovider: Add stubs for readdirplus

- Add GetDirectoryEntryWithMetadata to SambaInterface
- Add stub to the impl and fake

CQ-DEPEND=CL:1147303
BUG= chromium:844476 ,chromium:757625
TEST=emerges and unittests

Change-Id: I3a4eb42bf30da4bc033c8f67f8038bbe9c4a575c
Reviewed-on: https://chromium-review.googlesource.com/1104991
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0fa814875328e4f8b33717dc246f491aadf08a1d/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/0fa814875328e4f8b33717dc246f491aadf08a1d/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/0fa814875328e4f8b33717dc246f491aadf08a1d/smbprovider/samba_interface.h
[modify] https://crrev.com/0fa814875328e4f8b33717dc246f491aadf08a1d/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/0fa814875328e4f8b33717dc246f491aadf08a1d/smbprovider/samba_interface_impl.h

Project Member

Comment 358 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8fc1dd86b38d256a7589671cb09e1ae2430112de

commit 8fc1dd86b38d256a7589671cb09e1ae2430112de
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 06:59:43 2018

smbprovider: Add fake implementation of readdirplus

- Add fake implementation and tests

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Iebf0256d76401524e102e4c7024afdbf199776e9
Reviewed-on: https://chromium-review.googlesource.com/1104992
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/constants.h
[modify] https://crrev.com/8fc1dd86b38d256a7589671cb09e1ae2430112de/smbprovider/fake_samba_test.cc

Project Member

Comment 359 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/375ecd1ac23eeeeb5ce99ffb69918c466fd564b1

commit 375ecd1ac23eeeeb5ce99ffb69918c466fd564b1
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 06:59:44 2018

smbprovider: Add implementation of readdirplus

- Code is not called yet.
- Follow up CL's integrate to SmbProvider

BUG= chromium:844476 ,chromium:757625
TEST=emerges and unittests

Change-Id: I943fd84b03788539b582762e807003e0cdfcbf02
Reviewed-on: https://chromium-review.googlesource.com/1104993
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/375ecd1ac23eeeeb5ce99ffb69918c466fd564b1/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/375ecd1ac23eeeeb5ce99ffb69918c466fd564b1/smbprovider/samba_interface_impl.cc

Project Member

Comment 360 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/32cabe73b153e2b40a7a9fcc71db3efe14177e7c

commit 32cabe73b153e2b40a7a9fcc71db3efe14177e7c
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 15:50:54 2018

smbprovider: Add plumbing to iterators to support metadata

- Adds additional argument to BaseDirectoryIterator to specify
  whether the iterator should populate metadata while reading
  the directory.
- Makes no change to existing functionality in this CL.
- The new method to populate the metadata is implemented in a
  follow up CL.

BUG= chromium:844476 ,chromium:757625
TEST=emerges and unittest

Change-Id: I1658adf0fd3ede4366dcb5de8572cd737e46e489
Reviewed-on: https://chromium-review.googlesource.com/1104994
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/32cabe73b153e2b40a7a9fcc71db3efe14177e7c/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/32cabe73b153e2b40a7a9fcc71db3efe14177e7c/smbprovider/iterator/directory_iterator.h

Project Member

Comment 361 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/033a847e3bb706164a0e02e4107cf60a5a698ec8

commit 033a847e3bb706164a0e02e4107cf60a5a698ec8
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 15:50:55 2018

smbprovider: Factor out a ClearVector() method

- Adds a helper method to clear the vector and reset the index
- Follow up CL will use this in an additional place

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Id4e96c0354d173a02a6a5b33438b8badea598582
Reviewed-on: https://chromium-review.googlesource.com/1104995
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/033a847e3bb706164a0e02e4107cf60a5a698ec8/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/033a847e3bb706164a0e02e4107cf60a5a698ec8/smbprovider/iterator/directory_iterator.h

Project Member

Comment 362 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5

commit 0abbfcca2be3ee0ac0719fef2785e25eb659e3a5
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 27 18:56:00 2018

Use cr-searchable-drop-down in Add Smb Share dialog

This change makes the share entry field in the Add SmbShare dialog
a cr-searchable-drop-down that is populated with shares discovered
on the network as they are found.

Test=verified locally

Bug: chromium:757625
Change-Id: I6fdd74bc2c6f1efaea190bfc3d93eef046de7334
Reviewed-on: https://chromium-review.googlesource.com/1152211
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578732}
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/resources/settings/downloads_page/BUILD.gn
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
[modify] https://crrev.com/0abbfcca2be3ee0ac0719fef2785e25eb659e3a5/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc

Project Member

Comment 363 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a94a2f9536463e19180ddb41ad003583a171fe44

commit a94a2f9536463e19180ddb41ad003583a171fe44
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jul 27 20:56:26 2018

Add NetworkFileSharesAllowed pref and policy

This change adds a NetworkFileSharesAllowed pref and policy to store
whether or not a user is allowed to use the Network File Shares
feature.

Bug: chromium:757625
Change-Id: Icaf2015a841c31328b8cb36d26c73b2fa09fbcb6
Reviewed-on: https://chromium-review.googlesource.com/1141301
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578771}
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service_factory.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/chromeos/smb_client/smb_service_factory.h
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/common/pref_names.cc
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/common/pref_names.h
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/components/policy/resources/policy_templates.json
[modify] https://crrev.com/a94a2f9536463e19180ddb41ad003583a171fe44/tools/metrics/histograms/enums.xml

Project Member

Comment 364 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42

commit 4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:33 2018

smbprovider: Implement iterator including metadata

- Adds implementation to call readdir plus to support an iterator
  that includes metadata.

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I3c1cd2f219ab5f0b42ea4d6f79ecddb4fa3496ba
Reviewed-on: https://chromium-review.googlesource.com/1104996
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42/smbprovider/iterator/directory_iterator_test.cc
[modify] https://crrev.com/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/4148c30933a300ccc91c8daf8ce1d3fc5c4d9b42/smbprovider/iterator/directory_iterator.h

Project Member

Comment 365 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0196479b97944850be6b1b027c2cd018b6d79922

commit 0196479b97944850be6b1b027c2cd018b6d79922
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:33 2018

smbprovider: Add skeleton of metadata cache.

- Adds do nothing cache class and test file
- Adds cache and test file to build
- Follow up CL implements the cache

BUG= chromium:844476 ,chromium:757625
TEST=emerges and unit tests

Change-Id: I05f0e2a19f51a184709f919f99b7b7e700c0b078
Reviewed-on: https://chromium-review.googlesource.com/1106770
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/metadata_cache.cc
[add] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/metadata_cache.h
[add] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/metadata_cache_test.cc
[modify] https://crrev.com/0196479b97944850be6b1b027c2cd018b6d79922/smbprovider/smbprovider.gyp

Project Member

Comment 366 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4dd4469b76bae5009823921d7a523ec03d9f313a

commit 4dd4469b76bae5009823921d7a523ec03d9f313a
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:34 2018

smbprovider: Replace the mount_root with a MountInfo struct

- Changes the map in the mount manager to hold a struct instead
  of just a string.
- Currently the struct just contains the string mount_root field.
- Updates relevant references to the mount_root via mounts_
- Makes no change to behavior.
- Follow up CL will add the cache to the MountInfo struct.

BUG= chromium:844476 ,chromium:757625
TEST=emerges and unittests

Change-Id: Ib16706a3e90b683c17e8aa9a16fccb5ebce7eb34
Reviewed-on: https://chromium-review.googlesource.com/1106771
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4dd4469b76bae5009823921d7a523ec03d9f313a/smbprovider/mount_manager.cc
[modify] https://crrev.com/4dd4469b76bae5009823921d7a523ec03d9f313a/smbprovider/mount_manager.h

Project Member

Comment 367 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/de1ee63bb73b61e5905442a5d6a92af12fcbb44e

commit de1ee63bb73b61e5905442a5d6a92af12fcbb44e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:34 2018

smbprovider: Add a flag to SmbProvider to enable metadata cache

- Flag is currently not used

BUG=chromium:757625
TEST=emerges and unittests

Change-Id: I0cb5a616bc52eebafb55840ded5afcca6313f15a
Reviewed-on: https://chromium-review.googlesource.com/1106772
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider.cc
[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider.h
[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/de1ee63bb73b61e5905442a5d6a92af12fcbb44e/smbprovider/smbprovider_main.cc

Project Member

Comment 368 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c2a576f23929c3241188da00db220a0e9b36a840

commit c2a576f23929c3241188da00db220a0e9b36a840
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:35 2018

smbprovider: Support adding and finding entries from cache

- Adds AddEntry and FindEntry and tests
- Cache currently never invalidates or clears
- The cache code is not being used yet
- Follow up CL's wire up the cache and add purging and
  invalidation

BUG=chromium:757625
TEST=emerges and unittests

Change-Id: I11eab2e308a0be6541b71bbc70c41ba360adefd9
Reviewed-on: https://chromium-review.googlesource.com/1106773
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/c2a576f23929c3241188da00db220a0e9b36a840/smbprovider/metadata_cache.cc
[modify] https://crrev.com/c2a576f23929c3241188da00db220a0e9b36a840/smbprovider/metadata_cache.h
[modify] https://crrev.com/c2a576f23929c3241188da00db220a0e9b36a840/smbprovider/metadata_cache_test.cc

Project Member

Comment 369 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4b67f7a74545ec7869ececb35d913689bd750c51

commit 4b67f7a74545ec7869ececb35d913689bd750c51
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:37 2018

smbprovider: Wire up the metadata iterator

- The metadata iterator will now be used if caching is enabled
- The cache flag is currently off, so there is no behavior change
- Nothing currently consumes the additional metadata

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I70add04a16ace19ec3e8013398923ab802bad8ff
Reviewed-on: https://chromium-review.googlesource.com/1144613
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/smbprovider.cc
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/smbprovider.h
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/iterator/directory_iterator.h
[modify] https://crrev.com/4b67f7a74545ec7869ececb35d913689bd750c51/smbprovider/constants.h

Project Member

Comment 370 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/38ea0ba4104031e3386f8ba86c1e11cb40598cd1

commit 38ea0ba4104031e3386f8ba86c1e11cb40598cd1
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:37 2018

smbprovider: Add the cache to the MountManager

- Adds an instance of the cache for each mount in the mount
  manager.
- Nothing currently reads or writes from the cache.

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Id92d36c11d58684ea92823b56a5021d462237c91
Reviewed-on: https://chromium-review.googlesource.com/1144614
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/mount_manager.cc
[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/metadata_cache.h
[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/38ea0ba4104031e3386f8ba86c1e11cb40598cd1/smbprovider/mount_manager.h

Project Member

Comment 371 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3c1120159bee8430abea92f5f1605bcf1bbc08fe

commit 3c1120159bee8430abea92f5f1605bcf1bbc08fe
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:38 2018

smbprovider: Add code to check the cache on metadata requests

- Nothing populates the cache yet
- The flag is never turned on so this isn't run yet
- No change to existing behavior

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I4c329325ec7a45ffdca688afba28466e71a19c0d
Reviewed-on: https://chromium-review.googlesource.com/1144615
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/3c1120159bee8430abea92f5f1605bcf1bbc08fe/smbprovider/smbprovider.cc
[modify] https://crrev.com/3c1120159bee8430abea92f5f1605bcf1bbc08fe/smbprovider/smbprovider.h
[modify] https://crrev.com/3c1120159bee8430abea92f5f1605bcf1bbc08fe/smbprovider/smbprovider_test.cc

Project Member

Comment 372 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0781df5fffecf218a381480066a277fca7465fa4

commit 0781df5fffecf218a381480066a277fca7465fa4
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:38 2018

smbprovider: Implement a caching iterator

- Wraps an inner iterator and adds to the cache each time Get()
  is called

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I00aa5ed75f88cdd664b9455748f2f158ffbee055
Reviewed-on: https://chromium-review.googlesource.com/1144616
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/0781df5fffecf218a381480066a277fca7465fa4/smbprovider/iterator/caching_iterator.h
[modify] https://crrev.com/0781df5fffecf218a381480066a277fca7465fa4/smbprovider/smbprovider.gyp
[add] https://crrev.com/0781df5fffecf218a381480066a277fca7465fa4/smbprovider/iterator/caching_iterator_test.cc

Project Member

Comment 373 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9f221ba0bedef0a024f775901f1d7bd4b9728b8c

commit 9f221ba0bedef0a024f775901f1d7bd4b9728b8c
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:39 2018

smbprovider: Wire up CachingIterator in ReadDirectory

- When caching is enabled, ReadDirectory will use a caching
  iterator for DirectoryReads
- Caching is not used for reading shares.

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I8ed2d08354e08536d62c380b7ecfaaec8f741933
Reviewed-on: https://chromium-review.googlesource.com/1144617
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9f221ba0bedef0a024f775901f1d7bd4b9728b8c/smbprovider/smbprovider.cc
[modify] https://crrev.com/9f221ba0bedef0a024f775901f1d7bd4b9728b8c/smbprovider/smbprovider_test.cc

Project Member

Comment 374 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7fd728f2f97bd6f0c527a9754b3a19e8edc78045

commit 7fd728f2f97bd6f0c527a9754b3a19e8edc78045
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:39 2018

smbprovider: Add a TickClock to MountManager

- Adds a TickClock to MountManager to be used for the metadata cache
- Currently the clock is unused
- Future CL will use the clock when constructing MetadataCache
  so that it can be used to invalidate cache entries
- Makes no change to current behavior

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I7b6d6bb9d1b7050add5569ca8c0366a20a8344fd
Reviewed-on: https://chromium-review.googlesource.com/1144618
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/mount_manager.cc
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/mount_manager.h
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/7fd728f2f97bd6f0c527a9754b3a19e8edc78045/smbprovider/smbprovider_test.cc

Project Member

Comment 375 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921

commit dcfcf79752edb3624a4ee5c492cad5e6a6ec7921
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:40 2018

smbprovider: Adds TickClock to MetadataCache

- Construct the MetadataCache using the TickClock owned
  by MountManager
- Update test code
- Clock is currently not used
- Makes no change to current behavior

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Ibf245e518e6f240dd5f259b74d05346fd016b96a
Reviewed-on: https://chromium-review.googlesource.com/1144619
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/mount_manager.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/metadata_cache_test.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/iterator/caching_iterator_test.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/metadata_cache.cc
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/metadata_cache.h
[modify] https://crrev.com/dcfcf79752edb3624a4ee5c492cad5e6a6ec7921/smbprovider/mount_manager.h

Project Member

Comment 376 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ecaf8e55bd2f641e18eb555879b344a2a4dc97ba

commit ecaf8e55bd2f641e18eb555879b344a2a4dc97ba
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:41 2018

smbprovider: Rename a genericly named variable

- kBufferSize gave an ambiguous name resolution
- Limit the scope of the variable and give it a better name

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Ie696151624d1bb34057e9dc945f1823b6d146547
Reviewed-on: https://chromium-review.googlesource.com/1144620
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/ecaf8e55bd2f641e18eb555879b344a2a4dc97ba/smbprovider/mount_manager_test.cc

Project Member

Comment 377 by bugdroid1@chromium.org, Jul 27

Project Member

Comment 378 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/48f019d46479516677f5c80e467e1f7203f2eba7

commit 48f019d46479516677f5c80e467e1f7203f2eba7
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:42 2018

smbprovider: Support removing items from the metadata cache

- Adds method to remove an item from the cache by path
- Adds tests for removing item
- Does not change current behavior

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Ia2cc6c45e28351694f5d0beef092587002677410
Reviewed-on: https://chromium-review.googlesource.com/1144622
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/48f019d46479516677f5c80e467e1f7203f2eba7/smbprovider/metadata_cache.cc
[modify] https://crrev.com/48f019d46479516677f5c80e467e1f7203f2eba7/smbprovider/metadata_cache.h
[modify] https://crrev.com/48f019d46479516677f5c80e467e1f7203f2eba7/smbprovider/metadata_cache_test.cc

Project Member

Comment 379 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ff17c09d21a914380be0a7c9103ee838d04b2a9e

commit ff17c09d21a914380be0a7c9103ee838d04b2a9e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:42 2018

smbprovider: Add an IsExpired method to MetadatCache

- Add private method to test if a cache entry has expired

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: If328b84b37298d20a5a1a3ba8731aa9d82148ab0
Reviewed-on: https://chromium-review.googlesource.com/1144623
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/ff17c09d21a914380be0a7c9103ee838d04b2a9e/smbprovider/metadata_cache.cc
[modify] https://crrev.com/ff17c09d21a914380be0a7c9103ee838d04b2a9e/smbprovider/metadata_cache.h

Project Member

Comment 380 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9989a19c531171a5ac2f9f4098b59d6e61f4f482

commit 9989a19c531171a5ac2f9f4098b59d6e61f4f482
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:43 2018

smbprovider: FindEntry in cache respects expiration

- If an entry is expired don't return it and delete it

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: Ie126f51f3309c4c04fe9bfbcbe2e0e5e81b2b658
Reviewed-on: https://chromium-review.googlesource.com/1144624
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9989a19c531171a5ac2f9f4098b59d6e61f4f482/smbprovider/metadata_cache.cc
[modify] https://crrev.com/9989a19c531171a5ac2f9f4098b59d6e61f4f482/smbprovider/metadata_cache.h
[modify] https://crrev.com/9989a19c531171a5ac2f9f4098b59d6e61f4f482/smbprovider/metadata_cache_test.cc

Project Member

Comment 381 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bc4715434d4b9db305c784016983824202f9ce75

commit bc4715434d4b9db305c784016983824202f9ce75
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:43 2018

smbprovider: Support purging the entire cache by time

- Add a method to iterate the cache and remove items that are
  expired
- Makes no change to current behavior

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I18b2472069420c955a31a0107b0ee9aa16e1e04e
Reviewed-on: https://chromium-review.googlesource.com/1144625
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/bc4715434d4b9db305c784016983824202f9ce75/smbprovider/metadata_cache.cc
[modify] https://crrev.com/bc4715434d4b9db305c784016983824202f9ce75/smbprovider/metadata_cache.h
[modify] https://crrev.com/bc4715434d4b9db305c784016983824202f9ce75/smbprovider/metadata_cache_test.cc

Project Member

Comment 382 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/566801eb4d612aa4dfa94dbef020dc03368abfd6

commit 566801eb4d612aa4dfa94dbef020dc03368abfd6
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:44 2018

smbprovider: Purge the cache before each read directory

- Purges the cache of expired entries before each new directory
  is read
- This is the most simplistic strategy to keep the cache
  from growing uncontrollably
- Future CL's may further optimize this to use other information
  to decide whether to actually purge

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I7a986bf41d97cf20551397cfd34210fa6b64ed04
Reviewed-on: https://chromium-review.googlesource.com/1145554
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/566801eb4d612aa4dfa94dbef020dc03368abfd6/smbprovider/smbprovider.cc
[modify] https://crrev.com/566801eb4d612aa4dfa94dbef020dc03368abfd6/smbprovider/smbprovider_test.cc

Project Member

Comment 383 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/91be32d59fc705aa9d6892dcb57992ff84e961a2

commit 91be32d59fc705aa9d6892dcb57992ff84e961a2
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:44 2018

smbprovider: Enable the metadata cache

- Just turns on the caching flag to enable the optimization
- See previous CL's for full implementation
- Now all explicit ReadDirectories use readdirplus which reads
  directory entries with all the stat() metadata from one call
- The iterator caches the entries as they are iterated over
- GetMetadata calls check the cache before making a network call
- Cache just has a simple expiration time of 30 sec
- Cache is purged of all expired entries each time a new directory
  is read
- Future optimizations may make the purging smarter
- Implicit readDirectorys such as finding shares, or traversals
  to perform recursive copies or deletes do not use readdirplus
  or cache as they iterate

BUG= chromium:844476 ,chromium:757625
TEST=emerges

Change-Id: I07f0b37865a5ebb1a0f879f2b899aa73f7aa7f71
Reviewed-on: https://chromium-review.googlesource.com/1145555
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/91be32d59fc705aa9d6892dcb57992ff84e961a2/smbprovider/smbprovider_main.cc

Project Member

Comment 384 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a917d920050ae82b2be8f188a502983c550a6d07

commit a917d920050ae82b2be8f188a502983c550a6d07
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:35 2018

smbprovider: Support clearing and testing cache is empty

- Adds ClearAll() to remove all cache entries
- Adds IsEmpty() to test if the cache is empty

BUG= chromium:844476 ,chromium:757625
TEST=emerges and unittests

Change-Id: I125110aa29e93f1cd37360695325618640734851
Reviewed-on: https://chromium-review.googlesource.com/1146761
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/a917d920050ae82b2be8f188a502983c550a6d07/smbprovider/metadata_cache.cc
[modify] https://crrev.com/a917d920050ae82b2be8f188a502983c550a6d07/smbprovider/metadata_cache.h
[modify] https://crrev.com/a917d920050ae82b2be8f188a502983c550a6d07/smbprovider/metadata_cache_test.cc

Project Member

Comment 385 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e5a6f33596d96c402d25a418b50e27c74dcc923a

commit e5a6f33596d96c402d25a418b50e27c74dcc923a
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Jul 27 22:28:36 2018

smbprovider: Add support for setting date on fake directories

- Needed for testing the new metadata versions of ReadDirectory
  populate the fields correctly.

BUG= chromium:844476 ,chromium:757625
TEST=emerges and unittests

Change-Id: If128b4bb726ccb87a8112e8b668150a571b79903
Reviewed-on: https://chromium-review.googlesource.com/1146762
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/e5a6f33596d96c402d25a418b50e27c74dcc923a/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/e5a6f33596d96c402d25a418b50e27c74dcc923a/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/e5a6f33596d96c402d25a418b50e27c74dcc923a/smbprovider/fake_samba_test.cc

Project Member

Comment 386 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/adb6a28fb3639543118d0caa4c0eeefec5daab91

commit adb6a28fb3639543118d0caa4c0eeefec5daab91
Author: jimmy <jimmyxgong@google.com>
Date: Tue Jul 31 23:37:29 2018

Add SanityTest to SmbProvider autotest

- Adds SanityTest. Future CLs will add functionality to SanityTest so
  that it eventually tests all possible operations on the SMB daemon.
- Add Mount and Unmount test through mounting->unmounting error checks.

BUG=chromium:757625
TEST=emerges

Change-Id: I6e0f844f4eaac8d3eb36a320dc30e1fb28481818
Reviewed-on: https://chromium-review.googlesource.com/1149278
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/adb6a28fb3639543118d0caa4c0eeefec5daab91/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 387 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9f73edbb57d8414b4930cf4e0556384a51ce59a3

commit 9f73edbb57d8414b4930cf4e0556384a51ce59a3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Aug 03 08:31:23 2018

smbprovider: Use GetSambaInterface Method

This change is the first in a series that will introduce an instance
of SambaInterface for each mount, allowing per mount configurations and
improving the authentication flow.

Switches all methods in SmbProvider to calling SambaInterface via a
GetSambaInterface method, removing the dependency on the
samba_interface_ memeber variable. A follow-up CL will transition the
GetSambaInterface method to returning a unique SambaInterface* for each
mount id.

BUG=chromium:757625
TEST=unittests
Change-Id: I34b0958178cc1af6225b785c5012b1d55ec98291
Reviewed-on: https://chromium-review.googlesource.com/1157512
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9f73edbb57d8414b4930cf4e0556384a51ce59a3/smbprovider/smbprovider.cc
[modify] https://crrev.com/9f73edbb57d8414b4930cf4e0556384a51ce59a3/smbprovider/smbprovider.h

Project Member

Comment 388 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/248ca334a23d56248916c06165bfc5b4ff39991c

commit 248ca334a23d56248916c06165bfc5b4ff39991c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Aug 03 13:29:16 2018

smbprovider: Introduce FakeSambaProxy

This change introdcues FakeSambaProxy. FakeSambaProxy is a proxy
class that has zero logic and passes through all calls to an underlying
FakeSamabaInterface. FakeSambaProxy is needed for testing in order to
return unique_ptrs to SambaInterfaces that are all backed by the same
fake underneath.

BUG=chromium:757625
TEST=unittest
Change-Id: I5dca0745ae9529fd05d91aa9d19490a2e3085626
Reviewed-on: https://chromium-review.googlesource.com/1159081
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/248ca334a23d56248916c06165bfc5b4ff39991c/smbprovider/fake_samba_proxy.cc
[add] https://crrev.com/248ca334a23d56248916c06165bfc5b4ff39991c/smbprovider/fake_samba_proxy.h
[modify] https://crrev.com/248ca334a23d56248916c06165bfc5b4ff39991c/smbprovider/smbprovider.gyp

Project Member

Comment 389 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2ac19614c3e77f8aef9ae85993790df83c5c0b13

commit 2ac19614c3e77f8aef9ae85993790df83c5c0b13
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Aug 04 05:14:47 2018

smbprovider: use SambaInterface per mount

This change completes the switch from using one SambaInterface to having
one SambaInterface per mount.

- Calls to GetShares, used for discovering shares on a host, uses a
system SambaInterface maintained by the MountManager.
- All other calls use a SambaInterface mapped to the mount_id

BUG=chromium:757625
TEST=unittests
Change-Id: I3659086af6e230d413c0de6617c9a22885ee72e4
Reviewed-on: https://chromium-review.googlesource.com/1157690
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/mount_manager.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider.h
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/proto.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/constants.h
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/mount_manager.h
[modify] https://crrev.com/2ac19614c3e77f8aef9ae85993790df83c5c0b13/smbprovider/smbprovider_test.cc

Project Member

Comment 390 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0fc2a8524f4cb0660398cceb49e4d06fd0fe7d93

commit 0fc2a8524f4cb0660398cceb49e4d06fd0fe7d93
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 08:59:46 2018

smbprovider: Change map to unordered_map

- Lookup is faster and we never need ordered access

BUG=chromium:757625
TEST=unittests

Change-Id: I7b4aae136873de59da8f0db216f2f1903ff2f49f
Reviewed-on: https://chromium-review.googlesource.com/1157175
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0fc2a8524f4cb0660398cceb49e4d06fd0fe7d93/smbprovider/metadata_cache.h

Project Member

Comment 391 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7f089bb0bdc67faab9cb059b663624b0455ff704

commit 7f089bb0bdc67faab9cb059b663624b0455ff704
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Aug 04 08:59:47 2018

smbprovider: Remove unnecessary pass by value

This change switches the LogAndSetError method to pass the Proto
argument by const ref instead of by value to eliminate an unnecessary
copy.

BUG=chromium:757625
TEST=unittests
Change-Id: I6a54149c178fd37a05b02429ded663d20bb4e921
Reviewed-on: https://chromium-review.googlesource.com/1161286
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/7f089bb0bdc67faab9cb059b663624b0455ff704/smbprovider/smbprovider_helper.h

Project Member

Comment 392 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/49e77b2fc4e8c01d7fbf7067ae7975da2458af18

commit 49e77b2fc4e8c01d7fbf7067ae7975da2458af18
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:50 2018

smbprovider: Optimize the case where the entire cache is expired

- Keep track of the max expiration time
- If the current time if higher than the max then just clear the
  map and don't bother iterating.

BUG=chromium:757625
TEST=unittests

Change-Id: Ibd4d80c6f6eec3e9e687b32d2b8be95c2a225c6e
Reviewed-on: https://chromium-review.googlesource.com/1157176
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/49e77b2fc4e8c01d7fbf7067ae7975da2458af18/smbprovider/metadata_cache.cc
[modify] https://crrev.com/49e77b2fc4e8c01d7fbf7067ae7975da2458af18/smbprovider/metadata_cache.h

Project Member

Comment 393 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1c94351e72213412552fbe7a0bdac1ea022dbd98

commit 1c94351e72213412552fbe7a0bdac1ea022dbd98
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:50 2018

smbprovider: Rename SequentialIdMap to IdMap

- Only a rename with no logic change
- It's not necessary for the IDs to be sequential, just unique
  at any point in time.
- Follow up CL will change the behavior to allow re-use and remove
  possibility of overflow.

BUG=chromium:757625
TEST=unittests

Change-Id: Iceb304365d01a5f3dd5800813c96d4c2f475033d
Reviewed-on: https://chromium-review.googlesource.com/1158791
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/samba_interface_impl.h
[modify] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/smbprovider.gyp
[rename] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/id_map.h
[rename] https://crrev.com/1c94351e72213412552fbe7a0bdac1ea022dbd98/smbprovider/id_map_test.cc

Project Member

Comment 394 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/64407ce6fb0a4b911eb6563078e836c80725faa9

commit 64407ce6fb0a4b911eb6563078e836c80725faa9
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:49 2018

smbprovider: Improve the method comment for FindEntry

BUG=chromium:757625
TEST=unittests

Change-Id: I2377a7f791539a498418b22d1528b1ae1037a640
Reviewed-on: https://chromium-review.googlesource.com/1159083
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/64407ce6fb0a4b911eb6563078e836c80725faa9/smbprovider/metadata_cache.h

Project Member

Comment 395 by bugdroid1@chromium.org, Aug 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b6daa00d532c2262ad440c7f9da11b9e00fdbee7

commit b6daa00d532c2262ad440c7f9da11b9e00fdbee7
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Aug 04 22:47:49 2018

smbprovider: IsExpired method can be const

BUG=chromium:757625
TEST=unittests

Change-Id: I1f944f39ea039fe51975357dc06b57b59b860239
Reviewed-on: https://chromium-review.googlesource.com/1159084
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/b6daa00d532c2262ad440c7f9da11b9e00fdbee7/smbprovider/metadata_cache.cc
[modify] https://crrev.com/b6daa00d532c2262ad440c7f9da11b9e00fdbee7/smbprovider/metadata_cache.h

Project Member

Comment 396 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bb14de6063d6af9117ac35f6876d88ac935195a8

commit bb14de6063d6af9117ac35f6876d88ac935195a8
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Aug 07 08:50:42 2018

smbprovider: Remove assumptions that id are sequential

- Cleans up the tests to not make assumptions about how the
  ids get given out

BUG=chromium:757625
TEST=unittests

Change-Id: Ib46dd00a9e6c9933278ca2c7f307b1036e023171
Reviewed-on: https://chromium-review.googlesource.com/1162866
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/bb14de6063d6af9117ac35f6876d88ac935195a8/smbprovider/id_map_test.cc

Project Member

Comment 397 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/467241ee35f8eeafe9eeb5a094acf6e51fc2c78b

commit 467241ee35f8eeafe9eeb5a094acf6e51fc2c78b
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Aug 07 08:50:43 2018

smbprovider: Add a MapType typedef to the IdMap

- No logic change

BUG=chromium:757625
TEST=unittests

Change-Id: I3fe63e3a45d7a29de4872cae3650fc677ab2a2e5
Reviewed-on: https://chromium-review.googlesource.com/1162867
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/467241ee35f8eeafe9eeb5a094acf6e51fc2c78b/smbprovider/id_map.h

Project Member

Comment 398 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/10811ef6a25ed6640fa0ecf475173de092451b9f

commit 10811ef6a25ed6640fa0ecf475173de092451b9f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:45 2018

smbprovider: Use unordered_map in IdMap

BUG=chromium:757625
TEST=unittests

Change-Id: I3523d4a9364462c999de17e11b62c088436fced3
Reviewed-on: https://chromium-review.googlesource.com/1162868
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/10811ef6a25ed6640fa0ecf475173de092451b9f/smbprovider/id_map.h

Project Member

Comment 399 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f24bd321e537aa71653fd74c42fa1a8e4a21a173

commit f24bd321e537aa71653fd74c42fa1a8e4a21a173
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:45 2018

smbprovider: Add a helper method for getting the next id.

- No behavior change
- Follow up CL will change the way ids are assigned

BUG=chromium:757625
TEST=unittests

Change-Id: I73afe599e7a0a563ce8e061a0a64a57aedbd84be
Reviewed-on: https://chromium-review.googlesource.com/1162869
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/f24bd321e537aa71653fd74c42fa1a8e4a21a173/smbprovider/id_map.h

Project Member

Comment 400 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fff74e6604d04e9cc3dadf3d59e324bd06aea131

commit fff74e6604d04e9cc3dadf3d59e324bd06aea131
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:46 2018

smbprovider: Update the IdMap to reuse ids

BUG=chromium:757625
TEST=unittests

Change-Id: I05a283dd3c787ff0012423e34ae12a62336e83e0
Reviewed-on: https://chromium-review.googlesource.com/1162870
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/fff74e6604d04e9cc3dadf3d59e324bd06aea131/smbprovider/id_map.h
[modify] https://crrev.com/fff74e6604d04e9cc3dadf3d59e324bd06aea131/smbprovider/id_map_test.cc

Project Member

Comment 401 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c44f6581f56626de95407445126b7c3a539ac9e3

commit c44f6581f56626de95407445126b7c3a539ac9e3
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:46 2018

smbprovider: Add support for insertion with specific id to IdMap

- This is used for the remounting case to rebuild our mapping to
  be in sync with Chrome

BUG=chromium:757625
TEST=unittests

Change-Id: Ie09e80e834aa008b74c76f89ccccede26efeca38
Reviewed-on: https://chromium-review.googlesource.com/1162871
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/c44f6581f56626de95407445126b7c3a539ac9e3/smbprovider/id_map.h
[modify] https://crrev.com/c44f6581f56626de95407445126b7c3a539ac9e3/smbprovider/id_map_test.cc

Project Member

Comment 402 by bugdroid1@chromium.org, Aug 8 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b4efae3196141cc28bfbfda503acd1a240f51dfd

commit b4efae3196141cc28bfbfda503acd1a240f51dfd
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 17:24:52 2018

smbprovider: Use IdMap for MountManager

- Re-uses IdMap for handing out mount_ids
- Remove test that tested for not-reusing IDs

BUG=chromium:757625
TEST=unittests

Change-Id: Ia55cd800bb086a0e53955409404bfeb9951d9cbe
Reviewed-on: https://chromium-review.googlesource.com/1162872
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/mount_manager.cc
[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/mount_manager.h
[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/b4efae3196141cc28bfbfda503acd1a240f51dfd/smbprovider/id_map.h

Project Member

Comment 403 by bugdroid1@chromium.org, Aug 8 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ef68de91596cf74af277cab8886c9ad28902b421

commit ef68de91596cf74af277cab8886c9ad28902b421
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 17:24:52 2018

smbprovider: Use emplace instead of insert in IdMap

BUG=chromium:757625
TEST=unittests

Change-Id: If1a795d3d3b24fb936f3130aa0506031ec4c9d33
Reviewed-on: https://chromium-review.googlesource.com/1165501
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/ef68de91596cf74af277cab8886c9ad28902b421/smbprovider/id_map.h

Project Member

Comment 404 by bugdroid1@chromium.org, Aug 9 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649

commit e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649
Author: jimmy <jimmyxgong@google.com>
Date: Thu Aug 09 03:46:05 2018

Add CreateDirectory to SmbProvider autotest

- Implements CreateDirectory in smbprovider.py.
- Adds GenerateRandomID for directory/file naming purposes.
- Adds CreateDirectory test to sanity test for SmbProvder autotests.

BUG=chromium:757625
TEST=emerges

Change-Id: I68a9584fdacd348a17da0033c35e99b062b38c84
Reviewed-on: https://chromium-review.googlesource.com/1150458
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
[modify] https://crrev.com/e83b6fb5a5f5bd3de26a0f1b4b4f87be9ae1c649/client/common_lib/cros/smbprovider.py

Project Member

Comment 405 by bugdroid1@chromium.org, Aug 9 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8480fa1327818cafc8fc377b4bcbac9e31e5a31e

commit 8480fa1327818cafc8fc377b4bcbac9e31e5a31e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Aug 09 03:46:18 2018

smbprovider: Reuse IdMap for copy tracking

- Previously had duplicated logic for maintaining an ID mapping

BUG=chromium:757625
TEST=unittests

Change-Id: I34d3eeb66ff4b913d339662f652eeb6c8b3c230e
Reviewed-on: https://chromium-review.googlesource.com/1165582
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/8480fa1327818cafc8fc377b4bcbac9e31e5a31e/smbprovider/smbprovider.cc
[modify] https://crrev.com/8480fa1327818cafc8fc377b4bcbac9e31e5a31e/smbprovider/smbprovider.h

Project Member

Comment 406 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0f8b78f0afd9a7e6ec736d989f55ba9d02b4e76e

commit 0f8b78f0afd9a7e6ec736d989f55ba9d02b4e76e
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:07 2018

Add DeleteEntry to SmbProvider autotest

Adds DeleteEntry check to the autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: I99a5da72cac518655f1684d315b27aec94ea7c29
Reviewed-on: https://chromium-review.googlesource.com/1152165
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0f8b78f0afd9a7e6ec736d989f55ba9d02b4e76e/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 407 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c8261ef936c526b68dbcb4a35f67a99842db69ca

commit c8261ef936c526b68dbcb4a35f67a99842db69ca
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:07 2018

Add CreateFile to SmbProvider autotest

Adds CreateFile test to sanity test for SmbProvider autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: I5eb392f2818544b93c686d0476ba5dc749bd1cce
Reviewed-on: https://chromium-review.googlesource.com/1152448
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/c8261ef936c526b68dbcb4a35f67a99842db69ca/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 408 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9ca61906a1ff1397c6a587c54a13ee3abf40fd7a

commit 9ca61906a1ff1397c6a587c54a13ee3abf40fd7a
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:08 2018

Add open/close file to SmbProvider autotest

Adds open file testing along with close file testing to the autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: Id5a52f3cd336dfe8f970baa092af23412f8f60ae
Reviewed-on: https://chromium-review.googlesource.com/1152518
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9ca61906a1ff1397c6a587c54a13ee3abf40fd7a/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 409 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b381c2d4b2aa6d8585010aa99d01136872766c9a

commit b381c2d4b2aa6d8585010aa99d01136872766c9a
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:08 2018

Add write file to SmbProvider autotest

Adds WriteFile check to the autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: Idfd9f875f0416444b6187d41ec0f48b10d52c7cf
Reviewed-on: https://chromium-review.googlesource.com/1152533
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b381c2d4b2aa6d8585010aa99d01136872766c9a/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 410 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ead96786b9dbf4493f0f960d55cdf6ff186ecdd7

commit ead96786b9dbf4493f0f960d55cdf6ff186ecdd7
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:10 2018

Add recursive create test to SmbProvder autotest

Adds recursive creation of directories in SmbProvider autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: I38378fc5e41b3cb4553480c22af7b2f89f09aeaa
Reviewed-on: https://chromium-review.googlesource.com/1153506
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ead96786b9dbf4493f0f960d55cdf6ff186ecdd7/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 411 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8e5a01768a0a5c7cf3a6f89a3c780d295ce8dd07

commit 8e5a01768a0a5c7cf3a6f89a3c780d295ce8dd07
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:10 2018

Add GetMetadata to SmbProvider autotest

Adds GetMetadata test to SmbProvider autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: I47f5ae07d80202f9d13265e5b6583bda12a2ff70
Reviewed-on: https://chromium-review.googlesource.com/1156047
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/8e5a01768a0a5c7cf3a6f89a3c780d295ce8dd07/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Project Member

Comment 412 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/74b4d995c649b83ff5d94e447437859af22fba2c

commit 74b4d995c649b83ff5d94e447437859af22fba2c
Author: jimmy <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:11 2018

Add MoveEntry to SmbProvider autotest

Adds MoveEntry test to SmbProvider autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: Iecabee3fc7ece801b25cd687e9145d0447a1e312
Reviewed-on: https://chromium-review.googlesource.com/1157425
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/74b4d995c649b83ff5d94e447437859af22fba2c/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py
[modify] https://crrev.com/74b4d995c649b83ff5d94e447437859af22fba2c/client/common_lib/cros/smbprovider.py

Project Member

Comment 413 by bugdroid1@chromium.org, Aug 10 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e662652f5e3ee29ff948417ddc632f6a3bbe9694

commit e662652f5e3ee29ff948417ddc632f6a3bbe9694
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Fri Aug 10 05:04:09 2018

Add ReadFile to SmbProvider autotest

Adds ReadFile test to SmbProvider autotest.

BUG=chromium:757625
TEST=emerges

Change-Id: If3d31a432d3ca013f21001bc489cf0bae88e42ce
Reviewed-on: https://chromium-review.googlesource.com/1166284
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e662652f5e3ee29ff948417ddc632f6a3bbe9694/client/site_tests/enterprise_SmbProviderDaemon/enterprise_SmbProviderDaemon.py

Showing comments 314 - 413 of 413 Older

Sign in to add a comment