New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add native SMB support to Chrome OS

Project Member Reported by allenvic@chromium.org, Aug 21 2017 Back to list

Issue description

Description:

Add smbclientd to act as a DBus daemon server

 
Owner: allenvic@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/5fc40ab72e45c14f5d98b3b2498224079b574ebb

commit 5fc40ab72e45c14f5d98b3b2498224079b574ebb
Author: Allen Vicencio <allenvic@google.com>
Date: Thu Nov 02 18:07:14 2017

system_api: Add smbprovider D-Bus-constants and protobufs

Add dbus-constants file and DirectoryEntry and DirectoryEntryList protobufs.

BUG=chromium:757625
TEST=Runs locally
Change-Id: I80335bc7a1f2f941905914acb9890a9f5304de81
Reviewed-on: https://chromium-review.googlesource.com/738937
Commit-Ready: Zentaro Kavanagh <zentaro@google.com>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/dbus/smbprovider/dbus-constants.h
[add] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/dbus/smbprovider/directory_entry.proto
[modify] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/dbus/service_constants.h
[modify] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/system_api.gyp
[modify] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/system_api.pc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/5937e923c30d23c51cbec2bed999d847e800b7f4

commit 5937e923c30d23c51cbec2bed999d847e800b7f4
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 07 14:00:18 2017

system_api: Add smbprovider ErrorType enum

Add enum ErrorType that match ProvidedError on Chromium.

BUG=chromium:757625
TEST=runs locally
Change-Id: Ic641a3dccd48a0e3bdfc5da52ace381d238acca3
Reviewed-on: https://chromium-review.googlesource.com/744992
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@google.com>

[modify] https://crrev.com/5937e923c30d23c51cbec2bed999d847e800b7f4/dbus/smbprovider/directory_entry.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b

commit ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 07 17:25:56 2017

smbprovider: Add ebuild, USE mask flag, and system_api change

Add smbprovider ebuild, USE flag for arm, and also dependency in the
Chrome ebuild. Also add system_api ebuild change

BUG=chromium:757625
TEST=emerges on eve
CQ-DEPEND=CL:625074

Change-Id: I3cd1f8cf15cecf9ed23dbffdfe396cb8cd452fbf
Reviewed-on: https://chromium-review.googlesource.com/745102
Commit-Ready: Zentaro Kavanagh <zentaro@google.com>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/profiles/arch/arm/package.use.mask
[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/chromeos-chrome/metadata.xml
[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/system_api/system_api-9999.ebuild
[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[add] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/37015a3425f89da75cd49038326f990f090f75e2

commit 37015a3425f89da75cd49038326f990f090f75e2
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 07 17:25:56 2017

smbprovider: Implement DBus service for smbprovider with read-only
navigation

Initial CL for SmbProvider that implements the DBus service and contains
Mount, Unmount, ReadDirectory, and GetMetadata. This will be the first
of the CLs that will provide read-only navigation of an SMB share.

BUG=chromium:757625
TEST=Daemon runs, unit tests run fine
CQ-DEPEND=CL:744992
Change-Id: I799651470146d7be3ec3b31a343639a1debf700e
Reviewed-on: https://chromium-review.googlesource.com/625074
Commit-Ready: Zentaro Kavanagh <zentaro@google.com>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@google.com>

[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/samba_interface_impl.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider.gyp
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/constants.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_test.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_helper.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/OWNERS
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_helper_test.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_main.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/fake_samba_interface.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/dbus_bindings/dbus-service-config.json
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/constants.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/fake_samba_interface.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_helper.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/README.md
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/samba_interface_impl.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/samba_interface.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/1a6e64d708d5a6b1ca64265310230a27deef6ae9

commit 1a6e64d708d5a6b1ca64265310230a27deef6ae9
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 21 02:13:42 2017

system_api: Add Smbprovider Mount and Unmount protobuf

Add MountOptions and UnmountOptions protobuf.

BUG=chromium:757625
TEST=runs locally

Change-Id: I56b2f8f9e752883d42fc73ada52f1204ba31c872
Reviewed-on: https://chromium-review.googlesource.com/757869
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/1a6e64d708d5a6b1ca64265310230a27deef6ae9/dbus/smbprovider/directory_entry.proto

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/619471e97b6197290448c268f9d51974a9ac193f

commit 619471e97b6197290448c268f9d51974a9ac193f
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Nov 22 05:36:21 2017

smbprovider: Change Mount and Unmount to use protobuf

Using MountOptions and UnmountOptions protobuf.

BUG=chromium:757625
TEST=tested with local chrome client
CQ-DEPEND=CL:757869

Change-Id: I1153931b96e9c3b6864ded838ffac23341bc8199
Reviewed-on: https://chromium-review.googlesource.com/757983
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider.h
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider.cc
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider_helper_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/7d909c89b4178ca17bf091ed3dd738f2207cf626

commit 7d909c89b4178ca17bf091ed3dd738f2207cf626
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Nov 22 05:36:17 2017

smbprovider: Added user and group id for smbprovider

BUG=chromium:757625
TEST=emerges on cave

Change-Id: I4627fcd1ce4b50dec48c7ae3a659b2cca59e0e4c
Reviewed-on: https://chromium-review.googlesource.com/760179
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[add] https://crrev.com/7d909c89b4178ca17bf091ed3dd738f2207cf626/profiles/base/accounts/group/smbproviderd
[add] https://crrev.com/7d909c89b4178ca17bf091ed3dd738f2207cf626/profiles/base/accounts/user/smbproviderd

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6397da22ea826f692c67867ff6d097b8d84b928

commit b6397da22ea826f692c67867ff6d097b8d84b928
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Nov 22 17:12:28 2017

Roll src/third_party/cros_system_api/ 5fc40ab72..e46ef54fe (8 commits)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5fc40ab72e45..e46ef54fea48

$ git log 5fc40ab72..e46ef54fe --date=short --no-merges --format='%ad %ae %s'
2017-11-20 cernekee system_api: shill: Add constants for EAP.TLSVersionMax property
2017-11-14 akahuang hammerd: Add DBus signal to notify UI the base needs update.
2017-11-07 allenvic system_api: Add Smbprovider Mount and Unmount protobuf
2017-11-10 ejcaruso modemfwd_switches: reflect new interface
2017-11-15 benchan system_api: update OWNERS
2017-11-15 agawronska Add constant for EnumerateDevices method.
2017-10-30 allenvic system_api: Add smbprovider ErrorType enum
2017-11-03 matthewmwang system_api: adding constant for OpenVPN.TLSVersionMin support

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 757625
Change-Id: I18bd704fe108e84c59972a85f0576398b3e5345a
Reviewed-on: https://chromium-review.googlesource.com/782708
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518662}
[modify] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0245710f8469989985d2f02fa3d408249aa72e53

commit 0245710f8469989985d2f02fa3d408249aa72e53
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Nov 28 01:20:20 2017

smbprovider: Add SmbProviderClient

Add Mount and Unmount.

CQ-DEPEND=CL:782708

Bug: chromium:757625
Change-Id: Idbc9ccc80da7872317f3a0bd05b72447e09de1d0
Reviewed-on: https://chromium-review.googlesource.com/745304
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519507}
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/BUILD.gn
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_clients_browser.cc
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_clients_browser.h
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_thread_manager.h
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/fake_smb_provider_client.cc
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/fake_smb_provider_client.h
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/smb_provider_client.cc
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/smb_provider_client.h

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/e02e3da4841e85c69bc9f3ea2b758a65d78b341e

commit e02e3da4841e85c69bc9f3ea2b758a65d78b341e
Author: Allen Vicencio <allenvic@google.com>
Date: Wed Nov 29 04:17:02 2017

smbprovider: Add ReadDirectoryOptions and GetMetadataEntryOptions

Adds protobufs for ReadDirectory and GetMetadataEntry inputs.

BUG=chromium:757625
TEST=runs locally

Change-Id: Ia59d17229355255d41a0ec0a3e04140a32e85d85
Reviewed-on: https://chromium-review.googlesource.com/792599
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e02e3da4841e85c69bc9f3ea2b758a65d78b341e/dbus/smbprovider/directory_entry.proto

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 30

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9846cdf7720460d33c77cd2f90446153d1fb86f4

commit 9846cdf7720460d33c77cd2f90446153d1fb86f4
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 06 04:22:44 2017

smbprovider: Change smbprovider to use by default

Changes smbprovider flag to be on by default.

BUG=chromium:757625
TEST=builds with build_packages

Change-Id: Id0e01fb5855e68f1ce2bd645ab4869a1a5db7438
Reviewed-on: https://chromium-review.googlesource.com/802376
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9846cdf7720460d33c77cd2f90446153d1fb86f4/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

i *think* this is causing asan failures.  presumably, we weren't
running smbprovider unit tests through asan until we turned it on.

https://uberchromegw.corp.google.com/i/chromiumos/builders/amd64-generic-asan/builds/22269

Looks like it. Looking into it.
I talked to Caveh@ last night and I sent in a rollback CL here while I take a look at it more closely:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/812434
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3df1821504a2146e7001aff49cbf069b94237c88

commit 3df1821504a2146e7001aff49cbf069b94237c88
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:08 2017

smbprovider: Change ebuild and add dbus service activation with minijail

Add jailed binary and /usr/share/dbus-1/system-services to ebuild.

BUG=chromium:757625
TEST=builds locally
CQ-DEPEND=CL:783559

Change-Id: I6baa7211a8d4a2b6099b280c5972cde36a8257e9
Reviewed-on: https://chromium-review.googlesource.com/783521
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/3df1821504a2146e7001aff49cbf069b94237c88/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2238c7d178090d995bc5441fcc8047f148d41d61

commit 2238c7d178090d995bc5441fcc8047f148d41d61
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:07 2017

smbprovider: Add .service file for DBus service activation with minijail

Add .service file for DBus service activation and run smbproviderd using
minijail

BUG=chromium:757625
TEST=builds locally

Change-Id: I1e492c0bd64ed0e33e31f6ccb865eaf0fcdbb29e
Reviewed-on: https://chromium-review.googlesource.com/783559
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/2238c7d178090d995bc5441fcc8047f148d41d61/smbprovider/org.chromium.SmbProvider.service
[add] https://crrev.com/2238c7d178090d995bc5441fcc8047f148d41d61/smbprovider/smbproviderd-jailed.sh

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c83089a8af9156802a21cc034f0388250fcba2f9

commit c83089a8af9156802a21cc034f0388250fcba2f9
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:08 2017

smbprovider: Add smb.conf file

Adds smb.conf file to disable use of SMB1 protocol.

BUG=chromium:757625
TEST=Can connect to local share configured to SMB2 protocol
CQ-DEPEND=CL:783559

Change-Id: Ib4159717edc406a033f5cbb56283e2b50f982807
Reviewed-on: https://chromium-review.googlesource.com/809611
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/c83089a8af9156802a21cc034f0388250fcba2f9/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/c83089a8af9156802a21cc034f0388250fcba2f9/smbprovider/constants.cc
[modify] https://crrev.com/c83089a8af9156802a21cc034f0388250fcba2f9/smbprovider/constants.h

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1cead9196e12dd000dbd93e5b2eb139f5d665d97

commit 1cead9196e12dd000dbd93e5b2eb139f5d665d97
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:13 2017

smbprovider: Fix for ASAN failure

Fixes misaligned type for ASAN failure in smbprovider.

BUG=chromium:757625
TEST=trybot

Change-Id: I1cca29e29a3e3e41b9021a78412c18202f46a4dd
Reviewed-on: https://chromium-review.googlesource.com/814578
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/1cead9196e12dd000dbd93e5b2eb139f5d665d97/smbprovider/smbprovider_helper.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37515d3dc46eba641c0b4704a4c9dd8275aaa629

commit 37515d3dc46eba641c0b4704a4c9dd8275aaa629
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Dec 11 23:55:10 2017

smbprovider: Add ReadDirectory and GetMetadataEntry

Add ReadDirectory and GetMetadataEntry methods for SmbProviderClient.
This allows read-only navigation of the share, excluding reading files.

Bug:chromium:757625
CQ-DEPEND=CL:794892

Change-Id: I55d4baa6dec95392774cdea3c07c13989b31e782
Reviewed-on: https://chromium-review.googlesource.com/749897
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523259}
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/smb_provider_client.h

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/078707c7eaef2f629b5f0bc52d84655b4c3d65b6

commit 078707c7eaef2f629b5f0bc52d84655b4c3d65b6
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 00:21:36 2017

smbprovider: Change ReadDirectory and GetMetadataEntry to accept protobuf

Changes ReadDirectory and GetMetadataEntry to use ReadDirectoryOptions
and GetMetadataEntryOptions protobuf since protobufs are easier to
modify going forward.

BUG=chromium:757625
TEST=Unit tests run.
CQ-DEPEND=CL:763608

Change-Id: Ib2d7b20e57db51eb7f248b90c6fd2b9e8458e774
Reviewed-on: https://chromium-review.googlesource.com/794892
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/smbprovider.cc
[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/smbprovider.h

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d432b68cccde0733cea267761890dc9bde2c07c0

commit d432b68cccde0733cea267761890dc9bde2c07c0
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 18:55:57 2017

SmbProviderClient: Change mount id to start at 0

Change SmbProviderClient to expect mount_id to start at 0.

CQ-DEPEND=CL:823086

Bug: chromium:757625
Change-Id: I55a13a0e15bf887176825e60c7297827fb45a017
Reviewed-on: https://chromium-review.googlesource.com/823270
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523837}
[modify] https://crrev.com/d432b68cccde0733cea267761890dc9bde2c07c0/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/d432b68cccde0733cea267761890dc9bde2c07c0/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ac418fd57126684b34bf09bad527814936d816a2

commit ac418fd57126684b34bf09bad527814936d816a2
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 22:58:21 2017

smbprovider: Change mount ids to start at 0

Changes mount_id to start at 0 instead of 1.

BUG=chromium:757625
TEST=unit tests run.

Change-Id: I2a53f0faede38ae3d50dc4a4eec26042022fa78e
Reviewed-on: https://chromium-review.googlesource.com/823086
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ac418fd57126684b34bf09bad527814936d816a2/smbprovider/smbprovider.cc
[modify] https://crrev.com/ac418fd57126684b34bf09bad527814936d816a2/smbprovider/smbprovider_test.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5677aabd65950a3ba0eee7636ca942e19dc45a29

commit 5677aabd65950a3ba0eee7636ca942e19dc45a29
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 22:58:20 2017

smbprovider: Refactor LogAndSetError

Refactor LogAndSetError calls to use constants instead of string
literals. Also add a helper method to log dbus errors.

BUG=chromium:757625
TEST=Unit tests run.

Change-Id: I5b7a08e82b58093e29c9432193ec13214de8b9c8
Reviewed-on: https://chromium-review.googlesource.com/823565
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/5677aabd65950a3ba0eee7636ca942e19dc45a29/smbprovider/smbprovider.cc

emerge-eve submprovide is failed on eve.
How can I fix this?


failed.txt
13.2 KB View Download
Hi Hiroh,

It seems like your system-api isn't getting built properly. The protobuf definitions and dbus-constants are taken from there. Are you by chance doing cros-workon on system-api? Also are you fully synced on that repo as well? 
I thought I did repo sync at that time.
I tried again just now. emerge-eve was successful.
Sorry for that.

Thanks
Project Member

Comment 30 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/b9797a0794435eecb9899ec13bc4ea3ea164e264

commit b9797a0794435eecb9899ec13bc4ea3ea164e264
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Dec 20 18:14:48 2017

adding open and close to sys api

BUG=chromium:757625
TEST=none
Change-Id: Id1eaeade80625f5269e8a4925d04e8af6bf396f4
Reviewed-on: https://chromium-review.googlesource.com/826244
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b9797a0794435eecb9899ec13bc4ea3ea164e264/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/b9797a0794435eecb9899ec13bc4ea3ea164e264/dbus/smbprovider/directory_entry.proto

Project Member

Comment 31 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b9f2850fac62279ed907af3ef3a0417e86b04e

commit b9b9f2850fac62279ed907af3ef3a0417e86b04e
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 20 18:54:55 2017

Implement ReadDirectory for SmbFileSystem

Implements ReadDirectory for SmbFileSystem. This will allow the files
app to be able to populate entries when inside a directory.

Bug: chromium:757625
Change-Id: I972bc19a0791acf607f181dd4d051c5b6d4ed9d4
Reviewed-on: https://chromium-review.googlesource.com/824912
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525390}
[modify] https://crrev.com/b9b9f2850fac62279ed907af3ef3a0417e86b04e/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/b9b9f2850fac62279ed907af3ef3a0417e86b04e/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 32 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5f147ea1bcc7f001d4e385c196e81236492da291

commit 5f147ea1bcc7f001d4e385c196e81236492da291
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 20 20:58:30 2017

smbprovider: Add setup for logging

Added logging in order for log messages to be viewed in syslog.

BUG=chromium:757625
TEST=Can see logs locally

Change-Id: Ib40cb77720b240ce08204327aa48c5f525ed6771

[modify] https://crrev.com/5f147ea1bcc7f001d4e385c196e81236492da291/smbprovider/smbprovider_main.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10df1c1ccd7e62e3fcb657b2e189a336c1ac3e13

commit 10df1c1ccd7e62e3fcb657b2e189a336c1ac3e13
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Dec 21 20:49:11 2017

smb_client: Implement GetMetadata

Implement GetMetadata for SmbFileSystem.

Bug: chromium:757625
Change-Id: I02c4c7e7527047f4146765d1059c7a4409470f13
Reviewed-on: https://chromium-review.googlesource.com/826257
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525797}
[modify] https://crrev.com/10df1c1ccd7e62e3fcb657b2e189a336c1ac3e13/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/10df1c1ccd7e62e3fcb657b2e189a336c1ac3e13/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 34 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9657b7166d21128febaa7781cc693a4ce534571

commit b9657b7166d21128febaa7781cc693a4ce534571
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Dec 21 21:06:22 2017

smb_provider_client: Refactor calls to DBUS methods.

- Removes duplicated code in calling DBUS methods
- Add helper method that sets up the message and provides all the
  default arguments.

BUG: chromium:757625
Change-Id: I59652da1da2c33a89cdab3a16d80c4b3d95b63d6
Reviewed-on: https://chromium-review.googlesource.com/837722
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525801}
[modify] https://crrev.com/b9657b7166d21128febaa7781cc693a4ce534571/chromeos/dbus/OWNERS
[modify] https://crrev.com/b9657b7166d21128febaa7781cc693a4ce534571/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 21

Project Member

Comment 36 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6afd7e91e5df638fd7eef8748577165bf82b117

commit e6afd7e91e5df638fd7eef8748577165bf82b117
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Dec 22 02:03:35 2017

Change SmbProviderClient OpenFile and CloseFile to CallMethod helper.

Bug: 757625
Change-Id: I03f9b56227e05fdc0ecb1e5f948e7fb107397c70
Reviewed-on: https://chromium-review.googlesource.com/841541
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525899}
[modify] https://crrev.com/e6afd7e91e5df638fd7eef8748577165bf82b117/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/275f4b9565b4e59d7c1eac1e5392ba35e24b2b2f

commit 275f4b9565b4e59d7c1eac1e5392ba35e24b2b2f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Dec 22 09:40:12 2017

chromeos-base/smbprovider: Add missing DEPENDS.

- Adds a missing dependency on system_api

BUG=chromium:757625
TEST=emerges

Change-Id: Iff1e8d8b9155536aa87b871b6176618e8d7ab143

[modify] https://crrev.com/275f4b9565b4e59d7c1eac1e5392ba35e24b2b2f/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 39 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9852c8c6b6d6803aad162f777b47542ce68590d9

commit 9852c8c6b6d6803aad162f777b47542ce68590d9
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Dec 22 09:40:15 2017

smbprovider: Add baileyberro@ as owner.

BUG=chromium:757625
TEST=not needed

Change-Id: Id65731d8eef3af76d3845483c261c8eec890ae24

[modify] https://crrev.com/9852c8c6b6d6803aad162f777b47542ce68590d9/smbprovider/OWNERS

Project Member

Comment 40 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb982dcc6b7cde1dd8c641db7511c67ebe615437

commit eb982dcc6b7cde1dd8c641db7511c67ebe615437
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Dec 22 17:25:26 2017

Adding OpenFile/CloseFile to SmbFileSystem.

This change implements OpenFile and CloseFile in SmbFileSystem.

Bug: 757625
Test: Open and Close called manually via UI, producing expected results
Change-Id: Ib45025963afdaced2da646bda610e6a54b079f40
Reviewed-on: https://chromium-review.googlesource.com/840730
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526013}
[modify] https://crrev.com/eb982dcc6b7cde1dd8c641db7511c67ebe615437/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/eb982dcc6b7cde1dd8c641db7511c67ebe615437/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 41 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7f4a647404118294524345c7e96c027fbe25b925

commit 7f4a647404118294524345c7e96c027fbe25b925
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Jan 03 05:32:20 2018

smbprovider: Clean up override and default.

BUG=chromium:757625
TEST=emerge

Change-Id: Ie494e12fa9893e2e4ce3f4573f3645a553988b83
Reviewed-on: https://chromium-review.googlesource.com/839981
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/7f4a647404118294524345c7e96c027fbe25b925/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/7f4a647404118294524345c7e96c027fbe25b925/smbprovider/smbprovider_helper_test.cc
[modify] https://crrev.com/7f4a647404118294524345c7e96c027fbe25b925/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/7f4a647404118294524345c7e96c027fbe25b925/smbprovider/samba_interface.h

Project Member

Comment 42 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/eb4f690a5d0355aeecb87de0fbb8ec3abc0f4427

commit eb4f690a5d0355aeecb87de0fbb8ec3abc0f4427
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Jan 03 05:32:16 2018

smbprovider: Refactor DBUS parsing.

BUG=chromium:757625
TEST=emerges

Change-Id: I49ec5f8ef3a7c3fbdc15724c885e8a66dfda65ec
Reviewed-on: https://chromium-review.googlesource.com/841129
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/eb4f690a5d0355aeecb87de0fbb8ec3abc0f4427/smbprovider/smbprovider.cc
[modify] https://crrev.com/eb4f690a5d0355aeecb87de0fbb8ec3abc0f4427/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/eb4f690a5d0355aeecb87de0fbb8ec3abc0f4427/smbprovider/smbprovider.h

Project Member

Comment 43 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/31a140c2bcbcd883a0891c3ba7e0b041ae71996e

commit 31a140c2bcbcd883a0891c3ba7e0b041ae71996e
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Jan 03 05:32:16 2018

smbprovider: Refactor mount and unmount.

- Added method that creates the full path.
- Eliminates extra string copy of mount root.
- Add helpers to manipulate the mount map.
- Add helper to check if a path can be mounted.

BUG=chromium:757625
TEST=emerges

Change-Id: I608857f5902aff60a394a65c364ea88d80c2d64d
Reviewed-on: https://chromium-review.googlesource.com/843143
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/31a140c2bcbcd883a0891c3ba7e0b041ae71996e/smbprovider/smbprovider.cc
[modify] https://crrev.com/31a140c2bcbcd883a0891c3ba7e0b041ae71996e/smbprovider/smbprovider.h

Project Member

Comment 44 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/551a638c1fc92cd23d43bbd10927b2744e3eac55

commit 551a638c1fc92cd23d43bbd10927b2744e3eac55
Author: Allen Vicencio <allenvic@google.com>
Date: Wed Jan 03 22:23:27 2018

smbprovider: Add ReadFile proto

Adding input parameter for ReadFile() as protobuf format.

BUG=chromium:757625
TEST=emerges
Change-Id: Ia2676f8002c5d0529998477bfc0af72e35e3fc32
Reviewed-on: https://chromium-review.googlesource.com/841527
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/551a638c1fc92cd23d43bbd10927b2744e3eac55/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/551a638c1fc92cd23d43bbd10927b2744e3eac55/dbus/smbprovider/directory_entry.proto

Project Member

Comment 45 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/9efc03a3dca4b439e0ee7aa940009c73779a2b75

commit 9efc03a3dca4b439e0ee7aa940009c73779a2b75
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Jan 04 22:35:23 2018

smbprovider: Add missing mount_id field.

- mount_id was missing from CloseFileOptions
- Although this modifies the field index, there are no real clients.

BUG=chromium:757625
TEST=none

Change-Id: I8b255130f451777f541a02a0b89add94820cf9ff
Reviewed-on: https://chromium-review.googlesource.com/848315
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9efc03a3dca4b439e0ee7aa940009c73779a2b75/dbus/smbprovider/directory_entry.proto

Project Member

Comment 46 by bugdroid1@chromium.org, Jan 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5f61b1ce31b123f8692e0fef92efc0634a6667d5

commit 5f61b1ce31b123f8692e0fef92efc0634a6667d5
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jan 05 05:52:04 2018

smbprovider: Add check for mount_id for CloseFile.

BUG=chromium:757625
TEST=none

Change-Id: I35eea3045f5671b608106bfb6e6fd8c6dbe8d0cd
Reviewed-on: https://chromium-review.googlesource.com/850949
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/5f61b1ce31b123f8692e0fef92efc0634a6667d5/smbprovider/smbprovider.cc
[modify] https://crrev.com/5f61b1ce31b123f8692e0fef92efc0634a6667d5/smbprovider/smbprovider_test.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Jan 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2c17ba826c4bb0c67770d4f10d4df92cae9fea3

commit b2c17ba826c4bb0c67770d4f10d4df92cae9fea3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jan 05 22:55:58 2018

Updating SmbProviderClient to use modified CloseFile proto.

This change makes the necessary modifications to support Mount Id as
a proto field as added by CL=848315.

Bug: 757625
Change-Id: I8e6f2dcfa3460c153403d265bf2fc38f26ba7a8e
Reviewed-on: https://chromium-review.googlesource.com/850537
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527420}
[modify] https://crrev.com/b2c17ba826c4bb0c67770d4f10d4df92cae9fea3/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/b2c17ba826c4bb0c67770d4f10d4df92cae9fea3/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/b2c17ba826c4bb0c67770d4f10d4df92cae9fea3/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/b2c17ba826c4bb0c67770d4f10d4df92cae9fea3/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/b2c17ba826c4bb0c67770d4f10d4df92cae9fea3/chromeos/dbus/smb_provider_client.h

Project Member

Comment 48 by bugdroid1@chromium.org, Jan 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/154b4b76246ad3a23876f18abf8b544b996711b2

commit 154b4b76246ad3a23876f18abf8b544b996711b2
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jan 06 05:14:14 2018

smbprovider: Add helper to parse and extract path.

- Adds a helper that can parse the proto and return the full path
  (appended to the root path).
- Adds template functions to extract the entry name from the proto
  even though it has different names (entry_path, file_path, dir_path).

BUG=chromium:757625
TEST=emerges

Change-Id: Ia88b17f714ebfdfd1b32a5f9de7213f0d07f2ecd
Reviewed-on: https://chromium-review.googlesource.com/843476
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/154b4b76246ad3a23876f18abf8b544b996711b2/smbprovider/smbprovider.cc
[modify] https://crrev.com/154b4b76246ad3a23876f18abf8b544b996711b2/smbprovider/smbprovider.h

Project Member

Comment 49 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d0d859027afcd2b01a50d3cba0b1cc472be1ab62

commit d0d859027afcd2b01a50d3cba0b1cc472be1ab62
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Jan 09 01:22:53 2018

smbprovider: Refactor out mount management.

- Moves the data structures for maintaining mounts to another class.
- Add tests for new class.
- Update smbprovider tests to validate mount manager state.
- New class in future will also manage open file descriptors.

BUG=chromium:757625
TEST=unittests

Change-Id: I9e1e75ecb1124ca0683d71c5aead6b15db150da7
Reviewed-on: https://chromium-review.googlesource.com/850898
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/mount_manager.cc
[modify] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/smbprovider.h
[modify] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/smbprovider.gyp
[modify] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/smbprovider.cc
[add] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/mount_manager_test.cc
[modify] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/smbprovider_main.cc
[add] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/mount_manager.h
[modify] https://crrev.com/d0d859027afcd2b01a50d3cba0b1cc472be1ab62/smbprovider/smbprovider_test.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ee7309ed37c6353e508f9faa363ae246f14fc465

commit ee7309ed37c6353e508f9faa363ae246f14fc465
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Jan 09 06:42:09 2018

smbprovider: Refactor to eliminate passing method name strings.

- Uses template specialization to map the options argument to a type
  name that is used for logging.

BUG=chromium:757625
TEST=emerges

Change-Id: I138207cbaf04f7676160796205aab406becbb0a1
Reviewed-on: https://chromium-review.googlesource.com/847892
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ee7309ed37c6353e508f9faa363ae246f14fc465/smbprovider/smbprovider.cc
[modify] https://crrev.com/ee7309ed37c6353e508f9faa363ae246f14fc465/smbprovider/smbprovider.h

Project Member

Comment 51 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149747b800f91dce8066cb337730e8a41970f8c6

commit 149747b800f91dce8066cb337730e8a41970f8c6
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Jan 09 21:42:28 2018

smb_provider_client: Use BindOnce not Bind.

BUG=chromium:757625

Change-Id: I8d7b43df67660edb271345b75edbdfb744f498f2
Reviewed-on: https://chromium-review.googlesource.com/840882
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528120}
[modify] https://crrev.com/149747b800f91dce8066cb337730e8a41970f8c6/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9278a56dbd2c965b8c11a3d3534c86be6c790c0

commit e9278a56dbd2c965b8c11a3d3534c86be6c790c0
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Jan 10 19:16:52 2018

Setting SmbProvider multiple_mounts to true.

This cl changes the SmbProvider setting for multiple_mounts to true
as users should be able to mount multiple Smb shares.

Bug: 757625
Change-Id: I25fd52c80af398be8d10039ec05d7d251b514cab
Reviewed-on: https://chromium-review.googlesource.com/860536
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528376}
[modify] https://crrev.com/e9278a56dbd2c965b8c11a3d3534c86be6c790c0/chrome/browser/chromeos/smb_client/smb_provider.cc

Project Member

Comment 54 by bugdroid1@chromium.org, Jan 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aea690c41bc793de26be1243f233b1079cf7485a

commit aea690c41bc793de26be1243f233b1079cf7485a
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Jan 12 01:35:23 2018

Add call to file_system_provider::Service::UnmountFileSystem().

This change adds a call to file_system_provider::Service::UnmountFileSystem()
to SmbFileSystem::HandleRequestUnmountCallback() via SmbService, fixing a bug
where smb mounts were not actually removed from VolumeManager when
unmounting via Files App.

Bug: 757625
Test: Verified manually on eve.
Change-Id: Ib38fd944a04e589c33670b084fd052a74bfeb9b1
Reviewed-on: https://chromium-review.googlesource.com/850819
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528840}
[modify] https://crrev.com/aea690c41bc793de26be1243f233b1079cf7485a/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/aea690c41bc793de26be1243f233b1079cf7485a/chrome/browser/chromeos/smb_client/smb_file_system.h
[modify] https://crrev.com/aea690c41bc793de26be1243f233b1079cf7485a/chrome/browser/chromeos/smb_client/smb_provider.cc
[modify] https://crrev.com/aea690c41bc793de26be1243f233b1079cf7485a/chrome/browser/chromeos/smb_client/smb_provider.h
[modify] https://crrev.com/aea690c41bc793de26be1243f233b1079cf7485a/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/aea690c41bc793de26be1243f233b1079cf7485a/chrome/browser/chromeos/smb_client/smb_service.h

Cc: baileyberro@chromium.org
Labels: -Pri-3 Pri-2
Status: Assigned
Summary: Add native SMB support to Chrome OS (was: Add smbclientd package to Chrome OS)
Project Member

Comment 56 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/740fe7a12e78c44d85e2181bcbac04256f5f9e38

commit 740fe7a12e78c44d85e2181bcbac04256f5f9e38
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Jan 13 01:12:34 2018

smbprovider: Cleanup unused includes.

BUG=chromium:757625
TEST=unittests

Change-Id: I11f3ff0b29f5082e8148f2d120f88dce14524806
Reviewed-on: https://chromium-review.googlesource.com/850640
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/smbprovider.cc
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/samba_interface.h
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/740fe7a12e78c44d85e2181bcbac04256f5f9e38/smbprovider/samba_interface_impl.h

Project Member

Comment 57 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3d27ade66d34d33ebe4666f703e957e3a7c6cb84

commit 3d27ade66d34d33ebe4666f703e957e3a7c6cb84
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Jan 13 06:37:49 2018

smbprovider: Add TempFileManager class

Adds TempFileManager to handle construction and deletion of temporary
directories and files.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I938a4d44210c603963e65b4b8b7c7f79e3710360
Reviewed-on: https://chromium-review.googlesource.com/862389
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/3d27ade66d34d33ebe4666f703e957e3a7c6cb84/smbprovider/smbprovider.h
[modify] https://crrev.com/3d27ade66d34d33ebe4666f703e957e3a7c6cb84/smbprovider/smbprovider.gyp
[add] https://crrev.com/3d27ade66d34d33ebe4666f703e957e3a7c6cb84/smbprovider/temp_file_manager.cc
[add] https://crrev.com/3d27ade66d34d33ebe4666f703e957e3a7c6cb84/smbprovider/temp_file_manager.h
[add] https://crrev.com/3d27ade66d34d33ebe4666f703e957e3a7c6cb84/smbprovider/temp_file_manager_test.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ad2b4c16eb54cd287d41ec09952ba0327f9a4eca

commit ad2b4c16eb54cd287d41ec09952ba0327f9a4eca
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Jan 13 06:37:51 2018

smbprovider: add delete methods unlink and removedir

This change adds and implements Unlink and RemoveDirectory
methods on SambaInterface and the corresponding fake.

TEST=compiles
BUG=chromium:757625
Change-Id: I09abf2c6509281f13b99b8000dcc7da361c64591
Reviewed-on: https://chromium-review.googlesource.com/864626
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ad2b4c16eb54cd287d41ec09952ba0327f9a4eca/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/ad2b4c16eb54cd287d41ec09952ba0327f9a4eca/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/ad2b4c16eb54cd287d41ec09952ba0327f9a4eca/smbprovider/samba_interface.h
[modify] https://crrev.com/ad2b4c16eb54cd287d41ec09952ba0327f9a4eca/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/ad2b4c16eb54cd287d41ec09952ba0327f9a4eca/smbprovider/samba_interface_impl.h

Project Member

Comment 59 by bugdroid1@chromium.org, Jan 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dba54499811f034334bfd6940cd17d3f8597933

commit 3dba54499811f034334bfd6940cd17d3f8597933
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Jan 18 01:19:49 2018

SmbFileSystem: Implement a stub AbortCallback.

- Provides a valid callback so that if it gets called there is no
  crash.
- Currently does not perform an abort since no operations can be
  aborted.
- The file system provider will just ignore any callback that happens
  after it requested above.

Bug: 757625
Change-Id: I5d52eb7117aaa364c78433fba2ab0249e8d8df1f
Reviewed-on: https://chromium-review.googlesource.com/869462
Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529995}
[modify] https://crrev.com/3dba54499811f034334bfd6940cd17d3f8597933/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/3dba54499811f034334bfd6940cd17d3f8597933/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 60 by bugdroid1@chromium.org, Jan 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/1b879ee32f68c5e41c105868f7a60e644f949f40

commit 1b879ee32f68c5e41c105868f7a60e644f949f40
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Jan 18 22:44:40 2018

smbprovider: Add DeleteEntryOptions protobuf to systemapi

This change adds a protobuf defintion for DeleteEntryOptions
as well as the method name constant for DeleteEntry.

TEST=emerge
BUG=chromium:757625

Change-Id: Ib1a9eaa817fd69ca27c461937217bfe249e4be47
Reviewed-on: https://chromium-review.googlesource.com/868931
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/1b879ee32f68c5e41c105868f7a60e644f949f40/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/1b879ee32f68c5e41c105868f7a60e644f949f40/dbus/smbprovider/directory_entry.proto

Project Member

Comment 61 by bugdroid1@chromium.org, Jan 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/89751074ac746a85418c3963ec9c88df59ce2c95

commit 89751074ac746a85418c3963ec9c88df59ce2c95
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Jan 18 22:44:43 2018

smbprovider: Fix for AddFile and AddDirectory in FakeSambaInterface

Fixes the bug where AddFile and AddDirectory can incorrectly add an
entry when an entry already exists in the path.

TEST=Unit tests run
BUG=chromium:757625

Change-Id: I5ca3f66b41d73d1148f4f38d0eba7e3fe3613d51
Reviewed-on: https://chromium-review.googlesource.com/872117
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/89751074ac746a85418c3963ec9c88df59ce2c95/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/89751074ac746a85418c3963ec9c88df59ce2c95/smbprovider/fake_samba_interface.cc

Project Member

Comment 62 by bugdroid1@chromium.org, Jan 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b968cf3299b505edd6f4898644eff9973adc039b

commit b968cf3299b505edd6f4898644eff9973adc039b
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Jan 18 22:44:44 2018

smbprovider: Rename ExpectNoDirectories function to ExpectNoEntries

Renames ExpectNoDirectories function to ExpectNoEntries

TEST=tests run
BUG=chromium:757625

Change-Id: I62833f4da0e1525870c6df24bd89fef9745d3437
Reviewed-on: https://chromium-review.googlesource.com/872236
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b968cf3299b505edd6f4898644eff9973adc039b/smbprovider/smbprovider_test.cc

Project Member

Comment 64 by bugdroid1@chromium.org, Jan 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/82dfc1d83b700236466563b8b85d193ab89fa152

commit 82dfc1d83b700236466563b8b85d193ab89fa152
Author: Allen Vicencio <allenvic@google.com>
Date: Fri Jan 19 08:29:45 2018

smbprovider: Add CreateFileOptions and TruncateOptions protobuf

This change adds the input protobuf definitions as well as the
method name constant for CreateFile and Truncate.

TEST=emerge
BUG=chromium:757625

Change-Id: I1784c3cdc1524621873894f10a957286040ba844
Reviewed-on: https://chromium-review.googlesource.com/871650
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/82dfc1d83b700236466563b8b85d193ab89fa152/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/82dfc1d83b700236466563b8b85d193ab89fa152/dbus/smbprovider/directory_entry.proto

Project Member

Comment 65 by bugdroid1@chromium.org, Jan 19

Project Member

Comment 67 by bugdroid1@chromium.org, Jan 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4c50666c1f92c9bf23621739633233238b46c23d

commit 4c50666c1f92c9bf23621739633233238b46c23d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Jan 20 04:35:42 2018

smbprovider: Add ReadFile

Added ReadFile to SmbProviderDaemon including tests.

BUG=chromium:757625
TEST=Unit tests run, runs locally
CQ-DEPEND=CL:862389

Change-Id: I672dbb2527433e51303eba4c1aa505b3b0136f7f
Reviewed-on: https://chromium-review.googlesource.com/860742
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/smbprovider.h
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/smbprovider.cc
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/temp_file_manager_test.cc
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/4c50666c1f92c9bf23621739633233238b46c23d/smbprovider/smbprovider_test.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Jan 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5070a04247e0c1ed0cfdf36628492b7d48659c5d

commit 5070a04247e0c1ed0cfdf36628492b7d48659c5d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Jan 22 18:13:36 2018

smbprovider: Add Truncate method for SambaInterface

Adds Truncate for SambaInterface and FakeSambaInterface

TEST=Unit tests run
BUG=chromium:757625
CQ-DEPEND=CL:871433

Change-Id: Iaf357ec45bfff52ea064db382beb63d14eaeb99e
Reviewed-on: https://chromium-review.googlesource.com/874517
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/5070a04247e0c1ed0cfdf36628492b7d48659c5d/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/5070a04247e0c1ed0cfdf36628492b7d48659c5d/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/5070a04247e0c1ed0cfdf36628492b7d48659c5d/smbprovider/samba_interface.h
[modify] https://crrev.com/5070a04247e0c1ed0cfdf36628492b7d48659c5d/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/5070a04247e0c1ed0cfdf36628492b7d48659c5d/smbprovider/samba_interface_impl.h

Project Member

Comment 73 by bugdroid1@chromium.org, Jan 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/55af1ecf95886bd60661dd7c62a9e32ec364afc1

commit 55af1ecf95886bd60661dd7c62a9e32ec364afc1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jan 23 06:07:15 2018

smbprovider: Add proto suffix to protos.

This change adds a 'proto' suffix to all protos to
make it more clear to callers that they are protobufs
and reduce naming confusion with other objects.

BUG=chromium:757625
TEST=emerge
CQ-DEPEND=876947
Change-Id: I5ad861649b1515576d001f4291ce559509a99ca3
Reviewed-on: https://chromium-review.googlesource.com/876946
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/55af1ecf95886bd60661dd7c62a9e32ec364afc1/dbus/smbprovider/directory_entry.proto

Project Member

Comment 75 by bugdroid1@chromium.org, Jan 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cfde312a0fc82c74ac5cbff6e0c8274d72cc30f5

commit cfde312a0fc82c74ac5cbff6e0c8274d72cc30f5
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Jan 26 03:23:44 2018

smbprovider: Add GetFileSize to FakeSmbProvider

Adds GetFileSize method to FakeSmbProvider for easier testing of tests
that include file size.

BUG=chromium:757625
TEST=Unit tests run

Change-Id: I1ab0dc83daa0a5317ebe959ea6eccd3b2346eaf5
Reviewed-on: https://chromium-review.googlesource.com/879385
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/cfde312a0fc82c74ac5cbff6e0c8274d72cc30f5/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/cfde312a0fc82c74ac5cbff6e0c8274d72cc30f5/smbprovider/fake_samba_interface.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Jan 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6d113fc78b363fb4b0db089146118c139ff34619

commit 6d113fc78b363fb4b0db089146118c139ff34619
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Jan 26 21:25:44 2018

smbprovider: Add test helper method to set error on Truncate and
CloseFile

Adds methods to force CloseFile and Truncate to return an error in tests.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I50e08d8715093ad43f23cc75d1bc29840ab259c1
Reviewed-on: https://chromium-review.googlesource.com/879131
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/6d113fc78b363fb4b0db089146118c139ff34619/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/6d113fc78b363fb4b0db089146118c139ff34619/smbprovider/fake_samba_interface.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Jan 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/1e29dfd4002f98e12745d2b88c58334590968c1b

commit 1e29dfd4002f98e12745d2b88c58334590968c1b
Author: Allen Vicencio <allenvic@google.com>
Date: Sat Jan 27 02:17:19 2018

smbprovider: Add WriteFile protobuf

This change adds WriteFileOptionsProto as a protobuf that will be used
to pass inputs into WriteFile.

BUG=chromium:757625
TEST=emerges

Change-Id: I2a6c92fc63d1b6a41ad000da653fc459e777726e
Reviewed-on: https://chromium-review.googlesource.com/882389
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/1e29dfd4002f98e12745d2b88c58334590968c1b/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/1e29dfd4002f98e12745d2b88c58334590968c1b/dbus/smbprovider/directory_entry.proto

Project Member

Comment 78 by bugdroid1@chromium.org, Jan 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9cef3d1ad7a857fd6a2b6c1d081e614ef4f909ee

commit 9cef3d1ad7a857fd6a2b6c1d081e614ef4f909ee
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Jan 27 09:36:49 2018

smbprovider: Cleanup SmbProvider Test by providing path getter methods

Add GetFilePath helper methods to provide default file paths

BUG=chromium:757625
TEST=Unit tests run

Change-Id: I36b85a20c35e59d3a9fa26eaf83f0085155c5033
Reviewed-on: https://chromium-review.googlesource.com/881946
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/9cef3d1ad7a857fd6a2b6c1d081e614ef4f909ee/smbprovider/smbprovider_test.cc

Project Member

Comment 79 by bugdroid1@chromium.org, Jan 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b61840ce643d5f41f4fe29835d4aa15bb9e42c78

commit b61840ce643d5f41f4fe29835d4aa15bb9e42c78
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Jan 27 09:36:49 2018

smbprovider: Add OpenFile and CloseFile helpers

Adds helper methods OpenFile and CloseFile.

BUG=chromium:757625
TEST=unit tests pass

Change-Id: Ibf97b5ce3d40c9887134c0355e4ed7c78d285e09
Reviewed-on: https://chromium-review.googlesource.com/885481
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b61840ce643d5f41f4fe29835d4aa15bb9e42c78/smbprovider/smbprovider.cc
[modify] https://crrev.com/b61840ce643d5f41f4fe29835d4aa15bb9e42c78/smbprovider/smbprovider.h

Project Member

Comment 80 by bugdroid1@chromium.org, Jan 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dc7a1d79428c176e0f6a0124fdebf96b9bdb14ae

commit dc7a1d79428c176e0f6a0124fdebf96b9bdb14ae
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Jan 27 09:36:50 2018

smbprovider: Add IsFileDataEqual to FakeSmb

Adds helper method to compare file data to an expected value.

BUG=chromium:757625
TEST=compiles

Change-Id: I0475b459a71636eac135d1ece70674884f5cb89e
Reviewed-on: https://chromium-review.googlesource.com/886567
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/dc7a1d79428c176e0f6a0124fdebf96b9bdb14ae/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/dc7a1d79428c176e0f6a0124fdebf96b9bdb14ae/smbprovider/fake_samba_interface.cc

Project Member

Comment 81 by bugdroid1@chromium.org, Jan 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2353a6375d1ab26f28dba09f28b64adbba653eac

commit 2353a6375d1ab26f28dba09f28b64adbba653eac
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Jan 30 00:38:29 2018

smbprovider: Refactor IsFileDataEqual to check for file size

Adds check in IsFileDataEqual for file size.

BUG=chromium:757625
TEST=unit tests run

Change-Id: Ica6e51a6761d0b715949736aa4ae9671ee96a52e
Reviewed-on: https://chromium-review.googlesource.com/891692
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/2353a6375d1ab26f28dba09f28b64adbba653eac/smbprovider/fake_samba_interface.cc

Project Member

Comment 82 by bugdroid1@chromium.org, Jan 30

Project Member

Comment 83 by bugdroid1@chromium.org, Jan 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/12dbce0344662ad8d1f0470c372f24f763227049

commit 12dbce0344662ad8d1f0470c372f24f763227049
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jan 30 20:06:21 2018

smbprovider: refactor out loop from GetDirectoryEntriesVector

This change adds a function to execute the loop from
GetDirectoryEntriesVector once so that future functions
can get just one buffer's worth of DirectoryEntries at a time.

TEST=unittests pass
BUG=chromium:757625
Change-Id: I80c3143c818c023c3ea15f9ca59b42438acd3a37
Reviewed-on: https://chromium-review.googlesource.com/887295
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/12dbce0344662ad8d1f0470c372f24f763227049/smbprovider/smbprovider.cc
[modify] https://crrev.com/12dbce0344662ad8d1f0470c372f24f763227049/smbprovider/smbprovider.h

Project Member

Comment 84 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7a4601f74fbcf977d8a17ca5c1442eba421e0186

commit 7a4601f74fbcf977d8a17ca5c1442eba421e0186
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Jan 31 01:47:13 2018

smbprovider: Implement Truncate for SmbProvider daemon

Implements Truncate for SmbProvider and adds tests.

BUG=chromium:757625
TEST=Unit tests run

Change-Id: I6ac07acf1c552b8f7184f6d4ddcc9124b9142004
Reviewed-on: https://chromium-review.googlesource.com/879387
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider.h
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider.cc
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/proto.h
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/proto.cc
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider_test_helper.cc
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/proto_test.cc
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/7a4601f74fbcf977d8a17ca5c1442eba421e0186/smbprovider/smbprovider_test.cc

Project Member

Comment 85 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e9f7bd76bfa920d6a369cec0bedc853731ef1e6a

commit e9f7bd76bfa920d6a369cec0bedc853731ef1e6a
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Jan 31 01:47:13 2018

smbprovider: Add WriteFile for SambaInterface

Adds WriteFile method for SambaInterface and implements
SambaInterfaceImpl.

BUG=chromium:757625
TEST=emerges

Change-Id: I9d5119a533649aa556900a70239e54d7194cacda
Reviewed-on: https://chromium-review.googlesource.com/882452
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e9f7bd76bfa920d6a369cec0bedc853731ef1e6a/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/e9f7bd76bfa920d6a369cec0bedc853731ef1e6a/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/e9f7bd76bfa920d6a369cec0bedc853731ef1e6a/smbprovider/samba_interface.h
[modify] https://crrev.com/e9f7bd76bfa920d6a369cec0bedc853731ef1e6a/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/e9f7bd76bfa920d6a369cec0bedc853731ef1e6a/smbprovider/samba_interface_impl.h

Project Member

Comment 87 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58881f7e49ba146916ad3df75b74bcca7bd07801

commit 58881f7e49ba146916ad3df75b74bcca7bd07801
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Jan 31 01:55:21 2018

Add Truncate to SmbProviderClient

Adds Truncate to SmbProviderClient and FakeSmbProviderClient

CQ-DEPEND=CL:879387

Bug: chromium:757625
Change-Id: Iff2f62efc059a41ad4d15c3cbb18bafac277c690
Reviewed-on: https://chromium-review.googlesource.com/879566
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533156}
[modify] https://crrev.com/58881f7e49ba146916ad3df75b74bcca7bd07801/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/58881f7e49ba146916ad3df75b74bcca7bd07801/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/58881f7e49ba146916ad3df75b74bcca7bd07801/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/58881f7e49ba146916ad3df75b74bcca7bd07801/chromeos/dbus/smb_provider_client.h

Project Member

Comment 88 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94092b8f650d5552ed3595eb2b3a0a96488524e7

commit 94092b8f650d5552ed3595eb2b3a0a96488524e7
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Jan 31 02:13:58 2018

Implement Truncate for SmbFileSystem

Implements Truncate for SmbFileSystem.

Bug: chromium:757625
CQ-DEPEND=CL:879566

Change-Id: Iecf94821ec7237be1fcc07b693c0bdec35903d97
Reviewed-on: https://chromium-review.googlesource.com/889558
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533164}
[modify] https://crrev.com/94092b8f650d5552ed3595eb2b3a0a96488524e7/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/94092b8f650d5552ed3595eb2b3a0a96488524e7/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 89 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/efdb73ee7482532610e503509f2e1643830210e9

commit efdb73ee7482532610e503509f2e1643830210e9
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Jan 31 11:36:26 2018

smbprovider: Fix error logic.

- Be consistent that functions returning boolean true don't
  set the error code.

BUG=chromium:757625
TEST=unittests

Change-Id: I2464009f14b1dbc95ba98fce691ad45d52296b84
Reviewed-on: https://chromium-review.googlesource.com/890100
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/efdb73ee7482532610e503509f2e1643830210e9/smbprovider/smbprovider.cc

Project Member

Comment 90 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f130ef83f658cf003218c7840c907ed5ea2e9726

commit f130ef83f658cf003218c7840c907ed5ea2e9726
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Jan 31 19:14:00 2018

smbprovider: Create FileSystemIteratorInterface

This change adds the interface class for File System Iterators
and creates a directory for iterator classes to live in.

BUG=chromium:757625
TEST=none
Change-Id: I97a9822a50e31b25869431ce47c877ddce9f97a9
Reviewed-on: https://chromium-review.googlesource.com/891423
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/f130ef83f658cf003218c7840c907ed5ea2e9726/smbprovider/iterator/file_system_iterator_interface.h
[modify] https://crrev.com/f130ef83f658cf003218c7840c907ed5ea2e9726/smbprovider/smbprovider.gyp

Project Member

Comment 91 by bugdroid1@chromium.org, Jan 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/453509163bd03a85e90dc52661fdd3d17408a797

commit 453509163bd03a85e90dc52661fdd3d17408a797
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Jan 31 21:04:11 2018

Add overload of CallMethod in SmbProviderClient

Adds an overload of CallMethod in preparation for WriteFile.

Bug: chromium:757625
Change-Id: Idd78a4b3b475c5eda176f7feb03cd52424aad96d
Reviewed-on: https://chromium-review.googlesource.com/893435
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533406}
[modify] https://crrev.com/453509163bd03a85e90dc52661fdd3d17408a797/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 92 by bugdroid1@chromium.org, Feb 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/27039576b9b3a107970feb37bf83bc4ebe484e0d

commit 27039576b9b3a107970feb37bf83bc4ebe484e0d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 01 02:00:58 2018

smbprovider: Implement WriteFile in FakeSambaInterface and add FakeSambaTest

Implements WriteFile in FakeSambaInterface and adds FakeSambaTest in
order to test FakeSambaInterface methods.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I23ccf82902e1116a0da4e3f941f4b6bc82f00fe1
Reviewed-on: https://chromium-review.googlesource.com/883604
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/27039576b9b3a107970feb37bf83bc4ebe484e0d/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/27039576b9b3a107970feb37bf83bc4ebe484e0d/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/27039576b9b3a107970feb37bf83bc4ebe484e0d/smbprovider/smbprovider.gyp
[add] https://crrev.com/27039576b9b3a107970feb37bf83bc4ebe484e0d/smbprovider/fake_samba_test.cc

Project Member

Comment 93 by bugdroid1@chromium.org, Feb 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/12e216695265af1ed1c1eabc9d0e8afa975406aa

commit 12e216695265af1ed1c1eabc9d0e8afa975406aa
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 01 02:00:58 2018

smbprovider: Add IsValidFlag method to SmbProviderHelper

Adds IsValidFlag method to SmbProviderHelper and refactors OpenFile flag
checking in FakeSambaInterface::OpenFile

BUG=chromium:757625
TEST=unit tests run

Change-Id: Ie30a0de2784abda42f789e3400c3be265b0f037e
Reviewed-on: https://chromium-review.googlesource.com/891577
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/12e216695265af1ed1c1eabc9d0e8afa975406aa/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/12e216695265af1ed1c1eabc9d0e8afa975406aa/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/12e216695265af1ed1c1eabc9d0e8afa975406aa/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/12e216695265af1ed1c1eabc9d0e8afa975406aa/smbprovider/smbprovider_helper_test.cc
[modify] https://crrev.com/12e216695265af1ed1c1eabc9d0e8afa975406aa/smbprovider/samba_interface_impl.cc

Project Member

Comment 94 by bugdroid1@chromium.org, Feb 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2a2bafeb0c24eb4adca6fc9befeb49789232c961

commit 2a2bafeb0c24eb4adca6fc9befeb49789232c961
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 01 10:41:54 2018

smbprovider: Add tests for FileDataEqual in FakeSambaTest

Adds tests for FileDataEqual in FakeSambaTest.

BUG=chromium:757625
TEST=unit tests run
Change-Id: I9e0f20ab7b69e00568aa1ad9d12fde2b3ea1a575
Reviewed-on: https://chromium-review.googlesource.com/887644
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/2a2bafeb0c24eb4adca6fc9befeb49789232c961/smbprovider/fake_samba_test.cc

Project Member

Comment 95 by bugdroid1@chromium.org, Feb 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f87fc479f136cb4e2e12a2049623fa282a553abd

commit f87fc479f136cb4e2e12a2049623fa282a553abd
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 01 19:44:05 2018

Add WriteFile to SmbProviderClient

Adds WriteFile to SmbProviderClient and FakeSmbProviderClient.

Bug: chromium:757625
Change-Id: I00f09ad71787dc4db922b318e0ae7afbf845ea46
Reviewed-on: https://chromium-review.googlesource.com/889559
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533779}
[modify] https://crrev.com/f87fc479f136cb4e2e12a2049623fa282a553abd/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/f87fc479f136cb4e2e12a2049623fa282a553abd/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/f87fc479f136cb4e2e12a2049623fa282a553abd/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/f87fc479f136cb4e2e12a2049623fa282a553abd/chromeos/dbus/smb_provider_client.h

Project Member

Comment 96 by bugdroid1@chromium.org, Feb 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b4f6a109d7a3373357d011d68df6badfff225024

commit b4f6a109d7a3373357d011d68df6badfff225024
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Feb 02 15:03:20 2018

smbprovider: Add override to destructor of TempFileManager

BUG=chromium:757625
TEST=unit tests run

Change-Id: If7eb1a77cc7891588b6a36658736f7d0421cac54
Reviewed-on: https://chromium-review.googlesource.com/894165
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/b4f6a109d7a3373357d011d68df6badfff225024/smbprovider/temp_file_manager_test.cc

Project Member

Comment 97 by bugdroid1@chromium.org, Feb 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8be1194cfd1736bb840f3c01bc8605e12e014a6c

commit 8be1194cfd1736bb840f3c01bc8605e12e014a6c
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Feb 02 18:16:56 2018

smbprovider: Add WriteFile helpers

Adds WriteFile helpers WriteFileFromBuffer, ReadFromFD
protobuf boilerplate (GetMethodName, IsValidProto) and test helpers.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I3644d830aa20166b2a9ae3a897d5cb55548cf6aa
Reviewed-on: https://chromium-review.googlesource.com/887546
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider.h
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider.cc
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/proto.h
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/proto.cc
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider_test_helper.cc
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/proto_test.cc
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/8be1194cfd1736bb840f3c01bc8605e12e014a6c/smbprovider/smbprovider_helper_test.cc

Project Member

Comment 98 by bugdroid1@chromium.org, Feb 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/27296ce4064a4d69807736f5f966aa6f13538578

commit 27296ce4064a4d69807736f5f966aa6f13538578
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Feb 02 18:16:58 2018

smbprovider: Implement WriteFile and add tests

Implements WriteFile and adds the related tests.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I3b10afc195a5d580e3a3c1185719a91fd740f961
Reviewed-on: https://chromium-review.googlesource.com/888138
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/27296ce4064a4d69807736f5f966aa6f13538578/smbprovider/smbprovider.cc
[modify] https://crrev.com/27296ce4064a4d69807736f5f966aa6f13538578/smbprovider/smbprovider_test.cc

Project Member

Comment 99 by bugdroid1@chromium.org, Feb 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/efc861016bccc0c30254f90b07b95347d203ac65

commit efc861016bccc0c30254f90b07b95347d203ac65
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Feb 02 18:16:57 2018

smbprovider: Add overloaded methods in SmbProviderTest for WriteFile

Adds methods and overloads for methods in SmbProviderTest in preparation
for WriteFile.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I134b51b6235acd9a33bfbeef26702e28a98cbbb8
Reviewed-on: https://chromium-review.googlesource.com/892052
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/efc861016bccc0c30254f90b07b95347d203ac65/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/efc861016bccc0c30254f90b07b95347d203ac65/smbprovider/smbprovider_helper_test.cc
[modify] https://crrev.com/efc861016bccc0c30254f90b07b95347d203ac65/smbprovider/smbprovider_test.cc

Project Member

Comment 100 by bugdroid1@chromium.org, Feb 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/184ccf4e990bfca1b2217e7e605ee8bd116c47b4

commit 184ccf4e990bfca1b2217e7e605ee8bd116c47b4
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Feb 02 21:19:36 2018

smbprovider: Add default dtor to SmbProviderTest

TEST=unittestes
BUG=chromium:757625
Change-Id: I34fa25641005d3244f3ca757d7554eccd88a4554
Reviewed-on: https://chromium-review.googlesource.com/894897
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/184ccf4e990bfca1b2217e7e605ee8bd116c47b4/smbprovider/smbprovider_test.cc

Project Member

Comment 101 by bugdroid1@chromium.org, Feb 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/27ea190fc3d5e5dc99dfb1d8c5058f50c5c447ca

commit 27ea190fc3d5e5dc99dfb1d8c5058f50c5c447ca
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Feb 06 03:09:11 2018

smbprovider: refactor SmbProvider to use DirectoryIterator

This change updates SmbProvider to use the DirectoryIterator
class for ReadDirectory. This change also removes tests regarding
ReadDirectory and buffer size because the buffer is now managed
by the DirectoryIterator class.

TEST=unittests
BUG=chromium:757625
Change-Id: I6b5babb86f3948f90e6a92216d46d23024df5563
Reviewed-on: https://chromium-review.googlesource.com/894714
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/27ea190fc3d5e5dc99dfb1d8c5058f50c5c447ca/smbprovider/smbprovider.cc
[modify] https://crrev.com/27ea190fc3d5e5dc99dfb1d8c5058f50c5c447ca/smbprovider/smbprovider.h
[modify] https://crrev.com/27ea190fc3d5e5dc99dfb1d8c5058f50c5c447ca/smbprovider/smbprovider_test.cc

Project Member

Comment 103 by bugdroid1@chromium.org, Feb 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc68bfa155deea8148f409ec65cf2b5d12f763ed

commit bc68bfa155deea8148f409ec65cf2b5d12f763ed
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Feb 06 23:34:56 2018

Implement WriteFile in SmbFileSystem

Implements WriteFile in SmbFileSystem using TempFileManager.

Bug: chromium:757625
Change-Id: I176079aca1bb752f628c86942f2ee89b46c19729
Reviewed-on: https://chromium-review.googlesource.com/894983
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534834}
[modify] https://crrev.com/bc68bfa155deea8148f409ec65cf2b5d12f763ed/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/bc68bfa155deea8148f409ec65cf2b5d12f763ed/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 104 by bugdroid1@chromium.org, Feb 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7a466fc2041b17875c8e97ab35cc917998321744

commit 7a466fc2041b17875c8e97ab35cc917998321744
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 07 02:18:54 2018

smbprovider: move path helpers to SmbProviderHelper

This change moves SMB url manipulators to the
SmbProviderHelper class so that they can be reused

TEST=emerges
BUG=chromium:757625
Change-Id: I0c9635f04ec68658a27439c10963b8914e34e531
Reviewed-on: https://chromium-review.googlesource.com/900133
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/7a466fc2041b17875c8e97ab35cc917998321744/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/7a466fc2041b17875c8e97ab35cc917998321744/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/7a466fc2041b17875c8e97ab35cc917998321744/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/7a466fc2041b17875c8e97ab35cc917998321744/smbprovider/smbprovider_helper_test.cc
[modify] https://crrev.com/7a466fc2041b17875c8e97ab35cc917998321744/smbprovider/constants.h

Project Member

Comment 105 by bugdroid1@chromium.org, Feb 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/21f5cb03e23154fcbbb8f102a4bb3cd32d58c5d8

commit 21f5cb03e23154fcbbb8f102a4bb3cd32d58c5d8
Author: Allen Vicencio <allenvic@google.com>
Date: Wed Feb 07 05:32:44 2018

smbprovider: Add CreateDirectory protobuf

Adds CreateDirectory protobuf used for passing inputs to
CreateDirectory and method name.

BUG=chromium:757625
TEST=emerges

Change-Id: I5916e2fecabddc2cda141ed275b9678423476b49
Reviewed-on: https://chromium-review.googlesource.com/896110
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/21f5cb03e23154fcbbb8f102a4bb3cd32d58c5d8/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/21f5cb03e23154fcbbb8f102a4bb3cd32d58c5d8/dbus/smbprovider/directory_entry.proto

Project Member

Comment 106 by bugdroid1@chromium.org, Feb 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/805aa03b86ea18077b8090dbd59a1447874b5273

commit 805aa03b86ea18077b8090dbd59a1447874b5273
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Feb 07 05:32:52 2018

smbprovider: Add CreateDirectory to D-Bus

Adds CreateDirectory stub and definition to D-Bus.

BUG=chromium:757625
TEST=emerges

Change-Id: I3ae2b9997268fd6305ebbc4c0217eb189de6eb06
Reviewed-on: https://chromium-review.googlesource.com/896033
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/805aa03b86ea18077b8090dbd59a1447874b5273/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/805aa03b86ea18077b8090dbd59a1447874b5273/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/805aa03b86ea18077b8090dbd59a1447874b5273/smbprovider/smbprovider.h
[modify] https://crrev.com/805aa03b86ea18077b8090dbd59a1447874b5273/smbprovider/smbprovider.cc

Project Member

Comment 108 by bugdroid1@chromium.org, Feb 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ab305e65f6d6d180c8a63607a6de65c9b726525b

commit ab305e65f6d6d180c8a63607a6de65c9b726525b
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 08 05:27:17 2018

smbprovider: Add CreateDirectory boilerplate methods

Adds boilerplate methods for CreateDirectory and test helper methods.

BUG=chromium:757625
TEST=unit tests run

Change-Id: Iea0dc3ae0a904014666bb2ac82ea0b134fb2e7c6
Reviewed-on: https://chromium-review.googlesource.com/897968
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/ab305e65f6d6d180c8a63607a6de65c9b726525b/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/ab305e65f6d6d180c8a63607a6de65c9b726525b/smbprovider/proto_test.cc
[modify] https://crrev.com/ab305e65f6d6d180c8a63607a6de65c9b726525b/smbprovider/proto.h
[modify] https://crrev.com/ab305e65f6d6d180c8a63607a6de65c9b726525b/smbprovider/proto.cc
[modify] https://crrev.com/ab305e65f6d6d180c8a63607a6de65c9b726525b/smbprovider/smbprovider_test_helper.cc

Project Member

Comment 109 by bugdroid1@chromium.org, Feb 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/47abccfb3601f8ae9ce6b377faf23f64d777c947

commit 47abccfb3601f8ae9ce6b377faf23f64d777c947
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 08 05:27:18 2018

smbprovider: Refactor kCreateFilePermissions to kCreateEntryPermissions

Refactors the name of the constant for create file permissions in
preparation for CreateDirectory.

BUG=chromium:757625
TEST=unit tests run

Change-Id: Ib68a867cc4b99fd5739e047abe9caa790b8fd378
Reviewed-on: https://chromium-review.googlesource.com/898551
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/47abccfb3601f8ae9ce6b377faf23f64d777c947/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/47abccfb3601f8ae9ce6b377faf23f64d777c947/smbprovider/constants.h

Project Member

Comment 110 by bugdroid1@chromium.org, Feb 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/757ffe7062793cdf71486d801264c238c73c157d

commit 757ffe7062793cdf71486d801264c238c73c157d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 08 09:23:57 2018

smbprovider: Add CreateDirectory in SambaInterface

Adds CreateDirectory in SambaInterface, FakeSambaInterface and
SambaInterfaceImpl for non-recursive implementation.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I6fc4eb2fd9cd289251f1b8c3f00732d464339a33
Reviewed-on: https://chromium-review.googlesource.com/898552
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/757ffe7062793cdf71486d801264c238c73c157d/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/757ffe7062793cdf71486d801264c238c73c157d/smbprovider/samba_interface.h
[modify] https://crrev.com/757ffe7062793cdf71486d801264c238c73c157d/smbprovider/samba_interface_impl.cc
[modify] https://crrev.com/757ffe7062793cdf71486d801264c238c73c157d/smbprovider/fake_samba_test.cc
[modify] https://crrev.com/757ffe7062793cdf71486d801264c238c73c157d/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/757ffe7062793cdf71486d801264c238c73c157d/smbprovider/samba_interface_impl.h

Project Member

Comment 111 by bugdroid1@chromium.org, Feb 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9cc79e69dda32bf1c1c78853c14bda28e24b0789

commit 9cc79e69dda32bf1c1c78853c14bda28e24b0789
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Feb 09 07:42:21 2018

smbprovider: Remove FileSystemIteratorInterface

This change removes the FileSystemIteratorInterface and
moves comments explaining various functions down into
DirectoryIterator

TEST=unittests
BUG=chromium:757625
Change-Id: Ib164164f9572b19291a4add753076b5ba5950097
Reviewed-on: https://chromium-review.googlesource.com/902162
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[delete] https://crrev.com/46422da23c67d6c2aa089ef918b7535343fbe9e6/smbprovider/iterator/file_system_iterator_interface.h
[modify] https://crrev.com/9cc79e69dda32bf1c1c78853c14bda28e24b0789/smbprovider/iterator/directory_iterator.h
[modify] https://crrev.com/9cc79e69dda32bf1c1c78853c14bda28e24b0789/smbprovider/smbprovider.gyp

Project Member

Comment 113 by bugdroid1@chromium.org, Feb 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c0d68f9ec3374099fd309798e074abd79b5f22bb

commit c0d68f9ec3374099fd309798e074abd79b5f22bb
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Feb 13 03:08:06 2018

smbprovider: create PostDepthFirstIterator

This change implements PostDepthFirstIterator,
and iterator class that performs a post-order traversal
of an SMB filesystem.

TEST=unittests
BUG=chromium:757625
Change-Id: I8c0a4fdc43cb9e267f03f842865e9cd8c2aae90e
Reviewed-on: https://chromium-review.googlesource.com/902925
Tested-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/c0d68f9ec3374099fd309798e074abd79b5f22bb/smbprovider/iterator/post_depth_first_iterator.h
[add] https://crrev.com/c0d68f9ec3374099fd309798e074abd79b5f22bb/smbprovider/iterator/post_depth_first_iterator.cc
[modify] https://crrev.com/c0d68f9ec3374099fd309798e074abd79b5f22bb/smbprovider/smbprovider.gyp
[add] https://crrev.com/c0d68f9ec3374099fd309798e074abd79b5f22bb/smbprovider/iterator/post_depth_first_iterator_test.cc

Project Member

Comment 114 by bugdroid1@chromium.org, Feb 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac2e180a1265f88dd4030bb35d69f5d0b2dc488d

commit ac2e180a1265f88dd4030bb35d69f5d0b2dc488d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Feb 13 19:22:36 2018

Fix bug in SmbProviderClient to use WriteFile callback

Bug: chromium:757625
Change-Id: I5261a67c5d7fe55fa4cd63321ebce3c5c8cf65e1
Reviewed-on: https://chromium-review.googlesource.com/915062
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536418}
[modify] https://crrev.com/ac2e180a1265f88dd4030bb35d69f5d0b2dc488d/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 116 by bugdroid1@chromium.org, Feb 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/792c536c5e60313a5886c854ba2af060d28f95b9

commit 792c536c5e60313a5886c854ba2af060d28f95b9
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Feb 13 21:26:06 2018

Implement CreateDirectory in SmbFileSystem

Bug: chromium:757625
Change-Id: I781ee0ab1cfff9669797dbe796a2b3a84856560a
Reviewed-on: https://chromium-review.googlesource.com/915241
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536485}
[modify] https://crrev.com/792c536c5e60313a5886c854ba2af060d28f95b9/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/792c536c5e60313a5886c854ba2af060d28f95b9/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 117 by bugdroid1@chromium.org, Feb 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0f9d4e9287a34fd26c2735606a47fb22ec2932e

commit f0f9d4e9287a34fd26c2735606a47fb22ec2932e
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Feb 13 23:31:43 2018

Refactor SmbFileSystem to use default callback

Refactor duplicated callback methods into a default status callback.

Bug: chromium:757625
Change-Id: Ib38d1582eaa480a1faacce6654ac210606ea3c5d
Reviewed-on: https://chromium-review.googlesource.com/916824
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536546}
[modify] https://crrev.com/f0f9d4e9287a34fd26c2735606a47fb22ec2932e/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/f0f9d4e9287a34fd26c2735606a47fb22ec2932e/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 118 by bugdroid1@chromium.org, Feb 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/a8aa6aa88f0b1daf808e787f9a319e102d48cb05

commit a8aa6aa88f0b1daf808e787f9a319e102d48cb05
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 14 05:16:15 2018

smbprovider: Add MoveEntry protobuf

Adds MoveEntry protobuf used for passing inputs to
MoveEntry as well as the method name definition.

BUG=chromium:757625
TEST=emerges
Change-Id: I9e9eaf0564929aaffd265c36671ecaf052b17a62
Reviewed-on: https://chromium-review.googlesource.com/913721
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/a8aa6aa88f0b1daf808e787f9a319e102d48cb05/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/a8aa6aa88f0b1daf808e787f9a319e102d48cb05/dbus/smbprovider/directory_entry.proto

Project Member

Comment 119 by bugdroid1@chromium.org, Feb 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9e447e24efbedff976c6258dc182cda39d01814f

commit 9e447e24efbedff976c6258dc182cda39d01814f
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 14 05:17:16 2018

smbprovider: Implement PreDepthFirstIterator

This change implements PreDepthFirstIterator which
does a preorder traversal of an smb filesystem.

BUG=chromium:757625
TEST=unittests
Change-Id: I035ee3b6bd983e253bd30f227292dfe92ed44ef5
Reviewed-on: https://chromium-review.googlesource.com/902776
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/9e447e24efbedff976c6258dc182cda39d01814f/smbprovider/iterator/pre_depth_first_iterator.cc
[modify] https://crrev.com/9e447e24efbedff976c6258dc182cda39d01814f/smbprovider/smbprovider.gyp
[add] https://crrev.com/9e447e24efbedff976c6258dc182cda39d01814f/smbprovider/iterator/pre_depth_first_iterator_test.cc
[add] https://crrev.com/9e447e24efbedff976c6258dc182cda39d01814f/smbprovider/iterator/pre_depth_first_iterator.h

Project Member

Comment 120 by bugdroid1@chromium.org, Feb 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/611774b9d8eb8444f0f17a7d3eb3260db6d1a277

commit 611774b9d8eb8444f0f17a7d3eb3260db6d1a277
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Feb 14 05:17:06 2018

smbprovider: Implement non-recursive CreateDirectory

Adds non-recursive implementation of CreateDirectory.

BUG=chromium:757625
TEST=unit tests run

Change-Id: I80dd64f178ccc794ecace87b546b0f6ebfbb845b
Reviewed-on: https://chromium-review.googlesource.com/905633
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/611774b9d8eb8444f0f17a7d3eb3260db6d1a277/smbprovider/smbprovider.cc
[modify] https://crrev.com/611774b9d8eb8444f0f17a7d3eb3260db6d1a277/smbprovider/smbprovider.h
[modify] https://crrev.com/611774b9d8eb8444f0f17a7d3eb3260db6d1a277/smbprovider/smbprovider_test.cc

Project Member

Comment 121 by bugdroid1@chromium.org, Feb 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89a2bb9d73f609b63128c9bba498774d90d22e0

commit e89a2bb9d73f609b63128c9bba498774d90d22e0
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Feb 14 05:34:30 2018

Refactor SmbProviderClient methods to use default handler

This change adds a default handler in order to reduce code duplication
among similar methods in SmbProviderClient.

Bug: chromium:757625
Change-Id: Iaf01dc185f94fae713ffd5f3ec2494c3f910429f
Reviewed-on: https://chromium-review.googlesource.com/917123
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536656}
[modify] https://crrev.com/e89a2bb9d73f609b63128c9bba498774d90d22e0/chromeos/dbus/smb_provider_client.cc

Project Member

Comment 122 by bugdroid1@chromium.org, Feb 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d377fffb20163983a8042ed688a313ebc7553dcc

commit d377fffb20163983a8042ed688a313ebc7553dcc
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 14 12:07:05 2018

smbprovider: fix ReadDirectory bug introduced by DirectoryIterator

This change fixes a bug introduced by DirectoryIterator where
a directory was not correctly being marked as empty when there were
non-files and non-directories. An additional test is added to catch
this bug.

BUG=chromium:757625
TEST=unittests
Change-Id: I08f13587c644ab117abf8fa6e6e477a302b2b662
Reviewed-on: https://chromium-review.googlesource.com/907870
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/d377fffb20163983a8042ed688a313ebc7553dcc/smbprovider/iterator/directory_iterator_test.cc
[modify] https://crrev.com/d377fffb20163983a8042ed688a313ebc7553dcc/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/d377fffb20163983a8042ed688a313ebc7553dcc/smbprovider/iterator/depth_first_iterator.cc

Project Member

Comment 123 by bugdroid1@chromium.org, Feb 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/198b10edf07fffd2983bbcb3e1d5716310b5d279

commit 198b10edf07fffd2983bbcb3e1d5716310b5d279
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 15 04:38:55 2018

smbprovider: refactor fake to support permissions

This change adds a 'locked' boolean to indicate that operations
on an entry should be restricted, and adds corresponding tests.

BUG=chromium:757625
TEST=unittests
Change-Id: I84d62fbb2e6d5ce80025b7ebf59f23d2af98ba2d
Reviewed-on: https://chromium-review.googlesource.com/907871
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/198b10edf07fffd2983bbcb3e1d5716310b5d279/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/198b10edf07fffd2983bbcb3e1d5716310b5d279/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/198b10edf07fffd2983bbcb3e1d5716310b5d279/smbprovider/fake_samba_test.cc

Project Member

Comment 124 by bugdroid1@chromium.org, Feb 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b7b934b897b80344302f35cb3c826ead98f60b39

commit b7b934b897b80344302f35cb3c826ead98f60b39
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Feb 15 04:38:56 2018

smbprovider: Add helper for recursive CreateDirectory

Adds helper methods for recursive implementation of CreateDirectory.

BUG=chromium:757625
TEST=unit tests run.

Change-Id: I63aad01ac63d453f012cb26321de81262c78e15f
Reviewed-on: https://chromium-review.googlesource.com/912270
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b7b934b897b80344302f35cb3c826ead98f60b39/smbprovider/smbprovider.cc
[modify] https://crrev.com/b7b934b897b80344302f35cb3c826ead98f60b39/smbprovider/smbprovider.h

Project Member

Comment 125 by bugdroid1@chromium.org, Feb 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/287731a9237363bab846d9ccedd0d709fd1c63e1

commit 287731a9237363bab846d9ccedd0d709fd1c63e1
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 15 04:45:26 2018

smbprovider: fix bug in fake

This change fixes a bug in the fake where an index into a directory
maintened by any OpenInfo for an open directory would point off
the end of the entries vector when an entry as deleted.

TEST=unittests
BUG=chromium:757625
Change-Id: I71906f496ca34e144fb95b2ec9b8aec3ca8f2e15
Reviewed-on: https://chromium-review.googlesource.com/909950
Tested-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/287731a9237363bab846d9ccedd0d709fd1c63e1/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/287731a9237363bab846d9ccedd0d709fd1c63e1/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/287731a9237363bab846d9ccedd0d709fd1c63e1/smbprovider/fake_samba_test.cc

Project Member

Comment 126 by bugdroid1@chromium.org, Feb 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/63660178f743f79ea2ed21f087d3eb91cf6eb44f

commit 63660178f743f79ea2ed21f087d3eb91cf6eb44f
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 15 08:11:05 2018

smbprovider: implement recursive delete

This change implements recursive delete for SmbProvider
and adds corresponding tests.

BUG=chromium:757625
TEST=unittests
Change-Id: I0a8b5379d533d0a85050ca568adaed78b4cdce48
Reviewed-on: https://chromium-review.googlesource.com/905444
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/63660178f743f79ea2ed21f087d3eb91cf6eb44f/smbprovider/smbprovider.cc
[modify] https://crrev.com/63660178f743f79ea2ed21f087d3eb91cf6eb44f/smbprovider/smbprovider.h
[modify] https://crrev.com/63660178f743f79ea2ed21f087d3eb91cf6eb44f/smbprovider/smbprovider_test.cc

Project Member

Comment 127 by bugdroid1@chromium.org, Feb 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fc81da80fb19a584ea9d9988f1ceab80e1b3840b

commit fc81da80fb19a584ea9d9988f1ceab80e1b3840b
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Feb 16 05:43:58 2018

smbprovider: Implement recursive CreateDirectory

Implements recursive CreateDirectory. This allows CreateDirectory to
create parent directories if they don't exist if recursive is set to
true. CreateDirectory will always fail if the leaf node directory
already exists. CreateDirectory will return true even if it did not have
to create any parent directory while recursive is true.

BUG=chromium:757625
TEST=unit tests pass

Change-Id: I207cb7427bd12530b33a43dbee8f12aaf718080a
Reviewed-on: https://chromium-review.googlesource.com/912271
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/fc81da80fb19a584ea9d9988f1ceab80e1b3840b/smbprovider/smbprovider.h
[modify] https://crrev.com/fc81da80fb19a584ea9d9988f1ceab80e1b3840b/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/fc81da80fb19a584ea9d9988f1ceab80e1b3840b/smbprovider/smbprovider.cc
[modify] https://crrev.com/fc81da80fb19a584ea9d9988f1ceab80e1b3840b/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/fc81da80fb19a584ea9d9988f1ceab80e1b3840b/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/fc81da80fb19a584ea9d9988f1ceab80e1b3840b/smbprovider/smbprovider_helper_test.cc

Project Member

Comment 128 by bugdroid1@chromium.org, Feb 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1e2c04321729aa19592e3b73471a14fd4d65fcb4

commit 1e2c04321729aa19592e3b73471a14fd4d65fcb4
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Feb 17 05:41:49 2018

smbprovider: Add MoveEntry to D-Bus

This change adds a D-Bus definition for MoveEntry
and adds a stub method on SmbProvider.

BUG=chromium:757625
TEST=emerges
Change-Id: I47988c787a6a5ceee7788c8a2b9f63965be6d09c
Reviewed-on: https://chromium-review.googlesource.com/913720
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/1e2c04321729aa19592e3b73471a14fd4d65fcb4/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/1e2c04321729aa19592e3b73471a14fd4d65fcb4/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/1e2c04321729aa19592e3b73471a14fd4d65fcb4/smbprovider/smbprovider.h
[modify] https://crrev.com/1e2c04321729aa19592e3b73471a14fd4d65fcb4/smbprovider/smbprovider.cc

Project Member

Comment 129 by bugdroid1@chromium.org, Feb 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f

commit bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Feb 17 05:49:29 2018

smbprovider: Add MoveEntry boilerplate methods

This change adds boilerplate methods for MoveEntry as well
as test helper methods.

BUG=chromium:757625
TEST=unittests
Change-Id: Ia992f6884d7182bbf026a281ec633f360bc491a8
Reviewed-on: https://chromium-review.googlesource.com/914289
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f/smbprovider/proto_test.cc
[modify] https://crrev.com/bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f/smbprovider/proto.h
[modify] https://crrev.com/bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f/smbprovider/proto.cc
[modify] https://crrev.com/bedc0bb829714b95a7cdb68c0ccf5fc1ce16559f/smbprovider/smbprovider_test_helper.cc

Project Member

Comment 131 by bugdroid1@chromium.org, Feb 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/134b591375e3e7cd6596251126c2b4af4ad7866f

commit 134b591375e3e7cd6596251126c2b4af4ad7866f
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Feb 17 07:06:12 2018

smbprovider: add ParseOptionsAndPaths method

This change adds a ParseOptionsAndPaths method
to be used by MoveEntry for constructing the full paths
for both the source and destination.

BUG=chromium:757625
TEST=emerges
Change-Id: I9f164bff3a52a0a4fd7fbb8170e084935bbed1fb
Reviewed-on: https://chromium-review.googlesource.com/916827
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/134b591375e3e7cd6596251126c2b4af4ad7866f/smbprovider/smbprovider.cc
[modify] https://crrev.com/134b591375e3e7cd6596251126c2b4af4ad7866f/smbprovider/smbprovider.h

Project Member

Comment 132 by bugdroid1@chromium.org, Feb 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879b7350de24ebcb29e757379a9ee67d9c7e8887

commit 879b7350de24ebcb29e757379a9ee67d9c7e8887
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Feb 20 23:14:16 2018

Implement MoveEntry on SmbProviderClient

This change implements MoveEntry on SmbProviderClient
and FakeSmbProviderClient.

BUG=chromium:757625
TEST=compiles

Change-Id: Icf38fa220dbb993a86f12e8c5464b93b18f06c3d
Reviewed-on: https://chromium-review.googlesource.com/923081
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537924}
[modify] https://crrev.com/879b7350de24ebcb29e757379a9ee67d9c7e8887/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/879b7350de24ebcb29e757379a9ee67d9c7e8887/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/879b7350de24ebcb29e757379a9ee67d9c7e8887/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/879b7350de24ebcb29e757379a9ee67d9c7e8887/chromeos/dbus/smb_provider_client.h

Project Member

Comment 133 by bugdroid1@chromium.org, Feb 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c1f87cd56de20008740f12c07c0d6466a0e45c4

commit 7c1f87cd56de20008740f12c07c0d6466a0e45c4
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 21 02:14:54 2018

Implement MoveEntry on SmbFileSystem

This change implements MoveEntry on SmbFileSystem, allowing
files to be moved on Samba shares via the Files App.

TEST=compiles
BUG=chromium:757625

Change-Id: Id7c34a10360165e3aa7b0ea51b710283f564d54a
Reviewed-on: https://chromium-review.googlesource.com/923115
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537996}
[modify] https://crrev.com/7c1f87cd56de20008740f12c07c0d6466a0e45c4/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 134 by bugdroid1@chromium.org, Feb 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/f24f0cc15f3f95c4eabb368a0e3d8be4dc587583

commit f24f0cc15f3f95c4eabb368a0e3d8be4dc587583
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 21 02:16:34 2018

smbprovider: Add CopyEntry protobuf

Adds CopyEntry protobuf used for passing inputs to
CopyEntry as well as the method name definition.

BUG=chromium:757625
TEST=emerges
Change-Id: I5cc442b4b8d73484186373e28cf631ae1f70e731
Reviewed-on: https://chromium-review.googlesource.com/923212
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/f24f0cc15f3f95c4eabb368a0e3d8be4dc587583/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/f24f0cc15f3f95c4eabb368a0e3d8be4dc587583/dbus/smbprovider/directory_entry.proto

Project Member

Comment 135 by bugdroid1@chromium.org, Feb 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/89dcea06144d810e663f6f1fbe2459e9c6253478

commit 89dcea06144d810e663f6f1fbe2459e9c6253478
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 21 06:50:07 2018

smbprovider: Refactor GetFullPath method

This change changes the GetFullPath method to reduce the arguments
now that all Protos have a mount_id field.

TEST=unittests
BUG=chromium:757625
Change-Id: I3499a9d02312e79873f8cfb85bcfec229e5c582c
Reviewed-on: https://chromium-review.googlesource.com/919147
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/89dcea06144d810e663f6f1fbe2459e9c6253478/smbprovider/smbprovider.cc
[modify] https://crrev.com/89dcea06144d810e663f6f1fbe2459e9c6253478/smbprovider/smbprovider.h

Project Member

Comment 136 by bugdroid1@chromium.org, Feb 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/626285543f087d4c715282a044d8269ebc589968

commit 626285543f087d4c715282a044d8269ebc589968
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Feb 21 12:27:07 2018

smbprovider: refactor fake to use IsFile and IsDir

This change replaces manual checks whether an entry is
of type SMBC_FILE or SMBC_DIR with calls to IsFile() and
IsDir() functions.

TEST=unittests
BUG=chromium:757625
Change-Id: If31cf3b3b5f8cf20a599ec3c5711550a65c93190
Reviewed-on: https://chromium-review.googlesource.com/917015
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/626285543f087d4c715282a044d8269ebc589968/smbprovider/fake_samba_interface.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Feb 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5e3e8f3ea9e8cc71c4c17d41bbe5592d60a62285

commit 5e3e8f3ea9e8cc71c4c17d41bbe5592d60a62285
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 22 01:25:10 2018

smbprovider: Add support for EISDIR errno

This change adds a mapping for the EISDIR errno
and adds a check to the corresponding test.

BUG=chromium:757625
TEST=unittests
Change-Id: Id517b7cd8f8420555c78d2d0741800bb5345e4e7
Reviewed-on: https://chromium-review.googlesource.com/919504
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/5e3e8f3ea9e8cc71c4c17d41bbe5592d60a62285/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/5e3e8f3ea9e8cc71c4c17d41bbe5592d60a62285/smbprovider/smbprovider_helper_test.cc

Project Member

Comment 138 by bugdroid1@chromium.org, Feb 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dc3c32e94652acce3a8d0270020f27196f6bf30c

commit dc3c32e94652acce3a8d0270020f27196f6bf30c
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 22 09:53:27 2018

smbprovider: implement MoveEntry on SmbProvider

This change implements MoveEntry on SmbProvider and
adds corresponding tests to SmbProviderTest.

TEST=unittests
BUG=chromium:757625
Change-Id: I3f8f6f5287ec9d2ed06890d3519b7eab5ff23017
Reviewed-on: https://chromium-review.googlesource.com/917468
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/dc3c32e94652acce3a8d0270020f27196f6bf30c/smbprovider/smbprovider.cc
[modify] https://crrev.com/dc3c32e94652acce3a8d0270020f27196f6bf30c/smbprovider/smbprovider.h
[modify] https://crrev.com/dc3c32e94652acce3a8d0270020f27196f6bf30c/smbprovider/smbprovider_test.cc

Project Member

Comment 139 by bugdroid1@chromium.org, Feb 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe6020f6514f9be91303b7ffb31a941091487e83

commit fe6020f6514f9be91303b7ffb31a941091487e83
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 22 21:55:41 2018

Roll src/third_party/cros_system_api/ 131396396..7d15090bd (3 commits)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/13139639690b..7d15090bd036

$ git log 131396396..7d15090bd --date=short --no-merges --format='%ad %ae %s'
2017-04-06 jdufault cryptohome: support key policies and LE credentials
2018-02-15 baileyberro smbprovider: Add CopyEntry protobuf
2018-02-09 emaxx system_api: New fields and messages for challenge-response cryptohome keys

Created with:
  roll-dep src/third_party/cros_system_api

Bug: chromium:757625
Change-Id: I38b6fa915b099ba272579eb1bcb57c6dd8e32e76
Reviewed-on: https://chromium-review.googlesource.com/931983
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538576}
[modify] https://crrev.com/fe6020f6514f9be91303b7ffb31a941091487e83/DEPS

Project Member

Comment 140 by bugdroid1@chromium.org, Feb 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4447af24a6ebcf4930e7312028056fc051a1c6d

commit e4447af24a6ebcf4930e7312028056fc051a1c6d
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 22 22:54:44 2018

Implement CopyEntry on SmbProviderClient

This change implements CopyEntry on SmbProviderClient

Bug: chromium:757625
Change-Id: I3c9d68f34f80e6019417e39af87934c6431b3c2b
Reviewed-on: https://chromium-review.googlesource.com/929424
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538604}
[modify] https://crrev.com/e4447af24a6ebcf4930e7312028056fc051a1c6d/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/e4447af24a6ebcf4930e7312028056fc051a1c6d/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/e4447af24a6ebcf4930e7312028056fc051a1c6d/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/e4447af24a6ebcf4930e7312028056fc051a1c6d/chromeos/dbus/smb_provider_client.h

Project Member

Comment 141 by bugdroid1@chromium.org, Feb 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/900d5ea6c6ab62a7be71c2ee21b075b929d01a80

commit 900d5ea6c6ab62a7be71c2ee21b075b929d01a80
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Feb 22 23:32:30 2018

Implement CopyEntry on SmbFileSystem

This change implements CopyEntry on SmbFileSystem. This change allows
users to copy entries within an SMB Share.

Bug: chromium:757625
Change-Id: I68ee8a73832ca1fab01df22b7c2fafb47760c229
Reviewed-on: https://chromium-review.googlesource.com/929317
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538616}
[modify] https://crrev.com/900d5ea6c6ab62a7be71c2ee21b075b929d01a80/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 142 by bugdroid1@chromium.org, Feb 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f3eb7d3303b2edb78d2a83afd82e9b1c66b07c74

commit f3eb7d3303b2edb78d2a83afd82e9b1c66b07c74
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Feb 23 07:54:15 2018

smbprovider: Add CopyEntry to D-Bus

This change adds a D-Bus definition for CopyEntry
and adds a stub method on SmbProvider.

TEST=emerges
BUG=chromium:757625
Change-Id: I478404e14d1eeb941a206d8ca3fe21dcc89d9981
Reviewed-on: https://chromium-review.googlesource.com/923285
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/f3eb7d3303b2edb78d2a83afd82e9b1c66b07c74/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/f3eb7d3303b2edb78d2a83afd82e9b1c66b07c74/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/f3eb7d3303b2edb78d2a83afd82e9b1c66b07c74/smbprovider/smbprovider.h
[modify] https://crrev.com/f3eb7d3303b2edb78d2a83afd82e9b1c66b07c74/smbprovider/smbprovider.cc

Project Member

Comment 143 by bugdroid1@chromium.org, Feb 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/85c8bf73abbd6afa7256951e53f17a58deb31a58

commit 85c8bf73abbd6afa7256951e53f17a58deb31a58
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Feb 23 22:15:59 2018

smbprovider: Add CopyEntry boilerplate methods

This changes adds boilerplate methods for CopyEntry as well
ass test helper methods.

BUG=chromium:757625
TEST=unittests
Change-Id: I9afb0af065e13bd99135b46e92d94f9525e4ddce
Reviewed-on: https://chromium-review.googlesource.com/923286
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/85c8bf73abbd6afa7256951e53f17a58deb31a58/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/85c8bf73abbd6afa7256951e53f17a58deb31a58/smbprovider/proto_test.cc
[modify] https://crrev.com/85c8bf73abbd6afa7256951e53f17a58deb31a58/smbprovider/proto.h
[modify] https://crrev.com/85c8bf73abbd6afa7256951e53f17a58deb31a58/smbprovider/proto.cc
[modify] https://crrev.com/85c8bf73abbd6afa7256951e53f17a58deb31a58/smbprovider/smbprovider_test_helper.cc

Project Member

Comment 144 by bugdroid1@chromium.org, Feb 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34c6e7db8d596b335f94956d2852ee89bb699d57

commit 34c6e7db8d596b335f94956d2852ee89bb699d57
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Feb 26 18:31:37 2018

Remove erroneous callback.Run in SmbFileSystem

This change removes an extra callback.Run() call
in SmbFileSystem unmount().

BUG=chromium:757625

Change-Id: Iedc3eeadc28a50aca4ef5ead763eb19eda52dc1f
Reviewed-on: https://chromium-review.googlesource.com/934979
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539204}
[modify] https://crrev.com/34c6e7db8d596b335f94956d2852ee89bb699d57/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 145 by bugdroid1@chromium.org, Feb 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8b12c49fc1ba1504a6553513924de98bd76e1a36

commit 8b12c49fc1ba1504a6553513924de98bd76e1a36
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Feb 26 19:43:57 2018

smbprovider: Refactor SmbProvider functions to be more reusable

This change templates functions so that they can be reused by
MoveEntry including:
- CreateFile
- CreateDirectory
- WriteFileFromBuffer

BUG=chromium:757625
TEST=unittests
Change-Id: I1535bf243d61232288ace65274f198ff101db8da
Reviewed-on: https://chromium-review.googlesource.com/924329
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/8b12c49fc1ba1504a6553513924de98bd76e1a36/smbprovider/smbprovider.cc
[modify] https://crrev.com/8b12c49fc1ba1504a6553513924de98bd76e1a36/smbprovider/smbprovider.h

Project Member

Comment 146 by bugdroid1@chromium.org, Feb 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9aeb08c10bb0c3040e49b0cf90ba4d6ed1c98fc5

commit 9aeb08c10bb0c3040e49b0cf90ba4d6ed1c98fc5
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Feb 26 22:10:01 2018

smbprovider: Add GetOpenFilePermissions for CopyEntry

This change adds an overloaded GetOpenFilePermissions method
that takes a CopyEntryOptionsProto.

TEST=unittests
BUG=chromium:757625
Change-Id: Ifa5b5c94cb80b827dfb62a7cf3c747cb2ab39748
Reviewed-on: https://chromium-review.googlesource.com/924330
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9aeb08c10bb0c3040e49b0cf90ba4d6ed1c98fc5/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/9aeb08c10bb0c3040e49b0cf90ba4d6ed1c98fc5/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/9aeb08c10bb0c3040e49b0cf90ba4d6ed1c98fc5/smbprovider/smbprovider_helper_test.cc

Project Member

Comment 147 by bugdroid1@chromium.org, Feb 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a9ad55d923f2040fb1a968792fcac60d4b19f1ac

commit a9ad55d923f2040fb1a968792fcac60d4b19f1ac
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Feb 27 06:07:37 2018

smbprovider: Update CreateFile failures

This change adds checks in FakeSambaInterface::CreateFile
that the parent directory exists and that it is not locked
as well as corresponding tests in SmbProviderTest.

TEST=unittests
BUG=chromium:757625
Change-Id: I032cf31fb30af1c10b17d995715f86da96b90180
Reviewed-on: https://chromium-review.googlesource.com/927523
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/a9ad55d923f2040fb1a968792fcac60d4b19f1ac/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/a9ad55d923f2040fb1a968792fcac60d4b19f1ac/smbprovider/smbprovider_test.cc

Project Member

Comment 148 by bugdroid1@chromium.org, Feb 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/77fccbeecef3fb901ddb1a93f779f857c9094f47

commit 77fccbeecef3fb901ddb1a93f779f857c9094f47
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Feb 27 17:52:33 2018

smbprovider: Implement CopyEntry (nonrecursive)

This change implements non-recursive CopyEntry on
SmbProvider.

A follow up for recursive CopyEntry will build on this
by creating a PreDepthFirstIterator and calling CopyEntry
on each entry iteratred over.

TEST=none yet
BUG=chromium:757625
Change-Id: I1f1237709f665e79bc0a79cd02b86371bb055f65
Reviewed-on: https://chromium-review.googlesource.com/924623
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/77fccbeecef3fb901ddb1a93f779f857c9094f47/smbprovider/smbprovider.cc
[modify] https://crrev.com/77fccbeecef3fb901ddb1a93f779f857c9094f47/smbprovider/smbprovider.h
[modify] https://crrev.com/77fccbeecef3fb901ddb1a93f779f857c9094f47/smbprovider/smbprovider_test.cc

Project Member

Comment 149 by bugdroid1@chromium.org, Mar 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/718d43bb9c497e9edf86029667a979268b5ac028

commit 718d43bb9c497e9edf86029667a979268b5ac028
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Mar 02 08:11:55 2018

smbprovider: Remove typo in xml

Removes "\" from the end of some lines in org.chromium.SmbProvider.xml

BUG=chromium:757625
TEST=emerges
Change-Id: Ib6c434671a088e84e8965336343959258453c2d8
Reviewed-on: https://chromium-review.googlesource.com/941732
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/718d43bb9c497e9edf86029667a979268b5ac028/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml

Project Member

Comment 150 by bugdroid1@chromium.org, Mar 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/670a0ff9f5a1d27b62e2a09d929f6e2ea32278ba

commit 670a0ff9f5a1d27b62e2a09d929f6e2ea32278ba
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Mar 06 22:39:09 2018

smbprovider: add GetDeleteList protos

This change adds protos for GetDeleteList.

TEST=emerges
BUG=chromium:757625
Change-Id: Ife59c2fcfb2120e1ff007361776a93c5e67afca3
Reviewed-on: https://chromium-review.googlesource.com/950306
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/670a0ff9f5a1d27b62e2a09d929f6e2ea32278ba/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/670a0ff9f5a1d27b62e2a09d929f6e2ea32278ba/dbus/smbprovider/directory_entry.proto

Project Member

Comment 151 by bugdroid1@chromium.org, Mar 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f7a5d99bc115fc32a8444385bf4f367acf86a9d

commit 2f7a5d99bc115fc32a8444385bf4f367acf86a9d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Mar 06 23:29:45 2018

Add HostLocator and in-memory implementation

This CL adds the HostLocator interface and InMemoryHostLocator
implementation. This will allow for manual addition of hosts, which will
be used later in NetworkScanner.

Bug: chromium:757625
Change-Id: I1aca8374c93a679c4894421f4cd881bf995de924
Reviewed-on: https://chromium-review.googlesource.com/940606
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541240}
[modify] https://crrev.com/2f7a5d99bc115fc32a8444385bf4f367acf86a9d/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/2f7a5d99bc115fc32a8444385bf4f367acf86a9d/chrome/browser/chromeos/smb_client/discovery/host_locator.h
[add] https://crrev.com/2f7a5d99bc115fc32a8444385bf4f367acf86a9d/chrome/browser/chromeos/smb_client/discovery/in_memory_host_locator.cc
[add] https://crrev.com/2f7a5d99bc115fc32a8444385bf4f367acf86a9d/chrome/browser/chromeos/smb_client/discovery/in_memory_host_locator.h
[add] https://crrev.com/2f7a5d99bc115fc32a8444385bf4f367acf86a9d/chrome/browser/chromeos/smb_client/discovery/in_memory_host_locator_unittest.cc

Project Member

Comment 152 by bugdroid1@chromium.org, Mar 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b54f8e56326433765d5cfefd082fdb24cc2acb02

commit b54f8e56326433765d5cfefd082fdb24cc2acb02
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Mar 07 04:19:16 2018

smbprovider: Add GetDeleteList to dbus

This change adds the GetDeleteList method to dbus
and adds a stub implementation of the method in SmbProvider.

TEST=emerges
BUG=chromium:757625
Change-Id: I70786d46d3aa6a6b5f57fd09665bd7b25643b809
Reviewed-on: https://chromium-review.googlesource.com/934980
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/b54f8e56326433765d5cfefd082fdb24cc2acb02/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/b54f8e56326433765d5cfefd082fdb24cc2acb02/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/b54f8e56326433765d5cfefd082fdb24cc2acb02/smbprovider/smbprovider.h
[modify] https://crrev.com/b54f8e56326433765d5cfefd082fdb24cc2acb02/smbprovider/smbprovider.cc

Project Member

Comment 153 by bugdroid1@chromium.org, Mar 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/862b44a92b6fd24a6e3ab20eaffd6ab1cea7368e

commit 862b44a92b6fd24a6e3ab20eaffd6ab1cea7368e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Mar 08 03:47:10 2018

smbprovider: add MountManager::GetRelativePath

This change adds a GetRelativePath method to the
MountManager class and a corresponding test.

BUG=chromium:757625
TEST=unittests
Change-Id: I2e26c3956abc2b0cfd6bd34e67b26e2e45a895e5
Reviewed-on: https://chromium-review.googlesource.com/935021
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/862b44a92b6fd24a6e3ab20eaffd6ab1cea7368e/smbprovider/mount_manager.cc
[modify] https://crrev.com/862b44a92b6fd24a6e3ab20eaffd6ab1cea7368e/smbprovider/mount_manager.h
[modify] https://crrev.com/862b44a92b6fd24a6e3ab20eaffd6ab1cea7368e/smbprovider/mount_manager_test.cc

Project Member

Comment 154 by bugdroid1@chromium.org, Mar 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0c2d56466be865965dd8f48b06d4637535e57b64

commit 0c2d56466be865965dd8f48b06d4637535e57b64
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Mar 08 08:37:41 2018

smbprovider: add boilerplate methods for GetDeleteList

This change adds boilerplate methods for the GetDeleteList
method on SmbProvider and corresponding unittests.

BUG=chromium:757625
TEST=unittests
Change-Id: I6349090f393fc3379037197d7f6dcabf6caf6b46
Reviewed-on: https://chromium-review.googlesource.com/935022
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/0c2d56466be865965dd8f48b06d4637535e57b64/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/0c2d56466be865965dd8f48b06d4637535e57b64/smbprovider/proto_test.cc
[modify] https://crrev.com/0c2d56466be865965dd8f48b06d4637535e57b64/smbprovider/proto.h
[modify] https://crrev.com/0c2d56466be865965dd8f48b06d4637535e57b64/smbprovider/proto.cc
[modify] https://crrev.com/0c2d56466be865965dd8f48b06d4637535e57b64/smbprovider/smbprovider_test_helper.cc

Project Member

Comment 155 by bugdroid1@chromium.org, Mar 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ceecaf148a2c9a4dcb597953fcc81c7ddb3ae0ac

commit ceecaf148a2c9a4dcb597953fcc81c7ddb3ae0ac
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Mar 08 19:33:13 2018

smbprovider: move ValidateFDContent

This change moves ValidateFDContent from the
SmbProviderTest class to the anon namespace.

BUG=chromium:757625
TEST=unittests
Change-Id: Ic27af122183c6ee9cd2a08715f466f59237abedf
Reviewed-on: https://chromium-review.googlesource.com/946867
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ceecaf148a2c9a4dcb597953fcc81c7ddb3ae0ac/smbprovider/smbprovider_test.cc

Project Member

Comment 156 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/34cef1019f883de341f4240d325b2c815ca20a3a

commit 34cef1019f883de341f4240d325b2c815ca20a3a
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 09 03:28:53 2018

smbprovider: Template smbprovider::WriteTempFile

This change makes WriteTempFile a templated method
so that it can be reused by other operations besides ReadFile.

BUG=chromium:757625
TEST=unittests
Change-Id: I3a15a75488cb71128cf34eabe57c490752068d85
Reviewed-on: https://chromium-review.googlesource.com/946868
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/34cef1019f883de341f4240d325b2c815ca20a3a/smbprovider/smbprovider.cc
[modify] https://crrev.com/34cef1019f883de341f4240d325b2c815ca20a3a/smbprovider/smbprovider.h

Project Member

Comment 157 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bc046d381a85aea827175c0e70bda4a3dddba789

commit bc046d381a85aea827175c0e70bda4a3dddba789
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 09 05:59:52 2018

smbprovider: Implement GetDeleteList method

This change implements the GetDeleteList method on
SmbProvider and adds corresponding tests. This change
does not alter the existing DeleteEntry recursive implementation
which will be removed by later CLs once recursive Delete
is implemented on the Chrome Client side.

TEST=unittests
BUG=chromium:757625
Change-Id: I1916219494b3351c6d428bb2df677e1634f5fe21
Reviewed-on: https://chromium-review.googlesource.com/935023
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/bc046d381a85aea827175c0e70bda4a3dddba789/smbprovider/smbprovider.h
[modify] https://crrev.com/bc046d381a85aea827175c0e70bda4a3dddba789/smbprovider/smbprovider.cc
[modify] https://crrev.com/bc046d381a85aea827175c0e70bda4a3dddba789/smbprovider/proto.h
[modify] https://crrev.com/bc046d381a85aea827175c0e70bda4a3dddba789/smbprovider/proto.cc
[modify] https://crrev.com/bc046d381a85aea827175c0e70bda4a3dddba789/smbprovider/proto_test.cc
[modify] https://crrev.com/bc046d381a85aea827175c0e70bda4a3dddba789/smbprovider/smbprovider_test.cc

Project Member

Comment 158 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2931faae99f3222686c097f64d2eeb9b5b8b2ce9

commit 2931faae99f3222686c097f64d2eeb9b5b8b2ce9
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 09 22:14:22 2018

Implement GetDeleteList on SmbProviderClient

This change implements a GetDeleteList function on
SmbProviderClient that maps to the GetDeleteList fn
on the SmbProvider daemon.

Bug: chromium:757625
Change-Id: I7e4e4a8f0e7f21a92c8dd9edd72ad4e26bd6cd07
Reviewed-on: https://chromium-review.googlesource.com/937815
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542248}
[modify] https://crrev.com/2931faae99f3222686c097f64d2eeb9b5b8b2ce9/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/2931faae99f3222686c097f64d2eeb9b5b8b2ce9/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/2931faae99f3222686c097f64d2eeb9b5b8b2ce9/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/2931faae99f3222686c097f64d2eeb9b5b8b2ce9/chromeos/dbus/smb_provider_client.h

Project Member

Comment 159 by bugdroid1@chromium.org, Mar 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/419dc977209edd7799484e0b772d0f3aa5cd200a

commit 419dc977209edd7799484e0b772d0f3aa5cd200a
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 09 22:30:16 2018

Refactor SmbFileSystem to use GetDeleteList

This change updates the DeleteEntry method on SmbFileSystem to use
GetDeleteList. When a DeleteEntry call comes in from the Files API,
SmbFileSystem first makes a call to GetDeleteList in order to get an
ordered list of entries that need to be deleted, and subsequently
calls DeleteEntry on each entry in the list.

If there is an error generating the delete_list, delete will still
be attempted on any entries in the delete_list, and the error will
be returned. Otherwise (ie generating the delete_list succeeds), the
error_code from performing the deletes willbe returned.


Bug: chromium:757625
Test: verified recursive delete still works on Eve
Change-Id: I1afb3498ee51280d70291dd31f50a550129c4381
Reviewed-on: https://chromium-review.googlesource.com/937881
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542252}
[modify] https://crrev.com/419dc977209edd7799484e0b772d0f3aa5cd200a/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/419dc977209edd7799484e0b772d0f3aa5cd200a/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 160 by bugdroid1@chromium.org, Mar 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d784a163f3bca1eb32855030ce170925c686ba4e

commit d784a163f3bca1eb32855030ce170925c686ba4e
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Mar 12 23:46:23 2018

Implement NetworkScanner and add tests

This CL implements NetworkScanner and adds tests. This allows the use of
multiple HostLocators by registering it with NetworkScanner.

Bug: chromium:757625
Change-Id: I5c607450196f3f1751cab44ff42b94057d142442
Reviewed-on: https://chromium-review.googlesource.com/952369
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542657}
[modify] https://crrev.com/d784a163f3bca1eb32855030ce170925c686ba4e/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/d784a163f3bca1eb32855030ce170925c686ba4e/chrome/browser/chromeos/smb_client/discovery/network_scanner.cc
[add] https://crrev.com/d784a163f3bca1eb32855030ce170925c686ba4e/chrome/browser/chromeos/smb_client/discovery/network_scanner.h
[add] https://crrev.com/d784a163f3bca1eb32855030ce170925c686ba4e/chrome/browser/chromeos/smb_client/discovery/network_scanner_unittest.cc

Project Member

Comment 161 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/07613ac918b92ed59ba9d5377a0232bb687a8f17

commit 07613ac918b92ed59ba9d5377a0232bb687a8f17
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Mar 13 20:04:59 2018

smbprovider: Add GetSharesOptionsProto

This CL adds the proto used for the method GetShares.

BUG=chromium:757625
TEST=emerges
Change-Id: Iaf7b57e392ce1b772b6c899957c7cf570183fc4e
Reviewed-on: https://chromium-review.googlesource.com/956669
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/07613ac918b92ed59ba9d5377a0232bb687a8f17/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/07613ac918b92ed59ba9d5377a0232bb687a8f17/dbus/smbprovider/directory_entry.proto

Project Member

Comment 162 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef

commit f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Mar 13 20:05:04 2018

smbprovider: Refactor DirectoryIterator to BaseDirectoryIterator

This CL adds a base class BaseDirectoryIterator which is subclassed by
DirectoryIterator. This will allow for BaseDirectoryIterator to have
different implementations and process different entry types such as
shares.

BUG=chromium:757625
TEST=tests run fine
Change-Id: Idcb74162f39d5de8f437bd5c6dd7dc7751a8e347
Reviewed-on: https://chromium-review.googlesource.com/956501
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef/smbprovider/iterator/directory_iterator.cc
[modify] https://crrev.com/f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef/smbprovider/iterator/directory_iterator.h
[modify] https://crrev.com/f59f47a317d60a2cf4d5a6e1ec1d6cb6f82e92ef/smbprovider/smbprovider_helper_test.cc

Project Member

Comment 163 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e606bdfa2f0e9a567ef9bf954a4a66625fbae98d

commit e606bdfa2f0e9a567ef9bf954a4a66625fbae98d
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Mar 13 20:32:24 2018

Create SmbTaskQueue

This change creates the SmbTaskQueue class for queueing FileSystem
operations that will be sent over D-Bus to the Smb Daemon.

BUG=chromium:757625

Change-Id: Id48b8b4abbc5841f42ae1b52dca2e142f2ba6706
Reviewed-on: https://chromium-review.googlesource.com/953134
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542899}
[modify] https://crrev.com/e606bdfa2f0e9a567ef9bf954a4a66625fbae98d/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/e606bdfa2f0e9a567ef9bf954a4a66625fbae98d/chrome/browser/chromeos/smb_client/smb_task_queue.cc
[add] https://crrev.com/e606bdfa2f0e9a567ef9bf954a4a66625fbae98d/chrome/browser/chromeos/smb_client/smb_task_queue.h
[add] https://crrev.com/e606bdfa2f0e9a567ef9bf954a4a66625fbae98d/chrome/browser/chromeos/smb_client/smb_task_queue_unittest.cc

Project Member

Comment 164 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcb5ba6087e274152ada9f49d61fbef3563b225

commit cbcb5ba6087e274152ada9f49d61fbef3563b225
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Mar 13 21:29:39 2018

Add abort functionality to SmbTaskQueue

This change adds Abort functionality to SmbTaskQueue. The unrun tasks for
a given operation can be aborted via SmbTaskQueue::AbortOperation().

Test=unittest

Bug: chromium:757625
Change-Id: I317cc95556e4952a2c7049ad2cdf358d3058147b
Reviewed-on: https://chromium-review.googlesource.com/956260
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542915}
[modify] https://crrev.com/cbcb5ba6087e274152ada9f49d61fbef3563b225/chrome/browser/chromeos/smb_client/smb_task_queue.cc
[modify] https://crrev.com/cbcb5ba6087e274152ada9f49d61fbef3563b225/chrome/browser/chromeos/smb_client/smb_task_queue.h
[modify] https://crrev.com/cbcb5ba6087e274152ada9f49d61fbef3563b225/chrome/browser/chromeos/smb_client/smb_task_queue_unittest.cc

Project Member

Comment 165 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/877194c071e82766b95c4c6e14a8f8345873bf7e

commit 877194c071e82766b95c4c6e14a8f8345873bf7e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Mar 13 21:33:22 2018

Use SupportsWeakPtr<SmbFileSystem>

This change updates SmbFileSystem to using SupportsWeakPtr instead of
manually implementing a WeakPtrFactory.

Bug: chromium:757625
Change-Id: I00cf23d863a5f094185217bc5d18bda49d4405db
Reviewed-on: https://chromium-review.googlesource.com/957205
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542917}
[modify] https://crrev.com/877194c071e82766b95c4c6e14a8f8345873bf7e/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/877194c071e82766b95c4c6e14a8f8345873bf7e/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 166 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69f26f495d7425399ae38f79e8e8a9b8c605813

commit c69f26f495d7425399ae38f79e8e8a9b8c605813
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Mar 13 23:48:31 2018

Use SupportsWeakPtr<SmbProviderClient>

This change switches SmbProviderClient to using base::SupportsWeakPtr
and SmbProviderClientImpl to using a helper class that wraps it
instead of a manually implemented WeakPtrFactory.

Bug: chromium:757625
Change-Id: I18f3b04c18ba28bdf8bf9c356b3ebeb98d546cd3
Reviewed-on: https://chromium-review.googlesource.com/956417
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542951}
[modify] https://crrev.com/c69f26f495d7425399ae38f79e8e8a9b8c605813/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/c69f26f495d7425399ae38f79e8e8a9b8c605813/chromeos/dbus/smb_provider_client.h

Project Member

Comment 167 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ae3541175db41a9d0dde956e263b0807bc2dbb3

commit 1ae3541175db41a9d0dde956e263b0807bc2dbb3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Mar 13 23:51:41 2018

Add SmbProviderClient weak getter

This change adds a SmbFileSystem::GetWeakSmbProviderClient() method for
getting a weak_ptr to the SmbProviderClient singleton. This weak_ptr will
be used for posting tasks in the form of base::OnceClosure to the SmbTaskQueue.

Bug: chromium:757625
Change-Id: I4e10bfd3b10a243cc65303a15e8f2e1249d1560b
Reviewed-on: https://chromium-review.googlesource.com/957307
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542952}
[modify] https://crrev.com/1ae3541175db41a9d0dde956e263b0807bc2dbb3/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/1ae3541175db41a9d0dde956e263b0807bc2dbb3/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 169 by bugdroid1@chromium.org, Mar 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8028ab77d4c511b5be1c5f19044f4b2a0ba7863d

commit 8028ab77d4c511b5be1c5f19044f4b2a0ba7863d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Mar 14 02:00:00 2018

smbprovider: Refactor AddEntryIfValid to identify shares as directories

AddEntryIfValid will identify entries with type SMBC_FILE_SHARE as a
directory. This is done so that is_directory will be true for shares in
DirectoryEntryProto.

BUG=chromium:757625
TEST=unit tests run
Change-Id: Ia69d38675704a636e428e189ab7e51b8ee090f1b
Reviewed-on: https://chromium-review.googlesource.com/957547
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/8028ab77d4c511b5be1c5f19044f4b2a0ba7863d/smbprovider/iterator/directory_iterator.cc

Project Member

Comment 170 by bugdroid1@chromium.org, Mar 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0b1ae2639afcdf46563d2f67548247459b9fa500

commit 0b1ae2639afcdf46563d2f67548247459b9fa500
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Mar 14 18:55:46 2018

smbprovider: Add GetShares to D-Bus

Adds GetShares stub and definition to D-Bus.

BUG=chromium:757625
TEST=emerges

Change-Id: I2ade8859d315b44dbac6dcfe66661a8f169fb4e1
Reviewed-on: https://chromium-review.googlesource.com/957434
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/0b1ae2639afcdf46563d2f67548247459b9fa500/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/0b1ae2639afcdf46563d2f67548247459b9fa500/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/0b1ae2639afcdf46563d2f67548247459b9fa500/smbprovider/smbprovider.h
[modify] https://crrev.com/0b1ae2639afcdf46563d2f67548247459b9fa500/smbprovider/smbprovider.cc

Project Member

Comment 171 by bugdroid1@chromium.org, Mar 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/26c33fe130cc7a3718d74228e058496fd867b263

commit 26c33fe130cc7a3718d74228e058496fd867b263
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Mar 14 18:55:47 2018

smbprovider: Add boilerplate methods for GetShares

Adds boilerplate methods for GetShares on SmbProvider and corresponding
unit tests.

BUG=chromium:757625
TEST=unit tests
Change-Id: I4e97cd9e506bdbae8b5c5e4fa735847089ee759e
Reviewed-on: https://chromium-review.googlesource.com/957435
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/26c33fe130cc7a3718d74228e058496fd867b263/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/26c33fe130cc7a3718d74228e058496fd867b263/smbprovider/proto_test.cc
[modify] https://crrev.com/26c33fe130cc7a3718d74228e058496fd867b263/smbprovider/proto.h
[modify] https://crrev.com/26c33fe130cc7a3718d74228e058496fd867b263/smbprovider/proto.cc
[modify] https://crrev.com/26c33fe130cc7a3718d74228e058496fd867b263/smbprovider/smbprovider_test_helper.cc

Project Member

Comment 172 by bugdroid1@chromium.org, Mar 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7abddb4a16e3f1d1e07db9b0f1afd020a0eede

commit 2a7abddb4a16e3f1d1e07db9b0f1afd020a0eede
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 16 21:58:35 2018

Add SmbTaskQueue to SmbFileSystem

This change switches SmbFileSystem to routing all calls to
SmbProviderClient through an SmbTaskQueue.

Test: verified manually on eve
Bug: chromium:757625
Change-Id: Id3466a5cbd0858070bf7170f1358d88bd8d32334
Reviewed-on: https://chromium-review.googlesource.com/957477
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543842}
[modify] https://crrev.com/2a7abddb4a16e3f1d1e07db9b0f1afd020a0eede/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/2a7abddb4a16e3f1d1e07db9b0f1afd020a0eede/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 173 by bugdroid1@chromium.org, Mar 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/88481efde4161ad9e80bfc44769804208c64da06

commit 88481efde4161ad9e80bfc44769804208c64da06
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Mar 16 22:56:24 2018

smbprovider: Add helper method to get mount id for a protobuf

Adds GetMountId for a protobuf object with template specialization.

BUG=chromium:757625
TEST=unit tests run
Change-Id: Ief3ff16bd13930bea582596845f9f2784dddf246
Reviewed-on: https://chromium-review.googlesource.com/965252
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/88481efde4161ad9e80bfc44769804208c64da06/smbprovider/smbprovider.cc
[modify] https://crrev.com/88481efde4161ad9e80bfc44769804208c64da06/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/88481efde4161ad9e80bfc44769804208c64da06/smbprovider/proto.h
[modify] https://crrev.com/88481efde4161ad9e80bfc44769804208c64da06/smbprovider/proto.cc

Project Member

Comment 174 by bugdroid1@chromium.org, Mar 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/95f6b085cb1dbe60eb35e5fec6105192b2819e4d

commit 95f6b085cb1dbe60eb35e5fec6105192b2819e4d
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Mar 17 03:55:44 2018

smbprovider: Refactor ReadDirectory to extract logic into a helper method

This CL extracts the logic from ReadDirectory to a helper method that
takes an iterator. This is done in preparation for GetShares.

BUG=chromium:757625
TEST=unit tests run
Change-Id: I83baaa1b4bdddd3a814e3cf6728d6d37599be29c
Reviewed-on: https://chromium-review.googlesource.com/957436
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/95f6b085cb1dbe60eb35e5fec6105192b2819e4d/smbprovider/smbprovider.h
[modify] https://crrev.com/95f6b085cb1dbe60eb35e5fec6105192b2819e4d/smbprovider/smbprovider.cc
[modify] https://crrev.com/95f6b085cb1dbe60eb35e5fec6105192b2819e4d/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/95f6b085cb1dbe60eb35e5fec6105192b2819e4d/smbprovider/iterator/directory_iterator.h
[modify] https://crrev.com/95f6b085cb1dbe60eb35e5fec6105192b2819e4d/smbprovider/smbprovider_helper.cc
[modify] https://crrev.com/95f6b085cb1dbe60eb35e5fec6105192b2819e4d/smbprovider/smbprovider_test.cc

Project Member

Comment 176 by bugdroid1@chromium.org, Mar 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d927492b95bcfae183359241e02a39c3afd7a941

commit d927492b95bcfae183359241e02a39c3afd7a941
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Mar 22 18:08:29 2018

Add success field to FindHostCallback

This CL adds a bool success field to FindHostCallback to indicate if the
HostLocator was successful in querying for hosts.

Bug: chromium:757625
Change-Id: Ie1a2c4ee0c8392157234cc1f1eefdb0d3bc4d88f
Reviewed-on: https://chromium-review.googlesource.com/963757
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545155}
[modify] https://crrev.com/d927492b95bcfae183359241e02a39c3afd7a941/chrome/browser/chromeos/smb_client/discovery/host_locator.h
[modify] https://crrev.com/d927492b95bcfae183359241e02a39c3afd7a941/chrome/browser/chromeos/smb_client/discovery/in_memory_host_locator.cc
[modify] https://crrev.com/d927492b95bcfae183359241e02a39c3afd7a941/chrome/browser/chromeos/smb_client/discovery/in_memory_host_locator_unittest.cc
[modify] https://crrev.com/d927492b95bcfae183359241e02a39c3afd7a941/chrome/browser/chromeos/smb_client/discovery/network_scanner.cc
[modify] https://crrev.com/d927492b95bcfae183359241e02a39c3afd7a941/chrome/browser/chromeos/smb_client/discovery/network_scanner.h
[modify] https://crrev.com/d927492b95bcfae183359241e02a39c3afd7a941/chrome/browser/chromeos/smb_client/discovery/network_scanner_unittest.cc

Project Member

Comment 177 by bugdroid1@chromium.org, Mar 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/072d519850dea414398c1e3dcea4c1ed7b21fa6e

commit 072d519850dea414398c1e3dcea4c1ed7b21fa6e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 23 17:07:48 2018

clean up SmbFileSystem member variables

This change includes some cleanup, removing unused member variables and
removing a reference to a bug that has been fixed.

Bug: chromium:757625, chromium:796334
Change-Id: I6a5901f355050a47aeb59850e34ed463b79b6899
Reviewed-on: https://chromium-review.googlesource.com/978379
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545494}
[modify] https://crrev.com/072d519850dea414398c1e3dcea4c1ed7b21fa6e/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/072d519850dea414398c1e3dcea4c1ed7b21fa6e/chrome/browser/chromeos/smb_client/smb_file_system.h

Project Member

Comment 178 by bugdroid1@chromium.org, Mar 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/917c570c9c94f8170ff5ccc343fc3156c016bbf6

commit 917c570c9c94f8170ff5ccc343fc3156c016bbf6
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Mar 24 00:29:33 2018

smbprovider: Implement GetShares

Implements GetShares method and adds tests

BUG=chromium:757625
TEST=unit tests run
Change-Id: Ie664783174b35bb7ed90f1df2db3e5ec65f73b77
Reviewed-on: https://chromium-review.googlesource.com/959622
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/917c570c9c94f8170ff5ccc343fc3156c016bbf6/smbprovider/smbprovider.cc
[modify] https://crrev.com/917c570c9c94f8170ff5ccc343fc3156c016bbf6/smbprovider/smbprovider_test.cc

Project Member

Comment 179 by bugdroid1@chromium.org, Mar 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ed2beec4890cd24dfef0632f198bca3b7c4bd851

commit ed2beec4890cd24dfef0632f198bca3b7c4bd851
Author: Allen Vicencio <allenvic@chromium.org>
Date: Sat Mar 24 00:29:32 2018

smbprovider: Add template for GetFullPath for GetSharesOptionsProto

This CL adds a template specialization for GetSharesOptionsProto to be
able to parse the path since it does not have a mount associated with
it.

BUG=chromium:757625
TEST=unit tests run
Change-Id: I62b9b2c81982a898f312729b95ad9638748440f7
Reviewed-on: https://chromium-review.googlesource.com/964897
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ed2beec4890cd24dfef0632f198bca3b7c4bd851/smbprovider/smbprovider.cc
[modify] https://crrev.com/ed2beec4890cd24dfef0632f198bca3b7c4bd851/smbprovider/proto.h
[modify] https://crrev.com/ed2beec4890cd24dfef0632f198bca3b7c4bd851/smbprovider/proto.cc

Project Member

Comment 181 by bugdroid1@chromium.org, Mar 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbd6c580c7c31ee43c2530c4575cbca9d2d9e0d4

commit bbd6c580c7c31ee43c2530c4575cbca9d2d9e0d4
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Mar 28 22:45:01 2018

Change NOTIMPLEMENTED to NOTREACHED in SmbFileSystem

Bug: 757625
Change-Id: I5b236d32fb39a3f581e745ea5cfe77a0336bd2dd
Reviewed-on: https://chromium-review.googlesource.com/984407
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546634}
[modify] https://crrev.com/bbd6c580c7c31ee43c2530c4575cbca9d2d9e0d4/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 182 by bugdroid1@chromium.org, Mar 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c66a07a6bacf15c57245475fba73f1eb50f170fd

commit c66a07a6bacf15c57245475fba73f1eb50f170fd
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Mar 29 18:52:01 2018

add SMB Shares settings

This change adds an SMB Shares subpage to the Downloads settings.
If the NativeSmb feature flag is enabled, an SMB Share can be
mounted by providing the url.

Bug: chromium:757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic0b52eeda2247edff8d61b330ecc8a2c755b1bab
Reviewed-on: https://chromium-review.googlesource.com/967160
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546900}
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/app/settings_strings.grdp
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/downloads_page.js
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/smb_browser_proxy.html
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/smb_browser_proxy.js
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/smb_shares_page.html
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/downloads_page/smb_shares_page.js
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
[add] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/ui/webui/settings/chromeos/smb_handler.h
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/c66a07a6bacf15c57245475fba73f1eb50f170fd/chrome/browser/ui/webui/settings/md_settings_ui.cc

Project Member

Comment 183 by bugdroid1@chromium.org, Mar 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b1a35d3e8394df227366b405226c99729f7497c2

commit b1a35d3e8394df227366b405226c99729f7497c2
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Mar 29 20:32:52 2018

smbprovider: Add etc/init/smbproviderd.conf file

This change adds the use of etc/init/smbprovider.conf

BUG=chromium:757625
TEST=emerges and runs locally
CQ-DEPEND=CL:982404

Change-Id: Ibe6812ac8ac0702c70eef23eef27808c112754b9
Reviewed-on: https://chromium-review.googlesource.com/982407
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b1a35d3e8394df227366b405226c99729f7497c2/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 184 by bugdroid1@chromium.org, Mar 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b52adfa13cb76c689a66d5b66f498f6f3e2327d0

commit b52adfa13cb76c689a66d5b66f498f6f3e2327d0
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Mar 29 20:32:52 2018

smbprovider: Change SmbProvider daemon to stop on ui

This change adds the ability for SmbProvider to stop when the ui stops.

BUG=chromium:757625
TEST=Test manually that it stops on logout
CQ-DEPEND=CL:982407

Change-Id: I7ae5d6eeeb1c08465dfab10c08f0f91982143073
Reviewed-on: https://chromium-review.googlesource.com/982404
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b52adfa13cb76c689a66d5b66f498f6f3e2327d0/smbprovider/org.chromium.SmbProvider.service
[rename] https://crrev.com/b52adfa13cb76c689a66d5b66f498f6f3e2327d0/smbprovider/etc/init/smbproviderd.conf

Project Member

Comment 185 by bugdroid1@chromium.org, Mar 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/276a5ec2226be8a17f9646e59785a9c8d6712518

commit 276a5ec2226be8a17f9646e59785a9c8d6712518
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Mar 30 04:59:58 2018

smbprovider: Add const to Proto param for GetFullPath methods

BUG=chromium:757625
TEST=unit tests pass
Change-Id: Ib5e22936ba7ad3b334352da230d1114689839c65
Reviewed-on: https://chromium-review.googlesource.com/978621
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/276a5ec2226be8a17f9646e59785a9c8d6712518/smbprovider/smbprovider.cc
[modify] https://crrev.com/276a5ec2226be8a17f9646e59785a9c8d6712518/smbprovider/smbprovider.h

Project Member

Comment 186 by bugdroid1@chromium.org, Mar 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2a0e53de6c0927de946a810cb607a6253a2b4ed5

commit 2a0e53de6c0927de946a810cb607a6253a2b4ed5
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Mar 30 05:00:10 2018

smbprovider: Use std is_same in SambaInterface

Use std::is_same for SambaInterface when asserting that int and int32_t
is the same size.

BUG=chromium:757625
TEST=unit tests run
Change-Id: I8fdf9bf5699f412390c3a90336d918121114ab77
Reviewed-on: https://chromium-review.googlesource.com/978622
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/2a0e53de6c0927de946a810cb607a6253a2b4ed5/smbprovider/samba_interface.h

Project Member

Comment 187 by bugdroid1@chromium.org, Mar 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d24f67ec1d87dc243a14adba223211b553d70e5f

commit d24f67ec1d87dc243a14adba223211b553d70e5f
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Mar 30 21:12:01 2018

Make Smb mounts writable by default

- Smb Shares mounted via the Settings app will be writable by default.

Bug: 757625
Change-Id: Ie01d34eb36a1bf4799fe905b323c3f554e6318e4
Reviewed-on: https://chromium-review.googlesource.com/988234
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547273}
[modify] https://crrev.com/d24f67ec1d87dc243a14adba223211b553d70e5f/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc

Project Member

Comment 188 by bugdroid1@chromium.org, Mar 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/4725eead59243c3f1476745b58efac394df53eef

commit 4725eead59243c3f1476745b58efac394df53eef
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Mar 31 02:46:42 2018

smbprovider: Add Remount protos

This change adds protos for the Remount method.

TEST=emerges
BUG=chromium:757625
Change-Id: I5afd119c8246d10782926d449abe7f08fb969e2a
Reviewed-on: https://chromium-review.googlesource.com/985412
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/4725eead59243c3f1476745b58efac394df53eef/dbus/smbprovider/dbus-constants.h
[modify] https://crrev.com/4725eead59243c3f1476745b58efac394df53eef/dbus/smbprovider/directory_entry.proto

Project Member

Comment 189 by bugdroid1@chromium.org, Apr 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a53aafc336b1840db5cdacf25b546ec5c17f26

commit b2a53aafc336b1840db5cdacf25b546ec5c17f26
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Apr 02 15:34:00 2018

Clean up SMB classes.

This change does some cleanup of SmbService, SmbFileSystem, and SmbProvider.
These changes include:
- Use AsWeakPtr() for SmbService.
- Add an SmbService::GetSmbProviderClient() helper method.
- Store provider_id_ as a member variable on SmbService.
- Remove provider_id as a parameter from SmbService::Unmount()
  - Remove provider_id from the UnmountCallbacks held by SmbProvider
    and SmbFileSystem

Bug: chromium:757625
Change-Id: Iaec9388b04f8bcd2aa781c654b00268ba0948aa2
Reviewed-on: https://chromium-review.googlesource.com/986629
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547439}
[modify] https://crrev.com/b2a53aafc336b1840db5cdacf25b546ec5c17f26/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/b2a53aafc336b1840db5cdacf25b546ec5c17f26/chrome/browser/chromeos/smb_client/smb_file_system.h
[modify] https://crrev.com/b2a53aafc336b1840db5cdacf25b546ec5c17f26/chrome/browser/chromeos/smb_client/smb_provider.h
[modify] https://crrev.com/b2a53aafc336b1840db5cdacf25b546ec5c17f26/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/b2a53aafc336b1840db5cdacf25b546ec5c17f26/chrome/browser/chromeos/smb_client/smb_service.h

Project Member

Comment 190 by bugdroid1@chromium.org, Apr 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/90ec889dac485186c7742c94fc00d3d04eb7a0af

commit 90ec889dac485186c7742c94fc00d3d04eb7a0af
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Apr 03 23:12:39 2018

smbprovider: Add Remount boilerplate

This change adds boilerplate helper functions to support
SmbProvider::Remount and corresponding tests.

BUG=chromium:757625
TEST=unittests
Change-Id: I8d5591631f8218da7e722b8ca9c1884e15df3d25
Reviewed-on: https://chromium-review.googlesource.com/986939
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/90ec889dac485186c7742c94fc00d3d04eb7a0af/smbprovider/smbprovider_test_helper.h
[modify] https://crrev.com/90ec889dac485186c7742c94fc00d3d04eb7a0af/smbprovider/proto_test.cc
[modify] https://crrev.com/90ec889dac485186c7742c94fc00d3d04eb7a0af/smbprovider/proto.h
[modify] https://crrev.com/90ec889dac485186c7742c94fc00d3d04eb7a0af/smbprovider/proto.cc
[modify] https://crrev.com/90ec889dac485186c7742c94fc00d3d04eb7a0af/smbprovider/smbprovider_test_helper.cc

Project Member

Comment 191 by bugdroid1@chromium.org, Apr 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/436af0af61418ce9e1cd831d52e4cbb0fab24501

commit 436af0af61418ce9e1cd831d52e4cbb0fab24501
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Apr 04 04:40:52 2018

smbprovider: Add Remount to D-Bus

This change adds Remount to D-Bus and adds a stub
implementation of the method in SmbProvider.

BUG=chromium:757625
TEST=emerges
Change-Id: Ic7947637b7f74f347f6a8eaf7922a023ed919813
Reviewed-on: https://chromium-review.googlesource.com/982420
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/436af0af61418ce9e1cd831d52e4cbb0fab24501/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[modify] https://crrev.com/436af0af61418ce9e1cd831d52e4cbb0fab24501/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/436af0af61418ce9e1cd831d52e4cbb0fab24501/smbprovider/smbprovider.h
[modify] https://crrev.com/436af0af61418ce9e1cd831d52e4cbb0fab24501/smbprovider/smbprovider.cc

Project Member

Comment 192 by bugdroid1@chromium.org, Apr 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6573295f56c6cc83ecdbdb1f4cc4b7ac64882775

commit 6573295f56c6cc83ecdbdb1f4cc4b7ac64882775
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Apr 04 18:25:27 2018

Add overloaded GetProvidedFileSystemInfoList function.

This change adds an overloaded GetProvidedFileSystemInfoList() method
that takes a ProviderId as a parameter, and returns a vector containing
only FileSystemInfo entries for a specific Provider.

This change also modifies the FileSystemProvider API to use this new
function to reduce code duplication.

Bug: chromium:757625
Change-Id: I5426f6768f12a3347aa8b196d2c1804b4f1ed01d
Reviewed-on: https://chromium-review.googlesource.com/986943
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548134}
[modify] https://crrev.com/6573295f56c6cc83ecdbdb1f4cc4b7ac64882775/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
[modify] https://crrev.com/6573295f56c6cc83ecdbdb1f4cc4b7ac64882775/chrome/browser/chromeos/file_system_provider/service.cc
[modify] https://crrev.com/6573295f56c6cc83ecdbdb1f4cc4b7ac64882775/chrome/browser/chromeos/file_system_provider/service.h

Project Member

Comment 193 by bugdroid1@chromium.org, Apr 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e37faa165f6dff8805a091ec78db0bb31457ff8b

commit e37faa165f6dff8805a091ec78db0bb31457ff8b
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Apr 04 19:50:45 2018

Add Remount to SmbProviderClient

This change implements Remount on SmbProviderClient which calls Remount
on the SmbProvider Daemon via D-Bus.

Bug: 757625
Change-Id: I11b419863996e6bba685f14136e54d65db007d0a
Reviewed-on: https://chromium-review.googlesource.com/987199
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548165}
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/smb_provider_client.h

Project Member

Comment 194 by bugdroid1@chromium.org, Apr 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e37faa165f6dff8805a091ec78db0bb31457ff8b

commit e37faa165f6dff8805a091ec78db0bb31457ff8b
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Apr 04 19:50:45 2018

Add Remount to SmbProviderClient

This change implements Remount on SmbProviderClient which calls Remount
on the SmbProvider Daemon via D-Bus.

Bug: 757625
Change-Id: I11b419863996e6bba685f14136e54d65db007d0a
Reviewed-on: https://chromium-review.googlesource.com/987199
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548165}
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/e37faa165f6dff8805a091ec78db0bb31457ff8b/chromeos/dbus/smb_provider_client.h

Project Member

Comment 195 by bugdroid1@chromium.org, Apr 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cdd0d3a121a8fb6708397520e3c26a47ae18bb84

commit cdd0d3a121a8fb6708397520e3c26a47ae18bb84
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Apr 05 01:52:10 2018

smbprovider: Add MountManager::Remount function

This change adds a Remount() function to MountManager
and corresponding tests.

BUG=chromium:757625
TEST=unittests
Change-Id: Ifa9dc22cd6ac99ba82d3b7775b48b28f8cd62da8
Reviewed-on: https://chromium-review.googlesource.com/982411
Commit-Ready: Bailey Berro <baileyberro@chromium.org>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/cdd0d3a121a8fb6708397520e3c26a47ae18bb84/smbprovider/mount_manager.cc
[modify] https://crrev.com/cdd0d3a121a8fb6708397520e3c26a47ae18bb84/smbprovider/mount_manager.h
[modify] https://crrev.com/cdd0d3a121a8fb6708397520e3c26a47ae18bb84/smbprovider/mount_manager_test.cc

Project Member

Comment 196 by bugdroid1@chromium.org, Apr 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/712bdd0115e01376a4dd6e0444778cba33ff5d10

commit 712bdd0115e01376a4dd6e0444778cba33ff5d10
Author: Bailey Berro <baileyberro@chromium.org>
Date: Sat Apr 07 05:00:16 2018

smbprovider: Implement Smbprovider::Remount

This change implements the Remount function on SmbProvider. Remount
will be called by SmbService when restoring file systems.

BUG=chromium:757625
TEST=unittests
Change-Id: I0fe73302c2cdcea264cf8913f9131a577bad11bf
Reviewed-on: https://chromium-review.googlesource.com/982892
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/712bdd0115e01376a4dd6e0444778cba33ff5d10/smbprovider/smbprovider.cc
[modify] https://crrev.com/712bdd0115e01376a4dd6e0444778cba33ff5d10/smbprovider/smbprovider_test.cc

Project Member

Comment 197 by bugdroid1@chromium.org, Apr 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3ebe59d8c8b80d80ab417343e7d904ff1aa90ef3

commit 3ebe59d8c8b80d80ab417343e7d904ff1aa90ef3
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Apr 12 01:09:05 2018

smbprovider: Add seccomp filters

BUG=chromium:757625
TEST=Tested starting with minijail and upstart

Change-Id: I8a8e40d7a370790a173cbb3ac528277fcf1118fb
Reviewed-on: https://chromium-review.googlesource.com/998679
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/3ebe59d8c8b80d80ab417343e7d904ff1aa90ef3/smbprovider/seccomp_filters/smbprovider-seccomp-amd64.policy
[modify] https://crrev.com/3ebe59d8c8b80d80ab417343e7d904ff1aa90ef3/smbprovider/etc/init/smbproviderd.conf

Project Member

Comment 198 by bugdroid1@chromium.org, Apr 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/6936bec1989d4f6a15cccc7cd9fd658aded84fb9

commit 6936bec1989d4f6a15cccc7cd9fd658aded84fb9
Author: Allen Vicencio <allenvic@google.com>
Date: Thu Apr 12 01:08:28 2018

smbprovider: Add auth params for MountOptionsProto

Adds workgroup and username for MountOptionsProto.

BUG=chromium:757625
TEST=emerges
Change-Id: I3aa02847dc882107cfa38eace977c51f92a41a61
Reviewed-on: https://chromium-review.googlesource.com/981048
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/6936bec1989d4f6a15cccc7cd9fd658aded84fb9/dbus/smbprovider/directory_entry.proto

Project Member

Comment 199 by bugdroid1@chromium.org, Apr 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5c2a1bc86542b586015deca52a67edd3ebc0a934

commit 5c2a1bc86542b586015deca52a67edd3ebc0a934
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Apr 12 03:28:06 2018

smbprovider: Change ebuild to add seccomp policy

Adds seccomp smbprovider-seccomp.policy to policies

BUG=chromium:757625
TEST=emerges
CQ-DEPEND=CL:998679

Change-Id: I4a036588e2303873f49bc8b99a9016c4e7ba9c40
Reviewed-on: https://chromium-review.googlesource.com/998686
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/5c2a1bc86542b586015deca52a67edd3ebc0a934/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 200 by bugdroid1@chromium.org, Apr 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0d0c6453fb4dacd80478122f0998d95e93e52546

commit 0d0c6453fb4dacd80478122f0998d95e93e52546
Author: Allen Vicencio <allenvic@chromium.org>
Date: Thu Apr 12 22:22:30 2018

smbprovider: Add libpasswordprovider dependency

BUG=chromium:757625
TEST=emerges

Change-Id: Icdc58baa75494600ba63cad6c2aff601714d5267
Reviewed-on: https://chromium-review.googlesource.com/993709
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/0d0c6453fb4dacd80478122f0998d95e93e52546/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 201 by bugdroid1@chromium.org, Apr 13 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3de72e6b47c2b301610af0c691ab59052c99f468

commit 3de72e6b47c2b301610af0c691ab59052c99f468
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Apr 13 06:10:59 2018

smbprovider: Add arguments to ioctl seccomp filter

Adding more arguments that gets passed to ioctl during runtime

BUG=chromium:757625
TEST=runs and doesnt crash after 10 minutes
Change-Id: Icaef3713f082e835af0fa5860f7ea64b6c40e1f4
Reviewed-on: https://chromium-review.googlesource.com/1011542
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/3de72e6b47c2b301610af0c691ab59052c99f468/smbprovider/seccomp_filters/smbprovider-seccomp-amd64.policy

Project Member

Comment 202 by bugdroid1@chromium.org, Apr 13 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e9a1ea294dec6f015ac51bfb3651da574b000ed8

commit e9a1ea294dec6f015ac51bfb3651da574b000ed8
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Apr 13 06:10:58 2018

smbprovider: Add CredentialStore interface

Adds CredentialStore which holds all credential info for a given mount

BUG=chromium:757625
TEST=unit tests run

Change-Id: I0c68b3da34b5806889ea6eb45e4fc6fe7b4aefcb
Reviewed-on: https://chromium-review.googlesource.com/999033
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/e9a1ea294dec6f015ac51bfb3651da574b000ed8/smbprovider/credential_store.cc
[add] https://crrev.com/e9a1ea294dec6f015ac51bfb3651da574b000ed8/smbprovider/credential_store.h
[modify] https://crrev.com/e9a1ea294dec6f015ac51bfb3651da574b000ed8/smbprovider/smbprovider.gyp

Project Member

Comment 203 by bugdroid1@chromium.org, Apr 13 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e

commit 79ca7eb8e23d3d3127aa2c169bc096e956b3b41e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Apr 13 16:24:34 2018

Make SMB file_system_id compound

- Creates a helper class that manages the creation and parsing of
a compound file_system_id.
- Switches to these functions.

Bug: chromium:757625
Change-Id: I611cfdf213da104f1dc63ce7ba442298bd362f41
Reviewed-on: https://chromium-review.googlesource.com/990580
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550635}
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system.cc
[add] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system_id.cc
[add] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system_id.h
[add] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system_id_test.cc
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_service.h

Project Member

Comment 204 by bugdroid1@chromium.org, Apr 13 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bff3dd53a35e7b03ed4a086a5d78254359be85e

commit 8bff3dd53a35e7b03ed4a086a5d78254359be85e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Apr 13 17:27:56 2018

Implement Remount on SmbService

- Creates a RestoreMounts() function that gets the remembered file systems
from the FSP service and then attempts to remount them. Any shares that fail
to remount will be unmounted from FSP so they are not remounted again.
- Logs when an attempted remount fails.

Bug: chromium:757625
Change-Id: Id7edf64150ddde1df912c8cc733dc2c834b42797
Reviewed-on: https://chromium-review.googlesource.com/990581
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550667}
[modify] https://crrev.com/8bff3dd53a35e7b03ed4a086a5d78254359be85e/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/8bff3dd53a35e7b03ed4a086a5d78254359be85e/chrome/browser/chromeos/smb_client/smb_service.h

Project Member

Comment 205 by bugdroid1@chromium.org, Apr 16 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea11e5eabdf35e9e402ee189db2a6a4f9e423421

commit ea11e5eabdf35e9e402ee189db2a6a4f9e423421
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Apr 16 18:12:16 2018

Add Native Network File Share to metrics

Adds "Native Network File Share (SMB)" as the name for "@smb" provider id in metrics.

Bug: chromium:757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic99300e66d9e0007a8946661a4a24a4cfc9d1b4c
Reviewed-on: https://chromium-review.googlesource.com/1011242
Reviewed-by: Steve McKay <smckay@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551040}
[modify] https://crrev.com/ea11e5eabdf35e9e402ee189db2a6a4f9e423421/ui/file_manager/file_manager/common/js/metrics_events.js

Project Member

Comment 206 by bugdroid1@chromium.org, Apr 16 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1

commit b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Apr 16 18:25:44 2018

Return success in WriteFile when writing from an empty buffer.

Changes WriteFile to return without calling D-Bus when attempting to write from an empty buffer.

Bug: chromium:757625
Change-Id: I386a571347ccf84785147ae91edea515b84a507a
Reviewed-on: https://chromium-review.googlesource.com/1005776
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551047}
[modify] https://crrev.com/b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 207 by bugdroid1@chromium.org, Apr 17 (2 days ago)

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e

commit 79ca7eb8e23d3d3127aa2c169bc096e956b3b41e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Apr 13 16:24:34 2018

Make SMB file_system_id compound

- Creates a helper class that manages the creation and parsing of
a compound file_system_id.
- Switches to these functions.

Bug: chromium:757625
Change-Id: I611cfdf213da104f1dc63ce7ba442298bd362f41
Reviewed-on: https://chromium-review.googlesource.com/990580
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550635}
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system.cc
[add] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system_id.cc
[add] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system_id.h
[add] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_file_system_id_test.cc
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/79ca7eb8e23d3d3127aa2c169bc096e956b3b41e/chrome/browser/chromeos/smb_client/smb_service.h

Project Member

Comment 208 by bugdroid1@chromium.org, Apr 17 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bff3dd53a35e7b03ed4a086a5d78254359be85e

commit 8bff3dd53a35e7b03ed4a086a5d78254359be85e
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Apr 13 17:27:56 2018

Implement Remount on SmbService

- Creates a RestoreMounts() function that gets the remembered file systems
from the FSP service and then attempts to remount them. Any shares that fail
to remount will be unmounted from FSP so they are not remounted again.
- Logs when an attempted remount fails.

Bug: chromium:757625
Change-Id: Id7edf64150ddde1df912c8cc733dc2c834b42797
Reviewed-on: https://chromium-review.googlesource.com/990581
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550667}
[modify] https://crrev.com/8bff3dd53a35e7b03ed4a086a5d78254359be85e/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/8bff3dd53a35e7b03ed4a086a5d78254359be85e/chrome/browser/chromeos/smb_client/smb_service.h

Project Member

Comment 209 by bugdroid1@chromium.org, Apr 17 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea11e5eabdf35e9e402ee189db2a6a4f9e423421

commit ea11e5eabdf35e9e402ee189db2a6a4f9e423421
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Apr 16 18:12:16 2018

Add Native Network File Share to metrics

Adds "Native Network File Share (SMB)" as the name for "@smb" provider id in metrics.

Bug: chromium:757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic99300e66d9e0007a8946661a4a24a4cfc9d1b4c
Reviewed-on: https://chromium-review.googlesource.com/1011242
Reviewed-by: Steve McKay <smckay@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551040}
[modify] https://crrev.com/ea11e5eabdf35e9e402ee189db2a6a4f9e423421/ui/file_manager/file_manager/common/js/metrics_events.js

Project Member

Comment 210 by bugdroid1@chromium.org, Apr 17 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1

commit b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Apr 16 18:25:44 2018

Return success in WriteFile when writing from an empty buffer.

Changes WriteFile to return without calling D-Bus when attempting to write from an empty buffer.

Bug: chromium:757625
Change-Id: I386a571347ccf84785147ae91edea515b84a507a
Reviewed-on: https://chromium-review.googlesource.com/1005776
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551047}
[modify] https://crrev.com/b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1/chrome/browser/chromeos/smb_client/smb_file_system.cc

Project Member

Comment 211 by bugdroid1@chromium.org, Yesterday (26 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c22d15995311d8e7b4fd1808cd320cdb53eaede2

commit c22d15995311d8e7b4fd1808cd320cdb53eaede2
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Apr 18 21:02:12 2018

smbprovider: Add libpasswordprovider to cros_workon_subtree

Adds libpasswordprovider to cros_workon_subtree to ensure that no
sandbox violation occurs when compiling the package. This is temporary
and will be reverted once crbug.com/833675 is fixed

BUG=chromium:757625
TEST=emerges without access violations
Change-Id: Ic5d5fae7f54ea501b89fd767617465fe6d91f8f3
Reviewed-on: https://chromium-review.googlesource.com/1015655
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/c22d15995311d8e7b4fd1808cd320cdb53eaede2/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member

Comment 212 by bugdroid1@chromium.org, Yesterday (26 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3612c3d26dc019dc51755acb6ddb5268317d9597

commit 3612c3d26dc019dc51755acb6ddb5268317d9597
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Apr 18 21:02:10 2018

smbprovider: Release FD when writing to temp file

Releases the file descriptor that is held by ScopedFD when writing to
temp file, instead of just getting it.

BUG=chromium:757625
TEST=manual test of readfile

Change-Id: I229124c7bb54bc90ffe517aa48194f484997781b
Reviewed-on: https://chromium-review.googlesource.com/1014333
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/3612c3d26dc019dc51755acb6ddb5268317d9597/smbprovider/smbprovider.cc

Sign in to add a comment