New issue
Advanced search Search tips
Starred by 3 users
Status: Untriaged
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment
Add smbclientd package to Chrome OS
Project Member Reported by allenvic@chromium.org, Aug 21 Back to list
Description:

Add smbclientd to act as a DBus daemon server

 
Owner: allenvic@chromium.org
Project Member Comment 2 by bugdroid1@chromium.org, Nov 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/5fc40ab72e45c14f5d98b3b2498224079b574ebb

commit 5fc40ab72e45c14f5d98b3b2498224079b574ebb
Author: Allen Vicencio <allenvic@google.com>
Date: Thu Nov 02 18:07:14 2017

system_api: Add smbprovider D-Bus-constants and protobufs

Add dbus-constants file and DirectoryEntry and DirectoryEntryList protobufs.

BUG=chromium:757625
TEST=Runs locally
Change-Id: I80335bc7a1f2f941905914acb9890a9f5304de81
Reviewed-on: https://chromium-review.googlesource.com/738937
Commit-Ready: Zentaro Kavanagh <zentaro@google.com>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/dbus/smbprovider/dbus-constants.h
[add] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/dbus/smbprovider/directory_entry.proto
[modify] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/dbus/service_constants.h
[modify] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/system_api.gyp
[modify] https://crrev.com/5fc40ab72e45c14f5d98b3b2498224079b574ebb/system_api.pc

Project Member Comment 3 by bugdroid1@chromium.org, Nov 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/5937e923c30d23c51cbec2bed999d847e800b7f4

commit 5937e923c30d23c51cbec2bed999d847e800b7f4
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 07 14:00:18 2017

system_api: Add smbprovider ErrorType enum

Add enum ErrorType that match ProvidedError on Chromium.

BUG=chromium:757625
TEST=runs locally
Change-Id: Ic641a3dccd48a0e3bdfc5da52ace381d238acca3
Reviewed-on: https://chromium-review.googlesource.com/744992
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@google.com>

[modify] https://crrev.com/5937e923c30d23c51cbec2bed999d847e800b7f4/dbus/smbprovider/directory_entry.proto

Project Member Comment 4 by bugdroid1@chromium.org, Nov 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b

commit ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 07 17:25:56 2017

smbprovider: Add ebuild, USE mask flag, and system_api change

Add smbprovider ebuild, USE flag for arm, and also dependency in the
Chrome ebuild. Also add system_api ebuild change

BUG=chromium:757625
TEST=emerges on eve
CQ-DEPEND=CL:625074

Change-Id: I3cd1f8cf15cecf9ed23dbffdfe396cb8cd452fbf
Reviewed-on: https://chromium-review.googlesource.com/745102
Commit-Ready: Zentaro Kavanagh <zentaro@google.com>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/profiles/arch/arm/package.use.mask
[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/chromeos-chrome/metadata.xml
[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/system_api/system_api-9999.ebuild
[modify] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[add] https://crrev.com/ab2e5d0e27190f0d7b31339e89c6f6fe2261df2b/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member Comment 5 by bugdroid1@chromium.org, Nov 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/37015a3425f89da75cd49038326f990f090f75e2

commit 37015a3425f89da75cd49038326f990f090f75e2
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 07 17:25:56 2017

smbprovider: Implement DBus service for smbprovider with read-only
navigation

Initial CL for SmbProvider that implements the DBus service and contains
Mount, Unmount, ReadDirectory, and GetMetadata. This will be the first
of the CLs that will provide read-only navigation of an SMB share.

BUG=chromium:757625
TEST=Daemon runs, unit tests run fine
CQ-DEPEND=CL:744992
Change-Id: I799651470146d7be3ec3b31a343639a1debf700e
Reviewed-on: https://chromium-review.googlesource.com/625074
Commit-Ready: Zentaro Kavanagh <zentaro@google.com>
Tested-by: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@google.com>

[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/samba_interface_impl.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider.gyp
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/constants.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_test.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_helper.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/OWNERS
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_helper_test.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_main.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/fake_samba_interface.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/dbus_bindings/dbus-service-config.json
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/constants.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/fake_samba_interface.h
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/smbprovider_helper.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/README.md
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/samba_interface_impl.cc
[add] https://crrev.com/37015a3425f89da75cd49038326f990f090f75e2/smbprovider/samba_interface.h

Project Member Comment 6 by bugdroid1@chromium.org, Nov 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/1a6e64d708d5a6b1ca64265310230a27deef6ae9

commit 1a6e64d708d5a6b1ca64265310230a27deef6ae9
Author: Allen Vicencio <allenvic@google.com>
Date: Tue Nov 21 02:13:42 2017

system_api: Add Smbprovider Mount and Unmount protobuf

Add MountOptions and UnmountOptions protobuf.

BUG=chromium:757625
TEST=runs locally

Change-Id: I56b2f8f9e752883d42fc73ada52f1204ba31c872
Reviewed-on: https://chromium-review.googlesource.com/757869
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/1a6e64d708d5a6b1ca64265310230a27deef6ae9/dbus/smbprovider/directory_entry.proto

Project Member Comment 7 by bugdroid1@chromium.org, Nov 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/619471e97b6197290448c268f9d51974a9ac193f

commit 619471e97b6197290448c268f9d51974a9ac193f
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Nov 22 05:36:21 2017

smbprovider: Change Mount and Unmount to use protobuf

Using MountOptions and UnmountOptions protobuf.

BUG=chromium:757625
TEST=tested with local chrome client
CQ-DEPEND=CL:757869

Change-Id: I1153931b96e9c3b6864ded838ffac23341bc8199
Reviewed-on: https://chromium-review.googlesource.com/757983
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider.h
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider.cc
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider_helper.h
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/619471e97b6197290448c268f9d51974a9ac193f/smbprovider/smbprovider_helper_test.cc

Project Member Comment 8 by bugdroid1@chromium.org, Nov 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/7d909c89b4178ca17bf091ed3dd738f2207cf626

commit 7d909c89b4178ca17bf091ed3dd738f2207cf626
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Nov 22 05:36:17 2017

smbprovider: Added user and group id for smbprovider

BUG=chromium:757625
TEST=emerges on cave

Change-Id: I4627fcd1ce4b50dec48c7ae3a659b2cca59e0e4c
Reviewed-on: https://chromium-review.googlesource.com/760179
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[add] https://crrev.com/7d909c89b4178ca17bf091ed3dd738f2207cf626/profiles/base/accounts/group/smbproviderd
[add] https://crrev.com/7d909c89b4178ca17bf091ed3dd738f2207cf626/profiles/base/accounts/user/smbproviderd

Project Member Comment 9 by bugdroid1@chromium.org, Nov 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6397da22ea826f692c67867ff6d097b8d84b928

commit b6397da22ea826f692c67867ff6d097b8d84b928
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Nov 22 17:12:28 2017

Roll src/third_party/cros_system_api/ 5fc40ab72..e46ef54fe (8 commits)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5fc40ab72e45..e46ef54fea48

$ git log 5fc40ab72..e46ef54fe --date=short --no-merges --format='%ad %ae %s'
2017-11-20 cernekee system_api: shill: Add constants for EAP.TLSVersionMax property
2017-11-14 akahuang hammerd: Add DBus signal to notify UI the base needs update.
2017-11-07 allenvic system_api: Add Smbprovider Mount and Unmount protobuf
2017-11-10 ejcaruso modemfwd_switches: reflect new interface
2017-11-15 benchan system_api: update OWNERS
2017-11-15 agawronska Add constant for EnumerateDevices method.
2017-10-30 allenvic system_api: Add smbprovider ErrorType enum
2017-11-03 matthewmwang system_api: adding constant for OpenVPN.TLSVersionMin support

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 757625
Change-Id: I18bd704fe108e84c59972a85f0576398b3e5345a
Reviewed-on: https://chromium-review.googlesource.com/782708
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518662}
[modify] https://crrev.com/b6397da22ea826f692c67867ff6d097b8d84b928/DEPS

Project Member Comment 10 by bugdroid1@chromium.org, Nov 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0245710f8469989985d2f02fa3d408249aa72e53

commit 0245710f8469989985d2f02fa3d408249aa72e53
Author: Allen Vicencio <allenvic@chromium.org>
Date: Tue Nov 28 01:20:20 2017

smbprovider: Add SmbProviderClient

Add Mount and Unmount.

CQ-DEPEND=CL:782708

Bug: chromium:757625
Change-Id: Idbc9ccc80da7872317f3a0bd05b72447e09de1d0
Reviewed-on: https://chromium-review.googlesource.com/745304
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519507}
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/BUILD.gn
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_clients_browser.cc
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_clients_browser.h
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/dbus_thread_manager.h
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/fake_smb_provider_client.cc
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/fake_smb_provider_client.h
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/smb_provider_client.cc
[add] https://crrev.com/0245710f8469989985d2f02fa3d408249aa72e53/chromeos/dbus/smb_provider_client.h

Project Member Comment 11 by bugdroid1@chromium.org, Nov 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/e02e3da4841e85c69bc9f3ea2b758a65d78b341e

commit e02e3da4841e85c69bc9f3ea2b758a65d78b341e
Author: Allen Vicencio <allenvic@google.com>
Date: Wed Nov 29 04:17:02 2017

smbprovider: Add ReadDirectoryOptions and GetMetadataEntryOptions

Adds protobufs for ReadDirectory and GetMetadataEntry inputs.

BUG=chromium:757625
TEST=runs locally

Change-Id: Ia59d17229355255d41a0ec0a3e04140a32e85d85
Reviewed-on: https://chromium-review.googlesource.com/792599
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/e02e3da4841e85c69bc9f3ea2b758a65d78b341e/dbus/smbprovider/directory_entry.proto

Project Member Comment 13 by bugdroid1@chromium.org, Dec 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9846cdf7720460d33c77cd2f90446153d1fb86f4

commit 9846cdf7720460d33c77cd2f90446153d1fb86f4
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 06 04:22:44 2017

smbprovider: Change smbprovider to use by default

Changes smbprovider flag to be on by default.

BUG=chromium:757625
TEST=builds with build_packages

Change-Id: Id0e01fb5855e68f1ce2bd645ab4869a1a5db7438
Reviewed-on: https://chromium-review.googlesource.com/802376
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9846cdf7720460d33c77cd2f90446153d1fb86f4/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

i *think* this is causing asan failures.  presumably, we weren't
running smbprovider unit tests through asan until we turned it on.

https://uberchromegw.corp.google.com/i/chromiumos/builders/amd64-generic-asan/builds/22269

Comment 15 by zentaro@chromium.org, Dec 7 (6 days ago)
Looks like it. Looking into it.
Comment 16 by allenvic@google.com, Dec 7 (6 days ago)
I talked to Caveh@ last night and I sent in a rollback CL here while I take a look at it more closely:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/812434
Project Member Comment 17 by bugdroid1@chromium.org, Dec 8 (5 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3df1821504a2146e7001aff49cbf069b94237c88

commit 3df1821504a2146e7001aff49cbf069b94237c88
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:08 2017

smbprovider: Change ebuild and add dbus service activation with minijail

Add jailed binary and /usr/share/dbus-1/system-services to ebuild.

BUG=chromium:757625
TEST=builds locally
CQ-DEPEND=CL:783559

Change-Id: I6baa7211a8d4a2b6099b280c5972cde36a8257e9
Reviewed-on: https://chromium-review.googlesource.com/783521
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/3df1821504a2146e7001aff49cbf069b94237c88/chromeos-base/smbprovider/smbprovider-9999.ebuild

Project Member Comment 18 by bugdroid1@chromium.org, Dec 8 (5 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2238c7d178090d995bc5441fcc8047f148d41d61

commit 2238c7d178090d995bc5441fcc8047f148d41d61
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:07 2017

smbprovider: Add .service file for DBus service activation with minijail

Add .service file for DBus service activation and run smbproviderd using
minijail

BUG=chromium:757625
TEST=builds locally

Change-Id: I1e492c0bd64ed0e33e31f6ccb865eaf0fcdbb29e
Reviewed-on: https://chromium-review.googlesource.com/783559
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/2238c7d178090d995bc5441fcc8047f148d41d61/smbprovider/org.chromium.SmbProvider.service
[add] https://crrev.com/2238c7d178090d995bc5441fcc8047f148d41d61/smbprovider/smbproviderd-jailed.sh

Project Member Comment 19 by bugdroid1@chromium.org, Dec 8 (5 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c83089a8af9156802a21cc034f0388250fcba2f9

commit c83089a8af9156802a21cc034f0388250fcba2f9
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:08 2017

smbprovider: Add smb.conf file

Adds smb.conf file to disable use of SMB1 protocol.

BUG=chromium:757625
TEST=Can connect to local share configured to SMB2 protocol
CQ-DEPEND=CL:783559

Change-Id: Ib4159717edc406a033f5cbb56283e2b50f982807
Reviewed-on: https://chromium-review.googlesource.com/809611
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/c83089a8af9156802a21cc034f0388250fcba2f9/smbprovider/smbprovider_main.cc
[modify] https://crrev.com/c83089a8af9156802a21cc034f0388250fcba2f9/smbprovider/constants.cc
[modify] https://crrev.com/c83089a8af9156802a21cc034f0388250fcba2f9/smbprovider/constants.h

Project Member Comment 20 by bugdroid1@chromium.org, Dec 8 (5 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1cead9196e12dd000dbd93e5b2eb139f5d665d97

commit 1cead9196e12dd000dbd93e5b2eb139f5d665d97
Author: Allen Vicencio <allenvic@chromium.org>
Date: Fri Dec 08 11:59:13 2017

smbprovider: Fix for ASAN failure

Fixes misaligned type for ASAN failure in smbprovider.

BUG=chromium:757625
TEST=trybot

Change-Id: I1cca29e29a3e3e41b9021a78412c18202f46a4dd
Reviewed-on: https://chromium-review.googlesource.com/814578
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/1cead9196e12dd000dbd93e5b2eb139f5d665d97/smbprovider/smbprovider_helper.cc

Project Member Comment 21 by bugdroid1@chromium.org, Dec 11 (2 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37515d3dc46eba641c0b4704a4c9dd8275aaa629

commit 37515d3dc46eba641c0b4704a4c9dd8275aaa629
Author: Allen Vicencio <allenvic@chromium.org>
Date: Mon Dec 11 23:55:10 2017

smbprovider: Add ReadDirectory and GetMetadataEntry

Add ReadDirectory and GetMetadataEntry methods for SmbProviderClient.
This allows read-only navigation of the share, excluding reading files.

Bug:chromium:757625
CQ-DEPEND=CL:794892

Change-Id: I55d4baa6dec95392774cdea3c07c13989b31e782
Reviewed-on: https://chromium-review.googlesource.com/749897
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523259}
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chrome/browser/chromeos/smb_client/smb_service.h
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/fake_smb_provider_client.cc
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/smb_provider_client.cc
[modify] https://crrev.com/37515d3dc46eba641c0b4704a4c9dd8275aaa629/chromeos/dbus/smb_provider_client.h

Project Member Comment 22 by bugdroid1@chromium.org, Yesterday (31 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/078707c7eaef2f629b5f0bc52d84655b4c3d65b6

commit 078707c7eaef2f629b5f0bc52d84655b4c3d65b6
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 00:21:36 2017

smbprovider: Change ReadDirectory and GetMetadataEntry to accept protobuf

Changes ReadDirectory and GetMetadataEntry to use ReadDirectoryOptions
and GetMetadataEntryOptions protobuf since protobufs are easier to
modify going forward.

BUG=chromium:757625
TEST=Unit tests run.
CQ-DEPEND=CL:763608

Change-Id: Ib2d7b20e57db51eb7f248b90c6fd2b9e8458e774
Reviewed-on: https://chromium-review.googlesource.com/794892
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/smbprovider.cc
[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml
[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/smbprovider_test.cc
[modify] https://crrev.com/078707c7eaef2f629b5f0bc52d84655b4c3d65b6/smbprovider/smbprovider.h

Project Member Comment 23 by bugdroid1@chromium.org, Today (12 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d432b68cccde0733cea267761890dc9bde2c07c0

commit d432b68cccde0733cea267761890dc9bde2c07c0
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 18:55:57 2017

SmbProviderClient: Change mount id to start at 0

Change SmbProviderClient to expect mount_id to start at 0.

CQ-DEPEND=CL:823086

Bug: chromium:757625
Change-Id: I55a13a0e15bf887176825e60c7297827fb45a017
Reviewed-on: https://chromium-review.googlesource.com/823270
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523837}
[modify] https://crrev.com/d432b68cccde0733cea267761890dc9bde2c07c0/chrome/browser/chromeos/smb_client/smb_service.cc
[modify] https://crrev.com/d432b68cccde0733cea267761890dc9bde2c07c0/chromeos/dbus/smb_provider_client.cc

Project Member Comment 24 by bugdroid1@chromium.org, Today (8 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ac418fd57126684b34bf09bad527814936d816a2

commit ac418fd57126684b34bf09bad527814936d816a2
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 22:58:21 2017

smbprovider: Change mount ids to start at 0

Changes mount_id to start at 0 instead of 1.

BUG=chromium:757625
TEST=unit tests run.

Change-Id: I2a53f0faede38ae3d50dc4a4eec26042022fa78e
Reviewed-on: https://chromium-review.googlesource.com/823086
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/ac418fd57126684b34bf09bad527814936d816a2/smbprovider/smbprovider.cc
[modify] https://crrev.com/ac418fd57126684b34bf09bad527814936d816a2/smbprovider/smbprovider_test.cc

Project Member Comment 25 by bugdroid1@chromium.org, Today (8 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5677aabd65950a3ba0eee7636ca942e19dc45a29

commit 5677aabd65950a3ba0eee7636ca942e19dc45a29
Author: Allen Vicencio <allenvic@chromium.org>
Date: Wed Dec 13 22:58:20 2017

smbprovider: Refactor LogAndSetError

Refactor LogAndSetError calls to use constants instead of string
literals. Also add a helper method to log dbus errors.

BUG=chromium:757625
TEST=Unit tests run.

Change-Id: I5b7a08e82b58093e29c9432193ec13214de8b9c8
Reviewed-on: https://chromium-review.googlesource.com/823565
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/5677aabd65950a3ba0eee7636ca942e19dc45a29/smbprovider/smbprovider.cc

Sign in to add a comment