New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757622 link

Starred by 2 users
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: Aug 2017
Cc:
xhw...@chromium.org
ddorwin@chromium.org
█ joeyparrish@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

MediaKeySession attribute closed does not match the EME spec

Project Member Reported by jrumm...@chromium.org, Aug 21 2017 
In running the W3C EME tests [1], Chrome reports a failure in the test "MediaKeySession interface: attribute closed".

The latest EME spec [2] has attribute closed defined as Promise<void>. However, the IDL for MediaKeySession [3] simply has
    [CallWith=ScriptState] readonly attribute Promise closed;

The Chromium IDL should be updated to match the spec.


[1] https://w3c-test.org/encrypted-media/idlharness.html
[2] http://w3c.github.io/encrypted-media/#mediakeysession-interface
[3] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.idl
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be46659f3909c9c483330cbbe91e56cbfc428796

commit be46659f3909c9c483330cbbe91e56cbfc428796
Author: John Rummell <jrummell@chromium.org>
Date: Wed Aug 23 20:31:28 2017

Change MediaKeySession attribute closed to match EME spec

There is no change to the implementation as the promise doesn't provide
any value when it resolves successfully.

BUG= 757622 
TEST=EME layout tests pass

Change-Id: I20018f9f06cbf22a321a4ce249a7f616a5d98d0e
Reviewed-on: https://chromium-review.googlesource.com/626996
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496793}
[modify] https://crrev.com/be46659f3909c9c483330cbbe91e56cbfc428796/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.idl

Comment 2 by jrumm...@chromium.org, Aug 25 2017

Status: Fixed (was: Assigned)
Fixed. However, the W3C IDL tests still fail due to  issue 758023 .
►

Sign in to add a comment