Issue metadata
Sign in to add a comment
|
Updating cl description should not send an email |
||||||||||||||||||||||
Issue descriptionAffected Version: What steps will reproduce the problem? $ git cl description ... edit the description and save .. What is the expected output? No new email is sent. What do you see instead? A new email is sent. Please provide any additional information below. Uploading a new patchset doesn't send an email, so it follows naturally that updating the description shoulnd't send an email (which has the side effect of triggering code reviews)
,
Aug 21 2017
This isn't issue 5291, this has to do with using chromium's custom command line tool to edit commit messages, not PolyGerrit.
,
Aug 21 2017
Moving to chromium project, as there are actually two issues on their end. The first issue is I don't think git cl description signals its intent to suppress notification to Gerrit. Should it support the --send_mail flag in the same way as git cl upload? If no preference is given, should it obey Gerrit's WIP semantics (notifies unless WIP), or default to no email? The second issue is that the code that git_cl.py depends on to edit the commit message no longer supports the notify argument. Its usage was inadvertently omitted here: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/544118
,
Aug 21 2017
,
Aug 24 2017
Thanks for raising this bug; looks like it was an oversight as Logan pointed out in his comment. Fix here: https://chromium-review.googlesource.com/634245
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/5a4ef4537e27a403bcd583fb80870c16a12e1076 commit 5a4ef4537e27a403bcd583fb80870c16a12e1076 Author: Aaron Gable <agable@chromium.org> Date: Wed Sep 06 00:08:25 2017 Don't send email from git-cl-description The 'notify' parameter was accidentally left out in https://crrev.com/c/544118. The calling code in git_cl.py already sets notify='NONE', so this will suppress all notifications as before. Bug: 757617 Change-Id: Ib0144d644d54b194fac0c0eb2fb51a6affa3340e Reviewed-on: https://chromium-review.googlesource.com/634245 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/5a4ef4537e27a403bcd583fb80870c16a12e1076/gerrit_util.py
,
Sep 6 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by wyatta@google.com
, Aug 21 2017Status: Duplicate (was: New)