New issue
Advanced search Search tips

Issue 757617 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue gerrit:5291
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:7055


Sign in to add a comment

Updating cl description should not send an email

Project Member Reported by gsat...@chromium.org, Aug 21 2017

Issue description

Affected Version:

What steps will reproduce the problem?
$ git cl description

... edit the description and save ..


What is the expected output?

No new email is sent.

What do you see instead?

A new email is sent.

Please provide any additional information below.

Uploading a new patchset doesn't send an email, so it follows naturally that updating the description shoulnd't send an email (which has the side effect of triggering code reviews)
 

Comment 1 by wyatta@google.com, Aug 21 2017

Mergedinto: 5291
Status: Duplicate (was: New)

Comment 2 by logan@google.com, Aug 21 2017

Status: New (was: Duplicate)
This isn't issue 5291, this has to do with using chromium's custom command line tool to edit commit messages, not PolyGerrit.

Comment 3 by logan@google.com, Aug 21 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration
Moving to chromium project, as there are actually two issues on their end.

The first issue is I don't think git cl description signals its intent to suppress notification to Gerrit. Should it support the --send_mail flag in the same way as git cl upload? If no preference is given, should it obey Gerrit's WIP semantics (notifies unless WIP), or default to no email?

The second issue is that the code that git_cl.py depends on to edit the commit message no longer supports the notify argument. Its usage was inadvertently omitted here:

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/544118

Comment 4 by logan@google.com, Aug 21 2017

Project: chromium
Moved issue gerrit:7055 to now be  issue chromium:757617 .

Comment 5 by aga...@chromium.org, Aug 24 2017

Components: Infra>SDK
Labels: -Proj=Gerrit-Migration Milestone-Afterglow Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Started (was: New)
Thanks for raising this bug; looks like it was an oversight as Logan pointed out in his comment. Fix here: https://chromium-review.googlesource.com/634245
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/5a4ef4537e27a403bcd583fb80870c16a12e1076

commit 5a4ef4537e27a403bcd583fb80870c16a12e1076
Author: Aaron Gable <agable@chromium.org>
Date: Wed Sep 06 00:08:25 2017

Don't send email from git-cl-description

The 'notify' parameter was accidentally left out in
https://crrev.com/c/544118. The calling code in git_cl.py
already sets notify='NONE', so this will suppress all
notifications as before.

Bug:  757617 
Change-Id: Ib0144d644d54b194fac0c0eb2fb51a6affa3340e
Reviewed-on: https://chromium-review.googlesource.com/634245
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/5a4ef4537e27a403bcd583fb80870c16a12e1076/gerrit_util.py

Status: Fixed (was: Started)

Sign in to add a comment