New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 757602 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:7054


Sign in to add a comment

git cl checkout doesn't work with the new url scheme

Project Member Reported by gsat...@chromium.org, Aug 21 2017

Issue description

Affected Version:

What steps will reproduce the problem?

$ git cl checkout https://chromium-review.googlesource.com/c/v8/v8/+/624377

What is the expected output?

Switch to the correct branch

What do you see instead?

git cl: error: invalid codereview url or CL id

Note --
git cl checkout https://chromium-review.googlesource.com/c/624519 works
 

Comment 1 by wyatta@google.com, Aug 21 2017

Cc: aga...@chromium.org

Comment 2 by wyatta@google.com, Aug 21 2017

Project: chromium
Moved issue gerrit:7054 to now be  issue chromium:757602 .

Comment 3 by aga...@chromium.org, Aug 25 2017

Components: Infra>SDK
Labels: Milestone-Afterglow Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Started (was: New)
https://chromium-review.googlesource.com/634518
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/01b91069170b411afd66edaca75287673be00745

commit 01b91069170b411afd66edaca75287673be00745
Author: Aaron Gable <agable@chromium.org>
Date: Fri Aug 25 08:02:25 2017

Support new urls in git-cl

This adds support for the new urls (which contain the project) to
git-cl [description|checkout|issue|patch] and others.

Bug:  757602 
Change-Id: I6e854a85e655e14daa7e4172ca938953778bf514
Reviewed-on: https://chromium-review.googlesource.com/634518
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/01b91069170b411afd66edaca75287673be00745/git_cl.py

Comment 5 by aga...@chromium.org, Aug 28 2017

Status: Fixed (was: Started)

Comment 6 by aga...@chromium.org, Aug 28 2017

 Issue 757949  has been merged into this issue.

Comment 7 by aga...@chromium.org, Aug 28 2017

Cc: phajdan.jr@chromium.org
 Issue 759885  has been merged into this issue.

Sign in to add a comment