New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757595 link

Starred by 3 users
Status: Fixed
Owner:
█ justincarlson@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
ka...@chromium.org
adlr@chromium.org
weifangsun@chromium.org
sontis@chromium.org
█ justincarlson@chromium.org
skau@chromium.org
█ helenzhang@chromium.org
█ rjahagir@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 758018



Sign in to add a comment

Printer URIs for discovered printers are not routeable

Project Member Reported by skau@chromium.org, Aug 21 2017 
lpadmin is rejecting printer uris which contain spaces.  We're receiving printer uris with spaces from the zeroconf printers.\

Workaround lack of local TLD resolution to be implemented in  crbug.com/626377

Comment 1 by skau@chromium.org, Aug 22 2017

Status: Started (was: Assigned)

Comment 2 by skau@chromium.org, Aug 22 2017 

It seems we can't route mDNS local addresses as well.  Investigating.

Comment 3 by skau@chromium.org, Aug 22 2017 

Note to self, if not using *.local hostnames, ensure we update uris when we re-detect a printer.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb9560052a9606bedad51935f042f80102399362

commit fb9560052a9606bedad51935f042f80102399362
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 22 20:10:34 2017

Use address for zeroconf printers instead of service_name.

The address field in ServiceDescription contains the *.local hostname
used to route requests to the printer.

Bug:  757595 
Change-Id: Ib361fbb9fb8b545fc52320c452aa0bc74908805e
Reviewed-on: https://chromium-review.googlesource.com/624940
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496418}
[modify] https://crrev.com/fb9560052a9606bedad51935f042f80102399362/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc

Comment 5 by skau@chromium.org, Aug 22 2017

Cc: skau@chromium.org
Owner: justincarlson@chromium.org
We should use this for .local name resolution.

Comment 6 by skau@chromium.org, Aug 22 2017

Summary: Printer URIs for discovered printers are not routeable (was: Printer URIs cannot contain Spaces)

Comment 7 by skau@chromium.org, Aug 22 2017

Description: Show this description

Comment 8 by skau@chromium.org, Aug 22 2017

Blocking: 758018

Comment 9 by skau@chromium.org, Aug 22 2017 

 Issue 758029  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c14400a94cb4f43e0e9b02e59e93cf5a082c6408

commit c14400a94cb4f43e0e9b02e59e93cf5a082c6408
Author: Justin Carlson <justincarlson@chromium.org>
Date: Wed Aug 23 00:58:17 2017

Resolve mDNS URIs before handing them to CUPS.

Implementing this also obsoleted the updated time mechanism
for tracking whether or not our configuration is up-to-date
in CUPS.  This involved a lot of fixups to remove the last_updated
field from the Printer object.

Bug:  757595 ,
Change-Id: I7c75f9ce6a3d16e8bba2a9e6cf0c2e7cf7a09358
Reviewed-on: https://chromium-review.googlesource.com/627342
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496533}
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/printer_configurer.h
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/specifics_translation.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/specifics_translation_unittest.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/synced_printers_manager.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/synced_printers_manager_unittest.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chromeos/printing/printer_configuration.h
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chromeos/printing/printer_translator.h
[modify] https://crrev.com/c14400a94cb4f43e0e9b02e59e93cf5a082c6408/chromeos/printing/printer_translator_unittest.cc

Comment 11 by justincarlson@chromium.org, Aug 23 2017

Status: Fixed (was: Started)

Comment 12 by skau@chromium.org, Aug 25 2017

Labels: Merge-Request-61
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 25 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by keta...@chromium.org, Aug 28 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for M61.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 28 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c7483f7afa164db070885768508ac81176669a6

commit 4c7483f7afa164db070885768508ac81176669a6
Author: Sean Kau <skau@chromium.org>
Date: Mon Aug 28 19:45:40 2017

Use address for zeroconf printers instead of service_name.

The address field in ServiceDescription contains the *.local hostname
used to route requests to the printer.

TBR=skau@chromium.org

(cherry picked from commit fb9560052a9606bedad51935f042f80102399362)

Bug:  757595 
Change-Id: Ib361fbb9fb8b545fc52320c452aa0bc74908805e
Reviewed-on: https://chromium-review.googlesource.com/624940
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496418}
Reviewed-on: https://chromium-review.googlesource.com/639312
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#942}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4c7483f7afa164db070885768508ac81176669a6/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c842cd4c245817a28a9b3483831fa36ed4cae39c

commit c842cd4c245817a28a9b3483831fa36ed4cae39c
Author: Sean Kau <skau@chromium.org>
Date: Mon Aug 28 19:52:00 2017

Resolve mDNS URIs before handing them to CUPS.

Implementing this also obsoleted the updated time mechanism
for tracking whether or not our configuration is up-to-date
in CUPS.  This involved a lot of fixups to remove the last_updated
field from the Printer object.

TBR=justincarlson@chromium.org

(cherry picked from commit c14400a94cb4f43e0e9b02e59e93cf5a082c6408)

Bug:  757595 ,
Change-Id: I7c75f9ce6a3d16e8bba2a9e6cf0c2e7cf7a09358
Reviewed-on: https://chromium-review.googlesource.com/627342
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496533}
Reviewed-on: https://chromium-review.googlesource.com/639313
Cr-Commit-Position: refs/branch-heads/3163@{#943}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/printer_configurer.h
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/specifics_translation.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/specifics_translation_unittest.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/synced_printers_manager.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/synced_printers_manager_unittest.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chrome/browser/chromeos/printing/zeroconf_printer_detector.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chromeos/printing/printer_configuration.h
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chromeos/printing/printer_translator.h
[modify] https://crrev.com/c842cd4c245817a28a9b3483831fa36ed4cae39c/chromeos/printing/printer_translator_unittest.cc

Comment 17 by skau@chromium.org, Aug 29 2017

Cc: rjahagir@chromium.org ka...@chromium.org adlr@chromium.org helenzhang@chromium.org sontis@chromium.org
 Issue 760226  has been merged into this issue.
►

Sign in to add a comment