New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757590 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ phajdan.jr@chromium.org
█ phajdan@google.com
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Automatically pass --disable-syntax-validation when syncing to old revisions

Project Member Reported by pdr@chromium.org, Aug 21 2017 
I recently hit this issue when gclient syncing to an older revision (8 months ago):
ValueError: unexpected AST node: <_ast.Import object at 0x7f463380a850> Import(names=[alias(name='os', asname=None)]) (file '/usr/local/google/home/ijamardo/Coding/chromium/src/third_party/skia/DEPS', line 51)

I found this issue was reported to chromium-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/TsMy80N6cZw

Using --disable-syntax-validation, I was able to successfully sync to my old revision.

Can gclient sync automatically use --disable-syntax-validation for syncing to old revisions? I think many folks are likely to hit this same issue and it is quite difficult to debug if you don't happen to go to google first.

Comment 1 by qyears...@chromium.org, Aug 21 2017

Components: -Blink>Infra Infra>SDK
Labels: -Type-Bug Type-Feature
This would be a change in depot_tools/gclient.py.

Comment 2 by aga...@chromium.org, Aug 28 2017

Owner: phajdan.jr@chromium.org
Status: Assigned (was: Untriaged)
Pawel, this is in your baliwick. Please prioritize -- I'm not sure how hairy this would be to implement, and if it is worth it or not.

Comment 3 by phajdan.jr@chromium.org, Sep 14 2017

Cc: phajdan@google.com
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment