New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757589 link

Starred by 1 user
Status: Fixed
Owner:
skau@chromium.org
Closed: Aug 2017
Cc:
x...@chromium.org
weifangsun@chromium.org
█ justincarlson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 588234



Sign in to add a comment

Printer Setup Crashes

Project Member Reported by skau@chromium.org, Aug 21 2017 
Chrome Version: 62.0.3193.0

What steps will reproduce the problem?
(1) Open Printer Setup
(2) Try to add Printer
(3) Click final add button

What is the expected result?
Printer is added

What happens instead?
ChromeOS Crash

There's a CHECK floating around in cups_printers_handler.cc that needs to be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/916f88c9ac3eed4569aa473dce1b10982a83efe1

commit 916f88c9ac3eed4569aa473dce1b10982a83efe1
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 22 17:02:06 2017

Fix check failure when adding a printer.

The printing WebUI handler is looking for a parameter which has been
removed.  Fix it so we can add printers again.

Bug:  757589 
Change-Id: Id25d21474f052a911e86384847e37b1f6d9c4c0f
Reviewed-on: https://chromium-review.googlesource.com/624731
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496334}
[modify] https://crrev.com/916f88c9ac3eed4569aa473dce1b10982a83efe1/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Comment 2 by skau@chromium.org, Aug 22 2017

Status: Fixed (was: Started)

Comment 3 by skau@chromium.org, Aug 22 2017

Blocking: 588234
Labels: Merge-Request-61 M-61
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 22 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by keta...@chromium.org, Aug 22 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26c2c41fd3af24185a0af037f47a35a113b99768

commit 26c2c41fd3af24185a0af037f47a35a113b99768
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 22 19:43:53 2017

Fix check failure when adding a printer.

The printing WebUI handler is looking for a parameter which has been
removed.  Fix it so we can add printers again.

TBR=skau@chromium.org

(cherry picked from commit 916f88c9ac3eed4569aa473dce1b10982a83efe1)

Bug:  757589 
Change-Id: Id25d21474f052a911e86384847e37b1f6d9c4c0f
Reviewed-on: https://chromium-review.googlesource.com/624731
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496334}
Reviewed-on: https://chromium-review.googlesource.com/627088
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#769}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/26c2c41fd3af24185a0af037f47a35a113b99768/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
►

Sign in to add a comment