Crash showing fullscreen app-list in mash |
||||
Issue descriptionCrash showing fullscreen app-list in mash 1) Run "chrome --mash --enable-features=EnableFullscreenAppList" 2) Click the app list button on the shelf. Expected: New fullscreen app-list window is shown. Actual: crash! (stack below) Here's the pertinent portion of the callstack and the error: [114362:114362:0821/135313.742912:FATAL:desktop_screen_position_client.cc(46)] Check failed: !desktop_native_widget || desktop_native_widget->GetNativeView() != window. #0 0x7f6171ade66d base::debug::StackTrace::StackTrace() #1 0x7f6171adcbec base::debug::StackTrace::StackTrace() #2 0x7f6171b6607d logging::LogMessage::~LogMessage() #3 0x7f6165e99703 views::DesktopScreenPositionClient::SetBounds() #4 0x7f6167c1ea94 aura::Window::SetBoundsInScreen() #5 0x7f61621e35eb app_list::AppListView::InitializeFullscreen() #6 0x7f61621e2caf app_list::AppListView::Initialize() #7 0x55fe80b04424 AppListPresenterDelegateMus::Init() #8 0x7f6160208555 app_list::AppListPresenterImpl::Show() #9 0x7f6160208d38 app_list::AppListPresenterImpl::ToggleAppList() #10 0x55fe80b05055 AppListPresenterService::ToggleAppList() #11 0x55fe7beb74cb app_list::mojom::AppListPresenterStubDispatch::Accept() #12 0x55fe80b05523 app_list::mojom::AppListPresenterStub<>::Accept() #13 0x7f61701aa4a6 mojo::InterfaceEndpointClient::HandleValidatedMessage()
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1425beb3f727edcbfface49170e6c169f1769011 commit 1425beb3f727edcbfface49170e6c169f1769011 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Aug 23 01:12:57 2017 cros: Fix crash showing fullscreen app list in mash Reason for crash: DesktopNativeWidgetAura::InitNativeWidget binds current widget with the root window's kDesktopNativeWidgetAuraKey for desktop build. But the DCHECK in DesktopScreenPositionClient::SetBounds() expects current widget's root window's kDesktopNativeWidgetAuraKey is not set or is not set to the current widget. Changes: Set bounds widget's native view in parent window's coordinates instead of screen coordinates to avoid calling Window::SetBoundsInScreen() which triggers DesktopScreenPositionClient::SetBounds(). BUG= 757573 Change-Id: Id627572256fd315ae4609d347a7999cecb2ee0f1 Reviewed-on: https://chromium-review.googlesource.com/627385 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#496538} [modify] https://crrev.com/1425beb3f727edcbfface49170e6c169f1769011/ui/app_list/views/app_list_view.cc
,
Aug 23 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8017d2eb2917a1d6d9d7338a50e0dba09d12c1cd commit 8017d2eb2917a1d6d9d7338a50e0dba09d12c1cd Author: Maajid <maajid@chromium.org> Date: Tue Aug 29 01:38:09 2017 cros: Fix crash showing fullscreen app list in mash Reason for crash: DesktopNativeWidgetAura::InitNativeWidget binds current widget with the root window's kDesktopNativeWidgetAuraKey for desktop build. But the DCHECK in DesktopScreenPositionClient::SetBounds() expects current widget's root window's kDesktopNativeWidgetAuraKey is not set or is not set to the current widget. Changes: Set bounds widget's native view in parent window's coordinates instead of screen coordinates to avoid calling Window::SetBoundsInScreen() which triggers DesktopScreenPositionClient::SetBounds(). BUG= 757573 TBR=weidongg@chromium.org (cherry picked from commit 1425beb3f727edcbfface49170e6c169f1769011) Change-Id: Id627572256fd315ae4609d347a7999cecb2ee0f1 Reviewed-on: https://chromium-review.googlesource.com/627385 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496538} Reviewed-on: https://chromium-review.googlesource.com/640151 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#964} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/8017d2eb2917a1d6d9d7338a50e0dba09d12c1cd/ui/app_list/views/app_list_view.cc
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by newcomer@chromium.org
, Aug 22 2017Owner: weidongg@chromium.org