New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 757572 link

Starred by 3 users
Status: Archived
Owner:
█ e...@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

DCHECK hit in ShellPortMash

Project Member Reported by sky@chromium.org, Aug 21 2017 
Specifically in OnCursorTouchVisibleChanged that the config is MASH. I had enabled mus in about:flags, not mash. I hit the DCHECK by building a tip of tree build (with DCHECKs enabled) pushing to device and touching the screen.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0748226854f8a781ba6dd3a2f762d3b998603cc

commit b0748226854f8a781ba6dd3a2f762d3b998603cc
Author: Elliot Glaysher <erg@chromium.org>
Date: Mon Aug 21 23:51:22 2017

Fix DCHECK in ShellPortMash.

While SetCursorTouchVisible() should never be called in --mus mode, receiving
OnCursorTouchVisibleChanged() events happens since the mus window server keeps
track of that piece of state, and we should filter them appropriately. Also
flips around another method in ShellPortMash for symmetry.

Bug:  757572 
Change-Id: Ic9cdb52b804c1f96c657317b3bc6627177379d13
Reviewed-on: https://chromium-review.googlesource.com/624936
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496126}
[modify] https://crrev.com/b0748226854f8a781ba6dd3a2f762d3b998603cc/ash/mus/bridge/shell_port_mash.cc

Comment 2 by e...@chromium.org, Aug 21 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment