CL: https://chromium-review.googlesource.com/c/chromium/src/+/624620

The CL above can't be applied to ToT because the TraceWrapperMember constructor no longer exists.  This is also not needed for M62 because TraceWrapper is done differently and the existing code works as is.

Requesting merge to M61 (branch 3163) to fix this for M61.  This is important because WebAudio decodeAudioData does not always call the callbacks, breaking many websites that use decodeAudioData.

This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approved for M61 branch 3163, please merge ASAP.

Do I need approval from all the other owners too?

No further approval is needed. Pls merge ASAP. Thank you.

Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59ff33d70ae25244291794b11c06afd69bc70b81

commit 59ff33d70ae25244291794b11c06afd69bc70b81
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Aug 21 22:43:25 2017

Apply TraceWrapper correctly for decudeAudioData callbacks.

emplace_back does not construct the object to include the
TraceWrapperMember.  Instead use push_back with explicit construction
of the TraceWrapperMember to wrap the callback pointers.

Manually tested this fix using the repro case from
https://bugs.chromium.org/p/chromium/issues/detail?id=717723#c23 and
verify that a tone is heard, as expected.

Bug:  757563 ,  717723 
Test: Run repro from 717723
Change-Id: If49501e0997c42f44e05f63323f3c42e6cee1913
Reviewed-on: https://chromium-review.googlesource.com/624620
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#738}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/59ff33d70ae25244291794b11c06afd69bc70b81/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

Many thanks to mlippautz for diagnosing the issue and supplying the fix!

So question is, will this be included in stable v61 in september? Thanks.

Yes, it has been merged to branch 3163 which means that it will either already be on the next beta (if there is a respin) or latest on M61 stable.

Thanks.

Tested this issue using #61.0.3163.59 on Windows 7, Mac 10.12.6 & Ubuntu 14.04  as per steps mentioned in original comment. Observed some tones are playing.

Please find the screen cast for the same. Hence adding verified labels.

Thanks!!

Deleted: Aug 23 2017 3-37 PM.webm 4.1 MB

	Aug 23 2017 3-37 PM.webm 4.1 MB View Download