New issue
Advanced search Search tips

Issue 757557 link

Starred by 1 user
Status: Fixed
Owner:
sahel@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Move Fling filtering logic out of gesture event queue

Project Member Reported by sahel@chromium.org, Aug 21 2017 
GEQ owns touchpad/touchscreen tap suppression controllers to filter
fling and other related events before adding them to the queue.

Add a helper class to hide the details of event filtering from GEQ.
This Fling Controller class can be used for browser side fling handling later on.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b47aa6a961034871318a17f09261c1ccda4e5d5

commit 0b47aa6a961034871318a17f09261c1ccda4e5d5
Author: Sahel Sharify <sahel@chromium.org>
Date: Tue Aug 22 21:24:08 2017

Fling controller added to geq to handle fling related event filterings.

GestureEventQueueWithSourceTest.GestureFlingCancelsFiltered

TBR: creis@chromium.org
Bug:  757557 
Test: GestureEventQueueTest.TapGetsSuppressedAfterTapDownCancellsFling,
Change-Id: Id0a314cd191dfd5c9bda74e92133ed4a8efb77bc
Reviewed-on: https://chromium-review.googlesource.com/624677
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496445}
[modify] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/BUILD.gn
[add] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/renderer_host/input/fling_controller.cc
[add] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/renderer_host/input/gesture_event_queue.h
[modify] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/0b47aa6a961034871318a17f09261c1ccda4e5d5/content/browser/renderer_host/input/input_router_config_helper.cc

Comment 2 by sahel@chromium.org, Aug 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment